semantic_puppet 0.1.3 → 1.0.3

data/spec/unit/semantic_puppet/version_spec.rb

@@ -9,6 +9,14 @@ describe SemanticPuppet::Version do
 
   describe '.parse' do
 
+    let(:parse_failure) do
+      /Unable to parse .* as a semantic version identifier/
+    end
+
+    let(:no_leading_zeroes) do
+      'Numeric pre-release identifiers MUST NOT contain leading zeroes'
+    end
+
     context 'Spec v2.0.0' do
       context 'Section 2' do
         # A normal version number MUST take the form X.Y.Z where X, Y, and Z are
@@ -17,10 +25,6 @@ describe SemanticPuppet::Version do
         # Each element MUST increase numerically.
         # For instance: 1.9.0 -> 1.10.0 -> 1.11.0.
 
-        let(:parse_failure) do
-          /Unable to parse .* as a semantic version identifier/
-        end
-
         it 'rejects versions that contain too few parts' do
           expect { subject('1.2') }.to raise_error(parse_failure)
         end
@@ -89,31 +93,19 @@ describe SemanticPuppet::Version do
         # by its associated normal version.
         # Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.
 
-        let(:restricted_charset) do
-          'Prerelease identifiers MUST use only ASCII alphanumerics and hyphens'
-        end
-
-        let(:must_not_be_empty) do
-          'Prerelease identifiers MUST NOT be empty'
-        end
-
-        let(:no_leading_zeroes) do
-          'Prerelease identifiers MUST NOT contain leading zeroes'
-        end
-
         it 'rejects prerelease identifiers with non-alphanumerics' do
-          expect { subject('1.2.3-$100') }.to raise_error(restricted_charset)
-          expect { subject('1.2.3-rc.1@me') }.to raise_error(restricted_charset)
+          expect { subject('1.2.3-$100') }.to raise_error(parse_failure)
+          expect { subject('1.2.3-rc.1@me') }.to raise_error(parse_failure)
         end
 
         it 'rejects empty prerelease versions' do
-          expect { subject('1.2.3-') }.to raise_error(must_not_be_empty)
+          expect { subject('1.2.3-') }.to raise_error(parse_failure)
         end
 
         it 'rejects empty prerelease version identifiers' do
-          expect { subject('1.2.3-.rc1') }.to raise_error(must_not_be_empty)
-          expect { subject('1.2.3-rc1.') }.to raise_error(must_not_be_empty)
-          expect { subject('1.2.3-rc..1') }.to raise_error(must_not_be_empty)
+          expect { subject('1.2.3-.rc1') }.to raise_error(parse_failure)
+          expect { subject('1.2.3-rc1.') }.to raise_error(parse_failure)
+          expect { subject('1.2.3-rc..1') }.to raise_error(parse_failure)
         end
 
         it 'rejects numeric prerelease identifiers with leading zeroes' do
@@ -167,14 +159,6 @@ describe SemanticPuppet::Version do
       end
 
       context 'Section 10' do
-        # Build metadata is not yet in scope so
-        it 'rejects build identifiers' do
-          ver = '1.2.3+anything'
-          expect { subject(ver) }.to raise_error("'#{ver}' MUST NOT include build identifiers")
-        end
-      end
-
-      context 'Section 10', :pending => "build metadata is not yet in scope" do
         # Build metadata MAY be denoted by appending a plus sign and a series
         # of dot separated identifiers immediately following the patch or
         # pre-release version. Identifiers MUST comprise only ASCII
@@ -185,28 +169,19 @@ describe SemanticPuppet::Version do
         # Examples: 1.0.0-alpha+001, 1.0.0+20130313144700,
         # 1.0.0-beta+exp.sha.5114f85.
 
-
-        let(:restricted_charset) do
-          'Build identifiers MUST use only ASCII alphanumerics and hyphens'
-        end
-
-        let(:must_not_be_empty) do
-          'Build identifiers MUST NOT be empty'
-        end
-
         it 'rejects build identifiers with non-alphanumerics' do
-          expect { subject('1.2.3+$100') }.to raise_error(restricted_charset)
-          expect { subject('1.2.3+rc.1@me') }.to raise_error(restricted_charset)
+          expect { subject('1.2.3+$100') }.to raise_error(parse_failure)
+          expect { subject('1.2.3+rc.1@me') }.to raise_error(parse_failure)
         end
 
         it 'rejects empty build metadata' do
-          expect { subject('1.2.3+') }.to raise_error(must_not_be_empty)
+          expect { subject('1.2.3+') }.to raise_error(parse_failure)
         end
 
         it 'rejects empty build identifiers' do
-          expect { subject('1.2.3+.rc1') }.to raise_error(must_not_be_empty)
-          expect { subject('1.2.3+rc1.') }.to raise_error(must_not_be_empty)
-          expect { subject('1.2.3+rc..1') }.to raise_error(must_not_be_empty)
+          expect { subject('1.2.3+.rc1') }.to raise_error(parse_failure)
+          expect { subject('1.2.3+rc1.') }.to raise_error(parse_failure)
+          expect { subject('1.2.3+rc..1') }.to raise_error(parse_failure)
         end
 
         it 'permits numeric build identifiers with leading zeroes' do
@@ -263,10 +238,6 @@ describe SemanticPuppet::Version do
         # increments of one.
         # For instance: 1.9.0 -> 1.10.0 -> 1.11.0
 
-        let(:parse_failure) do
-          /Unable to parse .* as a semantic version identifier/
-        end
-
         it 'rejects versions that contain too few parts' do
           expect { subject('1.2') }.to raise_error(parse_failure)
         end
@@ -320,25 +291,13 @@ describe SemanticPuppet::Version do
         # lexicographic ASCII sort order.
         # For instance: 1.0.0-alpha1 < 1.0.0-beta1 < 1.0.0-beta2 < 1.0.0-rc1
 
-        let(:restricted_charset) do
-          'Prerelease identifiers MUST use only ASCII alphanumerics and hyphens'
-        end
-
-        let(:must_not_be_empty) do
-          'Prerelease identifiers MUST NOT be empty'
-        end
-
-        let(:no_leading_zeroes) do
-          'Prerelease identifiers MUST NOT contain leading zeroes'
-        end
-
         it 'rejects prerelease identifiers with non-alphanumerics' do
-          expect { subject('1.2.3-$100') }.to raise_error(restricted_charset)
-          expect { subject('1.2.3-rc.1@me') }.to raise_error(restricted_charset)
+          expect { subject('1.2.3-$100') }.to raise_error(parse_failure)
+          expect { subject('1.2.3-rc.1@me') }.to raise_error(parse_failure)
         end
 
         it 'rejects empty prerelease versions' do
-          expect { subject('1.2.3-') }.to raise_error(must_not_be_empty)
+          expect { subject('1.2.3-') }.to raise_error(parse_failure)
         end
 
         it 'rejects numeric prerelease identifiers with leading zeroes' do
@@ -392,22 +351,199 @@ describe SemanticPuppet::Version do
   end
 
   describe '.valid?' do
-    # All the specific variations are tested in the .parse tests, so these are just basic
-    # smoke tests.
-
     def subject(str)
       SemanticPuppet::Version.valid?(str)
     end
 
-    it 'recognizes valid versions' do
-      expect(subject('1.0.1')).to be true
-      expect(subject('1.0.3-p324')).to be true
+    context 'Spec v2.0.0' do
+      context 'Section 2' do
+        # A normal version number MUST take the form X.Y.Z where X, Y, and Z are
+        # non-negative integers, and MUST NOT contain leading zeroes. X is the
+        # major version, Y is the minor version, and Z is the patch version.
+
+        it 'rejects versions that contain too few parts' do
+          expect(subject('1.2')).to be false
+        end
+
+        it 'rejects versions that contain too many parts' do
+          expect(subject('1.2.3.4')).to be false
+        end
+
+        it 'rejects versions that contain non-integers' do
+          expect(subject('x.2.3')).to be false
+          expect(subject('1.y.3')).to be false
+          expect(subject('1.2.z')).to be false
+        end
+
+        it 'rejects versions that contain negative integers' do
+          expect(subject('-1.2.3')).to be false
+          expect(subject('1.-2.3')).to be false
+          expect(subject('1.2.-3')).to be false
+        end
+
+        it 'rejects version numbers containing leading zeroes' do
+          expect(subject('01.2.3')).to be false
+          expect(subject('1.02.3')).to be false
+          expect(subject('1.2.03')).to be false
+        end
+
+        it 'permits zeroes in version number parts' do
+          expect(subject('0.2.3')).to be true
+          expect(subject('1.0.3')).to be true
+          expect(subject('1.2.0')).to be true
+        end
+      end
+
+      context 'Section 9' do
+        # A pre-release version MAY be denoted by appending a hyphen and a
+        # series of dot separated identifiers immediately following the patch
+        # version. Identifiers MUST comprise only ASCII alphanumerics and
+        # hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric
+        # identifiers MUST NOT include leading zeroes. Pre-release versions
+        # have a lower precedence than the associated normal version. A
+        # pre-release version indicates that the version is unstable and
+        # might not satisfy the intended compatibility requirements as denoted
+        # by its associated normal version.
+        # Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.
+
+        it 'rejects prerelease identifiers with non-alphanumerics' do
+          expect(subject('1.2.3-$100')).to be false
+          expect(subject('1.2.3-rc.1@me')).to be false
+        end
+
+        it 'rejects empty prerelease versions' do
+          expect(subject('1.2.3-')).to be false
+        end
+
+        it 'rejects empty prerelease version identifiers' do
+          expect(subject('1.2.3-.rc1')).to be false
+          expect(subject('1.2.3-rc1.')).to be false
+          expect(subject('1.2.3-rc..1')).to be false
+        end
+
+        it 'rejects numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-01')).to be false
+          expect(subject('1.2.3-rc.01')).to be false
+        end
+
+        it 'permits numeric prerelease identifiers of zero' do
+          expect(subject('1.2.3-0')).to be true
+          expect(subject('1.2.3-rc.0')).to be true
+        end
+
+        it 'permits non-numeric prerelease identifiers' do
+          expect(subject('1.2.3-DEADBEEF')).to be true
+          expect(subject('1.2.3-DE.AD.BE.EF')).to be true
+          expect(subject('2.1.0-12-BE-EF')).to be true
+        end
+
+        it 'permits non-numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-0xDEADBEEF')).to be true
+          expect(subject('1.2.3-rc.0x10c')).to be true
+          expect(subject('2.1.0-0016-13fae4a9')).to be true
+        end
+      end
+
+      context 'Section 10' do
+        # Build metadata MAY be denoted by appending a plus sign and a series
+        # of dot separated identifiers immediately following the patch or
+        # pre-release version. Identifiers MUST comprise only ASCII
+        # alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty.
+        # Build metadata SHOULD be ignored when determining version precedence.
+        # Thus two versions that differ only in the build metadata, have the
+        # same precedence.
+        # Examples: 1.0.0-alpha+001, 1.0.0+20130313144700,
+        # 1.0.0-beta+exp.sha.5114f85.
+
+        it 'rejects build identifiers with non-alphanumerics' do
+          expect(subject('1.2.3+$100')).to be false
+          expect(subject('1.2.3+rc.1@me')).to be false
+        end
+
+        it 'rejects empty build metadata' do
+          expect(subject('1.2.3+')).to be false
+        end
+
+        it 'rejects empty build identifiers' do
+          expect(subject('1.2.3+.rc1')).to be false
+          expect(subject('1.2.3+rc1.')).to be false
+          expect(subject('1.2.3+rc..1')).to be false
+        end
+
+        it 'permits numeric build identifiers with leading zeroes' do
+          expect(subject('1.2.3+01')).to be true
+          expect(subject('1.2.3+rc.01')).to be true
+        end
+
+        it 'permits numeric build identifiers of zero' do
+          expect(subject('1.2.3+0')).to be true
+          expect(subject('1.2.3+rc.0')).to be true
+        end
+
+        it 'permits non-numeric build identifiers with leading zeroes' do
+          expect(subject('1.2.3+0xDEADBEEF')).to be true
+          expect(subject('1.2.3+rc.0x10c')).to be true
+        end
+      end
     end
 
-    it 'does not recognize invalid versions' do
-      expect(subject('1.0')).to be false      # too few segments
-      expect(subject('1.0.3.6')).to be false  # too many segments
-      expect(subject('1.03.14')).to be false  # leading zero in segment
+    context 'Spec v1.0.0' do
+      context 'Section 2' do
+        # A normal version number MUST take the form X.Y.Z where X, Y, and Z
+        # are integers. X is the major version, Y is the minor version, and Z
+        # is the patch version.
+
+        it 'rejects versions that contain too few parts' do
+          expect(subject('1.2')).to be false
+        end
+
+        it 'rejects versions that contain too many parts' do
+          expect(subject('1.2.3.4')).to be false
+        end
+
+        it 'rejects versions that contain non-integers' do
+          expect(subject('x.2.3')).to be false
+          expect(subject('1.y.3')).to be false
+          expect(subject('1.2.z')).to be false
+        end
+
+        it 'permits zeroes in version number parts' do
+          expect(subject('0.2.3')).to be true
+          expect(subject('1.0.3')).to be true
+          expect(subject('1.2.0')).to be true
+        end
+      end
+
+      context 'Section 4' do
+        # A pre-release version number MAY be denoted by appending an arbitrary
+        # string immediately following the patch version and a dash. The string
+        # MUST be comprised of only alphanumerics plus dash [0-9A-Za-z-].
+        # Pre-release versions satisfy but have a lower precedence than the
+        # associated normal version. Precedence SHOULD be determined by
+        # lexicographic ASCII sort order.
+        # For instance: 1.0.0-alpha1 < 1.0.0-beta1 < 1.0.0-beta2 < 1.0.0-rc1
+
+        it 'rejects prerelease identifiers with non-alphanumerics' do
+          expect(subject('1.2.3-$100')).to be false
+          expect(subject('1.2.3-rc.1@me')).to be false
+        end
+
+        it 'rejects empty prerelease versions' do
+          expect(subject('1.2.3-')).to be false
+        end
+
+        it 'rejects numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-01')).to be false
+        end
+
+        it 'permits numeric prerelease identifiers of zero' do
+          expect(subject('1.2.3-0')).to be true
+        end
+
+        it 'permits non-numeric prerelease identifiers with leading zeroes' do
+          expect(subject('1.2.3-0xDEADBEEF')).to be true
+        end
+      end
     end
   end
 
@@ -540,14 +676,19 @@ describe SemanticPuppet::Version do
             expect(b).to be > a
           end
 
-          example 'build metadata does not figure into precendence' do
-            pending 'build metadata is not yet in scope'
+          example 'build metadata does figure into equality' do
             a = parse('1.0.0-alpha+SHA1')
             b = parse('1.0.0-alpha+MD5')
-            expect(a).to eql b
+            expect(a).not_to eql b
             expect(a.to_s).to_not eql b.to_s
           end
 
+          example 'build metadata does not figure into precendence' do
+            a = parse('1.0.0-alpha+SHA1')
+            b = parse('1.0.0-alpha+MD5')
+            expect(a <=> b).to eql(0)
+          end
+
           example 'sorted order' do
             list = %w[
               1.0.0-alpha
@@ -631,7 +772,6 @@ describe SemanticPuppet::Version do
       end
 
       it 'removes any build information' do
-        pending 'build metadata is not yet in scope'
         expect(subject('1.0.0+abc').next(:major)).to eql(subject('2.0.0'))
       end
     end
@@ -656,7 +796,6 @@ describe SemanticPuppet::Version do
       end
 
       it 'removes any build information' do
-        pending 'build metadata is not yet in scope'
         expect(subject('1.1.0+abc').next(:minor)).to eql(subject('1.2.0'))
       end
     end
@@ -677,7 +816,6 @@ describe SemanticPuppet::Version do
       end
 
       it 'removes any build information' do
-        pending 'build metadata is not yet in scope'
         expect(subject('1.0.0+abc').next(:patch)).to eql(subject('1.0.1'))
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: semantic_puppet
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 1.0.3
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-24 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -103,12 +103,16 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
+- CODEOWNERS
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
+- appveyor.yml
 - lib/semantic_puppet.rb
 - lib/semantic_puppet/dependency.rb
 - lib/semantic_puppet/dependency/graph.rb
@@ -116,6 +120,7 @@ files:
 - lib/semantic_puppet/dependency/module_release.rb
 - lib/semantic_puppet/dependency/source.rb
 - lib/semantic_puppet/dependency/unsatisfiable_graph.rb
+- lib/semantic_puppet/gem_version.rb
 - lib/semantic_puppet/version.rb
 - lib/semantic_puppet/version_range.rb
 - semantic_puppet.gemspec
@@ -140,17 +145,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.8.7
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Useful tools for working with Semantic Versions.
 test_files: []
-has_rdoc: