semantic_logger 3.2.1 → 3.3.0

data/test/appender/http_test.rb

@@ -7,8 +7,10 @@ module Appender
 
     describe SemanticLogger::Appender::Http do
       before do
-        @appender = SemanticLogger::Appender::Http.new(url: 'http://localhost:8088/path')
-        @message  = 'AppenderHttpTest log message'
+        Net::HTTP.stub_any_instance(:start, true) do
+          @appender = SemanticLogger::Appender::Http.new(url: 'http://localhost:8088/path')
+        end
+        @message = 'AppenderHttpTest log message'
       end
 
       SemanticLogger::LEVELS.each do |level|

data/test/appender/mongodb_test.rb

@@ -67,7 +67,6 @@ module Appender
         end
 
         it 'handle message without payload' do
-          log = SemanticLogger::Log.new(:debug)
           @appender.debug('hello world')
 
           document = @appender.collection.find_one
@@ -94,7 +93,7 @@ module Appender
             assert_equal 12345, document['tracking_number']
             assert_equal 'HSSKLEU@JDK767', document['session_id']
             assert_equal $$, document['pid']
-            assert_equal 'test', document['host']
+            assert_equal 'test', document['host'], document.ai
             assert_equal 'test_application', document['application']
           end
         end

data/test/appender/splunk_http_test.rb

@@ -7,10 +7,12 @@ module Appender
 
     describe SemanticLogger::Appender::SplunkHttp do
       before do
-        @appender = SemanticLogger::Appender::SplunkHttp.new(
-          url:   'http://localhost:8088/path',
-          token: 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
-        )
+        Net::HTTP.stub_any_instance(:start, true) do
+          @appender = SemanticLogger::Appender::SplunkHttp.new(
+            url:   'http://localhost:8088/path',
+            token: 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
+          )
+        end
         @message  = 'AppenderSplunkHttpTest log message'
       end
 
@@ -20,7 +22,7 @@ module Appender
           @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
             @appender.send(level, @message)
           end
-          body = decompress_data(request.body)
+          body    = decompress_data(request.body)
           message = JSON.parse(body)
           assert_equal @message, message['event']['message']
           assert_equal level.to_s, message['event']['level']
@@ -53,7 +55,7 @@ module Appender
           @appender.http.stub(:request, -> r { request = r; response_mock.new('200', 'ok') }) do
             @appender.send(level, @message, {key1: 1, key2: 'a'})
           end
-          body = decompress_data(request.body)
+          body    = decompress_data(request.body)
           message = JSON.parse(body)
           assert message['event'], message.ai
           assert_equal @message, message['event']['message']

data/test/appender/splunk_test.rb

@@ -17,65 +17,68 @@ module Appender
     describe SemanticLogger::Appender::Splunk do
       before do
         SemanticLogger::Appender::Splunk.stub_any_instance(:reopen, nil) do
-          @appender = SemanticLogger::Appender::Splunk.new(level: :info)
+          @appender = SemanticLogger::Appender::Splunk.new
         end
         @message = 'AppenderSplunkTest log message'
       end
 
-      it 'not send :trace notifications to Splunk when set to :error' do
-        mock = Mock.new
-        @appender.stub(:service_index, mock) do
-          @appender.trace('AppenderSplunkTest trace message')
+      SemanticLogger::LEVELS.each do |level|
+        it "send #{level}" do
+          mock = Mock.new
+          @appender.stub(:service_index, mock) do
+            @appender.send(level, @message)
+          end
+          assert_equal @message, mock.message
+          assert_equal level, mock.event[:event][:level]
+          refute mock.event[:event][:exception]
         end
-        assert_nil mock.event
-        assert_nil mock.message
-      end
 
-      it 'send exception notifications to Splunk with severity' do
-        hash = nil
-        exc  = nil
-        begin
-          Uh oh
-        rescue Exception => e
-          exc = e
-        end
-        mock = Mock.new
-        @appender.stub(:service_index, mock) do
-          @appender.error 'Reading File', exc
+        it "sends #{level} exceptions" do
+          exc = nil
+          begin
+            Uh oh
+          rescue Exception => e
+            exc = e
+          end
+
+          mock = Mock.new
+          @appender.stub(:service_index, mock) do
+            @appender.send(level, @message, exc)
+          end
+          assert_equal @message, mock.message
+
+          assert exception = mock.event[:event][:exception]
+          assert 'NameError', exception[:name]
+          assert 'undefined local variable or method', exception[:message]
+          assert_equal level, mock.event[:event][:level]
+          assert exception[:stack_trace].first.include?(__FILE__), exception
         end
-        assert_equal 'Reading File', mock.message
-        hash = mock.event
-        refute hash[:message]
-        assert 'NameError', hash[:exception][:name]
-        assert 'undefined local variable or method', hash[:exception][:message]
-        assert_equal 4, hash[:level_index], 'Should be error level (4)'
-        assert_equal :error, hash[:level]
-        assert hash[:exception][:stack_trace].first.include?(__FILE__), hash[:exception]
-      end
 
-      it 'send error notifications to Splunk with severity' do
-        mock = Mock.new
-        @appender.stub(:service_index, mock) do
-          @appender.error @message
+        it "sends #{level} custom attributes" do
+          mock = Mock.new
+          @appender.stub(:service_index, mock) do
+            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          end
+          assert_equal @message, mock.message
+
+          assert mock.event[:event], mock.event.ai
+          assert_equal level, mock.event[:event][:level]
+          refute mock.event[:event][:stack_trace]
+          assert_equal(1, mock.event[:event][:key1], mock.event)
+          assert_equal('a', mock.event[:event][:key2], mock.event)
         end
-        assert_equal @message, mock.message
-        assert_equal :error, mock.event[:level]
-        refute mock.event[:stack_trace]
       end
 
-      it 'send notification to Splunk with custom attributes' do
-        mock = Mock.new
+      it 'does not send :trace notifications to Splunk when set to :error' do
+        mock            = Mock.new
+        @appender.level = :error
         @appender.stub(:service_index, mock) do
-          @appender.error @message, {key1: 1, key2: 'a'}
+          @appender.trace('AppenderSplunkTest trace message')
         end
-        assert_equal @message, mock.message
-        hash = mock.event
-        assert_equal :error, hash[:level]
-        refute hash[:stack_trace]
-        assert_equal(1, hash[:key1], hash)
-        assert_equal('a', hash[:key2], hash)
+        assert_nil mock.event
+        assert_nil mock.message
       end
-
     end
+
   end
 end

data/test/appender/syslog_test.rb

@@ -15,7 +15,7 @@ module Appender
             syslog_appender.debug 'AppenderSyslogTest log message'
           end
         end
-        assert_match /D (.*?) SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message/, message
+        assert_match(/D (.*?) SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message/, message)
       end
 
       it 'handle remote syslog over TCP' do
@@ -28,7 +28,7 @@ module Appender
             end
           end
         end
-        assert_match /<70>(.*?)SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message\r\n/, message
+        assert_match(/<70>(.*?)SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message\r\n/, message)
       end
 
       it 'handle remote syslog over UDP' do
@@ -37,7 +37,7 @@ module Appender
         UDPSocket.stub_any_instance(:send, -> msg, num, host, port { message = msg }) do
           syslog_appender.debug 'AppenderSyslogTest log message'
         end
-        assert_match /<70>(.*?)SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message/, message
+        assert_match(/<70>(.*?)SemanticLogger::Appender::Syslog -- AppenderSyslogTest log message/, message)
       end
 
       # Should be able to log each level.

data/test/appender/tcp_test.rb

@@ -0,0 +1,68 @@
+require_relative '../test_helper'
+
+# Unit Test for SemanticLogger::Appender::Tcp
+module Appender
+  class TcpTest < Minitest::Test
+    response_mock = Struct.new(:code, :body)
+
+    describe SemanticLogger::Appender::Tcp do
+      before do
+        Net::TCPClient.stub_any_instance(:connect, true) do
+          @appender = SemanticLogger::Appender::Tcp.new(server: 'localhost:8088')
+        end
+        @appender.tcp_client.instance_eval do
+          def retry_on_connection_failure
+            yield
+          end
+        end
+        @message = 'AppenderTcpTest log message'
+      end
+
+      SemanticLogger::LEVELS.each do |level|
+        it "send #{level}" do
+          data = nil
+          @appender.tcp_client.stub(:write, -> d { data = d }) do
+            @appender.send(level, @message)
+          end
+          hash = JSON.parse(data)
+          assert_equal @message, hash['message']
+          assert_equal level.to_s, hash['level']
+          refute hash['stack_trace']
+        end
+
+        it "send #{level} exceptions" do
+          exc = nil
+          begin
+            Uh oh
+          rescue Exception => e
+            exc = e
+          end
+          data = nil
+          @appender.tcp_client.stub(:write, -> d { data = d }) do
+            @appender.send(level, 'Reading File', exc)
+          end
+          hash = JSON.parse(data)
+          assert 'Reading File', hash['message']
+          assert 'NameError', hash['exception']['name']
+          assert 'undefined local variable or method', hash['exception']['message']
+          assert_equal level.to_s, hash['level'], 'Should be error level (3)'
+          assert hash['exception']['stack_trace'].first.include?(__FILE__), hash['exception']
+        end
+
+        it "send #{level} custom attributes" do
+          data = nil
+          @appender.tcp_client.stub(:write, -> d { data = d }) do
+            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          end
+          hash = JSON.parse(data)
+          assert_equal @message, hash['message']
+          assert_equal level.to_s, hash['level']
+          refute hash['stack_trace']
+          assert_equal 1, hash['key1'], hash
+          assert_equal 'a', hash['key2'], hash
+        end
+
+      end
+    end
+  end
+end

data/test/appender/udp_test.rb

@@ -0,0 +1,61 @@
+require_relative '../test_helper'
+
+# Unit Test for SemanticLogger::Appender::Tcp
+module Appender
+  class UdpTest < Minitest::Test
+    response_mock = Struct.new(:code, :body)
+
+    describe SemanticLogger::Appender::Udp do
+      before do
+        @appender = SemanticLogger::Appender::Udp.new(server: 'localhost:8088')
+        @message = 'AppenderUdpTest log message'
+      end
+
+      SemanticLogger::LEVELS.each do |level|
+        it "send #{level}" do
+          data = nil
+          @appender.socket.stub(:send, -> d, flags { data = d }) do
+            @appender.send(level, @message)
+          end
+          hash = JSON.parse(data)
+          assert_equal @message, hash['message']
+          assert_equal level.to_s, hash['level']
+          refute hash['stack_trace']
+        end
+
+        it "send #{level} exceptions" do
+          exc = nil
+          begin
+            Uh oh
+          rescue Exception => e
+            exc = e
+          end
+          data = nil
+          @appender.socket.stub(:send, -> d, flags { data = d }) do
+            @appender.send(level, 'Reading File', exc)
+          end
+          hash = JSON.parse(data)
+          assert 'Reading File', hash['message']
+          assert 'NameError', hash['exception']['name']
+          assert 'undefined local variable or method', hash['exception']['message']
+          assert_equal level.to_s, hash['level'], 'Should be error level (3)'
+          assert hash['exception']['stack_trace'].first.include?(__FILE__), hash['exception']
+        end
+
+        it "send #{level} custom attributes" do
+          data = nil
+          @appender.socket.stub(:send, -> d, flags { data = d }) do
+            @appender.send(level, @message, {key1: 1, key2: 'a'})
+          end
+          hash = JSON.parse(data)
+          assert_equal @message, hash['message']
+          assert_equal level.to_s, hash['level']
+          refute hash['stack_trace']
+          assert_equal 1, hash['key1'], hash
+          assert_equal 'a', hash['key2'], hash
+        end
+
+      end
+    end
+  end
+end

data/test/appender/wrapper_test.rb

@@ -19,7 +19,7 @@ module Appender
           log.time  = Time.now
           log.level = :debug
           @appender.log(log)
-          assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] /, @mock_logger.message
+          assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] /, @mock_logger.message)
         end
 
         it 'handle nil message and payload' do
@@ -28,7 +28,7 @@ module Appender
           log.level = :debug
           log.name  = 'class'
           @appender.log(log)
-          assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] class/, @mock_logger.message
+          assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] class/, @mock_logger.message)
         end
 
         it 'handle nil payload' do
@@ -38,7 +38,7 @@ module Appender
           log.name    = 'class'
           log.message = 'hello world'
           @appender.log(log)
-          assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] class -- hello world/, @mock_logger.message
+          assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] class -- hello world/, @mock_logger.message)
         end
 
         it 'handle payload' do
@@ -49,7 +49,7 @@ module Appender
           log.message = 'hello world'
           log.payload = @hash
           @appender.log(log)
-          assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] class -- hello world -- #{@hash_str}/, @mock_logger.message
+          assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ D \[\d+:\] class -- hello world -- #{@hash_str}/, @mock_logger.message)
         end
       end
 
@@ -58,7 +58,7 @@ module Appender
         Logger::Severity.constants.each do |level|
           it "log #{level.downcase.to_sym} info" do
             @appender.log SemanticLogger::Log.new(level.downcase.to_sym, 'thread', 'class', 'hello world', @hash, Time.now)
-            assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:thread\] class -- hello world -- #{@hash_str}/, @mock_logger.message
+            assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:thread\] class -- hello world -- #{@hash_str}/, @mock_logger.message)
           end
         end
       end

data/test/concerns/compatibility_test.rb

@@ -23,19 +23,19 @@ class CompatibilityTest < Minitest::Test
     it '#add' do
       @logger.add(Logger::INFO, 'hello world', 'progname') { 'Data' }
       SemanticLogger.flush
-      assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data -- \"progname\"/, @mock_logger.message
+      assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data -- \"progname\"/, @mock_logger.message)
     end
 
     it '#log' do
       @logger.log(Logger::FATAL, 'hello world', 'progname') { 'Data' }
       SemanticLogger.flush
-      assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ F \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data -- \"progname\"/, @mock_logger.message
+      assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ F \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data -- \"progname\"/, @mock_logger.message)
     end
 
     it '#unknown' do
       @logger.unknown('hello world') { 'Data' }
       SemanticLogger.flush
-      assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ E \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data/, @mock_logger.message
+      assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ E \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data/, @mock_logger.message)
     end
 
     it '#unknown? as error?' do
@@ -51,7 +51,7 @@ class CompatibilityTest < Minitest::Test
     it '#<< as info' do
       @logger << 'hello world'
       SemanticLogger.flush
-      assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world/, @mock_logger.message
+      assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world/, @mock_logger.message)
     end
 
     it '#progname= as #name=' do
@@ -92,14 +92,14 @@ class CompatibilityTest < Minitest::Test
       @logger.close
       @logger.info('hello world') { 'Data' }
       SemanticLogger.flush
-      assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data/, @mock_logger.message
+      assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data/, @mock_logger.message)
     end
 
     it '#reopen NOOP' do
       @logger.reopen
       @logger.info('hello world') { 'Data' }
       SemanticLogger.flush
-      assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data/, @mock_logger.message
+      assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ I \[\d+:#{@thread_name}\] CompatibilityTest -- hello world -- Data/, @mock_logger.message)
     end
 
   end

data/test/debug_as_trace_logger_test.rb

@@ -81,14 +81,14 @@ class DebugAsTraceLoggerTest < Minitest::Test
           @logger.level = :trace
           @logger.debug('hello world', @hash) { "Calculations" }
           SemanticLogger.flush
-          assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ T \[\d+:.+\] DebugAsTraceLoggerTest -- hello world -- Calculations -- #{@hash_str}/, @mock_logger.message
+          assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ T \[\d+:.+\] DebugAsTraceLoggerTest -- hello world -- Calculations -- #{@hash_str}/, @mock_logger.message)
         end
 
         it 'log trace as trace' do
           @logger.level = :trace
           @logger.trace('hello world', @hash) { "Calculations" }
           SemanticLogger.flush
-          assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ T \[\d+:.+\] DebugAsTraceLoggerTest -- hello world -- Calculations -- #{@hash_str}/, @mock_logger.message
+          assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ T \[\d+:.+\] DebugAsTraceLoggerTest -- hello world -- Calculations -- #{@hash_str}/, @mock_logger.message)
         end
       end
     end

data/test/loggable_test.rb

@@ -97,7 +97,7 @@ class AppenderFileTest < Minitest::Test
               SemanticLogger.stub(:appenders, [@appender]) do
                 TestAttribute.logger.send(level, "hello #{level}", @hash)
                 SemanticLogger.flush
-                assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:#{@thread_name} loggable_test.rb:\d+\] TestAttribute -- hello #{level} -- #{@hash_str}/, @mock_logger.message
+                assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:#{@thread_name} loggable_test.rb:\d+\] TestAttribute -- hello #{level} -- #{@hash_str}/, @mock_logger.message)
               end
             end
           end
@@ -107,7 +107,7 @@ class AppenderFileTest < Minitest::Test
               SemanticLogger.stub(:appenders, [@appender]) do
                 TestAttribute.new.logger.send(level, "hello #{level}", @hash)
                 SemanticLogger.flush
-                assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:#{@thread_name} loggable_test.rb:\d+\] TestAttribute -- hello #{level} -- #{@hash_str}/, @mock_logger.message
+                assert_match(/\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:#{@thread_name} loggable_test.rb:\d+\] TestAttribute -- hello #{level} -- #{@hash_str}/, @mock_logger.message)
               end
             end
           end