sell_object 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e66f41e5be9b9edf6af8dd1aa6db9593b9e57029
-  data.tar.gz: d8005a5e92b84d1228e94ff025291489f92016b4
+  metadata.gz: 665de705c01ee47f22ee95e56e6d8f82dd62a366
+  data.tar.gz: 9f0d8b807b17be2ccabfd34d169acdab16b55997
 SHA512:
-  metadata.gz: fb98d17c1d0624b74b641f84cf7daf431dbb96b17b3ed8ee7c3158697644dc2770ca593502dcf07686feef4453f9b96a86181eab003402fe60247265aca0ae67
-  data.tar.gz: 114e737c66420a74851a29ca6c8c9496ef893798e9dbdd38114376aaf1e07b49b5d5de88e8a2bfdc773bc1ed8a15eee7d80a95f0916c1c8b9405848f53b78f80
+  metadata.gz: ebd40595762cc31d6bb553ca92ea62b2adc0a8ae68e65c88a45ce15ab0d678f51b43259fd70db786c958cfbb26a1e09fb2e51a9726ad7e210e045e80c9435ec4
+  data.tar.gz: d8819b592e8bc6b5857b464cab798a4393ab77e9cdc042090d3d639f43f090f75fbcb875ded15736d3d56a9842b0f6cce71e4c8b8ba6dad5e5c549585d83169f

data/.travis.yml

@@ -1,6 +1,2 @@
 language: ruby
 script: bundle exec rspec spec
-rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
 ## v0.1.0
 
-* initial release with shopping engines: ShoppingUOL (Brazil) and Buscape (Brazil)
+* initial release with shopping engines: ShoppingUOL (Brazil) and Buscape (Brazil)
+
+## v0.1.4
+
+* Drop dependency for ruby 1.9.3

data/README.md

@@ -1,9 +1,7 @@
 # SellObject
 
-By [Ima Bold](http://imabold.com).
-
 [![Code Climate](https://codeclimate.com/github/imaboldcompany/sell_object.png)](https://codeclimate.com/github/imaboldcompany/sell_object)
-[![Build Status](https://travis-ci.org/imaboldcompany/sell_object.svg?branch=master)](https://travis-ci.org/imaboldcompany/sell_object)
+[![Build Status](https://travis-ci.org/dferrazm/sell_object.svg?branch=master)](https://travis-ci.org/dferrazm/sell_object)
 
 SellObject is an extensible solution to make it easy exporting ruby objects to be used on price comparison shopping engines. The gem adds helper methods that format your objects, making them ready to be consumable by the supported price comparison engines.
 
@@ -38,7 +36,7 @@ This will add the SellObject initializer into your Rails config/initializers fol
 
 ### Setting up the class
 
-Suppose you have a class `Product` and want to make its objects sellable through Shopping UOL. 
+Suppose you have a class `Product` and want to make its objects sellable through Shopping UOL.
 You do that by using `sell_through` as shown below:
 
 ```ruby
@@ -73,16 +71,16 @@ SellObject comes with a default mapping to be applied through the exporting proc
 module SellObject
 	module DefaultMappings
 		def self.shopping_uol
-			{ 
-				:CODIGO => :id, 
-				:DESCRICAO => :description, 
+			{
+				:CODIGO => :id,
+				:DESCRICAO => :description,
 				:PRECO => :price,
 				:URL => :url,
 				:URL_IMAGEM => :image_url,
 				:DEPARTAMENTO => :category  
 			}
 		end
-	end	
+	end
 end
 ```
 If you want to use the default mapping, just make sure that the object responds to the required methods. In our example, `product` would have to respond to `:id`, `:description`, `:price` and so forth.
@@ -93,13 +91,13 @@ If you want to create your own mapping, you can define a module named with the o
 module SellObject
 	module ProductMappings
 		def self.shopping_uol
-			{ 
-				:CODIGO => :code, 
-				:DESCRICAO => :details, 
+			{
+				:CODIGO => :code,
+				:DESCRICAO => :details,
 				:URL => :web_page  
 			}
 		end
-	end	
+	end
 end
 ```
 In this case, `product` would have to respond to `:code`, `:details` and `:web_page`. Note that we didn't overwrite all the attribute mappings. The leftovers will fall back to the default mapping. So in this example, `product` would still have to respond to the `:price`, `:image_url` and `:category` methods.
@@ -132,7 +130,7 @@ Here's the list of shopping engines that require a store name for the exporting
 
 ## Contributing
 
-Questions or problems? Please post them on the [issue tracker](https://github.com/imaboldcompany/sell_object/issues).
+Questions or problems? Please post them on the [issue tracker](https://github.com/dferrazm/sell_object/issues).
 
 You can contribute by doing the following:
 
@@ -144,4 +142,4 @@ You can contribute by doing the following:
 
 ## License
 
-MIT License.
+MIT License.

data/lib/sell_object/version.rb

@@ -1,3 +1,3 @@
 module SellObject
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/sell_object.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["d.ferrazm@gmail.com"]
   spec.description   = %q{Extensible solution to make it easy to export ruby objects to be used on price comparison shopping engines}
   spec.summary       = %q{Sell your Ruby on Rails objects on price comparison shopping engines}
-  spec.homepage      = "http://github.com/imaboldcompany/sell_object"
+  spec.homepage      = "http://github.com/dferrazm/sell_object"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)
@@ -18,11 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version     = '>= 1.9.3'
-
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec", "~> 3.0"
 
   spec.add_dependency "nokogiri"
 end

data/spec/sell_object/buscape/formatter_proxy_spec.rb

@@ -5,7 +5,7 @@ describe SellObject::Buscape::FormatterProxy do
 	let(:formatter) { SellObject::Buscape::FormatterProxy.new target_object }
 
 	it 'extends from SellObject::FormatterProxy' do
-		expect(formatter.is_a? SellObject::FormatterProxy).to be_true
+		expect(formatter.is_a? SellObject::FormatterProxy).to be_truthy
 	end
 
 	describe '#preco' do
@@ -17,4 +17,4 @@ describe SellObject::Buscape::FormatterProxy do
 			expect { formatter.preco :description }.to raise_error ArgumentError, 'method expects a number, got String: Lorem ipsum'
 		end
 	end
-end
+end

data/spec/sell_object/buscape_spec.rb

@@ -12,7 +12,7 @@ describe SellObject::Buscape do
 		let(:product) { Product.new }
 
 		before do
-			SellObject::XmlFormatter.stub(:format).and_return 'xml element'
+			allow(SellObject::XmlFormatter).to receive(:format).and_return 'xml element'
 		end
 
 		describe 'class_methods' do
@@ -36,50 +36,50 @@ describe SellObject::Buscape do
 						expect(remove_xml_noise product.to_buscape('My Awesome  Store')).to match /<My_Awesome_Store><produtos>.*<\/produtos><\/My_Awesome_Store>/
 					end
 				end
-			end			
+			end
 		end
-	end	
+	end
 
 	describe '#wrap_xml' do
 		before do
-			SellObject::Config.stub(:store_name).and_return 'awesome'
+			allow(SellObject::Config).to receive(:store_name).and_return 'awesome'
 		end
 
 		it 'inserts the timestamp into the xml' do
 			timestamp = Time.now.to_s
-			subject.stub(:timestamp).and_return '2014-03-29 13:28:32 -0300'
+			allow(subject).to receive(:timestamp).and_return '2014-03-29 13:28:32 -0300'
 			expect(subject.wrap_xml 'xml elements').to include '<!--2014-03-29 13:28:32 -0300-->'
 		end
 
 		it 'inserts the given elements inside the <produtos> tag' do
-			expect(remove_xml_noise subject.wrap_xml('xml elements')).to include '<produtos>xml elements</produtos>'			
+			expect(remove_xml_noise subject.wrap_xml('xml elements')).to include '<produtos>xml elements</produtos>'
 		end
 
 		it 'wraps the <produtos> tag with the store name set up in config' do
-			SellObject::Config.stub(:store_name).and_return 'awesome'
+			allow(SellObject::Config).to receive(:store_name).and_return 'awesome'
 			expect(remove_xml_noise subject.wrap_xml('elements')).to match /<awesome><produtos>.*<\/produtos><\/awesome>/
-		end		
+		end
 
 		it 'raises an error if theres no store name set up' do
-			SellObject::Config.stub(:store_name).and_return nil
+			allow(SellObject::Config).to receive(:store_name).and_return nil
 			expect { subject.wrap_xml 'elements' }.to raise_error ArgumentError, 'No store name found (nil). You have to either pass it as an argument or set it up in SellObject::Config'
 		end
 
 		context 'when passing the store name as an argument' do
 			it 'wraps the <produtos> tag with the given store name' do
 				expect(remove_xml_noise subject.wrap_xml('elements', 'boring')).to match /<boring><produtos>.*<\/produtos><\/boring>/
-			end		
+			end
 		end
 	end
 
 	describe '#timestamp' do
 		it 'returns the time now correctly formatted' do
-			Time.stub(:now).and_return Time.new(2014,3,28,10,42,48,'-03:00')
+			allow(Time).to receive(:now).and_return Time.new(2014,3,28,10,42,48,'-03:00')
 			expect(subject.timestamp).to eq 'Generated at 2014-03-28T10:42:48GMT-3'
-			Time.stub(:now).and_return Time.new(2011,1,4,17,22,58,'+01:00')
+			allow(Time).to receive(:now).and_return Time.new(2011,1,4,17,22,58,'+01:00')
 			expect(subject.timestamp).to eq 'Generated at 2011-01-04T17:22:58GMT+1'
-			Time.stub(:now).and_return Time.new(2011,1,4,17,22,58,'+00:00')
+			allow(Time).to receive(:now).and_return Time.new(2011,1,4,17,22,58,'+00:00')
 			expect(subject.timestamp).to eq 'Generated at 2011-01-04T17:22:58GMT+0'
 		end
 	end
-end
+end

data/spec/sell_object/xml_formatter_spec.rb

@@ -5,7 +5,7 @@ describe SellObject::XmlFormatter do
 		let(:target_object) { double some_value: 'some value' }
 
 		before do
-			SellObject.stub(:mapping_for).with(target_object, :foo).and_return({some_tag: :some_value})
+			allow(SellObject).to receive(:mapping_for).with(target_object, :foo).and_return({some_tag: :some_value})
 		end
 
 		it 'formats an object into a xml element based on its mapping, given an engine and a xml root' do

data/spec/sell_object_spec.rb

@@ -12,12 +12,8 @@ describe SellObject do
 			Object.send :remove_const, :TargetClass
 		end
 
-		it 'makes the target class extend SellObject::ClassMethods'	do
-			expect(TargetClass.is_a? SellObject::ClassMethods).to be_true
-		end
-
 		describe 'ClassMethods' do
-			describe '#sell_through' do		
+			describe '#sell_through' do
 				context 'passing invalid arguments' do
 					it 'raises ArgumentError with an invalid engine' do
 						expect { TargetClass.sell_through :foo }.to raise_error ArgumentError, 'invalid shopping engine foo'
@@ -28,22 +24,22 @@ describe SellObject do
 					end
 				end
 
-				context 'buscape' do			
+				context 'buscape' do
 					it 'includes the module SellObject::Buscape in the target class' do
 						TargetClass.sell_through :buscape
-						expect(TargetClass.included_modules).to include SellObject::Buscape				
+						expect(TargetClass.included_modules).to include SellObject::Buscape
 					end
 				end
 
-				context 'shopping_uol' do			
+				context 'shopping_uol' do
 					it 'includes the module SellObject::ShoppingUol in the target class' do
 						TargetClass.sell_through :shopping_uol
-						expect(TargetClass.included_modules).to include SellObject::ShoppingUol				
+						expect(TargetClass.included_modules).to include SellObject::ShoppingUol
 					end
 				end
 			end
 		end
-	end	
+	end
 
 	describe '#supported_engines' do
 		it 'returns the supported shopping engines array' do
@@ -59,13 +55,13 @@ describe SellObject do
 			end
 			expect(config_module.name).to eq 'SellObject::Config'
 		end
-	end	
+	end
 
 	describe '#mapping_for' do
 		before do
-			SellObject.stub(:supported_engines).and_return %w(bar)
-			SellObject::DefaultMappings.stub(:bar).and_return({t1: :v1, t2: :v2})
-			
+			allow(SellObject).to receive(:supported_engines).and_return %w(bar)
+			allow(SellObject::DefaultMappings).to receive(:bar).and_return({t1: :v1, t2: :v2})
+
 			class TargetObject
 			end
 		end
@@ -83,7 +79,7 @@ describe SellObject do
 				expect(subject.mapping_for TargetObject.new, :bar).to eq({t1: :v1, t2: :v2})
 			end
 		end
-		
+
 		context 'when there\s a custom mapping defined' do
 			before do
 				module SellObject::TargetObjectMappings
@@ -115,6 +111,6 @@ describe SellObject do
 				subject.store_name = 'My Store'
 				expect(subject.store_name).to eq 'My Store'
 			end
-		end		
+		end
 	end
-end
+end

data/spec/support/shared_examples/shopping_engine.rb

@@ -7,21 +7,21 @@ shared_examples_for 'shopping_engine' do |engine|
 	let(:products) { [lame_product, boring_product] }
 
 	before do
-		lame_product.stub(:id).and_return 'PR1'
-		lame_product.stub(:description).and_return 'Some lame product'
-		lame_product.stub(:price).and_return 10.5
-		lame_product.stub(:category).and_return 'Electronics'
-		lame_product.stub(:url).and_return 'http://example.com/lame-product'
-		lame_product.stub(:image_url).and_return 'http://example.com/images/lame-product.png'
+		allow(lame_product).to receive(:id).and_return 'PR1'
+		allow(lame_product).to receive(:description).and_return 'Some lame product'
+		allow(lame_product).to receive(:price).and_return 10.5
+		allow(lame_product).to receive(:category).and_return 'Electronics'
+		allow(lame_product).to receive(:url).and_return 'http://example.com/lame-product'
+		allow(lame_product).to receive(:image_url).and_return 'http://example.com/images/lame-product.png'
 
-		boring_product.stub(:id).and_return 'PR2'
-		boring_product.stub(:description).and_return 'Some boring product'
-		boring_product.stub(:price).and_return 7
-		boring_product.stub(:category).and_return 'Kitchenware'
-		boring_product.stub(:url).and_return 'http://example.com/boring-product'
-		boring_product.stub(:image_url).and_return 'http://example.com/images/boring-product.png'
+		allow(boring_product).to receive(:id).and_return 'PR2'
+		allow(boring_product).to receive(:description).and_return 'Some boring product'
+		allow(boring_product).to receive(:price).and_return 7
+		allow(boring_product).to receive(:category).and_return 'Kitchenware'
+		allow(boring_product).to receive(:url).and_return 'http://example.com/boring-product'
+		allow(boring_product).to receive(:image_url).and_return 'http://example.com/images/boring-product.png'
 
-		SellObject::Config.stub(:store_name).and_return 'awesome_store'
+		allow(SellObject::Config).to receive(:store_name).and_return 'awesome_store'
 	end
 
 	describe 'class_methods' do
@@ -34,10 +34,10 @@ shared_examples_for 'shopping_engine' do |engine|
 
 			context 'using custom mappings' do
 				before do
-					lame_product.stub(:custom_description).and_return 'My custom lame product description'
-					lame_product.stub(:custom_url).and_return 'http://example.com/custom-lame-product'
-					boring_product.stub(:custom_description).and_return 'My custom boring product description'
-					boring_product.stub(:custom_url).and_return 'http://example.com/custom-boring-product'
+					allow(lame_product).to receive(:custom_description).and_return 'My custom lame product description'
+					allow(lame_product).to receive(:custom_url).and_return 'http://example.com/custom-lame-product'
+					allow(boring_product).to receive(:custom_description).and_return 'My custom boring product description'
+					allow(boring_product).to receive(:custom_url).and_return 'http://example.com/custom-boring-product'
 
 					module SellObject::ProductMappings
 		 				def self.buscape
@@ -47,7 +47,7 @@ shared_examples_for 'shopping_engine' do |engine|
 		 				def self.shopping_uol
 			 				{ :DESCRICAO => :custom_description,  :URL => :custom_url }
 			 			end
-			 		end		
+			 		end
 				end
 
 				after do
@@ -57,7 +57,7 @@ shared_examples_for 'shopping_engine' do |engine|
 				it 'generates the XML accordingly with all the objects attributes and the custom mappings' do
 					expect(remove_xml_noise Product.send("to_#{engine}", products)).to eq remove_xml_noise macros::CUSTOM_MAPPING_FIXTURE_MANY
 				end
-			end			
+			end
 		end
 	end
 
@@ -66,11 +66,6 @@ shared_examples_for 'shopping_engine' do |engine|
 			it 'generates the XML accordingly with the object attributes' do
 				expect(remove_xml_noise lame_product.send("to_#{engine}")).to eq remove_xml_noise macros::DEFAULT_MAPPING_FIXTURE_ONE
 			end
-
-			# it "calls the #to_#{engine} class method passing the instance wrapped in an array" do
-			# 	Product.should_receive(:"to_#{engine}").with [lame_product]
-			# 	lame_product.send "to_#{engine}"
-			# end
-		end			
+		end
 	end
-end
+end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: sell_object
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Daniel Ferraz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-01 00:00:00.000000000 Z
+date: 2015-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Extensible solution to make it easy to export ruby objects to be used
@@ -74,9 +74,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -104,7 +104,7 @@ files:
 - spec/support/engine_macros.rb
 - spec/support/shared_examples/shopping_engine.rb
 - spec/support/spec_macros.rb
-homepage: http://github.com/imaboldcompany/sell_object
+homepage: http://github.com/dferrazm/sell_object
 licenses:
 - MIT
 metadata: {}
@@ -114,17 +114,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Sell your Ruby on Rails objects on price comparison shopping engines