selfies 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d2779a51d2de784eefdf3f45ceea218f7d6fb7cc
-  data.tar.gz: 036c1e49e616d5417bcb13ede00d67ee2881f111
+  metadata.gz: 85d6373067c8c9773cbf11a7c4a5cd4f522c3cde
+  data.tar.gz: 03b21feacc2cb82878bc201ed807c2c83942d209
 SHA512:
-  metadata.gz: 7ab254cd4b2e08f68f78507a566d3a54bd67ba27f7ffc280881166dd5589310b69ca93fc44d8fbd53c6e4d80f746adde3071ec0b33800eec160468d4fdba5a84
-  data.tar.gz: 01bce53ae70ed2faa87191dc6c58a57331d5131463d3e35efbbba8e51385ea833307d232b16acf0d19252bb9fcb7087130ffb965322aaac312ef6af81c957b6d
+  metadata.gz: 408b2541b8760bcea0c5e8e48ae626279b0b1294b391fbbfc221a5f08511a33b91a060ef0df08b2798edae25e7e3a04dd13a90125945876241e247dc844a2178
+  data.tar.gz: 656a2d54502b6353ab1b7c332b262ae964a7f34cfabcefbce1e3fcdef6b8eddae97e9ef814ad9541c6f407484487ff57204a0ec1399879e7d3d70a10eb4d7ca8

data/.gitignore

@@ -7,6 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
-
-# rspec failure tracking
 .rspec_status

data/CODE_OF_CONDUCT.md

@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
 ## Enforcement
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at mario.darco@onthebeach.co.uk. All
+reported by contacting the project team at mariodarco78@icloud.com All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. The project team is
 obligated to maintain confidentiality with regard to the reporter of an incident.

data/Gemfile

@@ -1,4 +1,3 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-# Specify your gem's dependencies in selfies.gemspec
 gemspec

data/README.md

@@ -12,6 +12,45 @@ Another day at work, or on your personal project, and you need to create yet ano
 
 This gets boring with the years. So boring that someone might decide to write some macros to reduce the boilerplate.
 
+## TL;DR
+
+You add this:
+```ruby
+gem 'selfies'
+```
+
+You write this:
+```ruby
+class Rectangle
+  attr_accessor_init :width, :height, scale: 100
+  selfie :area, :perimeter
+
+  def area
+    proportion(width * height)
+  end
+
+  def perimeter
+    proportion((width + height) * 2)
+  end
+
+  private
+
+  def proportion(value)
+    value.to_f / 100 * scale
+  end
+end
+```
+
+You get this:
+```ruby
+>> Rectangle.area(8, 4)
+=> 32.0
+>> Rectangle.perimeter(5, 3)
+=> 16.0
+>> Rectangle.perimeter(5, 3, 50)
+=> 8.0
+```
+
 ## Disclaimer
 In this project you will likely read me using both ```initialize``` and ```initialise```. I'm Italian, I learnt to code from American books and now live in UK, to me they both make sense. As a rule of thumb, it's the ```ize``` form in code and ```ise``` form everywhere else. But might mix them so bear with me. Thanks!
 
@@ -60,21 +99,21 @@ class Search
 end
 ```
 
-***attr_accessor_init***: same as ```attr_reader_init```, but generates accessors for the given attributes
+It is possible to specify a default for the last argument only:
 
 This code:
 ```ruby
 class Search
-  attr_accessor_init :term, :page, :limit
+  attr_reader_init :term, :page, limit: 5
 end
 ```
 
 Is equivalent to:
 ```ruby
 class Search
-  attr_accessor :term, :page, :limit
+  attr_reader :term, :page, :limit
 
-  def initialize(term, page, limit)
+  def initialize(term, page, limit = 5)
     @term = term
     @page = page
     @limit = limit
@@ -82,32 +121,60 @@ class Search
 end
 ```
 
-It is possible to specify a default for the last argument only:
+```ruby
+>> search = Search.new('foo', 1)
+>> search.limit
+=> 5
+```
+
+You can use any variable name that would make for a valid Ruby variable;
+Only exception is ```:args``` which is used by ```selfies``` to define a splat operator:
 
 This code:
 ```ruby
 class Search
-  attr_accessor_init :term, :page, limit: 5
+  attr_reader_init :term, :args
 end
 ```
 
 Is equivalent to:
 ```ruby
 class Search
-  attr_accessor :term, :page, :limit
+  attr_reader :term, :args
 
-  def initialize(term, page, limit = 5)
+  def initialize(term, *args)
     @term = term
-    @page = page
-    @limit = limit
+    @args = args
   end
 end
 ```
 
 ```ruby
->> search = Search.new('foo', 1)
->> search.limit
-=> 5
+>> search = Search.new('foo', 2, 10)
+>> search.args
+=> [2, 10]
+```
+
+***attr_accessor_init***: same as ```attr_reader_init```, but generates accessors for the given attributes
+
+This code:
+```ruby
+class Search
+  attr_accessor_init :term, :page, :limit
+end
+```
+
+Is equivalent to:
+```ruby
+class Search
+  attr_accessor :term, :page, :limit
+
+  def initialize(term, page, limit)
+    @term = term
+    @page = page
+    @limit = limit
+  end
+end
 ```
 
 ***selfie***: can be used to automatically create a class method that reference to the instance method of the same class
@@ -174,36 +241,10 @@ class Search
 end
 ```
 
-## TL;DR
-
-You write this:
-```ruby
-class Rectangle
-  attr_accessor_init :width, :height
-  selfie :area, :perimeter
-
-  def area
-    width * height
-  end
-
-  def perimeter
-    (width + height) * 2
-  end
-end
-```
-
-You get this:
-```ruby
->> Rectangle.area(8, 4)
-=> 32
->> Rectangle.perimeter(5, 3)
-=> 16
-```
-
 ## Next Steps
 
 ***attr_reader_init*** and ***attr_accessor_init:***
-- Implement the possibility to pass indefinite number of arguments;
+- Improve message when raising ArgumentError;
 
 ***selfie:***
 - Find a suitable syntax that would allow to 'selfie' an instance method that has arguments;

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,6 @@
 #!/usr/bin/env ruby
-
-require "bundler/setup"
-require "selfies"
+require 'bundler/setup'
+require 'selfies'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -9,6 +8,5 @@ require "selfies"
 # (If you use this, don't forget to add pry to your Gemfile!)
 # require "pry"
 # Pry.start
-
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/lib/selfies/self_init.rb

@@ -18,16 +18,24 @@ module Selfies
 
           variables.each_with_index do |variable, index|
             variable_name, default = decouple(variable)
-            instance_variable_set("@#{variable_name}", args[index] || default)
+            if variable_name == :args
+              instance_variable_set("@#{variable_name}", args[index..-1] || default)
+            else
+              instance_variable_set("@#{variable_name}", args[index] || default)
+            end
           end
         end
 
         private_class_method
 
         define_method(:correct_argument_count?) do |variables, expected, given|
+
           correct_argument_count = given == expected
           if variables.last.is_a? Hash
             correct_argument_count ||= given == expected - 1
+          elsif variables.last == :args
+            at_least = variables[0..variables.index(:args)].count
+            correct_argument_count ||= given >= at_least
           end
 
           correct_argument_count

data/lib/selfies/version.rb

@@ -1,3 +1,3 @@
 module Selfies
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selfies
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Mario D’Arco