selenium-webdriver 4.51.0 → 4.52.0

data/lib/selenium/webdriver/common/websocket_connection.rb

@@ -109,16 +109,21 @@ module Selenium
         data = JSON.generate(data)
         out_frame = WebSocket::Frame::Outgoing::Client.new(version: ws.version, data: data, type: 'text')
 
-        begin
-          socket.write(out_frame.to_s)
-        rescue *CONNECTION_ERRORS => e
-          raise e, "WebSocket is closed (#{e.class}: #{e.message})"
-        end
+        @messages_mtx.synchronize { pending_responses[id] = ConditionVariable.new }
 
-        wait.until do
-          raise IOError, 'WebSocket connection closed while waiting for a response' if @closing
+        begin
+          begin
+            socket.write(out_frame.to_s)
+          rescue *CONNECTION_ERRORS => e
+            raise e, "WebSocket is closed (#{e.class}: #{e.message})"
+          end
 
-          @messages_mtx.synchronize { messages.delete(id) }
+          await_response(id)
+        ensure
+          @messages_mtx.synchronize do
+            pending_responses.delete(id)
+            messages.delete(id)
+          end
         end
       end
 
@@ -128,6 +133,30 @@ module Selenium
         @messages ||= {}
       end
 
+      def pending_responses
+        @pending_responses ||= {}
+      end
+
+      def await_response(id)
+        deadline = Process.clock_gettime(Process::CLOCK_MONOTONIC) + RESPONSE_WAIT_TIMEOUT
+        @messages_mtx.synchronize do
+          until messages.key?(id)
+            raise IOError, 'WebSocket connection closed while waiting for a response' if @closing
+
+            remaining = deadline - Process.clock_gettime(Process::CLOCK_MONOTONIC)
+            raise Error::TimeoutError, "timed out after #{RESPONSE_WAIT_TIMEOUT} seconds" if remaining <= 0
+
+            pending_responses[id].wait(@messages_mtx, remaining)
+          end
+          messages.delete(id)
+        end
+      end
+
+      # Once the socket is closed no reply can arrive, so wake waiters instead of letting them run out the timeout
+      def release_pending_responses
+        @messages_mtx.synchronize { pending_responses.each_value(&:broadcast) }
+      end
+
       def process_handshake
         socket.print(ws.to_s)
         ws << socket.readpartial(1024) until ws.finished?
@@ -147,6 +176,9 @@ module Selenium
           end
         rescue *CONNECTION_ERRORS, WebSocket::Error => e
           WebDriver.logger.debug "WebSocket listener closed: #{e.class}: #{e.message}", id: :ws
+        ensure
+          # Nothing reads replies once the listener stops, however it stopped
+          close_socket
         end
       end
 
@@ -155,6 +187,8 @@ module Selenium
         socket.close
       rescue *CONNECTION_ERRORS => e
         WebDriver.logger.debug "WebSocket socket closed: #{e.class}: #{e.message}", id: :ws
+      ensure
+        release_pending_responses
       end
 
       def process_incoming_frames
@@ -198,7 +232,15 @@ module Selenium
         return {} if message.empty?
 
         msg = JSON.parse(message)
-        @messages_mtx.synchronize { messages[msg['id']] = msg if msg.key?('id') }
+        if msg.key?('id')
+          @messages_mtx.synchronize do
+            # Replies to commands that already timed out are dropped so they don't accumulate
+            if (waiter = pending_responses[msg['id']])
+              messages[msg['id']] = msg
+              waiter.signal
+            end
+          end
+        end
 
         WebDriver.logger.debug('WebSocket <-', id: :ws) { msg.to_s[...MAX_LOG_MESSAGE_SIZE] }
         msg
@@ -221,10 +263,6 @@ module Selenium
         end
       end
 
-      def wait
-        @wait ||= Wait.new(timeout: RESPONSE_WAIT_TIMEOUT, interval: RESPONSE_WAIT_INTERVAL)
-      end
-
       def socket
         @socket ||= if URI(@url).scheme == 'wss'
                       socket = TCPSocket.new(ws.host, ws.port)

data/lib/selenium/webdriver/remote/http/default.rb

@@ -72,7 +72,11 @@ module Selenium
               http = new_http_client
               if server_url.scheme == 'https'
                 http.use_ssl = true
-                http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+                http.verify_mode = if client_config.ignore_certificates
+                                     OpenSSL::SSL::VERIFY_NONE
+                                   else
+                                     OpenSSL::SSL::VERIFY_PEER
+                                   end
               end
 
               http.open_timeout = open_timeout if open_timeout
@@ -85,6 +89,18 @@ module Selenium
 
           def start(http)
             http.start
+          rescue OpenSSL::SSL::SSLError => e
+            failure = e.message.match(/certificate verify failed(?: \((.+?)\))?/)
+            raise unless failure
+
+            raise e.class, unverified_certificate_message(failure[1] || failure[0]), e.backtrace
+          end
+
+          def unverified_certificate_message(reason)
+            location = server_url.dup.tap { |url| url.user = nil }
+            "Cannot verify the certificate for #{location} (#{reason}). " \
+              'Trust its issuer if it is self-signed or from a private CA, ' \
+              'or skip verification with ignore_certificates: true on a ClientConfig passed to the driver constructor'
           end
 
           MAX_RETRIES = 3

data/lib/selenium/webdriver/version.rb

@@ -19,6 +19,6 @@
 
 module Selenium
   module WebDriver
-    VERSION = '4.51.0'
+    VERSION = '4.52.0'
   end # WebDriver
 end # Selenium

data/selenium-webdriver.gemspec

@@ -53,16 +53,4 @@ Gem::Specification.new do |s|
   s.add_dependency 'logger', ['~> 1.4']
   s.add_dependency 'rubyzip', ['>= 1.2.2', '< 4.0']
   s.add_dependency 'websocket', ['~> 1.0']
-
-  s.add_development_dependency 'git', ['~> 1.19']
-  s.add_development_dependency 'rack', ['~> 2.0']
-  s.add_development_dependency 'rake', ['~> 13.0']
-  s.add_development_dependency 'rspec', ['~> 3.0']
-  s.add_development_dependency 'rubocop', ['~> 1.75']
-  s.add_development_dependency 'rubocop-performance', ['~> 1.25']
-  s.add_development_dependency 'rubocop-rake', ['~> 0.7']
-  s.add_development_dependency 'rubocop-rspec', ['~> 3.5']
-  s.add_development_dependency 'webmock', ['~> 3.5']
-  s.add_development_dependency 'webrick', ['~> 1.7']
-  s.add_development_dependency 'yard', ['~> 0.9.11', '>= 0.9.36']
 end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: selenium-webdriver
 version: !ruby/object:Gem::Version
-  version: 4.51.0
+  version: 4.52.0
 platform: ruby
 authors:
 - Alex Rodionov
 - Titus Fortner
 - Thomas Walpole
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64
@@ -73,166 +74,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: git
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.19'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.19'
-- !ruby/object:Gem::Dependency
-  name: rack
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.75'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.75'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.25'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.25'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
-- !ruby/object:Gem::Dependency
-  name: webrick
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.11
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.36
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.11
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.36
 description: |2
       Selenium implements the W3C WebDriver protocol to automate popular browsers.
       It aims to mimic the behaviour of a real user as it interacts with the application's HTML.
@@ -472,6 +313,7 @@ metadata:
   source_code_uri: https://github.com/SeleniumHQ/selenium/tree/trunk/rb
   rubygems_mfa_required: 'true'
   funding_uri: https://github.com/sponsors/SeleniumHQ
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -486,7 +328,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: Selenium is a browser automation tool for automated testing of webapps and
   more