selenium-webdriver 3.5.2 → 3.6.0

data/CHANGES

@@ -1,5 +1,19 @@
+3.6.0 (2017-09-22)
+==================
+
+Edge:
+  * Fixed a bug when execute_script failed using server + Edge (issue #4651)
+
+Firefox:
+  * Fixed a bug when web extension failed to install using profile class (issue #4093)
+
+PhantomJS:
+  * Support is deprecated in favor of headless Chrome/Firefox or HTMLUnit.
+    PhantomJS is no longer actively developed, and support will eventually
+    be dropped.
+
 3.5.2 (2017-09-07)
-  ==================
+==================
 
 Ruby:
   * Removed platformVersion from W3C payload (issue #4641)

data/lib/selenium/server.rb

@@ -84,7 +84,7 @@ module Selenium
                   progress += segment.length
                   segment_count += 1
 
-                  if segment_count % 15 == 0
+                  if (segment_count % 15).zero?
                     percent = (progress.to_f / total.to_f) * 100
                     print "#{CL_RESET}Downloading #{download_file_name}: #{percent.to_i}% (#{progress} / #{total})"
                     segment_count = 0

data/lib/selenium/webdriver/common/platform.rb

@@ -117,7 +117,7 @@ module Selenium
       end
 
       def make_writable(file)
-        File.chmod 0766, file
+        File.chmod 0o766, file
       end
 
       def assert_file(path)
@@ -208,7 +208,7 @@ module Selenium
   end # WebDriver
 end # Selenium
 
-if __FILE__ == $PROGRAM_NAME
+if $PROGRAM_NAME == __FILE__
   p engine: Selenium::WebDriver::Platform.engine,
     os: Selenium::WebDriver::Platform.os,
     ruby_version: Selenium::WebDriver::Platform.ruby_version,

data/lib/selenium/webdriver/common/port_prober.rb

@@ -40,6 +40,7 @@ module Selenium
 
       IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+      IGNORED_ERRORS << Errno::EACCES if Platform.windows?
       IGNORED_ERRORS.freeze
 
       def self.free?(port)

data/lib/selenium/webdriver/common/profile_helper.rb

@@ -46,7 +46,7 @@ module Selenium
 
         # TODO: must be a better way..
         FileUtils.rm_rf tmp_directory
-        FileUtils.mkdir_p File.dirname(tmp_directory), mode: 0700
+        FileUtils.mkdir_p File.dirname(tmp_directory), mode: 0o700
         FileUtils.cp_r directory, tmp_directory
 
         tmp_directory

data/lib/selenium/webdriver/common/service.rb

@@ -155,7 +155,7 @@ module Selenium
       protected
 
       def extract_service_args(driver_opts)
-        driver_opts.key?(:args) ? driver_opts.delete(:args) :  []
+        driver_opts.key?(:args) ? driver_opts.delete(:args) : []
       end
 
     end # Service

data/lib/selenium/webdriver/edge/bridge.rb

@@ -24,10 +24,10 @@ module Selenium
 
         def commands(command)
           unsupported = %i[execute_script execute_async_script submit_element double_click
-           mouse_down mouse_up mouse_move_to click
-           send_keys_to_active_element get_window_handles get_current_window_handle
-           get_window_size set_window_size get_window_position set_window_position
-           maximize_window get_alert_text accept_alert dismiss_alert]
+                           mouse_down mouse_up mouse_move_to click
+                           send_keys_to_active_element get_window_handles get_current_window_handle
+                           get_window_size set_window_size get_window_position set_window_position
+                           maximize_window get_alert_text accept_alert dismiss_alert]
           if unsupported.include? command
             Remote::OSS::Bridge::COMMANDS[command]
           else

data/lib/selenium/webdriver/firefox/extension.rb

@@ -38,10 +38,10 @@ module Selenium
 
         def write_to(extensions_dir)
           root_dir = create_root
-          ext_path = File.join extensions_dir, read_id_from_install_rdf(root_dir)
+          ext_path = File.join extensions_dir, read_id(root_dir)
 
           FileUtils.rm_rf ext_path
-          FileUtils.mkdir_p File.dirname(ext_path), mode: 0700
+          FileUtils.mkdir_p File.dirname(ext_path), mode: 0o700
           FileUtils.cp_r root_dir, ext_path
 
           FileReaper.reap(root_dir) if @should_reap_root
@@ -62,8 +62,14 @@ module Selenium
           end
         end
 
+        def read_id(directory)
+          read_id_from_install_rdf(directory) || read_id_from_manifest_json(directory)
+        end
+
         def read_id_from_install_rdf(directory)
           rdf_path = File.join(directory, 'install.rdf')
+          return unless File.exist?(rdf_path)
+
           doc = REXML::Document.new(File.read(rdf_path))
           namespace = doc.root.namespaces.key(NAMESPACE)
 
@@ -77,6 +83,14 @@ module Selenium
 
           raise Error::WebDriverError, "cannot locate extension id in #{rdf_path}"
         end
+
+        def read_id_from_manifest_json(directory)
+          manifest_path = File.join(directory, 'manifest.json')
+          return unless File.exist?(manifest_path)
+
+          manifest = JSON.parse(File.read(manifest_path))
+          [manifest['name'].delete(' '), manifest['version']].join('@')
+        end
       end # Extension
     end # Firefox
   end # WebDriver

data/lib/selenium/webdriver/firefox/launcher.rb

@@ -90,11 +90,11 @@ module Selenium
         end
 
         def fetch_profile
-          if @profile_name
-            @profile = Profile.from_name @profile_name
-          else
-            @profile = Profile.new
-          end
+          @profile = if @profile_name
+                       Profile.from_name @profile_name
+                     else
+                       Profile.new
+                     end
         end
 
         def assert_profile

data/lib/selenium/webdriver/firefox/marionette/bridge.rb

@@ -34,7 +34,7 @@ module Selenium
 
           def install_addon(path, temporary)
             payload = {path: path}
-            payload.merge!(temporary: temporary) unless temporary.nil?
+            payload[:temporary] = temporary unless temporary.nil?
             execute :install_addon, {}, payload
           end
 

data/lib/selenium/webdriver/phantomjs/driver.rb

@@ -30,6 +30,8 @@ module Selenium
         include DriverExtensions::TakesScreenshot
 
         def initialize(opts = {})
+          WebDriver.logger.deprecate 'Selenium support for PhantomJS', 'headless Chrome/Firefox or HTMLUnit'
+
           opts[:desired_capabilities] ||= Remote::Capabilities.phantomjs
 
           unless opts.key?(:url)

data/lib/selenium/webdriver/remote/capabilities.rb

@@ -48,6 +48,15 @@ module Selenium
           end
         end
 
+        #
+        # Returns javascript_enabled capability.
+        # It is true if not set explicitly.
+        #
+        def javascript_enabled
+          javascript_enabled = @capabilities.fetch(:javascript_enabled)
+          javascript_enabled.nil? ? true : javascript_enabled
+        end
+
         alias_method :css_selectors_enabled?, :css_selectors_enabled
         alias_method :javascript_enabled?, :javascript_enabled
         alias_method :native_events?, :native_events
@@ -111,6 +120,7 @@ module Selenium
           alias_method :ie, :internet_explorer
 
           def phantomjs(opts = {})
+            WebDriver.logger.deprecate 'Selenium support for PhantomJS', 'headless Chrome/Firefox or HTMLUnit'
             new({
               browser_name: 'phantomjs',
               javascript_enabled: true,

data/lib/selenium/webdriver/remote/http/default.rb

@@ -94,7 +94,6 @@ module Selenium
               retries += 1
               sleep 2
               retry
-
             rescue Errno::ECONNREFUSED => ex
               raise ex.class, "using proxy: #{proxy.http}" if use_proxy?
               raise

data/lib/selenium/webdriver/support/color.rb

@@ -78,12 +78,12 @@ module Selenium
           l = Float(l) / 100
           a = Float(a || 1)
 
-          if s == 0
+          if s.zero?
             r = l
             g = r
             b = r
           else
-            luminocity2 = (l < 0.5) ? l * (1 + s) : l + s - l * s
+            luminocity2 = l < 0.5 ? l * (1 + s) : l + s - l * s
             luminocity1 = 2 * l - luminocity2
 
             r = hue_to_rgb(luminocity1, luminocity2, h + 1.0 / 3.0)

data/selenium-webdriver.gemspec

@@ -5,7 +5,7 @@ raise "cwd must be #{root} when reading gemspec" if root != Dir.pwd
 
 Gem::Specification.new do |s|
   s.name = 'selenium-webdriver'
-  s.version = '3.5.2'
+  s.version = '3.6.0'
 
   s.authors = ['Alex Rodionov', 'Titus Fortner']
   s.email = ['p0deje@gmail.com', 'titusfortner@gmail.com']

metadata

@@ -2,7 +2,7 @@
 name: selenium-webdriver
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 3.5.2
+  version: 3.6.0
 platform: ruby
 authors: 
   - Alex Rodionov
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2017-09-07 00:00:00 +07:00
+date: 2017-09-25 00:00:00 +02:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -96,7 +96,6 @@ extra_rdoc_files: []
 files: 
   - CHANGES
   - Gemfile
-  - Gemfile.lock
   - LICENSE
   - README.md
   - selenium-webdriver.gemspec

data/Gemfile.lock

@@ -1,56 +0,0 @@
-PATH
-  remote: .
-  specs:
-    selenium-webdriver (3.5.1)
-      childprocess (~> 0.5)
-      rubyzip (~> 1.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.5.1)
-      public_suffix (~> 2.0, >= 2.0.2)
-    childprocess (0.7.1)
-      ffi (~> 1.0, >= 1.0.11)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.3)
-    ffi (1.9.18)
-    ffi (1.9.18-x64-mingw32)
-    hashdiff (0.3.4)
-    public_suffix (2.0.5)
-    rack (1.6.8)
-    rspec (3.6.0)
-      rspec-core (~> 3.6.0)
-      rspec-expectations (~> 3.6.0)
-      rspec-mocks (~> 3.6.0)
-    rspec-core (3.6.0)
-      rspec-support (~> 3.6.0)
-    rspec-expectations (3.6.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-mocks (3.6.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-support (3.6.0)
-    rubyzip (1.2.1)
-    safe_yaml (1.0.4)
-    webmock (2.3.2)
-      addressable (>= 2.3.6)
-      crack (>= 0.3.2)
-      hashdiff
-    yard (0.9.9)
-
-PLATFORMS
-  ruby
-  x64-mingw32
-
-DEPENDENCIES
-  rack (~> 1.0)
-  rspec (~> 3.0)
-  selenium-webdriver!
-  webmock (~> 2.0)
-  yard (~> 0.9.9)
-
-BUNDLED WITH
-   1.15.4