selenium-webdriver 3.142.0 → 3.142.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c49d98b41b1b4019754a8c48e695d80c13a6920
-  data.tar.gz: 89388af584e8090ab3ffc07744800a4476616ec6
+  metadata.gz: d3ab72be7aa7d763442528c54d9cfcd5ca5d2b14
+  data.tar.gz: c26d2d6a59e9268990ea74cc32d8302bddad5fdb
 SHA512:
-  metadata.gz: 3a395f0069eab5781ce742630a13d688d3c7a9688806105f938b266fc515fefbc71b0ac08248784f0594a7e0a07e27d59b309d4b39808be262344e1c7b1ec96e
-  data.tar.gz: a1d3bf1d12ca7209b5d92d27f2a530ecdf15fd3f9a8ab125380064e656e434b3fbb9010f4b0bd2e9ceb2477e33d46b73a1e0ed10140d153799ce8ebda5b0a222
+  metadata.gz: bdc0d5a6d9ccf1f66002f0b6536e12c04fa894df838c306b34c951a20e0e66a9df59d8fb22e198bef5fd4d4613e06430ed4809ae5b7be3d651677436a198bd94
+  data.tar.gz: f13990a7b3af740745c75fe362bf1b0ab4118bf8f1471a48e8245da2e39107146fbc9ba83ef419bd92bd04723ecbe9e6ddba31b3d768f6e06a7f495a35a04176

data/CHANGES

@@ -1,3 +1,29 @@
+3.142.3 (2019-05-21)
+====================
+
+Firefox:
+  * Fixed a regression when Firefox binary path was not sent to GeckoDriver
+    by default and browser could not be located (issue #7219)
+
+
+3.142.2 (2019-05-11)
+====================
+
+Chrome:
+  * Fixed an issue when getting/setting network conditions and sending CDP
+    commands didn't work with Grid (issue #7174)
+
+Safari:
+  * Fixed an issue when getting/setting permissions and attaching debugger
+    didn't work with Grid (issue #7174)
+
+3.142.1 (2019-05-07)
+====================
+
+Firefox:
+  * Fixed an issue when processing error in legacy driver would result
+    in NoMethodError (issue #7178)
+
 3.142.0 (2019-04-24)
 ====================
 

data/lib/selenium/webdriver/chrome/bridge.rb

@@ -23,9 +23,9 @@ module Selenium
       module Bridge
 
         COMMANDS = {
-          get_network_conditions: [:get, '/session/:session_id/chromium/network_conditions'],
-          set_network_conditions: [:post, '/session/:session_id/chromium/network_conditions'],
-          send_command: [:post, '/session/:session_id/goog/cdp/execute']
+          get_network_conditions: [:get, 'session/:session_id/chromium/network_conditions'],
+          set_network_conditions: [:post, 'session/:session_id/chromium/network_conditions'],
+          send_command: [:post, 'session/:session_id/goog/cdp/execute']
         }.freeze
 
         def commands(command)

data/lib/selenium/webdriver/common/service.rb

@@ -37,25 +37,38 @@ module Selenium
       class << self
         attr_reader :default_port, :driver_path, :executable, :missing_text, :shutdown_supported
 
-        def chrome(*args)
-          Chrome::Service.new(*args)
+        def chrome(**opts)
+          Chrome::Service.new(**opts)
         end
 
-        def firefox(*args)
-          Firefox::Service.new(*args)
+        def firefox(**opts)
+          binary_path = Firefox::Binary.path
+          args = opts.delete(:args)
+          case args
+          when Hash
+            args[:binary] ||= binary_path
+            opts[:args] = args
+          when Array
+            opts[:args] = ["--binary=#{binary_path}"]
+            opts[:args] += args
+          else
+            opts[:args] = ["--binary=#{binary_path}"]
+          end
+
+          Firefox::Service.new(**opts)
         end
 
-        def ie(*args)
-          IE::Service.new(*args)
+        def ie(**opts)
+          IE::Service.new(**opts)
         end
         alias_method :internet_explorer, :ie
 
-        def edge(*args)
-          Edge::Service.new(*args)
+        def edge(**opts)
+          Edge::Service.new(**opts)
         end
 
-        def safari(*args)
-          Safari::Service.new(*args)
+        def safari(**opts)
+          Safari::Service.new(**opts)
         end
 
         def driver_path=(path)

data/lib/selenium/webdriver/remote/response.rb

@@ -79,9 +79,11 @@ module Selenium
         def add_backtrace(ex)
           return unless error_payload.is_a?(Hash)
 
+          # Legacy Firefox returns String in ['value'], while we expect Hash.
+          # Use #dig when Firefox legacy is removed (4.0).
           server_trace = error_payload[STACKTRACE_KEY] ||
                          error_payload[STACKTRACE_KEY.downcase] ||
-                         error_payload.dig('value', STACKTRACE_KEY)
+                         (error_payload['value'] && error_payload['value'][STACKTRACE_KEY])
           return unless server_trace
 
           backtrace = case server_trace

data/lib/selenium/webdriver/safari/bridge.rb

@@ -24,9 +24,9 @@ module Selenium
 
         # https://developer.apple.com/library/content/documentation/NetworkingInternetWeb/Conceptual/WebDriverEndpointDoc/Commands/Commands.html
         COMMANDS = {
-          get_permissions: [:get, '/session/:session_id/apple/permissions'],
-          set_permissions: [:post, '/session/:session_id/apple/permissions'],
-          attach_debugger: [:post, '/session/:session_id/apple/attach_debugger']
+          get_permissions: [:get, 'session/:session_id/apple/permissions'],
+          set_permissions: [:post, 'session/:session_id/apple/permissions'],
+          attach_debugger: [:post, 'session/:session_id/apple/attach_debugger']
         }.freeze
 
         def commands(command)

data/lib/selenium/webdriver/version.rb

@@ -19,6 +19,6 @@
 
 module Selenium
   module WebDriver
-    VERSION = '3.142.0'
+    VERSION = '3.142.3'
   end # WebDriver
 end # Selenium

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selenium-webdriver
 version: !ruby/object:Gem::Version
-  version: 3.142.0
+  version: 3.142.3
 platform: ruby
 authors:
 - Alex Rodionov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-24 00:00:00.000000000 Z
+date: 2019-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -246,7 +246,6 @@ files:
 - lib/selenium/webdriver/common/manager.rb
 - lib/selenium/webdriver/common/mouse.rb
 - lib/selenium/webdriver/common/navigation.rb
-- lib/selenium/webdriver/common/options.rb
 - lib/selenium/webdriver/common/platform.rb
 - lib/selenium/webdriver/common/port_prober.rb
 - lib/selenium/webdriver/common/profile_helper.rb
@@ -261,7 +260,6 @@ files:
 - lib/selenium/webdriver/common/touch_screen.rb
 - lib/selenium/webdriver/common/w3c_action_builder.rb
 - lib/selenium/webdriver/common/w3c_manager.rb
-- lib/selenium/webdriver/common/w3c_options.rb
 - lib/selenium/webdriver/common/wait.rb
 - lib/selenium/webdriver/common/window.rb
 - lib/selenium/webdriver/common/zipper.rb

data/lib/selenium/webdriver/common/options.rb

@@ -1,177 +0,0 @@
-# frozen_string_literal: true
-
-# Licensed to the Software Freedom Conservancy (SFC) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The SFC licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-module Selenium
-  module WebDriver
-    class Options
-      #
-      # @api private
-      #
-
-      def initialize(bridge)
-        @bridge = bridge
-      end
-
-      #
-      # Add a cookie to the browser
-      #
-      # @param [Hash] opts the options to create a cookie with.
-      # @option opts [String] :name A name
-      # @option opts [String] :value A value
-      # @option opts [String] :path ('/') A path
-      # @option opts [String] :secure (false) A boolean
-      # @option opts [Time,DateTime,Numeric,nil] :expires (nil) Expiry date, either as a Time, DateTime, or seconds since epoch.
-      #
-      # @raise [ArgumentError] if :name or :value is not specified
-      #
-
-      def add_cookie(opts = {})
-        raise ArgumentError, 'name is required' unless opts[:name]
-        raise ArgumentError, 'value is required' unless opts[:value]
-
-        opts[:path] ||= '/'
-        opts[:secure] ||= false
-
-        obj = opts.delete(:expires)
-        opts[:expiry] = seconds_from(obj).to_i if obj
-
-        @bridge.add_cookie opts
-      end
-
-      #
-      # Get the cookie with the given name
-      #
-      # @param [String] name the name of the cookie
-      # @return [Hash, nil] the cookie, or nil if it wasn't found.
-      #
-
-      def cookie_named(name)
-        all_cookies.find { |c| c[:name] == name }
-      end
-
-      #
-      # Delete the cookie with the given name
-      #
-      # @param [String] name the name of the cookie to delete
-      #
-
-      def delete_cookie(name)
-        @bridge.delete_cookie name
-      end
-
-      #
-      # Delete all cookies
-      #
-
-      def delete_all_cookies
-        @bridge.delete_all_cookies
-      end
-
-      #
-      # Get all cookies
-      #
-      # @return [Array<Hash>] list of cookies
-      #
-
-      def all_cookies
-        @bridge.cookies.map { |cookie| convert_cookie(cookie) }
-      end
-
-      def timeouts
-        @timeouts ||= Timeouts.new(@bridge)
-      end
-
-      #
-      # @api beta This API may be changed or removed in a future release.
-      #
-
-      def logs
-        @logs ||= Logs.new(@bridge)
-      end
-
-      #
-      # Create a new top-level browsing context
-      # https://w3c.github.io/webdriver/#new-window
-      # @param type [Symbol] Supports two values: :tab and :window.
-      #  Use :tab if you'd like the new window to share an OS-level window
-      #  with the current browsing context.
-      #  Use :window otherwise
-      # @return [String] The value of the window handle
-      #
-      def new_window(type = :tab)
-        case type
-        when :tab, :window
-          result = @bridge.new_window(type)
-          unless result.key?('handle')
-            raise UnknownError, "the driver did not return a handle. " \
-                                "The returned result: #{result.inspect}"
-          end
-          result['handle']
-        else
-          raise ArgumentError, "invalid argument for type. Got: '#{type.inspect}'. " \
-                               "Try :tab or :window"
-        end
-      end
-
-      #
-      # @api beta This API may be changed or removed in a future release.
-      #
-
-      def window
-        @window ||= Window.new(@bridge)
-      end
-
-      private
-
-      SECONDS_PER_DAY = 86_400.0
-
-      def datetime_at(int)
-        DateTime.civil(1970) + (int / SECONDS_PER_DAY)
-      end
-
-      def seconds_from(obj)
-        case obj
-        when Time
-          obj.to_f
-        when DateTime
-          (obj - DateTime.civil(1970)) * SECONDS_PER_DAY
-        when Numeric
-          obj
-        else
-          raise ArgumentError, "invalid value for expiration date: #{obj.inspect}"
-        end
-      end
-
-      def strip_port(str)
-        str.split(':', 2).first
-      end
-
-      def convert_cookie(cookie)
-        {
-          name: cookie['name'],
-          value: cookie['value'],
-          path: cookie['path'],
-          domain: cookie['domain'] && strip_port(cookie['domain']),
-          expires: cookie['expiry'] && datetime_at(cookie['expiry']),
-          secure: cookie['secure']
-        }
-      end
-    end # Options
-  end # WebDriver
-end # Selenium

data/lib/selenium/webdriver/common/w3c_options.rb

@@ -1,45 +0,0 @@
-# frozen_string_literal: true
-
-# Licensed to the Software Freedom Conservancy (SFC) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The SFC licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-module Selenium
-  module WebDriver
-    class W3COptions < Options
-
-      #
-      # Get the cookie with the given name
-      #
-      # @param [String] name the name of the cookie
-      # @return [Hash, nil] the cookie, or nil if it wasn't found.
-      #
-
-      def cookie_named(name)
-        convert_cookie(@bridge.cookie(name))
-      end
-
-      #
-      # Delete all cookies
-      #
-
-      def delete_all_cookies
-        @bridge.delete_all_cookies
-      end
-
-    end # WC3Options
-  end # WebDriver
-end # Selenium