selenium-webdriver 3.141.5926 → 3.142.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98597f8b669dbd074c696ddca89ec8c4a3fd9cd9
-  data.tar.gz: '097e90bbf9abb8a1a7cccce8fbcad9b7ad674990'
+  metadata.gz: 8c49d98b41b1b4019754a8c48e695d80c13a6920
+  data.tar.gz: 89388af584e8090ab3ffc07744800a4476616ec6
 SHA512:
-  metadata.gz: c8020fbcea75fd5aeef8ab8d8b2ed74667291d3166ed55a9cad23be3319824355579306bf62e2cd342b22ea5c41ec8571940378ca374d327fdff8c3bc837f35b
-  data.tar.gz: 138443d80b20220f2d008a33e283db77c34756fe0215edb95b584762ed186658c2b73cf77c945cd42e003dca5f6aba142b620c286eba3119898b5f2437d1c58a
+  metadata.gz: 3a395f0069eab5781ce742630a13d688d3c7a9688806105f938b266fc515fefbc71b0ac08248784f0594a7e0a07e27d59b309d4b39808be262344e1c7b1ec96e
+  data.tar.gz: a1d3bf1d12ca7209b5d92d27f2a530ecdf15fd3f9a8ab125380064e656e434b3fbb9010f4b0bd2e9ceb2477e33d46b73a1e0ed10140d153799ce8ebda5b0a222

data/CHANGES

@@ -1,3 +1,16 @@
+3.142.0 (2019-04-24)
+====================
+
+Ruby:
+  * Fixed an issue when services are not shutdown properly
+
+Firefox:
+  * Fixed an issue when passing :profile string to Firefox::Options.new would
+    result in NoMethodError. Now it will find a profile with such name on your
+    system and use it accordingly (issue #7119)
+  * Fixed an issue when instantiating Firefox driver with capabilities having
+    :marionette would result in NoMethodError (issue #7120)
+
 3.141.5926 (2019-04-18)
 =======================
 

data/lib/selenium/webdriver/common/service.rb

@@ -35,7 +35,7 @@ module Selenium
       @missing_text = nil
 
       class << self
-        attr_reader :default_port, :driver_path, :executable, :missing_text
+        attr_reader :default_port, :driver_path, :executable, :missing_text, :shutdown_supported
 
         def chrome(*args)
           Chrome::Service.new(*args)
@@ -100,7 +100,7 @@ module Selenium
       end
 
       def stop
-        return unless @shutdown_supported
+        return unless self.class.shutdown_supported
 
         stop_server
         @process.poll_for_exit STOP_TIMEOUT

data/lib/selenium/webdriver/firefox/driver.rb

@@ -39,7 +39,8 @@ module Selenium
           private
 
           def marionette?(opts)
-            opts.delete(:marionette) != false && (opts.dig(:desired_capabilities, :marionette) != false)
+            opts.delete(:marionette) != false &&
+              (!opts[:desired_capabilities] || opts[:desired_capabilities][:marionette] != false)
           end
         end
 

data/lib/selenium/webdriver/firefox/options.rb

@@ -45,7 +45,7 @@ module Selenium
         def initialize(**opts)
           @args = Set.new(opts.delete(:args) || [])
           @binary = opts.delete(:binary)
-          @profile = opts.delete(:profile)
+          @profile = process_profile(opts.delete(:profile))
           @log_level = opts.delete(:log_level)
           @prefs = opts.delete(:prefs) || {}
           @options = opts.delete(:options) || {}
@@ -123,11 +123,7 @@ module Selenium
         #
 
         def profile=(profile)
-          @profile = if profile.is_a?(Profile)
-                       profile
-                     else
-                       Profile.from_name(profile)
-                     end
+          @profile = process_profile(profile)
         end
 
         #
@@ -145,6 +141,21 @@ module Selenium
 
           {KEY => opts}
         end
+
+        private
+
+        def process_profile(profile)
+          return unless profile
+
+          case profile
+          when Profile
+            profile
+          when String
+            Profile.from_name(profile)
+          else
+            raise Error::WebDriverError, "don't know how to handle profile: #{profile.inspect}"
+          end
+        end
       end # Options
     end # Firefox
   end # WebDriver

data/lib/selenium/webdriver/version.rb

@@ -19,6 +19,6 @@
 
 module Selenium
   module WebDriver
-    VERSION = '3.141.5926'
+    VERSION = '3.142.0'
   end # WebDriver
 end # Selenium

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selenium-webdriver
 version: !ruby/object:Gem::Version
-  version: 3.141.5926
+  version: 3.142.0
 platform: ruby
 authors:
 - Alex Rodionov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-18 00:00:00.000000000 Z
+date: 2019-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement