selenium-connect 2.1.0 → 2.1.1

data/CHANGELOG.md

@@ -1,4 +1,12 @@
+#2.1.1 (2013-07-04)
+- Updated rakefile to propperly fetch the previous version for changelog purposes
+- Bumped version to 2.1.1 to prepare for release.
+- fixed bug with the server shutdown process and improved the exception handling for invalid configuration parameters
+- updated changelog
+
 #2.1.0 (2013-07-02)
+- Updated configuration method
+- Code quality fixes
 
 #2.0.0 (2013-06-27)
 - Added selenium server jar as explicit dependency

data/Rakefile

@@ -21,7 +21,7 @@ end
 RSpec::Core::RakeTask.new(:spec_full)
 
 RSpec::Core::RakeTask.new(:spec_unit) do |t|
-  t.rspec_opts = "--tag ~selenium"
+  t.rspec_opts = '--tag ~selenium'
 end
 
 desc 'Runs code quality check'
@@ -76,7 +76,9 @@ task :release_finish, :update_message do |t, args|
 
   ### Changelog
   # get the latest tag
+  system 'git checkout master'
   last_tag = `git describe --abbrev=0`
+  system "git checkout release/#{version}"
   # get the commit hash since the last that version was merged to develop
   hash = `git log --grep="Merge branch 'release/#{last_tag.chomp}' into develop" --format="%H"`
   # get all the commits since them less merges

data/lib/selenium-connect.rb

@@ -43,7 +43,7 @@ module SeleniumConnect
       # rubocop:enable HandleExceptions
       # no-op
     end
-    server.stop unless localhost?
+    server.stop if localhost?
   end
 
   alias_method :start, :run

data/lib/selenium-connect/configuration.rb

@@ -26,7 +26,11 @@ module SeleniumConnect
 
     def populate_with_hash(hash)
       hash.each do |key, value|
-        self.send "#{key}=", value unless value.nil?
+        begin
+          self.send "#{key}=", value unless value.nil?
+        rescue NoMethodError
+          raise ArgumentError.new "The config key: \"#{key}\" is unknown!"
+        end
       end
     end
 

data/selenium-connect.gemspec

@@ -1,12 +1,12 @@
 Gem::Specification.new do |s|
   s.name          = 'selenium-connect'
-  s.version       = '2.1.0'
+  s.version       = '2.1.1'
   s.platform      = Gem::Platform::RUBY
   s.authors       = ['Dave Haeffner', 'Jason Fox']
   s.email         = ['dave@arrgyle.com', 'jason@arrgyle.com']
   s.homepage      = 'https://github.com/arrgyle/selenium-connect'
   s.summary       = 'A stupid simple way to run your Selenium tests on localhost, against a Selenium Grid, or in the cloud (e.g. SauceLabs).'
-  s.description   = 'Updated configuration methods and improved code quality.'
+  s.description   = 'Fixed bug with localhost server quitting'
   s.license       = 'MIT'
 
   s.files         = `git ls-files`.split($/)

data/spec/configuration_spec.rb

@@ -30,8 +30,8 @@ describe SeleniumConnect::Configuration do
 
   it 'should throw an exception for unsupported config variable' do
     expect do
-      @configuration.hash = { bad: 'config-value' }
-    end.to raise_error NoMethodError
+      @configuration.populate_with_hash  bad: 'config-value'
+    end.to raise_error ArgumentError, 'The config key: "bad" is unknown!'
   end
 
   it 'sensible defaults persist when nothing is set' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selenium-connect
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-02 00:00:00.000000000 Z
+date: 2013-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
@@ -92,7 +92,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.0
-description: Updated configuration methods and improved code quality.
+description: Fixed bug with localhost server quitting
 email:
 - dave@arrgyle.com
 - jason@arrgyle.com
@@ -156,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2242765007989864300
+      hash: 2657149500405024858
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25