selective-ruby-core 0.2.15 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53768795f806a29d383b6b7a42863d6fcc765564f2a7069520fc02c0f5af050c
-  data.tar.gz: d2cc6e6ffab4347039987478d049beba77cbe46bac9842eeb3075074ff6d598a
+  metadata.gz: b1a2419b9f116139a88f893db32c30d4b20ede42f5e8d67e29efa7338ad25746
+  data.tar.gz: 4f74720e2576103b12a264a8d111c6b473e8abb9a59cf8f92a9a63fa3f6ea7e4
 SHA512:
-  metadata.gz: 0cec03160e36250d44556d597670c7235399d1b8b61abf21eeca12e95a2a57053b95885fbf2fd385e5a956575c1bb6a7c5ab2d52193546572cbd6f3a5ae5d881
-  data.tar.gz: 4093d37cc9ea427e3d469e7cff565ce79a24ddbb3ef71ea03fd49c2085ca1319aa6253d37c3e010a7c183099c18195b188a300d74964c5098dcf3eaddd7361cc
+  metadata.gz: dd99fe2d8968bb63a4ac93443648fb1aaa16c081bf1ffdf09f5aaef8696137ab1135814eac6bbdc8ef0159fb72741075ec000e96112dd68f835146731e8d98a4
+  data.tar.gz: 141d0a456bdc91ba810c14328d28dd2380028936834f5d403dda87f7be95ceea7014d0d119bca41dea7c06f81490b04700c11999a5cd18921f1eaed011fb12e6

data/lib/selective/ruby/core/controller.rb

@@ -7,10 +7,12 @@ module Selective
     module Core
       class Controller
         include Helper
+
         @@selective_suppress_reporting = false
         @@report_at_finish = {}
 
         TERMINATION_REPORT_GRACE = 0.25
+        CONNECT_TIMEOUT = 30
 
         REQUIRED_CONFIGURATION = {
           "host" => "SELECTIVE_HOST",
@@ -29,6 +31,7 @@ module Selective
           @log = log
           @runner = runner_class.new(runner_args, method(:test_case_callback))
           @retries = 0
+          @pending_commands = []
         end
 
         # A lost connection is retried by looping here, not by calling start
@@ -104,19 +107,25 @@ module Selective
 
         def run_main_loop
           loop do
-            message = pipe.read
-            response = JSON.parse(message, symbolize_names: true)
+            response = next_command
 
             logger.info("Received Command: #{response}")
             break if handle_command(response) == :break
           end
         end
 
+        def next_command
+          return @pending_commands.shift if @pending_commands.any?
+
+          JSON.parse(pipe.read, symbolize_names: true)
+        end
+
         # One connection: true when the run finished on it, false when it was
         # lost and the caller should reconnect.
         def connect_and_run(reconnect:)
-          @pipe = NamedPipe.new("/tmp/#{runner_id}_2", "/tmp/#{runner_id}_1")
-          @transport_pid = spawn_transport_process(reconnect: reconnect)
+          ensure_transport_supports_stdio!
+          @pipe = StdioTransport.open(transport_binary, transport_url(reconnect: reconnect))
+          @transport_pid = @pipe.pid
 
           handle_termination_signals(transport_pid)
           wait_for_connectivity
@@ -133,7 +142,7 @@ module Selective
           with_error_handling { raise "Too many retries" } if retries > 10
 
           puts("Retrying in #{retries} seconds...") if debug?
-          sleep(retries > 4 ? 4 : retries)
+          sleep([retries, 4].min)
           kill_transport
 
           pipe.reset!
@@ -159,7 +168,7 @@ module Selective
             run_id = build_env["run_id"]
             run_attempt = build_env["run_attempt"]
 
-            metadata = build_env.reject { |k,v| %w(host runner_id api_key run_id run_attempt).include?(k) }
+            metadata = build_env.reject { |k, v| %w[host runner_id api_key run_id run_attempt].include?(k) }
 
             {
               "api_key" => api_key,
@@ -198,43 +207,53 @@ module Selective
 
           with_error_handling do
             raise "Missing required environment variables: #{missing.join(", ")}" unless missing.empty?
-            raise "Invalid host: #{env['host']}" unless env['host'].match?(/^wss?:\/\//)
+            raise "Invalid host: #{env["host"]}" unless env["host"].match?(/^wss?:\/\//)
           end
         end
 
-        def spawn_transport_process(reconnect: false)
-          transport_path = File.join(ROOT_GEM_PATH, "lib", "bin", "transport")
-          get_transport_path = File.join(ROOT_GEM_PATH, "bin", "get_transport")
+        def ensure_transport_binary!
+          explicit = ENV["SELECTIVE_TRANSPORT"].to_s
+          path = explicit.empty? ? File.join(ROOT_GEM_PATH, "lib", "bin", "transport") : explicit
+          return path if File.exist?(path)
 
-          if !File.exist?(transport_path)
+          get_transport_path = File.join(ROOT_GEM_PATH, "bin", "get_transport")
+          if explicit.empty? && File.exist?(get_transport_path)
             # The get_transport script is not released with the gem, so this
             # code is intended for development/CI purposes.
-            if File.exist?(get_transport_path)
-              output, status = Open3.capture2e(get_transport_path)
-              if !status.success?
-                puts <<~TEXT
-                  Failed to download transport binary.
-
-                  #{output}
-                TEXT
-              end
-            else
-              with_error_handling do
-                raise "Selective transport binary not found. Please contact support or compile it manually. See: https://github.com/selectiveci/transport"
-              end
+            output, status = Open3.capture2e(get_transport_path)
+            unless status.success?
+              puts <<~TEXT
+                Failed to download transport binary.
+
+                #{output}
+              TEXT
+            end
+          else
+            with_error_handling do
+              raise "Selective transport binary not found. Please contact support or compile it manually. See: https://github.com/selectiveci/transport"
             end
           end
 
-          Process.spawn(transport_path, transport_url(reconnect: reconnect), runner_id).tap do |pid|
-            Process.detach(pid)
-          end
+          path
+        end
+
+        def transport_binary
+          @transport_binary ||= ensure_transport_binary!
+        end
+
+        def ensure_transport_supports_stdio!
+          help = Open3.capture2e(transport_binary, "--help").first.scrub
+          return if help.include?("--stdio")
+
+          with_error_handling { raise "#{transport_binary} does not support --stdio. selective-ruby-core needs transport 0.2.0 or newer. Run bin/get_transport.\n#{help}" }
         end
 
         def wait_for_connectivity
           @connectivity = false
+          @pending_commands = []
 
           Thread.new do
-            sleep(30)
+            Kernel.sleep(CONNECT_TIMEOUT)
             unless @connectivity
               puts "Transport process failed to start. Exiting..."
               kill_transport
@@ -244,14 +263,13 @@ module Selective
 
           loop do
             message = pipe.read
-
-            # The message is nil until the transport opens the pipe
-            # for writing. So, we must handle that here.
-            next sleep(0.1) if message.nil?
-
             response = JSON.parse(message, symbolize_names: true)
-            @connectivity = true if response[:command] == "connected"
-            break
+            if response[:command] == "connected"
+              @connectivity = true
+              break
+            end
+
+            @pending_commands << response
           end
         end
 
@@ -278,22 +296,19 @@ module Selective
 
           write({type: "terminating", data: {signal: signal}})
           sleep(TERMINATION_REPORT_GRACE)
-        rescue ConnectionLostError, IOError, SystemCallError
-          # Nothing to report to.
+        rescue ConnectionLostError, IOError, SystemCallError, ThreadError
+          nil
         end
 
         def kill_transport(signal: "TERM")
           begin
             pipe.write "exit"
 
-            # Give up to 5 seconds for graceful exit
-            # before killing it below
-            1..5.times do
+            100.times do
               Process.getpgid(transport_pid)
-
-              sleep(1)
+              Kernel.sleep(0.05)
             end
-          rescue ConnectionLostError, IOError
+          rescue ConnectionLostError, IOError, ThreadError
             # If the pipe is close, move straight to killing
             # it forcefully.
           end
@@ -308,8 +323,8 @@ module Selective
         def handle_command(data)
           if respond_to? "handle_#{data[:command]}", true
             send("handle_#{data[:command]}", data)
-          else
-            raise "Unknown command received: #{data[:command]}" if debug?
+          elsif debug?
+            raise "Unknown command received: #{data[:command]}"
           end
         end
 
@@ -428,10 +443,8 @@ module Selective
         end
 
         def modified_test_files(diff)
-          @modified_test_files ||= begin
-            diff.filter do |f|
-              f.match?(/^#{runner.base_test_path}/)
-            end
+          @modified_test_files ||= diff.filter do |f|
+            f.match?(/^#{runner.base_test_path}/)
           end
         end
 

data/lib/selective/ruby/core/stdio_transport.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+require "open3"
+
+module Selective
+  module Ruby
+    module Core
+      class StdioTransport
+        SHUTDOWN_GRACE = 1
+
+        attr_reader :pid, :wait_thread
+
+        def self.open(binary, url)
+          stdin, stdout, wait_thread = Open3.popen2(
+            {"SELECTIVE_TRANSPORT_URL" => url},
+            binary,
+            "--stdio",
+            pgroup: true
+          )
+          new(stdin, stdout, wait_thread)
+        end
+
+        def initialize(stdin, stdout, wait_thread)
+          @stdin = stdin
+          @stdout = stdout
+          @wait_thread = wait_thread
+          @pid = wait_thread.pid
+          @queue = Queue.new
+          @outbox = Queue.new
+          @reader = Thread.new { read_stdout }
+          @writer = Thread.new { write_stdin }
+        end
+
+        def write(message)
+          raise ConnectionLostError if @lost || !@wait_thread.alive?
+
+          @outbox << "#{message}\n"
+        rescue ClosedQueueError
+          raise ConnectionLostError
+        end
+
+        def read
+          @queue.pop || raise(ConnectionLostError)
+        end
+
+        def shutdown
+          @outbox.close
+          @writer.join(SHUTDOWN_GRACE)
+          @stdin.close
+          %w[TERM KILL].each do |signal|
+            break if @wait_thread.join(SHUTDOWN_GRACE)
+
+            signal_child(signal)
+          end
+          @wait_thread.join
+          @stdout.close
+          @reader.join(SHUTDOWN_GRACE)
+          @queue.close
+        end
+
+        alias_method :reset!, :shutdown
+        alias_method :delete_pipes, :shutdown
+
+        private
+
+        def read_stdout
+          while (line = @stdout.gets)
+            @queue << line.chomp
+          end
+        rescue IOError, ClosedQueueError
+          nil
+        ensure
+          @queue.close
+        end
+
+        def write_stdin
+          while (frame = @outbox.pop)
+            @stdin.write(frame)
+          end
+        rescue Errno::EPIPE, IOError
+          @lost = true
+        end
+
+        def signal_child(signal)
+          Process.kill(signal, @pid)
+        rescue Errno::ESRCH
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/selective/ruby/core/test_map/uploader.rb

@@ -88,13 +88,24 @@ module Selective
               file.flush
 
               env = CLEAN_ENV.merge("SELECTIVE_TEST_MAP_UPLOAD_KEY" => @api_key.to_s)
-              out, err, status = Open3.capture3(env, RbConfig.ruby, "-e", CHILD_SCRIPT, @uri.to_s, file.path)
+              out, err, status = run_child(env, file.path)
               raise "HTTP #{out.strip}: #{err.strip}" unless status.success?
 
               true
             end
           end
 
+          def run_child(env, path)
+            Open3.popen3(env, RbConfig.ruby, "-e", CHILD_SCRIPT, @uri.to_s, path) do |stdin, stdout, stderr, child|
+              stdin.close
+              readers = [stdout, stderr].map { |io| Thread.new { io.read } }
+              [*readers.map(&:value), child.value]
+            ensure
+              Process.kill("KILL", child.pid) if child.alive?
+              readers&.each(&:join)
+            end
+          end
+
           # The runner is configured with the WebSocket host (ws:// or wss://);
           # the upload goes to the same server over HTTP(S).
           def build_uri(host, **params)

data/lib/selective/ruby/core/version.rb

@@ -3,7 +3,7 @@
 module Selective
   module Ruby
     module Core
-      VERSION = "0.2.15"
+      VERSION = "0.3.0"
     end
   end
 end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: selective-ruby-core
 version: !ruby/object:Gem::Version
-  version: 0.2.15
+  version: 0.3.0
 platform: ruby
 authors:
 - Benjamin Wood
 - Nate Vick
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-10-23 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logger
@@ -63,14 +62,13 @@ files:
 - lib/selective/ruby/core/controller.rb
 - lib/selective/ruby/core/file_correlator.rb
 - lib/selective/ruby/core/helper.rb
-- lib/selective/ruby/core/named_pipe.rb
+- lib/selective/ruby/core/stdio_transport.rb
 - lib/selective/ruby/core/test_map.rb
 - lib/selective/ruby/core/test_map/recorder.rb
 - lib/selective/ruby/core/test_map/tracer.rb
 - lib/selective/ruby/core/test_map/tree.rb
 - lib/selective/ruby/core/test_map/uploader.rb
 - lib/selective/ruby/core/version.rb
-- selective-ruby-core.gemspec
 homepage: https://www.selective.ci
 licenses:
 - MIT
@@ -78,7 +76,6 @@ metadata:
   homepage_uri: https://www.selective.ci
   source_code_uri: http://github.com/selectiveci/selective-ruby-core
   changelog_uri: https://github.com/selectiveci/selective-ruby-core/blob/main/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -93,8 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Selective Ruby Client Core
 test_files: []

data/lib/selective/ruby/core/named_pipe.rb

@@ -1,101 +0,0 @@
-module Selective
-  module Ruby
-    module Core
-      class NamedPipe
-        attr_reader :read_pipe_path, :write_pipe_path
-
-        def initialize(read_pipe_path, write_pipe_path, skip_reset: false)
-          @read_pipe_path = read_pipe_path
-          @write_pipe_path = write_pipe_path
-
-          delete_pipes unless skip_reset
-          initialize_pipes
-        end
-
-        def initialize_pipes
-          create_pipes
-
-          # Open the read and write pipes in separate threads
-          Thread.new do
-            @read_pipe = File.open(read_pipe_path, "r")
-          end
-          Thread.new do
-            @write_pipe = File.open(write_pipe_path, "w")
-          end
-        end
-
-        def write(message)
-          return unless write_pipe
-
-          chunk_size = 1024  # 1KB chunks
-          offset = 0
-          begin
-            while offset < message.bytesize
-              chunk = message.byteslice(offset, chunk_size)
-
-              write_pipe.write(chunk)
-              write_pipe.flush
-
-              offset += chunk_size
-            end
-
-            write_pipe.write("\n")
-            write_pipe.flush
-          rescue Errno::EPIPE
-            raise ConnectionLostError
-          end
-        end
-
-        def read
-          return unless read_pipe
-          begin
-            message = read_pipe.gets.chomp
-          rescue NoMethodError => e
-            if e.name == :chomp
-              raise ConnectionLostError
-            else
-              raise e
-            end
-          end
-          message
-        end
-
-        def reset!
-          delete_pipes
-          initialize_pipes
-        end
-
-        def delete_pipes
-          # Close the pipes before deleting them
-          read_pipe&.close
-          write_pipe&.close
-
-          # Allow threads to close before deleting pipes
-          sleep(0.1)
-
-          delete_pipe(read_pipe_path)
-          delete_pipe(write_pipe_path)
-        rescue Errno::EPIPE
-          # Noop
-        end
-
-        private
-
-        attr_reader :read_pipe, :write_pipe
-
-        def create_pipes
-          create_pipe(read_pipe_path)
-          create_pipe(write_pipe_path)
-        end
-
-        def create_pipe(path)
-          system("mkfifo #{path}") unless File.exist?(path)
-        end
-
-        def delete_pipe(path)
-          File.delete(path) if File.exist?(path)
-        end
-      end
-    end
-  end
-end

data/selective-ruby-core.gemspec

@@ -1,53 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "lib/selective/ruby/core/version"
-
-Gem::Specification.new do |spec|
-  spec.name = "selective-ruby-core"
-  spec.version = Selective::Ruby::Core::VERSION
-  spec.authors = ["Benjamin Wood", "Nate Vick"]
-  spec.email = ["ben@hint.io", "nate@hint.io"]
-  spec.license = "MIT"
-
-  # Currently supported release platforms are:
-  # Linux: x86_64-linux, aarch64-linux
-  # MacOS: x86_64-darwin, arm64-darwin
-  if (platform = ENV["RELEASE_PLATFORM"])
-    spec.platform = platform
-  end
-
-  spec.summary = "Selective Ruby Client Core"
-  spec.description = "Selective is an intelligent test runner for your current CI provider. Get real-time test results, intelligent ordering based on code changes, shorter run times, automatic flake detection, the ability to re-enqueue failed tests, and more."
-  spec.homepage = "https://www.selective.ci"
-  spec.required_ruby_version = ">= 2.7.0"
-
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "http://github.com/selectiveci/selective-ruby-core"
-  spec.metadata["changelog_uri"] = "https://github.com/selectiveci/selective-ruby-core/blob/main/CHANGELOG.md"
-
-  # Specify which files should be added to the gem when it is released.
-  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(__dir__) do
-    `git ls-files -z`.split("\x0").reject do |f|
-      (File.expand_path(f) == __FILE__) || f.start_with?(*%w[bin/ test/ spec/ features/ log/ .git .circleci appveyor .rspec .ruby-version .standard.yml README.md CHANGELOG.md CODE_OF_CONDUCT.md Gemfile])
-    end
-  end
-
-  # Add the transport binary
-  unless ENV["RELEASE_PLATFORM"].nil?
-    spec.files << "lib/bin/transport"
-  end
-
-  # The optional test map tracer. extconf.rb writes a no-op Makefile when it
-  # can't build (no compiler, unsupported Ruby), so installation never fails
-  # because of it; the runner then reports it can't record.
-  spec.extensions = ["ext/selective_tracer/extconf.rb"]
-
-  spec.bindir = "exe"
-  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
-
-  # Uncomment to register a new dependency of your gem
-  spec.add_dependency("logger", "~> 1.6")
-  spec.add_dependency("zeitwerk", "~> 2.6.12")
-end