selective-ruby-core 0.2.1-arm64-darwin → 0.2.3-arm64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8126e9b36b7fa8536ef480c391018765cfc8f50c651edd3e09bd45d7b4e0c0f4
-  data.tar.gz: e0639c048e0af1b2c02788efd7e371eb8e0b080bb03cc2dcbb87b015b102f056
+  metadata.gz: 65a9d5ea2fc988fb01cc1966ec4eea098a9149593b0217fea94e74d8dfb9191d
+  data.tar.gz: c6c330b10973b8d83ee8ae51947e22b1cbe0bb2893c7beaf340f4dd91deed152
 SHA512:
-  metadata.gz: 2798ec33a52c77f737b369af74e013586539a561a5311ac4a434144fbf60f5047bca61a3f40fbd9aeca78059be9cf33b360582d3bb5562cd317259594b66c355
-  data.tar.gz: 9e79e6d91184a94716aa7824a388e924b4dac885ba6ab66b4c1dca281ae08c0844d8f6315b5efaf9e599560d05cf57d837c7b0df49a874dc3b147170be2e16f5
+  metadata.gz: 14788a8944552736e727242a3be3b5eb8240523f4b7b881836cc9ff95a00814fac741e6756a4a25b153439dece54c02e76732998dc282d7f4a6b07df50c4c15d
+  data.tar.gz: cdb477933ff7b2ebf328efc0ac5aa88bfaccdde6a4e7fe0ef27a6ac83256837596808fe3393d06fcb31d564b712c29a8d1caf40ad100aa104949c995f306f5a4

data/lib/selective/ruby/core/controller.rb

@@ -8,18 +8,20 @@ module Selective
       class Controller
         include Helper
         @@selective_suppress_reporting = false
+        @@report_at_finish = {}
 
         REQUIRED_CONFIGURATION = {
           "host" => "SELECTIVE_HOST",
           "api_key" => "SELECTIVE_API_KEY",
           "platform" => "SELECTIVE_PLATFORM",
           "run_id" => "SELECTIVE_RUN_ID",
+          "run_attempt" => "SELECTIVE_RUN_ATTEMPT",
           "branch" => "SELECTIVE_BRANCH"
         }.freeze
 
-        def initialize(runner, debug: false, log: false)
+        def initialize(runner_class, runner_args, debug: false, log: false)
           @debug = debug
-          @runner = runner
+          @runner = runner_class.new(runner_args, method(:test_case_callback))
           @retries = 0
           @runner_id = safe_filename(get_runner_id)
           @logger = init_logger(log)
@@ -32,7 +34,7 @@ module Selective
           handle_termination_signals(transport_pid)
           wait_for_connectivity
           run_main_loop
-        rescue NamedPipe::PipeClosedError
+        rescue ConnectionLostError
           retry!
         rescue => e
           with_error_handling { raise e }
@@ -56,12 +58,16 @@ module Selective
           @@selective_suppress_reporting
         end
 
+        def self.report_at_finish
+          @@report_at_finish
+        end
+
         private
 
         attr_reader :runner, :pipe, :transport_pid, :retries, :logger, :runner_id, :diff
 
         def get_runner_id
-          runner_id = build_env.delete("runner_id")
+          runner_id = build_env["runner_id"]
           return generate_runner_id if runner_id.nil? || runner_id.empty?
 
           runner_id
@@ -89,10 +95,10 @@ module Selective
         def retry!
           @retries += 1
 
-          with_error_handling { raise "Too many retries" } if retries > 4
+          with_error_handling { raise "Too many retries" } if retries > 10
 
-          puts("Retrying in #{retries} seconds...")
-          sleep(retries)
+          puts("Retrying in #{retries} seconds...") if debug?
+          sleep(retries > 4 ? 4 : retries)
           kill_transport
 
           pipe.reset!
@@ -108,30 +114,30 @@ module Selective
         end
 
         def transport_url(reconnect: false)
-          @transport_url ||= begin
-            api_key = build_env.delete("api_key")
-            host = build_env.delete("host")
-            run_id = build_env.delete("run_id")
-            run_attempt = build_env.delete("run_attempt")
-            run_attempt = SecureRandom.uuid if run_attempt.nil? || run_attempt.empty?
-
-            params = {
+          base_transport_url_params[:reconnect] = true if reconnect
+          query_string = URI.encode_www_form(base_transport_url_params)
+          "#{build_env["host"]}/transport/websocket?#{query_string}"
+        end
+
+        def base_transport_url_params
+          @base_transport_url_params ||= begin
+            api_key = build_env["api_key"]
+            run_id = build_env["run_id"]
+            run_attempt = build_env["run_attempt"]
+
+            metadata = build_env.reject { |k,v| %w(host runner_id api_key run_id run_attempt).include?(k) }
+
+            {
+              "api_key" => api_key,
               "run_id" => run_id,
               "run_attempt" => run_attempt,
-              "api_key" => api_key,
               "runner_id" => runner_id,
               "language" => "ruby",
               "core_version" => Selective::Ruby::Core::VERSION,
               "framework" => runner.framework,
               "framework_version" => runner.framework_version,
               "framework_wrapper_version" => runner.wrapper_version,
-            }.merge(metadata: build_env.to_json)
-
-            prams[:reconnect] = true if reconnect
-
-            query_string = URI.encode_www_form(params)
-
-            "#{host}/transport/websocket?#{query_string}"
+            }.merge(metadata: metadata.to_json)
           end
         end
 
@@ -224,7 +230,7 @@ module Selective
 
               sleep(1)
             end
-          rescue NamedPipe::PipeClosedError, IOError
+          rescue ConnectionLostError, IOError
             # If the pipe is close, move straight to killing
             # it forcefully.
           end
@@ -267,11 +273,14 @@ module Selective
         end
 
         def handle_run_test_cases(data)
-          runner.run_test_cases(data[:test_case_ids], method(:test_case_callback))
+          runner.run_test_cases(data[:test_case_ids])
         end
 
+        # Todo: Rename this command to match the method name
+        # on the runner wrapper. We should do something similar
+        # to normalize handle_print_notice and handle_print_message
         def handle_remove_failed_test_case_result(data)
-          runner.remove_failed_test_case_result(data[:test_case_id])
+          runner.remove_test_case_result(data[:test_case_id])
         end
 
         def handle_print_message(data)
@@ -281,7 +290,13 @@ module Selective
         def handle_close(data)
           exit_status = data[:exit_status]
           self.class.restore_reporting!
-          with_error_handling { runner.finish } unless exit_status.is_a?(Integer)
+
+          with_error_handling do
+            Selective::Ruby::Core::Controller.report_at_finish[:connection_retries] = @retries
+            write({type: "report_at_finish", data: Selective::Ruby::Core::Controller.report_at_finish})
+
+            runner.finish unless exit_status.is_a?(Integer)
+          end
 
           kill_transport
           pipe.delete_pipes

data/lib/selective/ruby/core/file_correlator.rb

@@ -9,7 +9,7 @@ module Selective
         FILE_CORRELATION_COLLECTOR_PATH = File.join(ROOT_GEM_PATH, "lib", "bin", "file_correlation_collector.sh")
 
         def initialize(diff, num_commits, target_branch)
-          @diff = diff
+          @diff = diff.reject {|f| f =~ /^spec\// }
           @num_commits = num_commits
           @target_branch = target_branch
         end

data/lib/selective/ruby/core/named_pipe.rb

@@ -2,8 +2,6 @@ module Selective
   module Ruby
     module Core
       class NamedPipe
-        class PipeClosedError < StandardError; end
-
         attr_reader :read_pipe_path, :write_pipe_path
 
         def initialize(read_pipe_path, write_pipe_path, skip_reset: false)
@@ -44,7 +42,7 @@ module Selective
             write_pipe.write("\n")
             write_pipe.flush
           rescue Errno::EPIPE
-            raise PipeClosedError
+            raise ConnectionLostError
           end
         end
 
@@ -54,7 +52,7 @@ module Selective
             message = read_pipe.gets.chomp
           rescue NoMethodError => e
             if e.name == :chomp
-              raise PipeClosedError
+              raise ConnectionLostError
             else
               raise e
             end

data/lib/selective/ruby/core/version.rb

@@ -3,7 +3,7 @@
 module Selective
   module Ruby
     module Core
-      VERSION = "0.2.1"
+      VERSION = "0.2.3"
     end
   end
 end

data/lib/selective-ruby-core.rb

@@ -14,6 +14,7 @@ module Selective
   module Ruby
     module Core
       class Error < StandardError; end
+      class ConnectionLostError < StandardError; end
 
       ROOT_GEM_PATH = Gem.loaded_specs["selective-ruby-core"].full_gem_path
 
@@ -44,7 +45,7 @@ module Selective
         attr_reader :debug, :log, :runner_name, :args, :command
 
         def run
-          Selective::Ruby::Core::Controller.new(runner, debug: debug, log: log).send(command)
+          Selective::Ruby::Core::Controller.new(runner_class, args, debug: debug, log: log).send(command)
         end
 
         def parse_args(args)
@@ -56,8 +57,8 @@ module Selective
           end
         end
 
-        def runner
-          Selective::Ruby::Core.runner_for(runner_name).new(args)
+        def runner_class
+          Selective::Ruby::Core.runner_for(runner_name)
         end
 
         def require_runner

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selective-ruby-core
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: arm64-darwin
 authors:
 - Benjamin Wood
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-19 00:00:00.000000000 Z
+date: 2024-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zeitwerk