selective-ruby-core 0.1.1-x86_64-darwin → 0.1.3-x86_64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1d91d7a556257a9d7f986f75e251f6d1da8389bced83c95bcbff6635e0ee082
-  data.tar.gz: b92e41af2b9be12afb1764d8da36cbf6f673550f6295e2f999480abe4858bfe7
+  metadata.gz: 768c13ee1e2c74fe8909abdb4cf2193402e16bea564c42cb040d3d97ca096738
+  data.tar.gz: d6f01be1d6bababc38807173b73ca4f77f329deca59f3c65d4be3b1458c24c56
 SHA512:
-  metadata.gz: 3ffe1313c77717a27665c5bcbd486bb7d724c1baa31e1f4af380781e83ef9550aadc22abf7d6e5369007a4d2070ad7e4543afa67293bea8c416753b80d3a09fd
-  data.tar.gz: 3610ad626e1d90cf26395afa8f5ab94b0985bc0d91c53a426157f435ba60ed68c5ae529e43120cabfc52170c4c3527c128f7f85ac081142d55000a532ea6456d
+  metadata.gz: 394cd0376b4ca2298917828d179fd82f373a49c0a147a1bc4ba06e630aacffc90518d13afd7ee0c886229d2502393e1980e35c40bc2772f35069ba065f61f686
+  data.tar.gz: 14bb3272aa4d945afff46647c3a8f63b464b83ced81f6ede396c58e944a3299cf0c265923132721a5d44700e4b03cd0997bd577c694a5e42e8b31552ba771f2b

data/lib/bin/build_env.sh

@@ -3,20 +3,24 @@
 # Detect the platform (only GitHub Actions in this case)
 if [ -n "$GITHUB_ACTIONS" ]; then
   # Get environment variables
-  platform="github_actions"
-  branch="${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}"
-  pr_title="$PR_TITLE"
-  target_branch="${GITHUB_BASE_REF}"
-  actor="$GITHUB_ACTOR"
-  sha="$GITHUB_SHA"
+  platform=github_actions
+  branch=${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}
+  pr_title=$SELECTIVE_PR_TITLE
+  target_branch=${GITHUB_BASE_REF}
+  actor=$GITHUB_ACTOR
+  sha=$GITHUB_SHA
+  run_id=$GITHUB_RUN_ID
+  run_attempt=$GITHUB_RUN_ATTEMPT
   commit_message=$(git log --format=%s -n 1 $sha)
 else
-  platform="$SELECTIVE_PLATFORM"
-  branch="$SELECTIVE_BRANCH"
-  pr_title="$SELECTIVE_PR_TITLE"
-  target_branch="$SELECTIVE_TARGET_BRANCH"
-  actor="$SELECTIVE_ACTOR"
-  sha="$SELECTIVE_SHA"
+  platform=$SELECTIVE_PLATFORM
+  branch=$SELECTIVE_BRANCH
+  pr_title=$SELECTIVE_PR_TITLE
+  target_branch=$SELECTIVE_TARGET_BRANCH
+  actor=$SELECTIVE_ACTOR
+  sha=$SELECTIVE_SHA
+  run_id=$SELECTIVE_RUN_ID
+  run_attempt=$SELECTIVE_RUN_ATTEMPT
   commit_message=$(git log --format=%s -n 1 $sha)
 fi
 
@@ -29,6 +33,8 @@ cat <<EOF
     "target_branch": "$target_branch",
     "actor": "$actor",
     "sha": "$sha",
+    "run_id": "$run_id",
+    "run_attempt": "$run_attempt",
     "commit_message": "$commit_message"
   }
 EOF

data/lib/selective/ruby/core/controller.rb

@@ -1,6 +1,8 @@
 require "logger"
 require "uri"
 require "json"
+require "fileutils"
+require "open3"
 
 module Selective
   module Ruby
@@ -8,12 +10,12 @@ module Selective
       class Controller
         @@selective_suppress_reporting = false
 
-        def initialize(runner, debug = false)
+        def initialize(runner, debug: false, log: false)
           @debug = debug
           @runner = runner
           @retries = 0
           @runner_id = ENV.fetch("SELECTIVE_RUNNER_ID", generate_runner_id)
-          @logger = Logger.new("log/#{runner_id}.log")
+          @logger = init_logger(log)
         end
 
         def start(reconnect: false)
@@ -52,6 +54,15 @@ module Selective
 
         BUILD_ENV_SCRIPT_PATH = "../../../bin/build_env.sh".freeze
 
+        def init_logger(enabled)
+          if enabled
+            FileUtils.mkdir_p("log")
+            Logger.new("log/#{runner_id}.log")
+          else
+            Logger.new("/dev/null")
+          end
+        end
+
         def run_main_loop
           loop do
             message = pipe.read
@@ -90,13 +101,15 @@ module Selective
         def transport_url
           @transport_url ||= begin
             api_key = ENV.fetch("SELECTIVE_API_KEY")
-            run_id = ENV.fetch("SELECTIVE_RUN_ID")
-            run_attempt = ENV.fetch("SELECTIVE_RUN_ATTEMPT", SecureRandom.uuid)
             host = ENV.fetch("SELECTIVE_HOST", "wss://app.selective.ci")
 
             # Validate that host is a valid websocket url(starts with ws:// or wss://)
             raise "Invalid host: #{host}" unless host.match?(/^wss?:\/\//)
 
+            run_id = build_env.delete("run_id")
+            run_attempt = build_env.delete("run_attempt")
+            run_attempt = SecureRandom.uuid if run_attempt.nil? || run_attempt.empty?
+
             params = {
               "run_id" => run_id,
               "run_attempt" => run_attempt,
@@ -111,8 +124,10 @@ module Selective
         end
 
         def build_env
-          result = `#{Pathname.new(__dir__) + BUILD_ENV_SCRIPT_PATH}`
-          JSON.parse(result)
+          @build_env ||= begin
+            result = `#{Pathname.new(__dir__) + BUILD_ENV_SCRIPT_PATH}`
+            JSON.parse(result)
+          end
         end
 
         def spawn_transport_process(url)
@@ -123,7 +138,6 @@ module Selective
           # The get_transport script is not released with the gem, so this
           # code is intended for development/CI purposes.
           if !File.exist?(transport_path) && File.exist?(get_transport_path)
-            require "open3"
             output, status = Open3.capture2e(get_transport_path)
             if !status.success?
               puts <<~TEXT
@@ -175,8 +189,8 @@ module Selective
 
         def handle_command(response)
           case response[:command]
-          when "init"
-            print_init(response[:runner_id])
+          when "print_notice"
+            print_notice(response[:message])
           when "test_manifest"
             handle_test_manifest
           when "run_test_cases"
@@ -189,10 +203,11 @@ module Selective
             handle_print_message(response[:message])
           when "close"
             handle_close(response[:exit_status])
-
-            # This is here for the sake of test where we
-            # cannot exit but we need to break the loop
+            # This return is here for the sake of test where
+            # we cannot exit but we need to break the loop
             return false
+          else
+            raise "Unknown command received: #{response[:command]}" if debug?
           end
 
           true
@@ -207,10 +222,9 @@ module Selective
         def handle_test_manifest
           self.class.restore_reporting!
           @logger.info("Sending Response: test_manifest")
-          write({type: "test_manifest", data: {
-            test_cases: runner.manifest["examples"],
-            modified_test_files: modified_test_files
-          }})
+          data = {test_cases: runner.manifest["examples"]}
+          data[:modified_test_files] = modified_test_files unless modified_test_files.nil?
+          write({type: "test_manifest", data: data})
         end
 
         def handle_run_test_cases(test_cases)
@@ -227,9 +241,17 @@ module Selective
         end
 
         def modified_test_files
-          # Todo: This should find files changed in the current branch
-          `git diff --name-only`.split("\n").filter do |f|
-            f.match?(/^#{runner.base_test_path}/)
+          @modified_test_files ||= begin
+            target_branch = build_env["target_branch"]
+            return [] if target_branch.nil? || target_branch.empty?
+
+            output, status = Open3.capture2e("git diff #{target_branch} --name-only")
+
+            if status.success?
+              output.split("\n").filter do |f|
+                f.match?(/^#{runner.base_test_path}/)
+              end
+            end
           end
         end
 
@@ -285,10 +307,10 @@ module Selective
           TEXT
         end
 
-        def print_init(runner_id)
+        def print_notice(message)
           puts_indented <<~TEXT
             #{banner}
-            Runner ID: #{runner_id.gsub("selgen-", "")}
+            #{message}
           TEXT
         end
 

data/lib/selective/ruby/core/version.rb

@@ -3,7 +3,7 @@
 module Selective
   module Ruby
     module Core
-      VERSION = "0.1.1"
+      VERSION = "0.1.3"
     end
   end
 end

data/lib/selective-ruby-core.rb

@@ -24,6 +24,7 @@ module Selective
       class Init
         def initialize(args)
           @debug = !args.delete("--debug").nil?
+          @log = !args.delete("--log").nil?
           @runner_name, @args, @command = parse_args(args)
           require_runner
         end
@@ -34,10 +35,10 @@ module Selective
 
         private
 
-        attr_reader :debug, :runner_name, :args, :command
+        attr_reader :debug, :log, :runner_name, :args, :command
 
         def run
-          Selective::Ruby::Core::Controller.new(runner, debug).send(command)
+          Selective::Ruby::Core::Controller.new(runner, debug: debug, log: log).send(command)
         end
 
         def parse_args(args)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selective-ruby-core
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: x86_64-darwin
 authors:
 - Benjamin Wood
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-11-03 00:00:00.000000000 Z
+date: 2023-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zeitwerk