selections 1.0.5 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 8d78e7577afff17ab44ad69db788df03a71120c1
+  data.tar.gz: d96af8c37726bb6073b9a4a3a572253321f2e70b
+SHA512:
+  metadata.gz: 2f14315a87aba90e7f09eacfc1c6e168a9aca59d75d98abcef515a7a049870057507430399bed2d6e140aa66fa9e7f410dae665e5f092426fdc4063e4cf7b8a9
+  data.tar.gz: d8c956234a9de51d96dde38728a5c9539f009399323b9b4a8e43e82610515a0bcad18dca555b863e54802bc6feb1cc721cdadaae4a6ccc68d70755bbbd406bfa

data/CHANGELOG.md

@@ -1,5 +1,6 @@
-## 1.0.4
-* Validation error message update (system code must start with a letter)
+## 1.1.0
+* Rails 4 update
+* clean up bug relating fixtures not matching dynamically
 
 ## 1.0.3
 * Rubocop cleanup

data/lib/selections/belongs_to_selection.rb

@@ -36,7 +36,7 @@ module Selections
             method_name = "#{s.system_code.sub("#{prefix}_", '')}?".to_sym
             class_eval do
               define_method method_name do
-                send(target_id) == s.id
+                send(target_id).to_i == s.id
               end
             end
           end

data/lib/selections/selectable.rb

@@ -15,7 +15,7 @@ module Selections
         validates_presence_of :name
         validates_uniqueness_of :name, scope: :parent_id
         validates_uniqueness_of :system_code, scope: :archived_at
-        validates_format_of :system_code, :with => /\A[a-z][a-zA-Z_0-9]*\Z/, :message => "Must start with a Letter and can only contain alphanumeric characters and '_', no spaces"
+        validates_format_of :system_code, :with => /\A[a-z][a-zA-Z_0-9]*\Z/, :message => "can only contain alphanumeric characters and '_', not spaces"
 
         before_validation :auto_gen_system_code, on: :create
         before_validation :disable_system_code_change, on: :update

data/lib/selections/version.rb

@@ -1,3 +1,3 @@
 module Selections
-  VERSION = '1.0.5'
+  VERSION = '1.1.0'
 end

data/selections.gemspec

@@ -26,10 +26,10 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency('activerecord', ">= 3.0")
-  gem.add_dependency('activesupport', ">= 3.0")
-  gem.add_dependency('actionpack', ">= 3.0")
-  gem.add_dependency 'acts_as_tree', '~> 2.4.0'
+  gem.add_dependency('activerecord', ">= 4.0")
+  gem.add_dependency('activesupport', ">= 4.0")
+  gem.add_dependency('actionpack', ">= 4.0")
+  gem.add_dependency 'acts_as_tree', '~> 1.6.0'
 
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '~> 3.2'

data/spec/selections/selections_tag_spec.rb

@@ -279,7 +279,7 @@ describe SelectionTag do
           end
         end
         it 'returns valid html' do
-          expect(edit_form.select_tag).to eq "<select id=\"ticket_priority_id\" name=\"ticket[priority_id]\"><option value=\"\"></option>\n<option value=\"4\">high</option>\n<option value=\"2\">low</option>\n<option value=\"3\">medium</option></select>"
+          expect(edit_form.select_tag).to eq "<select name=\"ticket[priority_id]\" id=\"ticket_priority_id\"><option value=\"\"></option>\n<option value=\"4\">high</option>\n<option value=\"2\">low</option>\n<option value=\"3\">medium</option></select>"
         end
       end
     end
@@ -324,7 +324,7 @@ describe SelectionTag do
         end
         it 'returns valid html' do
           ticket.update_attribute(:priority_id, selection_3.id)
-          expect(edit_form(options: {include_blank: true}, html_options: {class: 'fred'}).radio_tag).to eq "<label class=\"fred\" for=\"ticket_priority_id\"><input class=\"fred\" id=\"ticket_priority_id\" name=\"ticket[priority_id]\" type=\"radio\" />none</label><label class=\"fred\" for=\"ticket_priority_id_4\"><input checked=\"checked\" class=\"fred\" id=\"ticket_priority_id_4\" name=\"ticket[priority_id]\" type=\"radio\" value=\"4\" />high</label><label checked=\"checked\" class=\"fred\" for=\"ticket_priority_id_2\"><input class=\"fred\" id=\"ticket_priority_id_2\" name=\"ticket[priority_id]\" type=\"radio\" value=\"2\" />low</label><label class=\"fred\" for=\"ticket_priority_id_3\"><input class=\"fred\" id=\"ticket_priority_id_3\" name=\"ticket[priority_id]\" type=\"radio\" value=\"3\" />medium</label>"
+          expect(edit_form(options: {include_blank: true}, html_options: {class: 'fred'}).radio_tag).to eq "<label class=\"fred\" for=\"ticket_priority_id\"><input class=\"fred\" type=\"radio\" name=\"ticket[priority_id]\" id=\"ticket_priority_id\" />none</label><label class=\"fred\" for=\"ticket_priority_id_4\"><input class=\"fred\" type=\"radio\" value=\"4\" checked=\"checked\" name=\"ticket[priority_id]\" id=\"ticket_priority_id_4\" />high</label><label class=\"fred\" checked=\"checked\" for=\"ticket_priority_id_2\"><input class=\"fred\" type=\"radio\" value=\"2\" name=\"ticket[priority_id]\" id=\"ticket_priority_id_2\" />low</label><label class=\"fred\" for=\"ticket_priority_id_3\"><input class=\"fred\" type=\"radio\" value=\"3\" name=\"ticket[priority_id]\" id=\"ticket_priority_id_3\" />medium</label>"
         end
       end
     end

data/spec/spec_helper.rb

@@ -15,7 +15,7 @@ ActiveRecord::Migration.create_table :selections do |t|
   t.datetime :archived_at
   t.integer :position_value
   t.boolean :is_default
-  t.timestamps
+  t.timestamps null: false
 end
 ActiveRecord::Base.send(:include, ActsAsTree)
 
@@ -23,7 +23,7 @@ ActiveRecord::Migration.create_table :tickets do |t|
   t.string :name
   t.integer :parent_id
   t.integer :priority_id
-  t.timestamps
+  t.timestamps null: false
 end
 
 class Selection < ActiveRecord::Base #:nodoc:

metadata

@@ -1,221 +1,197 @@
 --- !ruby/object:Gem::Specification
 name: selections
 version: !ruby/object:Gem::Version
-  version: 1.0.5
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Nigel Rausch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2015-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: acts_as_tree
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: generator_spec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.4.0
-description: ! "Selection list management and form and view helpers.\n Manages one
-  table to hold all selections items/dropdown lists ( tree ).\n Dynamic lookup to
-  find parent or children ( eg. Selection.priorities ).\n Form helper to display lists
-  ( eg. f.selections :priorities ).\n Handling of archived items ( displaying if selected
-  only ).\n"
+description: |
+  Selection list management and form and view helpers.
+   Manages one table to hold all selections items/dropdown lists ( tree ).
+   Dynamic lookup to find parent or children ( eg. Selection.priorities ).
+   Form helper to display lists ( eg. f.selections :priorities ).
+   Handling of archived items ( displaying if selected only ).
 email:
 - nigelr@brisbanerails.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -254,27 +230,26 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/nigelr/selections
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.4.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Selection list management and form and view helpers. Manages one table to
   hold all selections items/dropdown lists ( tree ). Dynamic lookup to find parent
   or children ( eg. Selection.priorities ). Form helper to display lists ( eg. f.selections