select_pdf_api 0.0.2 → 0.0.3

data/test/minitest_helper.rb

@@ -1,3 +1,13 @@
 $:.unshift File.expand_path('../../lib', __FILE__)
+
 require 'select_pdf_api'
-require 'minitest/autorun'
+require 'minitest/autorun'
+require 'webmock/minitest'
+require 'vcr'
+
+VCR.configure do |c|
+	c.filter_sensitive_data('<KEY>') { ENV['SELECT_PDF_KEY'] }
+
+  c.cassette_library_dir = "test/fixtures/vcr"
+  c.hook_into :webmock
+end

data/test/test_select_pdf_api/test_api.rb

@@ -3,11 +3,14 @@ require './test/minitest_helper'
 # API test
 describe SelectPdfApi do
 	let(:fixtures)			 {"../test/fixtures"}
-	let(:minimum_config) {"#{fixtures}/minimum-config.yml"}
-	let(:maximum_config) {"#{fixtures}/all-config.yml"}
-	let(:blank_config)   {"#{fixtures}/blank-config.yml"}
+	let(:minimum_config) {"#{fixtures}/minimum-config"}
+	let(:maximum_config) {"#{fixtures}/all-config"}
+	let(:blank_config)   {"#{fixtures}/blank-config"}
 
-	let(:select_pdf)  {SelectPdfApi.new({url: 'http://www.google.com'})}
+	let(:select_pdf)  {SelectPdfApi.new({
+		url: 'http://www.google.com',
+		config: SelectPdfApi::YamlConfig.new(minimum_config)
+	})}
 
 	before do
 		select_pdf.config.load_config(minimum_config)
@@ -54,7 +57,17 @@ describe SelectPdfApi do
 		end
 
 		def test_it_fails_without_a_url
-			-> {SelectPdfApi.new.download}.must_raise SelectPdfApi::DownloadError
+			VCR.use_cassette('download_no_url') do
+				-> {select_pdf.download}.must_raise SelectPdfApi::DownloadError
+			end
+		end
+
+		def test_downloads_a_pdf
+			VCR.use_cassette('download_pdf') do
+				select_pdf.config.options['key'] = ENV["SELECT_PDF_KEY"]
+				select_pdf.download
+				select_pdf.success?.must_equal true
+			end
 		end
 	end
 end

data/test/test_select_pdf_api/test_env_config.rb

@@ -0,0 +1,28 @@
+require './test/minitest_helper'
+
+# Config test
+describe SelectPdfApi::EnvConfig do
+	let(:select_pdf) {SelectPdfApi.new({
+		url: "http://www.google.com",
+		config: SelectPdfApi::EnvConfig.new
+	})}
+
+	def test_it_exists
+		select_pdf.must_be_instance_of SelectPdfApi
+		select_pdf.config.must_be_instance_of SelectPdfApi::EnvConfig
+	end
+
+	def test_key_is_loaded_from_env
+		env_key = ENV['SELECT_PDF_KEY']
+		select_pdf.config.options['key'].must_equal env_key
+	end
+
+	def test_options_must_be_changable
+		original_key = ENV['SELECT_PDF_KEY']
+		modified_key = "modified-key-123"
+
+		select_pdf.config.options['key'].must_equal original_key
+		select_pdf.config.options['key'] = modified_key
+		select_pdf.config.options['key'].must_equal modified_key
+	end
+end

data/test/test_select_pdf_api/{test_yaml_file_config.rb → test_yaml_config.rb}

@@ -1,13 +1,13 @@
 require './test/minitest_helper'
 
 # Config test
-describe SelectPdfApi::YamlFileConfig do
+describe SelectPdfApi::YamlConfig do
 	let(:fixtures)			 {"../test/fixtures"}
 
-	let(:blank_config) 	 {SelectPdfApi::YamlFileConfig.new("#{fixtures}/blank-config.yml")}
-	let(:minimum_config) {SelectPdfApi::YamlFileConfig.new("#{fixtures}/minimum-config.yml")}
-	let(:maximum_config) {SelectPdfApi::YamlFileConfig.new("#{fixtures}/all-config.yml")}
-	let(:invalid_config) {SelectPdfApi::YamlFileConfig.new('invalid_config')}
+	let(:blank_config) 	 {SelectPdfApi::YamlConfig.new("#{fixtures}/blank-config")}
+	let(:minimum_config) {SelectPdfApi::YamlConfig.new("#{fixtures}/minimum-config")}
+	let(:maximum_config) {SelectPdfApi::YamlConfig.new("#{fixtures}/all-config")}
+	let(:invalid_config) {SelectPdfApi::YamlConfig.new('invalid_config')}
 
 	def test_it_should_fail_with_an_invalid_config
 		-> {invalid_config}.must_raise SelectPdfApi::ConfigError
@@ -31,9 +31,9 @@ describe SelectPdfApi::YamlFileConfig do
 		original = {"key"=>"random-valid-api-123abc-345dbc"}
 		modified = {"key"=>"valid-key-123-67ad", "page_size"=>"Letter", "page_orientation"=>"Landscape", "margin_right"=>"2pt", "margin_bottom"=>"2pt", "margin_left"=>"1.25pt", "user_password"=>"user123", "owner_password"=>"owner567"}
 
-		config = SelectPdfApi::YamlFileConfig.new("#{fixtures}/minimum-config.yml")
+		config = SelectPdfApi::YamlConfig.new("#{fixtures}/minimum-config")
 		config.options.must_equal original
-		config.load_config("#{fixtures}/all-config.yml")
+		config.load_config("#{fixtures}/all-config")
 		config.options.must_equal modified
 	end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: select_pdf_api
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Arian Amador
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-15 00:00:00.000000000 Z
+date: 2015-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,46 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.9.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.9.3
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.20'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.20.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.20'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.20.4
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -85,17 +125,22 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- config/select-pdf-config.yml
 - lib/select_pdf_api.rb
+- lib/select_pdf_api/env_config.rb
 - lib/select_pdf_api/exceptions.rb
 - lib/select_pdf_api/version.rb
-- lib/select_pdf_api/yaml_file_config.rb
+- lib/select_pdf_api/yaml_config.rb
 - select_pdf_api.gemspec
 - test/fixtures/all-config.yml
 - test/fixtures/blank-config.yml
 - test/fixtures/minimum-config.yml
+- test/fixtures/vcr/download_no_url.yml
+- test/fixtures/vcr/download_pdf.yml
 - test/minitest_helper.rb
 - test/test_select_pdf_api/test_api.rb
-- test/test_select_pdf_api/test_yaml_file_config.rb
+- test/test_select_pdf_api/test_env_config.rb
+- test/test_select_pdf_api/test_yaml_config.rb
 homepage: https://www.github.com/arian-amador/select_pdf_api
 licenses:
 - MIT
@@ -124,6 +169,9 @@ test_files:
 - test/fixtures/all-config.yml
 - test/fixtures/blank-config.yml
 - test/fixtures/minimum-config.yml
+- test/fixtures/vcr/download_no_url.yml
+- test/fixtures/vcr/download_pdf.yml
 - test/minitest_helper.rb
 - test/test_select_pdf_api/test_api.rb
-- test/test_select_pdf_api/test_yaml_file_config.rb
+- test/test_select_pdf_api/test_env_config.rb
+- test/test_select_pdf_api/test_yaml_config.rb

data/lib/select_pdf_api/yaml_file_config.rb

@@ -1,24 +0,0 @@
-class SelectPdfApi
-	class YamlFileConfig
-
-		def initialize(filename)
-			@data = {}
-			load_config filename
-		end
-
-		def load_config(filename)
-			config_file = File.join(File.expand_path(File.join('config')), filename)
-
-			raise SelectPdfApi::ConfigError, "Config file #{config_file} does not exist." unless
-				File.exist? config_file
-
-			@data = YAML::load_file(config_file)
-
-			raise SelectPdfApi::ConfigError, "Error loading values from #{config_file}" unless @data
-		end
-
-		def options
-			@data
-		end
-	end
-end