seems_rateable 1.0.13 → 2.0.0

data/spec/helpers/action_view_extension_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe SeemsRateable::Helpers::ActionViewExtension, type: :feature do
+  let(:user) { FactoryGirl.create(:user) }
+  let(:rateable) { DummyModel.create }
+  let(:view) { DummyView.new }
+
+  describe "#rating_for" do
+    context "valid rateable object" do
+      before do
+        DummyModel.seems_rateable
+      end
+
+      it "builds a new voting" do
+        SeemsRateable::Builder.should_receive(:build).with(rateable, an_instance_of(Hash))
+        view.rating_for rateable
+      end
+
+      describe "disabled rating" do
+        shared_examples "passing disabled true" do |options={}|
+          it "passes disabled: true as an option" do
+            SeemsRateable::Builder.should_receive(:build).with(rateable, hash_including(disabled: true))
+            view.rating_for rateable, options
+          end
+        end
+
+        context "when no current rater" do
+          it_behaves_like "passing disabled true"
+        end
+
+        context "when user has already rated" do
+          let(:rate) { FactoryGirl.create(:rate, rateable: rateable) }
+
+          before do
+            DummyView.stub(:current_rater).and_return(rate.rater)
+          end
+
+          it_behaves_like "passing disabled true"
+        end
+
+        context "when it is given explicitly" do
+          before do
+            DummyView.stub(:current_rater).and_return(user)
+          end
+
+          it_behaves_like "passing disabled true", disabled: true
+        end
+      end
+    end
+
+    context "invalid rateable object" do
+      it "raises an InvalidRateableError" do
+        expect {
+          view.rating_for "wtf?"
+        }.to raise_error(SeemsRateable::Errors::InvalidRateableError)
+      end
+    end
+  end
+end

data/spec/models/active_record_extension_spec.rb

@@ -0,0 +1,105 @@
+require 'spec_helper'
+
+describe SeemsRateable::Models::ActiveRecordExtension do
+  describe "#seems_rateable" do
+    subject { DummyModel.seems_rateable.new }
+
+    context "without any dimension" do
+      it { should have_many(:_rates).class_name(SeemsRateable::Rate) }
+      it { should have_many(:_raters).through(:_rates).dependent(:destroy) }
+    end
+
+    context "with dimensions" do
+      dimensions = [:speed, :quality]
+      let(:dimensions) { dimensions }
+
+      subject { DummyModel.seems_rateable(*dimensions).new }
+
+      dimensions.each do |dimension|
+        it { should have_many(:"#{dimension}_rates").conditions(dimension: dimension) }
+        it { should have_many(:"#{dimension}_raters").through(:"#{dimension}_rates") }
+      end
+    end
+
+    it { should be_a(SeemsRateable::Models::ActiveRecordExtension::Rateable) }
+  end
+
+  describe "#seems_rateable_rater" do
+    subject { DummyModel.seems_rateable_rater.new }
+
+    it { should have_many(:rates_given).class_name(SeemsRateable::Rate) }
+    it { should be_a(SeemsRateable::Models::ActiveRecordExtension::Rater) }
+  end
+
+  describe SeemsRateable::Models::ActiveRecordExtension::Rateable do
+    subject do
+      Class.new.send(:include, SeemsRateable::Models::ActiveRecordExtension::Rateable).new
+    end
+
+    %w[rates raters].each do |method|
+      describe "##{method}" do
+        context "valid dimension" do
+          context "no dimension" do
+            it "sends _#{method}" do
+              subject.should_receive(:"_#{method}")
+              subject.send method
+            end
+          end
+
+          context "existent dimension" do
+            let(:dimension) { 'quality' }
+
+            before do
+              subject.stub(dimension + '_' + method).and_return(true)
+            end
+
+            it "sends quality_rates" do
+              subject.should_receive(:"#{dimension}_#{method}")
+              subject.send method, dimension
+            end
+          end
+
+          context "non-existent dimension" do
+            it "raises NonExistentDimension error" do
+              expect { subject.send method, "foo" }.to raise_error
+            end
+          end
+        end
+      end
+    end
+
+    describe "#rating" do
+      let(:rates) { SeemsRateable::Rate.all }
+
+      before do
+        subject.stub(:rates).and_return(rates)
+      end
+
+      it "initializes a SeemsRateable::Rating instance with its rates" do
+        subject.rating.should be_a(SeemsRateable::Rating)
+        subject.rating.rates.should == rates
+      end
+    end
+
+    describe "#rated_by" do
+      context "when passed rater is nil" do
+        it "returns does not query the database and returns nil" do
+          subject.rated_by?(nil).should be_nil
+        end
+      end
+
+      context "when passed rater is not nil" do
+        before do
+          subject.stub(:raters).and_return([])
+        end
+
+        let(:rater) { "a random guy" }
+
+        it "checks wheter its raters includes the rater" do
+          subject.raters.should_receive(:include?).with(rater)
+          subject.rated_by?(rater)
+        end
+      end
+    end
+  end
+end

data/spec/models/rate_spec.rb

@@ -0,0 +1,6 @@
+require 'spec_helper'
+
+describe SeemsRateable::Rate do
+  it { should belong_to(:rateable) }
+  it { should belong_to(:rater) }
+end

data/spec/rating_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe SeemsRateable::Rating do
+  let(:rated_rateable) { FactoryGirl.create(:post) }
+  let(:unrated_rateable) { FactoryGirl.create(:post) }
+
+  let(:stars) { [1, 5, 4, 3, 5] }
+
+  let(:rates) { rated_rateable.rates }
+  let(:no_rates) { unrated_rateable.rates }
+
+  before do
+    stars.each do |value|
+      FactoryGirl.create(:rate, stars: value, rateable: rated_rateable)
+    end
+  end
+
+  def rating(rates)
+    SeemsRateable::Rating.new(rates)
+  end
+
+  subject { rating(rates) }
+
+  describe "#rates" do
+    subject { super().rates }
+
+    it { should be_a(ActiveRecord::Relation) }
+    its(:model) { should equal(SeemsRateable::Rate) }
+  end
+
+  describe "#stars" do
+    it "plucks rates for stars" do
+      subject.rates.should_receive(:pluck).with(:stars)
+      subject.stars
+    end
+  end
+
+  describe "#count" do
+    it "returns length of the plucked stars array" do
+      subject.stars.should_receive(:length)
+      subject.count
+    end
+  end
+
+  describe "#sum" do
+    it "sums the plucked stars array" do
+      subject.stars.should_receive(:inject).with(:+)
+      subject.sum
+    end
+  end
+
+  describe "average" do
+    context "with any rates" do
+      it "divides the sum by the length of stars" do
+        sum = subject.sum
+        count = subject.count
+
+        subject.average.should == sum/count
+      end
+    end
+
+    context "without any rate" do
+      subject { rating(no_rates) }
+
+      it "returns zero" do
+        subject.average.should == 0
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,45 @@
+ENV["RAILS_ENV"] ||= 'test'
+
+require 'simplecov'
+SimpleCov.start
+
+require File.expand_path("../dummy/config/environment", __FILE__)
+require 'rspec/rails'
+require 'rspec/autorun'
+
+require 'factory_girl_rails'
+require 'shoulda-matchers'
+require 'database_cleaner'
+require 'pry-rails'
+
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+ActiveRecord::Migration.check_pending! if defined?(ActiveRecord::Migration)
+
+Rails.backtrace_cleaner.remove_silencers!
+
+RSpec.configure do |config|
+  config.use_transactional_fixtures = false
+  config.infer_base_class_for_anonymous_controllers = false
+  config.order = "random"
+
+  config.before(:suite) do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  config.before(:each, js: true) do
+    DatabaseCleaner.strategy = :truncation
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end

data/spec/support/dummies.rb

@@ -0,0 +1,19 @@
+def active_record_extended
+  ActiveRecord::Base.extend(SeemsRateable::Models::ActiveRecordExtension)
+end
+
+def action_view_extended
+  ActionView::Base.extend(SeemsRateable::Helpers::ActionViewExtension)
+end
+
+class DummyModel < active_record_extended;end
+
+class DummyView < action_view_extended
+  def current_rater
+    nil
+  end
+end
+
+ActiveRecord::Migration.verbose = false
+ActiveRecord::Migration.create_table(:dummy_models) unless ActiveRecord::Migration.tables.include?("dummy_models")
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: seems_rateable
 version: !ruby/object:Gem::Version
-  version: 1.0.13
+  version: 2.0.0
 platform: ruby
 authors:
 - Peter Toth
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-20 00:00:00.000000000 Z
+date: 2014-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: jquery-rails
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +66,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: devise
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +94,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: factory_girl_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -81,7 +137,49 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl_rails
+  name: selenium-webdriver
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: shoulda-matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: generator_spec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -96,37 +194,117 @@ dependencies:
         version: '0'
 description: Star rating engine using jQuery plugin jRating for Rails applications
 email:
-- proximin@gmail.com
+- peter@petertoth.me
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- app/assets/stylesheets/seems_rateable/application.css
-- app/assets/javascripts/seems_rateable/application.js
-- app/assets/images/seems_rateable/stars.png
-- app/assets/images/seems_rateable/small.png
+- .gitignore
+- Gemfile
+- MIT-LICENSE
+- README.md
+- Rakefile
 - app/assets/images/seems_rateable/bg_jRatingInfos.png
-- app/controllers/seems_rateable/ratings_controller.rb
+- app/assets/images/seems_rateable/small.png
+- app/assets/images/seems_rateable/stars.png
+- app/assets/javascripts/seems_rateable/index.js
+- app/assets/javascripts/seems_rateable/jRating.js.erb
+- app/assets/stylesheets/seems_rateable/index.css.erb
 - app/controllers/seems_rateable/application_controller.rb
+- app/controllers/seems_rateable/rates_controller.rb
 - app/models/seems_rateable/rate.rb
-- app/models/seems_rateable/cached_rating.rb
+- bin/rails
 - config/routes.rb
-- lib/seems_rateable.rb
 - lib/generators/seems_rateable/install/install_generator.rb
 - lib/generators/seems_rateable/install/templates/initializer.rb
 - lib/generators/seems_rateable/install/templates/rateable.js.erb
 - lib/generators/seems_rateable/install/templates/rates_migration.rb
-- lib/generators/seems_rateable/install/templates/cached_ratings_migration.rb
-- lib/generators/seems_rateable/install/templates/jRating.js.erb
-- lib/seems_rateable/version.rb
-- lib/seems_rateable/helpers.rb
-- lib/seems_rateable/routes.rb
-- lib/seems_rateable/errors.rb
+- lib/generators/seems_rateable/manifest_finder.rb
+- lib/generators/seems_rateable/migration_helpers.rb
+- lib/generators/seems_rateable/uninstall/templates/drop_seems_rateable_rates_table.rb
+- lib/generators/seems_rateable/uninstall/uninstall_generator.rb
+- lib/generators/seems_rateable/uninstall_old/templates/drop_seems_rateable_cached_ratings_table.rb
+- lib/generators/seems_rateable/uninstall_old/templates/drop_seems_rateable_rates_table.rb
+- lib/generators/seems_rateable/uninstall_old/uninstall_old_generator.rb
+- lib/seems_rateable.rb
+- lib/seems_rateable/builder.rb
+- lib/seems_rateable/builder/html_options.rb
+- lib/seems_rateable/configuration.rb
 - lib/seems_rateable/engine.rb
-- lib/seems_rateable/model.rb
-- MIT-LICENSE
-- Rakefile
-- README.md
+- lib/seems_rateable/errors.rb
+- lib/seems_rateable/helpers/action_view_extension.rb
+- lib/seems_rateable/helpers/current_rater.rb
+- lib/seems_rateable/models/active_record_extension.rb
+- lib/seems_rateable/models/active_record_extension/rateable.rb
+- lib/seems_rateable/models/active_record_extension/rater.rb
+- lib/seems_rateable/rating.rb
+- lib/seems_rateable/routes.rb
+- lib/seems_rateable/version.rb
+- seems_rateable.gemspec
+- spec/builder_spec.rb
+- spec/controllers/rates_controller_spec.rb
+- spec/dummy/README.rdoc
+- spec/dummy/Rakefile
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/javascripts/posts.js
+- spec/dummy/app/assets/javascripts/rateable/rateable.js.erb
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/assets/stylesheets/scaffold.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/concerns/.keep
+- spec/dummy/app/controllers/posts_controller.rb
+- spec/dummy/app/models/.keep
+- spec/dummy/app/models/concerns/.keep
+- spec/dummy/app/models/post.rb
+- spec/dummy/app/models/user.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/posts/_form.html.erb
+- spec/dummy/app/views/posts/edit.html.erb
+- spec/dummy/app/views/posts/index.html.erb
+- spec/dummy/app/views/posts/new.html.erb
+- spec/dummy/app/views/posts/show.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/devise.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/seems_rateable.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/devise.en.yml
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/db/migrate/20140506144141_create_posts.rb
+- spec/dummy/db/migrate/20140506144841_devise_create_users.rb
+- spec/dummy/db/migrate/20140520170316_create_seems_rateable_rates.rb
+- spec/dummy/db/schema.rb
+- spec/dummy/lib/assets/.keep
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/factories/posts.rb
+- spec/factories/rate.rb
+- spec/factories/users.rb
+- spec/features/rating_spec.rb
+- spec/helpers/action_view_extension_spec.rb
+- spec/models/active_record_extension_spec.rb
+- spec/models/rate_spec.rb
+- spec/rating_spec.rb
+- spec/spec_helper.rb
+- spec/support/dummies.rb
 homepage: http://rateable.herokuapp.com
 licenses: []
 metadata: {}
@@ -150,5 +328,65 @@ rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Star Rating Engine
-test_files: []
-has_rdoc: 
+test_files:
+- spec/controllers/rates_controller_spec.rb
+- spec/dummy/README.rdoc
+- spec/dummy/Rakefile
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/javascripts/posts.js
+- spec/dummy/app/assets/javascripts/rateable/rateable.js.erb
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/assets/stylesheets/scaffold.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/concerns/.keep
+- spec/dummy/app/controllers/posts_controller.rb
+- spec/dummy/app/models/.keep
+- spec/dummy/app/models/concerns/.keep
+- spec/dummy/app/models/post.rb
+- spec/dummy/app/models/user.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/posts/_form.html.erb
+- spec/dummy/app/views/posts/edit.html.erb
+- spec/dummy/app/views/posts/index.html.erb
+- spec/dummy/app/views/posts/new.html.erb
+- spec/dummy/app/views/posts/show.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/devise.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/seems_rateable.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/devise.en.yml
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/db/migrate/20140506144141_create_posts.rb
+- spec/dummy/db/migrate/20140506144841_devise_create_users.rb
+- spec/dummy/db/migrate/20140520170316_create_seems_rateable_rates.rb
+- spec/dummy/db/schema.rb
+- spec/dummy/lib/assets/.keep
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/factories/posts.rb
+- spec/factories/rate.rb
+- spec/factories/users.rb
+- spec/features/rating_spec.rb
+- spec/helpers/action_view_extension_spec.rb
+- spec/models/active_record_extension_spec.rb
+- spec/models/rate_spec.rb
+- spec/support/dummies.rb