seeing_is_believing 0.0.21 → 0.0.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b04673605b79a81c7e47cd26c98a9b10fba50193
-  data.tar.gz: 3e98d95b8e19b3aca8087584218f21bfe7492e68
+  metadata.gz: 4b8af587001dcce44e111c4611d49e476e6d0248
+  data.tar.gz: 969a7c9d9fdb9dc658c7c8c18a9805da7a2baedd
 SHA512:
-  metadata.gz: 12d197241dabb6a700cfd2b241d2c88a1713d0ee2dc3ae3de359ea8364fdb9718758784ac5e7ca25a92137c23c14a486c440b9e5ec9fabda8899b0ce992ae733
-  data.tar.gz: 0da562f2291215aea0710cd1bd99575041d6de741c11cfdca692b2392645669e06d96e6441301cf216474c81f489896810758024919ff686879c80078140bbf3
+  metadata.gz: cb909d18af0d797c8236c53015a430f5bf7bf45b7c625a4986488b89bb8df8500220fc0208270ce9e44bb556f38f6b79356e71c8f4c2445a0126cf4697a67501
+  data.tar.gz: b72db4437845c50df7d5c948b2fa73d0397e7cbcf493600eeb953c612ec93cc6d0f759a6503504e89f642e619c21a231df8ca51c11fbc7e68d28aeab7c7f320f

data/Readme.md

@@ -83,6 +83,12 @@ Rubygems is allowing pushes again, but if it goes back down, you can install lik
     $ cd ..
     $ rm -rf "./seeing_is_believing"
 
+Sublime Text 2 Integration
+==========================
+
+See [sublime-text-2-seeing-is-believing](https://github.com/JoshCheek/sublime-text-2-seeing-is-believing).
+
+
 TextMate Integration
 ====================
 
@@ -138,6 +144,7 @@ Todo
 * Don't blow up on "a\\\n.b"
 * Record results with "a\n.b.\nc"
 * Record results with "a + \n b"
+* a\n.b(\n.c\n) will blow up, need to make sure that joining it with the next line is valid ruby
 * Refactor ExpressionList/SeeingIsBelieving to store lines in an array instead of as a string, so everyone doesn't magically need to know when to chomp
 
 License

data/features/errors.feature

@@ -82,3 +82,9 @@ Feature: Running the binary unsuccessfully
     m
     """
 
+  Scenario: Total Fucking Failure
+    Given the file "sib_will_utterly_die.rb" "BEGIN {}"
+    When I run "seeing_is_believing sib_will_utterly_die.rb"
+    Then stderr is not empty
+    And the exit status is 2
+    And stdout is empty

data/features/step_definitions/steps.rb

@@ -7,5 +7,6 @@ When("I run '$command'")                     { |command|              @last_exec
 Then(/^(stderr|stdout) is:$/)                { |stream_name, output|  @last_executed.send(stream_name).chomp.should == eval_curlies(output) }
 Then(/^(stderr|stdout) is ["'](.*?)["']$/)   { |stream_name, output|  @last_executed.send(stream_name).chomp.should == eval_curlies(output) }
 Then(/^(stderr|stdout) is empty$/)           { |stream_name|          @last_executed.send(stream_name).should == '' }
+Then(/^(stderr|stdout) is not empty$/)       { |stream_name|          @last_executed.send(stream_name).chomp.should_not be_empty }
 Then(/^(stderr|stdout) includes "([^"]*)"$/) { |stream_name, content| @last_executed.send(stream_name).should include eval_curlies(content) }
 Then('the exit status is $status')           { |status|               @last_executed.exitstatus.to_s.should == status }

data/lib/seeing_is_believing/binary.rb

@@ -10,7 +10,7 @@ class SeeingIsBelieving
     DISPLAYABLE_ERROR_STATUS    = 1 # e.g. there was an error, but the output is legit (we can display exceptions)
     NONDISPLAYABLE_ERROR_STATUS = 2 # e.g. an error like incorrect invocation or syntax that can't be displayed in the input program
 
-    attr_accessor :argv, :stdin, :stdout, :stderr, :timeout_error
+    attr_accessor :argv, :stdin, :stdout, :stderr, :timeout_error, :unexpected_exception
 
     def initialize(argv, stdin, stdout, stderr)
       self.argv   = argv
@@ -20,16 +20,17 @@ class SeeingIsBelieving
     end
 
     def call
-      @exitstatus ||= if    flags_have_errors?          then print_errors          ; NONDISPLAYABLE_ERROR_STATUS
-                      elsif should_print_help?          then print_help            ; SUCCESS_STATUS
-                      elsif should_print_version?       then print_version         ; SUCCESS_STATUS
-                      elsif has_filename? && file_dne?  then print_file_dne        ; NONDISPLAYABLE_ERROR_STATUS
-                      elsif should_clean?               then print_cleaned_program ; SUCCESS_STATUS
-                      elsif invalid_syntax?             then print_syntax_error    ; NONDISPLAYABLE_ERROR_STATUS
-                      elsif program_timedout?           then print_timeout_error   ; NONDISPLAYABLE_ERROR_STATUS
-                      else                                   print_program         ; (results.has_exception? ?
-                                                                                        DISPLAYABLE_ERROR_STATUS :
-                                                                                        SUCCESS_STATUS)
+      @exitstatus ||= if    flags_have_errors?          then print_errors           ; NONDISPLAYABLE_ERROR_STATUS
+                      elsif should_print_help?          then print_help             ; SUCCESS_STATUS
+                      elsif should_print_version?       then print_version          ; SUCCESS_STATUS
+                      elsif has_filename? && file_dne?  then print_file_dne         ; NONDISPLAYABLE_ERROR_STATUS
+                      elsif should_clean?               then print_cleaned_program  ; SUCCESS_STATUS
+                      elsif invalid_syntax?             then print_syntax_error     ; NONDISPLAYABLE_ERROR_STATUS
+                      elsif program_timedout?           then print_timeout_error    ; NONDISPLAYABLE_ERROR_STATUS
+                      elsif something_blew_up?          then print_unexpected_error ; NONDISPLAYABLE_ERROR_STATUS
+                      else                                   print_program          ; (results.has_exception? ?
+                                                                                         DISPLAYABLE_ERROR_STATUS :
+                                                                                         SUCCESS_STATUS)
                       end
     end
 
@@ -65,6 +66,16 @@ class SeeingIsBelieving
                                           timeout:   flags[:timeout]
     rescue Timeout::Error
       self.timeout_error = true
+    rescue Exception
+      self.unexpected_exception = $!
+    end
+
+    def something_blew_up?
+      !!unexpected_exception
+    end
+
+    def print_unexpected_error
+      stderr.puts unexpected_exception.class, unexpected_exception.message
     end
 
     def printer

data/lib/seeing_is_believing/evaluate_by_moving_files.rb

@@ -44,6 +44,8 @@ class SeeingIsBelieving
             evaluate_file
             fail unless exitstatus.success?
             deserialize_result
+          # Okay, really, I should wrap this in another exception and raise it on up,
+          # but for now, I'm feeling a little lazy and am not going to do it
           rescue Exception
             notify_user_of_error if error_implies_bug_in_sib? $!
             raise $!

data/lib/seeing_is_believing/syntax_analyzer.rb

@@ -159,7 +159,7 @@ class SeeingIsBelieving
     # this is conspicuosuly inferior, but I can't figure out how to actually parse it
     # see: http://www.ruby-forum.com/topic/4409633
     def self.void_value_expression?(code)
-      /(^|\s)(?:return|next|redo|retry|break).*?\n?\z/ =~ code
+      /(^|\s)(?:return|next|redo|retry|break)([^\w\n]|\n?\z).*?\n?\z/ =~ code
     end
 
     # HERE DOCS

data/lib/seeing_is_believing/version.rb

@@ -1,3 +1,3 @@
 class SeeingIsBelieving
-  VERSION = '0.0.21'
+  VERSION = '0.0.22'
 end

data/spec/seeing_is_believing_spec.rb

@@ -189,7 +189,7 @@ describe SeeingIsBelieving do
     DOC
   end
 
-  it 'does not try to record the keyword retry' do
+  it 'does not try to record the keyword retry', t2:true do
     values_for(<<-DOC).should == [[], [], [], ['nil']]
       def meth
       rescue

data/spec/syntax_analyzer_spec.rb

@@ -172,7 +172,9 @@ describe SeeingIsBelieving::SyntaxAnalyzer do
   end
 
   shared_examples_for 'void_value_expression?' do |keyword|
-    it "returns true when the expression ends in #{keyword}" do
+    it "`#{keyword}` returns true when the expression ends in #{keyword}", t:true do
+      described_class.void_value_expression?("#{keyword}").should be_true
+      described_class.void_value_expression?("#{keyword}(1)").should be_true
       described_class.void_value_expression?("#{keyword} 1").should be_true
       described_class.void_value_expression?("#{keyword} 1\n").should be_true
       described_class.void_value_expression?("#{keyword} 1 if true").should be_true
@@ -183,6 +185,8 @@ describe SeeingIsBelieving::SyntaxAnalyzer do
       described_class.void_value_expression?("def a\n#{keyword} 1\nend").should be_false
       described_class.void_value_expression?("-> {\n#{keyword} 1\n}").should be_false
       described_class.void_value_expression?("Proc.new {\n#{keyword} 1\n}").should be_false
+      described_class.void_value_expression?("#{keyword}_something").should be_false
+      described_class.void_value_expression?("def a\n#{keyword}\nend").should be_false
     end
 
     it "doesn't work because the return and next keyword evaluators are insufficient regexps" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: seeing_is_believing
 version: !ruby/object:Gem::Version
-  version: 0.0.21
+  version: 0.0.22
 platform: ruby
 authors:
 - Josh Cheek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-28 00:00:00.000000000 Z
+date: 2013-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake