seeing_is_believing 0.0.20 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9ba8a14985e629d8a7aa7f9f850bbbe9b720563
-  data.tar.gz: 562f431d621620445ab1387c8a20f781f0cfb26c
+  metadata.gz: b04673605b79a81c7e47cd26c98a9b10fba50193
+  data.tar.gz: 3e98d95b8e19b3aca8087584218f21bfe7492e68
 SHA512:
-  metadata.gz: b1c475f28d6b6125acdcd00c42393a623d72f3a89fa07b31619b484fa18e427bbdce098386e23ab3d4add181be07ed513aa5b4caeb41e48ff002e4f130520cb6
-  data.tar.gz: 61fd93446e41d472e1d4afd745e7d5bd981af84c7bf139154fec8dfcf5416330374f87e91759be6f21c64f369d60c0628f1f055e359cf7377167d99cc7e3a921
+  metadata.gz: 12d197241dabb6a700cfd2b241d2c88a1713d0ee2dc3ae3de359ea8364fdb9718758784ac5e7ca25a92137c23c14a486c440b9e5ec9fabda8899b0ce992ae733
+  data.tar.gz: 0da562f2291215aea0710cd1bd99575041d6de741c11cfdca692b2392645669e06d96e6441301cf216474c81f489896810758024919ff686879c80078140bbf3

data/Readme.md

@@ -130,10 +130,15 @@ Known Issues
 
 * `BEGIN/END` breaks things and I probably won't take the time to fix it, becuase it's nontrivial and its really meant for command-line scripts, but there is currently a cuke for it
 * Heredocs aren't recorded. It might actually be possible if the ExpressionList were to get smarter
-* Return statements and other control-flow changing keywords (next/break/redo/retry) are dealt with poorly, causing some situations where you could capture and display a value to not capture
 * errors come out really shitty if you're calling them from another program like TextMate, would be better to put a line in that shows where the error is.
-* Add a time limit to auto-kill it if it gets stuck or something (e.g. stack overflow is painful to wait for)
-* Doesn't handle # ~> -:5: stack level too deep (SystemStackError) gracefully
+* "1\\\n.even?" just fucks everything
+
+Todo
+====
+* Don't blow up on "a\\\n.b"
+* Record results with "a\n.b.\nc"
+* Record results with "a + \n b"
+* Refactor ExpressionList/SeeingIsBelieving to store lines in an array instead of as a string, so everyone doesn't magically need to know when to chomp
 
 License
 =======

data/features/examples.feature

@@ -42,6 +42,7 @@ Feature: Running the binary successfully
     # method invocation that occurs entirely on the next line
     [*1..10]
       .select(&:even?)
+      .map { |n| n * 2 }
 
     # mutliple levels of nesting
     class User
@@ -93,8 +94,9 @@ Feature: Running the binary successfully
     HERE
 
     # method invocation that occurs entirely on the next line
-    [*1..10]
-      .select(&:even?)  # => [2, 4, 6, 8, 10]
+    [*1..10]              # => [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+      .select(&:even?)    # => [2, 4, 6, 8, 10]
+      .map { |n| n * 2 }  # => [4, 8, 12, 16, 20]
 
     # mutliple levels of nesting
     class User
@@ -254,11 +256,3 @@ Feature: Running the binary successfully
     Then stderr is empty
     And the exit status is 0
     And stdout is "1 + 1  # => 2"
-
-  Scenario: Regression: A program containing a single comment
-    Given I have the stdin content "# single comment"
-    When I run "seeing_is_believing"
-    Then stderr is empty
-    And the exit status is 0
-    And stdout is "# single comment"
-

data/features/regression.feature

@@ -3,6 +3,13 @@ Feature:
   As the dev who wrote SeeingIsBelieving
   I want to have tests on those bugs that I found and could not have predicted
 
+  Scenario: A program containing a single comment
+    Given I have the stdin content "# single comment"
+    When I run "seeing_is_believing"
+    Then stderr is empty
+    And the exit status is 0
+    And stdout is "# single comment"
+
   Scenario: No method error just fucks everything
     Given the file "no_method_error.rb":
     """

data/lib/seeing_is_believing/evaluate_by_moving_files.rb

@@ -133,7 +133,7 @@ class SeeingIsBelieving
     end
 
     def notify_user_of_error
-      error_stream.puts "It blew up. Not too surprising given that seeing_is_believing is pretty rough around the edges, but still this shouldn't happen."
+      error_stream.puts "It blew up because SeeingIsBelieving isn't good enough >.<"
       error_stream.puts "Please log an issue at: https://github.com/JoshCheek/seeing_is_believing/issues"
       error_stream.puts
       error_stream.puts "Program: #{program.inspect}"

data/lib/seeing_is_believing/expression_list.rb

@@ -29,7 +29,13 @@ class SeeingIsBelieving
         pending_expression = generate
         debug { "GENERATED: #{pending_expression.expression.inspect}, ADDING IT TO #{inspected_expressions expressions}" }
         expressions << pending_expression
-        expression = reduce expressions, offset unless next_line_modifies_current?
+
+        expression = reduce expressions, offset
+
+        if next_line_modifies_current?
+          expressions << PendingExpression.new(expression.chomp, []) # chomp b/c on_complete callback prob adds newline, but we do to when joining
+        end
+
         offset += 1
       end until expressions.empty?
       return expression, offset

data/lib/seeing_is_believing/version.rb

@@ -1,3 +1,3 @@
 class SeeingIsBelieving
-  VERSION = '0.0.20'
+  VERSION = '0.0.21'
 end

data/spec/expression_list_spec.rb

@@ -181,19 +181,38 @@ describe SeeingIsBelieving::ExpressionList do
   example "example: method invocations on next line" do
     # example 1: consume the expression with lines after
     list = list_for ['a', '.b', ' .c', 'irrelevant'] do |*expressions, offset|
-      offset.should == 2
-      expressions.flatten.join('').should == 'a.b .c'
-      'a.b.c'
+      flat_expressions = expressions.flatten.join('')
+      case offset
+      when 0
+        flat_expressions.should == 'a'
+        'A'
+      when 1
+        flat_expressions.should == 'A.b'
+        'A.B'
+      when 2
+        flat_expressions.should == 'A.B .c'
+        'A.B.C'
+      else
+        raise "O.o"
+      end
     end
-    list.call.should == ['a.b.c', 3]
+    list.call.should == ['A.B.C', 3]
 
     # example 2: consume the expression with no lines after
     list = list_for ['a', '.b'] do |*expressions, offset|
-      offset.should == 1
-      expressions.flatten.join('').should == 'a.b'
-      'result'
+      flat_expressions = expressions.flatten.join('')
+      case offset
+      when 0
+        flat_expressions.should == 'a'
+        'A'
+      when 1
+        flat_expressions.should == 'A.b'
+        'A.B'
+      else
+        raise "O.o"
+      end
     end
-    list.call.should == ['result', 2]
+    list.call.should == ['A.B', 2]
   end
 
   example "example: smoke test debug option" do

data/spec/seeing_is_believing_spec.rb

@@ -269,8 +269,8 @@ describe SeeingIsBelieving do
   end
 
   it 'can deal with methods that are invoked entirely on the next line' do
-    values_for("1\n.even?").should == [[], ['false']]
-    values_for("1\n.even?\n__END__").should == [[], ['false']]
+    values_for("1\n.even?").should == [['1'], ['false']]
+    values_for("1\n.even?\n__END__").should == [['1'], ['false']]
   end
 
   it 'does not record leading comments' do
@@ -284,4 +284,23 @@ describe SeeingIsBelieving do
     expect { invoke "sleep 0.2", timeout: 0.1 }.to raise_error Timeout::Error
   end
 
+  it 'can record the middle of a chain of calls', t:true do
+    values_for("[*1..5]
+                  .select(&:even?)
+                  .map { |n| n * 3 }").should == [['[1, 2, 3, 4, 5]'],
+                                                  ['[2, 4]'],
+                                                  ['[6, 12]']]
+    # values_for("[*1..5]
+    #               .select(&:even)
+    #               .map { |n| n * 2 }.
+    #               map  { |n| n / 2 }\
+    #               .map { |n| n * 3 }").should == [['[1, 2, 3, 4, 5]'],
+    #                                               ['[2, 4]'],
+    #                                               ['[4, 8]'],
+    #                                               ['[2, 4]'],
+    #                                               ['[6, 12]']]
+    # values_for("1 +\n2").should == [['1'], ['3']]
+    # values_for("1\\\n+ 2").should == [['1'], ['3']]
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: seeing_is_believing
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Josh Cheek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-26 00:00:00.000000000 Z
+date: 2013-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake