seedbank 0.4.0 → 0.5.0

data/seedbank.gemspec

@@ -1,59 +1,36 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "seedbank/version"
-
-Gem::Specification.new do |s|
-  s.name = %q{seedbank}
-  s.version = Seedbank::VERSION
-  s.date = `git log -1 --format="%cd" --date=short lib/seedbank/version.rb`
-
-  s.required_rubygems_version = Gem::Requirement.new(">=1.2.0") if s.respond_to?(:required_rubygems_version=)
-  s.rubygems_version = %q{1.3.5}
-  s.license = "MIT"
-
-  s.authors = ["James McCarthy"]
-  s.email = %q{james2mccarthy@gmail.com}
-  s.homepage = %q{http://github.com/james2m/seedbank}
-  s.summary = %q{
-    Extends Rails seeds to split out complex seeds into their own file
-    and have different seeds for each environment.
-  }
-  s.description = %q{
-    Extends Rails seeds to split out complex seeds into multiple
-    files and lets each environment have it's own seeds.
-  }
-  s.license = "MIT"
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
-
-  s.rdoc_options = ["--charset=UTF-8"]
-  s.extra_rdoc_files = [
-    "MIT-LICENSE",
-    "README.md"
-  ]
-
-  s.add_development_dependency "minitest", "~> 5.0"
-  s.add_development_dependency "rails", "~> 3.2"
-
-  s.post_install_message = %q{
-  ================================================================================
-
-  Rails 2.x
-  ---------
-  If you are using Seedbank with Rails 2.x you will need to place the following at
-  the end of your Rakefile so Rubygems can load the seedbank tasks;
-
-    require 'seedbank'
-    Seedbank.load_tasks if defined?(Seedbank)
-
-  Rails 3.x and 4.x
-  ---------
-  Your work here is done!
-
-  ================================================================================
-  }
+# coding: utf-8
+# frozen_string_literal: true
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'seedbank/version'
+require 'English'
+
+Gem::Specification.new do |spec|
+  spec.name        = 'seedbank'
+  spec.version     = Seedbank::VERSION
+  spec.authors     = ['James McCarthy']
+  spec.email       = ['[james2mccarthy@gmail.com']
+  spec.required_ruby_version = '>= 2.1'
+  spec.summary     = 'Generate seeds data for your Ruby application.'
+  spec.description = %(
+    Adds simple rake commands for seeding your database. Simple dependencies let you organise your seeds.
+    If you are using Rails, Seedbank extends Rails seeds and lets you add seeds for each environment.
+  )
+  spec.date        = `git log -1 --format="%cd" --date=short lib/seedbank/version.rb`
+  spec.homepage    = 'http://github.com/james2m/seedbank'
+  spec.license     = 'MIT'
+
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.require_paths = ['lib']
+
+  spec.rdoc_options     = ['--charset=UTF-8']
+  spec.extra_rdoc_files = ['MIT-LICENSE', 'README.md']
+
+  spec.add_dependency 'rake', '>= 10.0'
+
+  spec.add_development_dependency 'bundler',  '~> 1.11'
+  spec.add_development_dependency 'rails',    '~> 4.2'
+  spec.add_development_dependency 'minitest', '~> 5.0'
 end
-

data/test/dummy/Rakefile

@@ -1,4 +1,5 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

data/test/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ApplicationController < ActionController::Base
   protect_from_forgery
 end

data/test/dummy/config/application.rb

@@ -1,29 +1,9 @@
+# frozen_string_literal: true
 require File.expand_path('../boot', __FILE__)
 
-# Pick the frameworks you want:
-require "active_record/railtie"
-
-Bundler.require  if defined?(Bundler)
-require 'seedbank'
+Bundler.require(:default, Rails.env)
 
 module Dummy
   class Application < Rails::Application
-    # Configure the default encoding used in templates for Ruby 1.9.
-    config.encoding = "utf-8"
-
-    # Configure sensitive parameters which will be filtered from the log file.
-    config.filter_parameters += [:password]
-
-    # Use SQL instead of Active Record's schema dumper when creating the database.
-    # This is necessary if your schema can't be completely dumped by the schema dumper,
-    # like if you have constraints or database-specific column types
-    # config.active_record.schema_format = :sql
-
-    # Enforce whitelist mode for mass assignment.
-    # This will create an empty whitelist of attributes available for mass-assignment for all models
-    # in your app. As such, your models will need to explicitly whitelist or blacklist accessible
-    # parameters by using an attr_accessible or attr_protected declaration.
-    config.active_record.whitelist_attributes = true
   end
 end
-

data/test/dummy/config/boot.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rubygems'
 gemfile = File.expand_path('../../../../Gemfile', __FILE__)
 
@@ -7,4 +8,4 @@ if File.exist?(gemfile)
   Bundler.setup
 end
 
-$:.unshift File.expand_path('../../../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)

data/test/dummy/config/environment.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Load the rails application
 require File.expand_path('../application', __FILE__)
 

data/test/dummy/config/environments/development.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
@@ -5,12 +6,13 @@ Dummy::Application.configure do
   # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
+  config.eager_load = false
 
   # Log error messages when you accidentally call methods on nil.
   config.whiny_nils = true
 
   # Show full error reports and disable caching
-  config.consider_all_requests_local       = true
+  config.consider_all_requests_local = true
   config.action_controller.perform_caching = false
 
   # Print deprecation notices to the Rails logger
@@ -19,16 +21,10 @@ Dummy::Application.configure do
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   config.active_record.auto_explain_threshold_in_seconds = 0.5
 
   # Do not compress assets
   config.assets.compress = false
-
-  # Expands the lines which load the assets
-  config.assets.debug = true
 end

data/test/dummy/config/environments/test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
@@ -6,26 +7,20 @@ Dummy::Application.configure do
   # your test database is "scratch space" for the test suite and is wiped
   # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
-
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  config.eager_load = false
 
   # Log error messages when you accidentally call methods on nil
   config.whiny_nils = true
 
   # Show full error reports and disable caching
-  config.consider_all_requests_local       = true
+  config.consider_all_requests_local = true
   config.action_controller.perform_caching = false
 
   # Raise exceptions instead of rendering exception templates
   config.action_dispatch.show_exceptions = false
 
   # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
-
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
+  config.action_controller.allow_forgery_protection = false
 
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr

data/test/dummy/config/initializers/secret_token.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Your secret key for verifying the integrity of signed cookies.

data/test/dummy/config/initializers/session_store.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
-Dummy::Application.config.session_store :cookie_store, :key => '_dummy_session'
+Dummy::Application.config.session_store :cookie_store, key: '_dummy_session'
 
 # Use the database for sessions instead of the cookie-based default,
 # which shouldn't be used to store highly confidential information

data/test/dummy/config/initializers/wrap_parameters.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 #
 # This file contains settings for ActionController::ParamsWrapper which
@@ -5,7 +6,7 @@
 
 # Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
 ActiveSupport.on_load(:action_controller) do
-  wrap_parameters :format => [:json]
+  wrap_parameters format: [:json]
 end
 
 # Disable root element in JSON by default.

data/test/dummy/config/routes.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 Dummy::Application.routes.draw do
 end

data/test/dummy/config.ru

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Dummy::Application

data/test/dummy/db/seeds/circular1.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :circular2 do
   FakeModel.seed('circular1')
-end
+end

data/test/dummy/db/seeds/circular2.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :circular1 do
   FakeModel.seed('circular2')
-end
+end

data/test/dummy/db/seeds/dependency.seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('dependency')

data/test/dummy/db/seeds/dependency2.seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('dependency2')

data/test/dummy/db/seeds/dependent.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :dependency do
   FakeModel.seed('dependent')
-end
+end

data/test/dummy/db/seeds/dependent_on_nested.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :dependent, :dependency2 do
   FakeModel.seed('dependent on nested')
-end
+end

data/test/dummy/db/seeds/dependent_on_several.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :dependency, :dependency2 do
   FakeModel.seed('dependent on several')
-end
+end

data/test/dummy/db/seeds/development/users.seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('development:users')

data/test/dummy/db/seeds/no_block.seeds.rb

@@ -1 +1,2 @@
-after :dependency
+# frozen_string_literal: true
+after :dependency

data/test/dummy/db/seeds/reference_memos.seeds.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 after('with_block_memo') do
   block_let
   inline_let
   inline_method
-end
+end

data/test/dummy/db/seeds/with_block_memo.seeds.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 after('with_inline_memo') do
   FakeModel.seed 'with_block_memo'
   let(:block_let) { FakeModel.calling_let 'BLOCK_LET' }
   let!(:block_let!) { FakeModel.calling_let! 'BLOCK_LET!' }
-end
+end

data/test/dummy/db/seeds/with_inline_memo.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 def inline_method
   FakeModel.calling_method 'inline_method'
 end

data/test/dummy/db/seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('db/seeds.rb')

data/test/dummy/script/rails

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 # This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
 
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
-require File.expand_path('../../config/boot',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
+require File.expand_path('../../config/boot', __FILE__)
 require 'rails/commands'

data/test/lib/seedbank/dsl_test.rb

@@ -1,135 +1,119 @@
+# frozen_string_literal: true
 require 'test_helper'
 
-describe Seedbank::DSL do
-
-  describe "scope_from_seed_file" do
-
-    it "is added to the namesapce" do
-      ns = Rake.application.in_namespace(:seedy) { self }
-
-      ns.must_respond_to :scope_from_seed_file
-    end
+using Seedbank::DSL
 
-    describe "in an environment directory" do
+describe Seedbank::DSL do
+  # TODO: This is private so should really be tested indirectly.
+  describe 'scope_from_seed_file' do
+    subject { scope_from_seed_file(seed_file) }
 
+    describe 'in an environment directory' do
       let(:seed_file) { File.expand_path('development/users.seeds.rb', Seedbank.seeds_root) }
-      let(:seed_namespace) { %w(development) }
+      let(:seed_namespace) { %w[development] }
 
-      subject { Seedbank::DSL.scope_from_seed_file seed_file }
-
-      it "returns the enviroment scope" do
+      it 'returns the enviroment scope' do
         subject.must_equal seed_namespace
       end
     end
 
-    describe "in a nested directory" do
-
+    describe 'in a nested directory' do
       let(:seed_file) { File.expand_path('development/shared/accounts.seeds.rb', Seedbank.seeds_root) }
-      let(:seed_namespace) { %w(development shared) }
+      let(:seed_namespace) { %w[development shared] }
 
-      subject { Seedbank::DSL.scope_from_seed_file seed_file }
-
-      it "returns the nested scope" do
+      it 'returns the nested scope' do
         subject.must_equal seed_namespace
       end
     end
 
-    describe "in seeds root" do
-
+    describe 'in seeds root' do
       let(:seed_file) { File.expand_path('no_block.seeds.rb', Seedbank.seeds_root) }
 
-      subject { Seedbank::DSL.scope_from_seed_file seed_file }
-
-      it "returns an array" do
+      it 'returns an array' do
         subject.must_be_instance_of Array
       end
 
-      it "must be empty" do
+      it 'must be empty' do
         subject.must_be_empty
       end
     end
   end
 
-  describe "seeds_root" do
-
+  describe 'seeds_root' do
     let(:seeds_root) { '/my/seeds/directory' }
 
-    subject { Seedbank::DSL.send(:seeds_root) }
+    subject { Seedbank::DSL.seeds_root }
 
-    it "returns a Pathname" do
+    it 'returns a Pathname' do
       Seedbank.stub(:seeds_root, seeds_root) do
-
         subject.must_equal Pathname.new(seeds_root)
-
       end
     end
-
   end
 
-  describe "glob_seed_files_matching" do
-
-    describe "with no namespace" do
-
+  describe 'glob_seed_files_matching' do
+    describe 'with no namespace' do
       let(:pattern) { '*.seeds.rb' }
 
-      it "returns all the files matching the pattern in seeds_root" do
+      it 'returns all the files matching the pattern in seeds_root' do
         expected_files = Dir.glob(File.join(Seedbank.seeds_root, pattern))
 
         Seedbank::DSL.glob_seed_files_matching(pattern).must_equal expected_files
       end
-
     end
 
-    describe "with a namespace" do
-
+    describe 'with a namespace' do
       let(:pattern) { '*.seeds.rb' }
       let(:namespace) { 'development' }
 
-      it "returns all the files matching the pattern in seeds_root" do
+      it 'returns all the files matching the pattern in seeds_root' do
         expected_files = Dir.glob(File.join(Seedbank.seeds_root, namespace, pattern))
 
         Seedbank::DSL.glob_seed_files_matching(namespace, pattern).must_equal expected_files
       end
-
     end
-
   end
 
-  describe "define_seed_task" do
+  describe 'define_seed_task' do
+    subject { Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies) }
 
     let(:task_name) { 'scoped:my_seed' }
-    let(:dependencies) { ['environment'] }
+    let(:dependencies) { ['scoped:another_seed'] }
     let(:seed_file) { File.expand_path('development/users.seeds.rb', Seedbank.seeds_root) }
 
-    it "returns a fully qualified task name" do
-      returned_name = Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    def define_prerequisite_task
+      Rake::Task.define_task('scoped:another_seed')
+    end
 
-      returned_name.must_equal task_name
+    before do
+      define_prerequisite_task
     end
 
-    it "creates a Rake Task" do
-      Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    it 'returns a fully qualified task name' do
+      subject.must_equal task_name
+    end
 
+    it 'creates a Rake Task' do
+      subject
       Rake::Task[task_name].wont_be_nil
     end
 
-    it "sets Rake Task description" do
-      Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    it 'sets Rake Task description' do
+      subject
+      relative_file = Pathname.new(seed_file).relative_path_from(Rails.root)
 
-      Rake::Task[task_name].comment.must_equal "Load the seed data from #{seed_file}"
+      Rake::Task[task_name].comment.must_equal "Load the seed data from #{relative_file}"
     end
 
-    it "sets Rake Task action to the seed_file contents" do
-      Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
-
+    it 'sets Rake Task action to the seed_file contents' do
+      subject
       FakeModel.expect :seed, true, ['development:users']
-
       Rake::Task[task_name].invoke
     end
 
-    describe "when db:abort_if_pending_migrations exists" do
-      it "sets Rake Task dependencies" do
-        Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    describe 'when db:abort_if_pending_migrations exists' do
+      it 'sets Rake Task dependencies' do
+        subject
         expected_dependencies = dependencies.map { |dependency| Rake::Task[dependency] }
         expected_dependencies << Rake::Task['db:abort_if_pending_migrations']
 
@@ -137,39 +121,39 @@ describe Seedbank::DSL do
       end
     end
 
-    describe "when db:abort_if_pending_migrations does not exist" do
-      it "sets Rake Task dependencies" do
+    describe 'when db:abort_if_pending_migrations does not exist' do
+      it 'adds environment dependency' do
         Rake.application.clear
-        Rake::Task.define_task 'environment'
+        define_prerequisite_task
 
-        Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+        expected_dependencies = dependencies.map { |dependency| Rake::Task[dependency] }
+        expected_dependencies << Rake::Task.define_task('environment')
+        subject
 
-        Rake::Task[task_name].prerequisite_tasks.must_equal dependencies.map { |dependency| Rake::Task[dependency] }
+        Rake::Task[task_name].prerequisite_tasks.must_equal expected_dependencies
       end
     end
   end
 
-  describe "override_seed_task" do
-
-    describe "when no task exists to override" do
-
+  describe 'override_seed_task' do
+    describe 'when no task exists to override' do
       let(:task_name) { 'my_task' }
-      let(:dependencies) { ['seedy:users'] }
+      let(:dependencies) { ['db:abort_if_pending_migrations'] }
 
-      it "creates a new task" do
+      it 'creates a new task' do
         Seedbank::DSL.override_seed_task(task_name => dependencies)
 
         Rake::Task[task_name].wont_be_nil
       end
 
-      it "applies the dependencies" do
+      it 'applies the dependencies' do
         expected_dependencies = dependencies.map { |dependency| Rake::Task[dependency] }
         Seedbank::DSL.override_seed_task(task_name => dependencies)
 
         Rake::Task[task_name].prerequisite_tasks.must_equal expected_dependencies
       end
 
-      it "applies the description" do
+      it 'applies the description' do
         description = 'Expected Description'
         Rake.application.last_description = description
 
@@ -178,6 +162,5 @@ describe Seedbank::DSL do
         Rake::Task[task_name].full_comment.must_equal description
       end
     end
-
   end
 end