seedbank 0.4.0 → 0.5.0.pre

data/test/dummy/db/seeds/dependency.seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('dependency')

data/test/dummy/db/seeds/dependency2.seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('dependency2')

data/test/dummy/db/seeds/dependent.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :dependency do
   FakeModel.seed('dependent')
-end
+end

data/test/dummy/db/seeds/dependent_on_nested.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :dependent, :dependency2 do
   FakeModel.seed('dependent on nested')
-end
+end

data/test/dummy/db/seeds/dependent_on_several.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 after :dependency, :dependency2 do
   FakeModel.seed('dependent on several')
-end
+end

data/test/dummy/db/seeds/development/users.seeds.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 FakeModel.seed('development:users')

data/test/dummy/db/seeds/no_block.seeds.rb

@@ -1 +1,2 @@
-after :dependency
+# frozen_string_literal: true
+after :dependency

data/test/dummy/db/seeds/reference_memos.seeds.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 after('with_block_memo') do
   block_let
   inline_let
   inline_method
-end
+end

data/test/dummy/db/seeds/with_block_memo.seeds.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 after('with_inline_memo') do
   FakeModel.seed 'with_block_memo'
   let(:block_let) { FakeModel.calling_let 'BLOCK_LET' }
   let!(:block_let!) { FakeModel.calling_let! 'BLOCK_LET!' }
-end
+end

data/test/dummy/db/seeds/with_inline_memo.seeds.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 def inline_method
   FakeModel.calling_method 'inline_method'
 end

data/test/dummy/script/rails

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 # This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
 
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
-require File.expand_path('../../config/boot',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
+require File.expand_path('../../config/boot', __FILE__)
 require 'rails/commands'

data/test/lib/seedbank/dsl_test.rb

@@ -1,135 +1,119 @@
+# frozen_string_literal: true
 require 'test_helper'
 
-describe Seedbank::DSL do
-
-  describe "scope_from_seed_file" do
-
-    it "is added to the namesapce" do
-      ns = Rake.application.in_namespace(:seedy) { self }
-
-      ns.must_respond_to :scope_from_seed_file
-    end
+using Seedbank::DSL
 
-    describe "in an environment directory" do
+describe Seedbank::DSL do
+  # TODO: This is private so should really be tested indirectly.
+  describe 'scope_from_seed_file' do
+    subject { scope_from_seed_file(seed_file) }
 
+    describe 'in an environment directory' do
       let(:seed_file) { File.expand_path('development/users.seeds.rb', Seedbank.seeds_root) }
       let(:seed_namespace) { %w(development) }
 
-      subject { Seedbank::DSL.scope_from_seed_file seed_file }
-
-      it "returns the enviroment scope" do
+      it 'returns the enviroment scope' do
         subject.must_equal seed_namespace
       end
     end
 
-    describe "in a nested directory" do
-
+    describe 'in a nested directory' do
       let(:seed_file) { File.expand_path('development/shared/accounts.seeds.rb', Seedbank.seeds_root) }
       let(:seed_namespace) { %w(development shared) }
 
-      subject { Seedbank::DSL.scope_from_seed_file seed_file }
-
-      it "returns the nested scope" do
+      it 'returns the nested scope' do
         subject.must_equal seed_namespace
       end
     end
 
-    describe "in seeds root" do
-
+    describe 'in seeds root' do
       let(:seed_file) { File.expand_path('no_block.seeds.rb', Seedbank.seeds_root) }
 
-      subject { Seedbank::DSL.scope_from_seed_file seed_file }
-
-      it "returns an array" do
+      it 'returns an array' do
         subject.must_be_instance_of Array
       end
 
-      it "must be empty" do
+      it 'must be empty' do
         subject.must_be_empty
       end
     end
   end
 
-  describe "seeds_root" do
-
+  describe 'seeds_root' do
     let(:seeds_root) { '/my/seeds/directory' }
 
-    subject { Seedbank::DSL.send(:seeds_root) }
+    subject { Seedbank::DSL.seeds_root }
 
-    it "returns a Pathname" do
+    it 'returns a Pathname' do
       Seedbank.stub(:seeds_root, seeds_root) do
-
         subject.must_equal Pathname.new(seeds_root)
-
       end
     end
-
   end
 
-  describe "glob_seed_files_matching" do
-
-    describe "with no namespace" do
-
+  describe 'glob_seed_files_matching' do
+    describe 'with no namespace' do
       let(:pattern) { '*.seeds.rb' }
 
-      it "returns all the files matching the pattern in seeds_root" do
+      it 'returns all the files matching the pattern in seeds_root' do
         expected_files = Dir.glob(File.join(Seedbank.seeds_root, pattern))
 
         Seedbank::DSL.glob_seed_files_matching(pattern).must_equal expected_files
       end
-
     end
 
-    describe "with a namespace" do
-
+    describe 'with a namespace' do
       let(:pattern) { '*.seeds.rb' }
       let(:namespace) { 'development' }
 
-      it "returns all the files matching the pattern in seeds_root" do
+      it 'returns all the files matching the pattern in seeds_root' do
         expected_files = Dir.glob(File.join(Seedbank.seeds_root, namespace, pattern))
 
         Seedbank::DSL.glob_seed_files_matching(namespace, pattern).must_equal expected_files
       end
-
     end
-
   end
 
-  describe "define_seed_task" do
+  describe 'define_seed_task' do
+    subject { Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies) }
 
     let(:task_name) { 'scoped:my_seed' }
-    let(:dependencies) { ['environment'] }
+    let(:dependencies) { ['scoped:another_seed'] }
     let(:seed_file) { File.expand_path('development/users.seeds.rb', Seedbank.seeds_root) }
 
-    it "returns a fully qualified task name" do
-      returned_name = Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    def define_prerequisite_task
+      Rake::Task.define_task('scoped:another_seed')
+    end
 
-      returned_name.must_equal task_name
+    before do
+      define_prerequisite_task
     end
 
-    it "creates a Rake Task" do
-      Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    it 'returns a fully qualified task name' do
+      subject.must_equal task_name
+    end
 
+    it 'creates a Rake Task' do
+      subject
       Rake::Task[task_name].wont_be_nil
     end
 
-    it "sets Rake Task description" do
-      Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    it 'sets Rake Task description' do
+      subject
+      relative_file = Pathname.new(seed_file).relative_path_from(Rails.root)
 
-      Rake::Task[task_name].comment.must_equal "Load the seed data from #{seed_file}"
+      Rake::Task[task_name].comment.must_equal "Load the seed data from #{relative_file}"
     end
 
-    it "sets Rake Task action to the seed_file contents" do
-      Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
-
+    it 'sets Rake Task action to the seed_file contents' do
+      subject
       FakeModel.expect :seed, true, ['development:users']
-
       Rake::Task[task_name].invoke
     end
 
-    describe "when db:abort_if_pending_migrations exists" do
-      it "sets Rake Task dependencies" do
-        Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+    describe 'when db:abort_if_pending_migrations exists' do
+      it 'sets Rake Task dependencies' do
+        subject
         expected_dependencies = dependencies.map { |dependency| Rake::Task[dependency] }
         expected_dependencies << Rake::Task['db:abort_if_pending_migrations']
 
@@ -137,39 +121,39 @@ describe Seedbank::DSL do
       end
     end
 
-    describe "when db:abort_if_pending_migrations does not exist" do
-      it "sets Rake Task dependencies" do
+    describe 'when db:abort_if_pending_migrations does not exist' do
+      it 'adds environment dependency' do
         Rake.application.clear
-        Rake::Task.define_task 'environment'
+        define_prerequisite_task
 
-        Seedbank::DSL.define_seed_task(seed_file, task_name => dependencies)
+        expected_dependencies = dependencies.map { |dependency| Rake::Task[dependency] }
+        expected_dependencies << Rake::Task.define_task('environment')
+        subject
 
-        Rake::Task[task_name].prerequisite_tasks.must_equal dependencies.map { |dependency| Rake::Task[dependency] }
+        Rake::Task[task_name].prerequisite_tasks.must_equal expected_dependencies
       end
     end
   end
 
-  describe "override_seed_task" do
-
-    describe "when no task exists to override" do
-
+  describe 'override_seed_task' do
+    describe 'when no task exists to override' do
       let(:task_name) { 'my_task' }
-      let(:dependencies) { ['seedy:users'] }
+      let(:dependencies) { ['db:abort_if_pending_migrations'] }
 
-      it "creates a new task" do
+      it 'creates a new task' do
         Seedbank::DSL.override_seed_task(task_name => dependencies)
 
         Rake::Task[task_name].wont_be_nil
       end
 
-      it "applies the dependencies" do
+      it 'applies the dependencies' do
         expected_dependencies = dependencies.map { |dependency| Rake::Task[dependency] }
         Seedbank::DSL.override_seed_task(task_name => dependencies)
 
         Rake::Task[task_name].prerequisite_tasks.must_equal expected_dependencies
       end
 
-      it "applies the description" do
+      it 'applies the description' do
         description = 'Expected Description'
         Rake.application.last_description = description
 
@@ -178,6 +162,5 @@ describe Seedbank::DSL do
         Rake::Task[task_name].full_comment.must_equal description
       end
     end
-
   end
 end

data/test/lib/seedbank/runner_test.rb

@@ -1,12 +1,11 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 describe Seedbank::Runner do
-
-  describe "seeds with dependency" do
-
+  describe 'seeds with dependency' do
     subject { Rake::Task['db:seed:dependent'] }
 
-    it "runs the dependencies in order" do
+    it 'runs the dependencies in order' do
       FakeModel.expect :seed, true, ['dependency']
       FakeModel.expect :seed, true, ['dependent']
 
@@ -15,7 +14,7 @@ describe Seedbank::Runner do
       FakeModel.verify
     end
 
-    it "executes the body of the dependencies exactly once per invocation" do
+    it 'executes the body of the dependencies exactly once per invocation' do
       FakeModel.expect :seed, true, ['dependency']
       FakeModel.expect :seed, true, ['dependent']
       FakeModel.expect :seed, true, ['dependency']
@@ -24,7 +23,7 @@ describe Seedbank::Runner do
       subject.invoke
 
       # Allow all tasks to be re-executed, including dependencies
-      Rake.application.tasks.each { |t| t.reenable }
+      Rake.application.tasks.each(&:reenable)
 
       subject.invoke
 
@@ -32,11 +31,10 @@ describe Seedbank::Runner do
     end
   end
 
-  describe "seeds with multiple dependencies" do
-
+  describe 'seeds with multiple dependencies' do
     subject { Rake::Task['db:seed:dependent_on_several'] }
 
-    it "runs the dependencies in order" do
+    it 'runs the dependencies in order' do
       FakeModel.expect :seed, true, ['dependency']
       FakeModel.expect :seed, true, ['dependency2']
       FakeModel.expect :seed, true, ['dependent on several']
@@ -47,11 +45,10 @@ describe Seedbank::Runner do
     end
   end
 
-  describe "seeds with nested dependencies" do
-
+  describe 'seeds with nested dependencies' do
     subject { Rake::Task['db:seed:dependent_on_nested'] }
 
-    it "runs all dependencies in order" do
+    it 'runs all dependencies in order' do
       FakeModel.expect :seed, true, ['dependency']
       FakeModel.expect :seed, true, ['dependent']
       FakeModel.expect :seed, true, ['dependency2']
@@ -61,14 +58,12 @@ describe Seedbank::Runner do
 
       FakeModel.verify
     end
-
   end
 
-  describe "after with no block given" do
-
+  describe 'after with no block given' do
     subject { Rake::Task['db:seed:no_block'] }
 
-    it "runs the dependencies" do
+    it 'runs the dependencies' do
       FakeModel.expect :seed, true, ['dependency']
 
       subject.invoke
@@ -77,20 +72,19 @@ describe Seedbank::Runner do
     end
   end
 
-  describe "let" do
-
-    describe "evaluates dependencies in order" do
-
+  describe 'let' do
+    describe 'evaluates dependencies in order' do
       subject { Rake::Task['db:seed:reference_memos'] }
 
-      it "runs the dependencies in order" do
+      it 'runs the dependencies in order' do
         FakeModel.expect :seed, true, ['with_inline_memo']
         FakeModel.expect :seed, true, ['with_block_memo']
         FakeModel.expect :calling_let, true, ['BLOCK_LET']
         FakeModel.expect :calling_let, true, ['INLINE_LET']
 
-        def FakeModel.calling_let!(*args); end
-        def FakeModel.calling_method(*args); end
+        def FakeModel.calling_let!(*_args); end
+
+        def FakeModel.calling_method(*_args); end
 
         subject.invoke
 
@@ -98,13 +92,12 @@ describe Seedbank::Runner do
       end
     end
 
-    describe "a previously defined method" do
-
+    describe 'a previously defined method' do
       let(:runner) { Seedbank::Runner.new }
 
       before { runner.let(:existing) {} }
 
-      %w(__eigenclass existing let let evaluate after).each do |name|
+      %w(existing let! let evaluate after extend).each do |name|
         it 'raises ArgumentError' do
           assert_raises(ArgumentError, Regexp.new(name)) do
             runner.let(name)
@@ -112,43 +105,44 @@ describe Seedbank::Runner do
         end
       end
     end
-
   end
 
-  describe "let!" do
-
-    describe "evaluates dependencies in order" do
-
+  # TODO: These don't really test in order. Maybe swap in rspec_mocks
+  describe 'let!' do
+    describe 'evaluates dependencies in order' do
       subject { Rake::Task['db:seed:reference_memos'] }
 
-      it "runs the dependencies in order" do
+      it 'runs the dependencies in order' do
+        FakeModel.expect :seed, true, ['with_inline_memo']
         FakeModel.expect :calling_let!, true, ['INLINE_LET!']
+        FakeModel.expect :seed, true, ['with_block_memo']
         FakeModel.expect :calling_let!, true, ['BLOCK_LET!']
-
-        def FakeModel.seed(*args); end
-        def FakeModel.calling_let(*args); end
-        def FakeModel.calling_method(*args); end
+        FakeModel.expect :calling_let, true, ['BLOCK_LET']
+        FakeModel.expect :calling_let, true, ['INLINE_LET']
+        FakeModel.expect :calling_method, true, ['inline_method']
 
         subject.invoke
 
         FakeModel.verify
       end
     end
-
   end
 
-  describe "defining an inline method" do
-
-    describe "evaluates dependencies in order" do
-
+  # TODO: This doesn't do anything more than the above except for
+  # isolating the inline method call. Would be better served by it's
+  # own seeds in isolation.
+  describe 'defining an inline method' do
+    describe 'evaluates dependencies in order' do
       subject { Rake::Task['db:seed:reference_memos'] }
 
-      it "runs the dependencies in order" do
+      it 'runs the dependencies in order' do
         FakeModel.expect :calling_method, true, ['inline_method']
 
-        def FakeModel.seed(*args); end
-        def FakeModel.calling_let(*args); end
-        def FakeModel.calling_let!(*args); end
+        def FakeModel.seed(*_args); end
+
+        def FakeModel.calling_let(*_args); end
+
+        def FakeModel.calling_let!(*_args); end
 
         subject.invoke
 
@@ -156,5 +150,4 @@ describe Seedbank::Runner do
       end
     end
   end
-
 end