seed_builder 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ecee50238e268d48a12368a6120f6e5aacdce21672621a19b6bbdf82215585e
-  data.tar.gz: '059a0424d354435ef544dc6627541d9ac64de3b25aad0191050a378dbdb81b27'
+  metadata.gz: d9c742827b3295c564267030107d2f26638923eedd268ee11b55dbbf845e245c
+  data.tar.gz: 0ee2ad8cdb1f2ccfcd1a5a912981d93bb7f2e742d9a33f78d358e5de2ff2c02a
 SHA512:
-  metadata.gz: 6d79169514a3b938ad45c8e57e68bb14f6de8e69cae56ac49cbc495fb64b314ea601d2798aebb42233b5b6f36d51d3b6666f9e7cec5746d69eb3a6d140089469
-  data.tar.gz: e9eb0af111a273efd24f7b883de27ff055ef8c19124475c4492fc7da553aa417135c06fab0506189afa48d327f6e6448b8fbbb00d166ae095479c88dee81d52c
+  metadata.gz: bbe89a5cc1a60c7eaf07399e07d12c18e5ea4caca20aceebd25f5e09967bd92ad23bfa75d2ae5582d7a6bb8a5fbf1581c7517556d9d603bbea4ab3983bfac175
+  data.tar.gz: 32f13630724be1890a49d30d005ff673363dc61971b41e609986034890848e72c5eaa55385f1e9e25e7d97decd09aae7ac0813a37bad84989470f5d206798890

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.1.0
+
+- Fix `seeds_path` to be relative to Rails root
+- Improve test coverage for generator
+
 # 1.0.1
 
 - Fix boolean config options to properly handle `nil` and `false` values

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    seed_builder (1.0.1)
+    seed_builder (1.1.0)
       activerecord (>= 6, < 8.1)
       rails (>= 6, < 8.1)
 

data/README.md

@@ -57,7 +57,7 @@ SeedBuilder.config.load_default_seeds = false
 Absolute path will be resolved by using `Rails.root`.
 
 ```ruby
-SeedBuilder.config.seeds_relative_path = "db/seeds"
+SeedBuilder.config.seeds_path = "db/seeds"
 ```
 
 ### Turn off test script generation

data/lib/generators/templates/seed.rb.tt

@@ -6,7 +6,7 @@ end
 <%- if SeedBuilder.config.generate_spec? %>
 
 # TESTING:
-# - bin/rspec <%= SeedBuilder.config.seeds_relative_path %>/<%= migration_number %>_<%= migration_file_name %>.rb
+# - bin/rspec <%= SeedBuilder.config.seeds_path %>/<%= migration_number %>_<%= migration_file_name %>.rb
 if Rails.env.test? && Object.const_defined?(:RSpec)
   require "rails_helper"
 

data/lib/seed_builder/config.rb

@@ -7,16 +7,16 @@ module SeedBuilder
 
     attr_writer :seeds_path
     def seeds_path
-      @seeds_path ||= Rails.root.join(seeds_relative_path)
+      @seeds_path ||= "db/seeds"
     end
 
-    def seeds_path_glob
-      "#{seeds_path}/*.rb"
+    attr_writer :seeds_full_path
+    def seeds_full_path
+      @seeds_full_path ||= Rails.root.join(seeds_path)
     end
 
-    attr_writer :seeds_relative_path
-    def seeds_relative_path
-      @seeds_relative_path ||= "db/seeds"
+    def seeds_path_glob
+      "#{seeds_full_path}/*.rb"
     end
 
     attr_writer :load_default_seeds

data/lib/seed_builder.rb

@@ -2,7 +2,7 @@ require "seed_builder/config"
 require "seed_builder/loader"
 
 module SeedBuilder
-  VERSION = "1.0.1".freeze
+  VERSION = "1.1.0".freeze
 
   module_function
 

data/spec/generator_spec.rb

@@ -7,12 +7,18 @@ describe SeedGenerator, type: :generator do
 
   subject(:generator) { described_class.start params }
   let(:destination_root) { File.expand_path("../../tmp/rspec", __FILE__) }
+  let(:seeds_path) { rails_root.join("db/seeds") }
 
-  let(:params) { ["create_users"] }
+  let(:seed_name) { "create_users" }
+  let(:params) { [seed_name] }
+
+  let(:created_files) { Dir["#{seeds_path}/*_#{seed_name}.rb"] }
+  let(:file_contents) { File.readlines(created_files.first).map(&:strip).reject(&:blank?) }
 
   before do
     mkdir_p destination_root
 
+    allow(SeedBuilder.config).to receive(:seeds_path).and_return(seeds_path)
     allow(Rails).to receive(:root).and_return(rails_root(destination_root))
   end
 
@@ -22,7 +28,23 @@ describe SeedGenerator, type: :generator do
 
   it "creates a migration file" do
     generator
-    seed_files = Dir[rails_root.join("db/seeds/*_create_users.rb")]
-    expect(seed_files).not_to be_empty
+
+    expect(created_files).not_to be_empty
+    expect(file_contents).to include("class CreateUsers")
+    expect(file_contents).not_to include("RSpec.describe CreateUsers")
+  end
+
+  context "when generate_spec is false" do
+    before do
+      allow(SeedBuilder.config).to receive(:generate_spec?).and_return(false)
+    end
+
+    it "does not create a spec file" do
+      generator
+
+      expect(created_files).not_to be_empty
+      expect(file_contents).to include("class CreateUsers")
+      expect(file_contents).not_to include("RSpec.describe CreateUsers")
+    end
   end
 end

data/spec/seed_builder/config_spec.rb

@@ -8,7 +8,7 @@ describe SeedBuilder::Config do
   end
 
   it "has default seeds path" do
-    expect(config.seeds_relative_path).to eq "db/seeds"
+    expect(config.seeds_path).to eq "db/seeds"
   end
 
   it "has default load_seeds" do
@@ -23,8 +23,8 @@ describe SeedBuilder::Config do
     expect(config.generate_spec?).to be true
   end
 
-  it "has default seeds_path" do
-    expect(config.seeds_path).to eq Rails.root.join("db/seeds")
+  it "has default seeds_full_path" do
+    expect(config.seeds_full_path).to eq Rails.root.join("db/seeds")
   end
 
   it "has default seeds_path_glob" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: seed_builder
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Andrei Makarov