security_identifiers 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 72c50ca8b151d2b24365161cf1349d638bfd71c5
-  data.tar.gz: 1f1f3a6c8607ffda761083b46bf934646409bf53
+  metadata.gz: 2966f074a72f9e3b0937e0d66ee7738f735da794
+  data.tar.gz: efdb4c760ec5945b8a5e2a90c2f046eeb4c4a898
 SHA512:
-  metadata.gz: 17e22d743cf8fb12c058820cfcea5dcb7aa16b484b848eef444ded844fe715b42b5cc75d35ac6964ec0e9241c80a8549dd191233fb8d7183293a14c4dac5337e
-  data.tar.gz: 6ad951a7bf8c9a5a500fbd01f693455a5403f037b3839e192d06d84d663d5d23a7194f4a331db2ab395ce8e45ee10fa181078cab577abaa272672427f8daaeaa
+  metadata.gz: 0e2c726c65b626c4cbb6f6d992b013a8c2280ee6ae3f7a30da5731951b56f0890684eef22f938d1e6b3218513c383108010cb81a8d3b826f2871198be3dbc2df
+  data.tar.gz: 0ec8c45c8a1a9665e4f3293e55e4125b81779b25e2f3e353b8c6d9f35e0d11272a609b2e8084990ff6a7a48db3034fe24f57a2d549cb49ed39361982fae8a122

data/README.md

@@ -3,8 +3,9 @@
 [![Build Status](https://travis-ci.org/invisiblelines/security_identifiers.png?branch=master)](https://travis-ci.org/invisiblelines/security_identifiers)
 [![Code Climate](https://codeclimate.com/github/invisiblelines/security_identifiers.png)](https://codeclimate.com/github/invisiblelines/security_identifiers)
 [![Dependency Status](https://gemnasium.com/invisiblelines/security_identifiers.png)](https://gemnasium.com/invisiblelines/security_identifiers)
+[![Gem Version](https://badge.fury.io/rb/security_identifiers.svg)](http://badge.fury.io/rb/security_identifiers)
 
-Security identifiers validation library for Ruby. 
+Security identifiers validation library for Ruby.
 
 Currently supports
 
@@ -42,11 +43,6 @@ or with an invalid identifier
 
     isin = SecurityIdentifiers::ISIN.new('S0378331005') # => raises SecurityIdentifiers::InvalidFormat
 
-To fix a missing check digit
-
-    isin = SecurityIdentifiers::ISIN.new('US037833100')
-    isin.fix! 
-
 Now you can validate
 
     isin.valid? # => true
@@ -62,13 +58,24 @@ CUSIPs and SEDOLs also support converting these identifiers to ISINs.
 
 Includes custom validators for use in ActiveModel/ActiveRecord
 
-    class MyModel < ActiveRecord::Base
-      include SecurityIdentifiers::Validators
-    
-      validates :isin, isin: true
-      validates :cusip, cusip: true
+    class Security
+      include ActiveModel::Validations
+      include SecurityIdentifiers::Validations
+
+      attr_accessor :cusip, :isin, :sedol
+
+      def initialize(options = {})
+        @cusip = options[:cusip]
+        @isin  = options[:isin]
+        @sedol = options[:sedol]
+      end
+
+      validates :cusip, cusip: true, allow_blank: true
+      validates :isin,  isin:  true, allow_blank: true
+      validates :sedol, sedol: true, allow_blank: true
     end
 
+
 ## Contributing
 
 1. Fork it

data/lib/security_identifiers/base.rb

@@ -15,10 +15,6 @@ module SecurityIdentifiers
       "#{@identifier}#{check_digit}"
     end
 
-    def fix!
-      @original_check_digit = check_digit
-    end
-
     private
 
       def digits
@@ -33,6 +29,10 @@ module SecurityIdentifiers
         @odd_values ||= digits.values_at(* digits.each_index.select { |i| i.odd? })
       end
 
+      def fix!
+        @original_check_digit = check_digit
+      end
+
   end
 
 end

data/lib/security_identifiers/cusip.rb

@@ -10,6 +10,8 @@ module SecurityIdentifiers
       raise InvalidFormat if match_data.nil?
 
       @identifier, @original_check_digit = match_data.captures
+
+      fix! if @original_check_digit.nil?
     end
 
     def check_digit

data/lib/security_identifiers/isin.rb

@@ -10,6 +10,8 @@ module SecurityIdentifiers
       raise InvalidFormat if match_data.nil?
 
       @identifier, @country_code, @nsin, @original_check_digit = match_data.captures
+
+      fix! if @original_check_digit.nil?
     end
 
     def check_digit

data/lib/security_identifiers/sedol.rb

@@ -10,6 +10,8 @@ module SecurityIdentifiers
       raise InvalidFormat if match_data.nil?
 
       @identifier, @original_check_digit = match_data.captures
+
+      fix! if @original_check_digit.nil?
     end
 
     def check_digit

data/lib/security_identifiers/version.rb

@@ -1,5 +1,5 @@
 module SecurityIdentifiers
 
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 
 end

data/spec/cusip_spec.rb

@@ -9,8 +9,8 @@ describe CUSIP do
   context 'Without a check digit' do
     let(:cusip) { CUSIP.new('83764912') }
 
-    it 'is invalid' do
-      expect(cusip).to_not be_valid
+    it 'calculates the check digit' do
+      expect(cusip.original_check_digit).to_not be_nil
     end
   end
 
@@ -70,12 +70,4 @@ describe CUSIP do
     end
   end
 
-  context '#fix!' do
-    let(:cusip) { CUSIP.new('125509BG') }
-
-    it 'calculates the check digit' do
-      expect { cusip.fix! }.to change(cusip, :original_check_digit).from(nil).to(3)
-    end
-  end
-
 end

data/spec/isin_spec.rb

@@ -13,8 +13,8 @@ describe ISIN do
   context 'Without a check digit' do
     let(:isin) { ISIN.new('US037833100') }
 
-    it 'is invalid' do
-      expect(isin).to_not be_valid
+    it 'calculates the check digit' do
+      expect(isin.original_check_digit).not_to be_nil
     end
   end
 
@@ -58,12 +58,4 @@ describe ISIN do
     end
   end
 
-  context '#fix!' do
-    let(:isin) { ISIN.new('AU0000XVGZA') }
-
-    it 'calculates the check digit' do
-      expect { isin.fix! }.to change(isin, :original_check_digit).from(nil).to(3)
-    end
-  end
-
 end

data/spec/sedol_spec.rb

@@ -9,8 +9,8 @@ describe SEDOL do
   context 'Without a check digit' do
     let(:sedol) { SEDOL.new('B0WNLY') }
 
-    it 'is invalid' do
-      expect(sedol).to_not be_valid
+    it 'calculates the check digit' do
+      expect(sedol.original_check_digit).to_not be_nil
     end
   end
 
@@ -50,12 +50,4 @@ describe SEDOL do
     end
   end
 
-  context '#fix!' do
-    let(:sedol) { SEDOL.new('B0WNLY') }
-
-    it 'calculates the check digit' do
-      expect { sedol.fix! }.to change(sedol, :original_check_digit).from(nil).to(7)
-    end
-  end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: security_identifiers
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Kieran Johnson