securities 0.1.0 → 0.1.1

data/README.md

@@ -1,7 +1,7 @@
 # Securities
 
 Financial information scraper gem. 
-Uses Yahoo Finance API.
+Uses Yahoo Finance API. Current functionality demo: http://strangemuseum.heroku.com
 
 [![Build Status](https://secure.travis-ci.org/Nedomas/securities.png)](http://travis-ci.org/Nedomas/securities)[![Build Status](https://gemnasium.com/Nedomas/securities.png)](https://gemnasium.com/Nedomas/securities)
 
@@ -74,6 +74,10 @@ Results are returned in a hash:
 
 ## To do:
 
+* Fix monthly+ and dividends+
+* Fix exception messages for friendlier displaying to end-user+ (and invalid symbol error=>"Illegal quoting in line 1.")+.
+* Rescue empty results error.+
+* Let it raise exception on one symbol, but continue on other and send the message.
 * Write specs.
 * Add quote info (P/E, P/S, etc.)
 * Add symbol from name lookup.

data/lib/securities/scraper.rb

@@ -37,12 +37,30 @@ module Securities
         end
 
         # Skip first line because it contains headers with Date,Open,High,Low,Close,Volume,Adj Close
-        csv = CSV.parse(get, :headers => true)
+        # Check for errors during CSV parsing.
+        begin
+          csv = CSV.parse(get, :headers => true)
+        rescue => error
+          # PROBABLY an invalid symbol specified or there was some other way the parser couldn't read a CSV.
+          # FIXME: Let it raise exception on one symbol, but continue on other and send the message.
+          raise ScraperException, "Invalid symbol '#{symbol}' specified."
+        end
 
         data = Array.new
-        csv.each_with_index {|row, index|
-          data[index] = {:date => row[0], :open => row[1], :high => row[2], :low => row[3], :close => row[4], :volume => row[5], :adj_close => row[6]}
-        }
+        csv.each_with_index do |row, index|
+          line = Hash.new
+          csv.headers.each_with_index do |header, i|
+            # Set headers as keys for data hash.
+            line[header.parameterize.underscore.to_sym] = row[i]
+            data[index] = line
+          end
+        end
+
+        # FIXME: Let it raise exception on one symbol, but continue on other and send the message.
+        if data.empty?
+          raise ScraperException, 'There were no results for these parameters.'
+        end
+
         @results[symbol] = data 
       end
       return @results

data/lib/securities/stock.rb

@@ -11,7 +11,7 @@ module Securities
 		attr_reader :symbols
 		# REGEX for YYYY-MM-DD
 		DATE_REGEX = /^[0-9]{4}\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])/
-		PERIODS_ARRAY = [:daily, :weekly, :montly, :dividends]
+		PERIODS_ARRAY = [:daily, :weekly, :monthly, :dividends]
 
 		# Error handling
 		class StockException < StandardError
@@ -93,7 +93,7 @@ module Securities
 			@symbols = parameters.reject(&:empty?)
 
 			unless !@symbols.empty?
-				raise StockException, 'You must specify stock symbols.'
+				raise StockException, 'You must specify at least one stock symbol.'
 			end
 
 			# FIXME: A kinda hacky way to check if parameters are a nested array (when accepting an array as a symbols argument).
@@ -101,7 +101,7 @@ module Securities
 			@symbols[0].is_a?(Array) ? @symbols = @symbols[0] : nil
 
 			unless @symbols.uniq.length == @symbols.length
-				raise StockException, 'Duplicate symbols given.'
+				raise StockException, 'Duplicate stock symbols given.'
 			end
 		end
 
@@ -111,30 +111,30 @@ module Securities
 			end
 
 			unless parameters.has_keys?(:start_date, :end_date)
-				raise StockException, 'You must specify :start_date and :end_date.'
+				raise StockException, 'You must specify start date and end date.'
 			end
  
 			unless DATE_REGEX.match(parameters[:start_date])
-				raise StockException, 'Invalid :start_date specified. Format YYYY-MM-DD.'
+				raise StockException, 'Invalid start date specified. Format YYYY-MM-DD.'
 			end
 
 			unless DATE_REGEX.match(parameters[:end_date])
-				raise StockException, 'Invalid :end_date specified. Format YYYY-MM-DD.'
+				raise StockException, 'Invalid end date specified. Format YYYY-MM-DD.'
 			end
 
 			unless parameters[:start_date].to_date < parameters[:end_date].to_date
-				raise StockException, ':end_date must be greater than the :start_date.'
+				raise StockException, 'End date must be greater than the start date.'
 			end
 
 			unless parameters[:start_date].to_date < Date.today
-				raise StockException, ':start_date must not be in the future.'
+				raise StockException, 'Start date must not be in the future.'
 			end
 
 			# Set to default :periods if key isn't specified.
 			parameters[:periods] = :daily if !parameters.has_key?(:periods)
 
 			unless PERIODS_ARRAY.include?(parameters[:periods])
-				raise StockException, 'Invalid :periods value specified.'
+				raise StockException, 'Invalid periods value specified.'
 			end
 		end
 

data/lib/securities/version.rb

@@ -1,3 +1,3 @@
 module Securities
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: securities
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-25 00:00:00.000000000 Z
+date: 2012-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -78,7 +78,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4396400797512649668
+      hash: -2122445770564870703
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -87,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4396400797512649668
+      hash: -2122445770564870703
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23