secupay_ruby 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74cce8c345746dc521f125a039949730aacfab03
-  data.tar.gz: d7799f2c75ca39b401e3d52350f6349728823b54
+  metadata.gz: bf8db51fd28c1ac636daeea2174d8bca246c0be0
+  data.tar.gz: 09d8166b9a8dce63d27f392a3e3e88072234bbfd
 SHA512:
-  metadata.gz: 7e689f7d252c9f5f4515b0f555bc24acd76844e87485841d61e98b59f62dc0531a9ea4da2282b30d1a5950826263974318471e5867d90ac77bafd0bca9b3a3fb
-  data.tar.gz: bae6f44fad6ca120da966681c59fa0dd85c2b33b02cda28d8fdc9e9c40480c36789c05c9a86af22d69da351e8d5c74f6c7885a42efbcdb9bd054e2bd31fbaef0
+  metadata.gz: 7e29133e6ea114fbd2088bf14b5053866a98f39cd2301df0995e8b7ce4cf754581ae4484d0643158c49a0e0ed75d11df9e678d6ba155322dfeaad783769ef5d4
+  data.tar.gz: 2058314c11690d6e9dff8d1f8b63e32e8f18f3434b9b862f5fca2a12e9267519f4f7f753a72bc558079ffef7aa676a280578b9cce9b7fbb2e106e531abdcc0ac

data/lib/secupay_ruby/payment.rb

@@ -54,7 +54,6 @@ module SecupayRuby
       @response = SecupayRuby::Requests::Init.post(api_key: api_key,
                                                    payment: self,
                                                    body: params)
-      raise_if_request_error
 
       extract_response_params(INIT_FIELDS)
     end
@@ -68,7 +67,6 @@ module SecupayRuby
       @response = SecupayRuby::Requests::Status.post(api_key: api_key,
                                                      payment: self,
                                                      body: params)
-      raise_if_request_error
 
       extract_response_params(STATUS_FIELDS)
     end
@@ -80,7 +78,6 @@ module SecupayRuby
 
       @response = SecupayRuby::Requests::Capture.post(api_key: api_key,
                                                       payment: self)
-      raise_if_request_error
     end
 
     def cancel
@@ -90,25 +87,18 @@ module SecupayRuby
 
       @response = SecupayRuby::Requests::Cancel.post(api_key: api_key,
                                                      payment: self)
-      raise_if_request_error
     end
 
     class << self
       def get_types(api_key: SecupayRuby::ApiKey::MasterKey.new)
         response = SecupayRuby::Requests::GetTypes.post(api_key: api_key)
 
-        raise RequestError, response.errors if response.http_status != "200" || response.status != "ok"
-
         response.data
       end
     end
 
     private
 
-    def raise_if_request_error
-      raise RequestError.new @response.errors if error?
-    end
-
     def raise_if_not_initiated
       raise PaymentStatusError.new "Not initiated" unless hash?
     end
@@ -123,10 +113,6 @@ module SecupayRuby
       raise PaymentStatusError.new "Payment already initiated" if hash?
     end
 
-    def error?
-      @response.http_status != "200" || @response.status != "ok"
-    end
-
     def extract_response_params(fields)
       fields.each do |field_name, param_name|
         instance_variable_set("@#{field_name}", @response.data[param_name])

data/lib/secupay_ruby/requests/base.rb

@@ -11,6 +11,8 @@ module SecupayRuby
     autoload :Cancel, "secupay_ruby/requests/cancel"
     autoload :RequestApiKey, "secupay_ruby/requests/request_api_key"
 
+    autoload :Response, "secupay_ruby/requests/response"
+
     class Base
       class << self
         def post(api_key: , payment: nil, body: {})
@@ -60,8 +62,6 @@ module SecupayRuby
         end
       end
 
-      Response = Struct.new(:http_status, :status, :data, :errors)
-
       def http_response
         @response ||= begin
           response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == "https") do |http|
@@ -70,10 +70,14 @@ module SecupayRuby
 
           json_response = JSON.parse(response.body)
 
-          Response.new(response.header.code,
-                       json_response["status"],
-                       json_response["data"],
-                       json_response["errors"])
+          response = SecupayRuby::Requests::Response.new(http_status: response.header.code,
+                                                         status: json_response["status"],
+                                                         data: json_response["data"],
+                                                         errors: json_response["errors"])
+
+          raise RequestError.new(response.errors) if response.failed?
+
+          response
         end
       end
     end

data/lib/secupay_ruby/requests/response.rb

@@ -0,0 +1,19 @@
+module SecupayRuby
+  module Requests
+    class Response
+      attr_accessor :http_status, :status, :data, :errors
+
+      def initialize(http_status:, status:, data:, errors:)
+        self.http_status = http_status
+        self.status = status
+        self.data = data
+        self.errors = errors
+      end
+
+      def failed?
+        http_status != "200" || status != "ok"
+      end
+    end
+  end
+end
+

data/lib/secupay_ruby/version.rb

@@ -1,3 +1,3 @@
 module SecupayRuby
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/secupay_ruby.rb

@@ -2,6 +2,7 @@ require "secupay_ruby/version"
 
 module SecupayRuby
   autoload :Configuration, "secupay_ruby/configuration"
+  autoload :Host, 'secupay_ruby/configuration'
   autoload :Payment, "secupay_ruby/payment"
 
   autoload :Requests, "secupay_ruby/requests/base"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: secupay_ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Dominic Breuker
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-03-04 00:00:00.000000000 Z
+date: 2016-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -143,6 +143,7 @@ files:
 - lib/secupay_ruby/requests/get_types.rb
 - lib/secupay_ruby/requests/init.rb
 - lib/secupay_ruby/requests/request_api_key.rb
+- lib/secupay_ruby/requests/response.rb
 - lib/secupay_ruby/requests/status.rb
 - lib/secupay_ruby/version.rb
 - secupay_ruby.gemspec