secretsanta 1.0.3 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3173eabef8c6f996fbc0ff484b24c304b1a3e63dc4259d281c7b61ce1c967996
-  data.tar.gz: 4a49421bd59a8738b9e74d83fc103fbcabde68aab3c108b8366df450f512552e
+  metadata.gz: 4d303454bdb8a9514390fca95bf5345fb4130594911d1c743e39b0e554ccb2ce
+  data.tar.gz: f95b26a7fa26c01f1c935f9bc38abdd6d0039d6bee49b02094e03a639b55fe46
 SHA512:
-  metadata.gz: 69b46346b916c79c48053e957300bee61900da35fe9331dbb4a09cdf1c98767ad658d031946dbe578cb705f421c82a52850aeefbcb863e7bcf1eb6606f869727
-  data.tar.gz: c040c42729d270688ee4a366f81a7ab64fa0f5d1dac5ca55f5ea1bb617946770d1c435e7468d9a3b691e22e5f54bc8572ec34a890aaefb6a1bb36480872a0bb1
+  metadata.gz: 8a7897f0595fefe1cf45e7cb7617948673db4f5d778c753279e31a34feda9d1a3418e7cdaba867be2873599ede680ee9c23318b9c132c766d861f65ee24406f0
+  data.tar.gz: 458aacc92f2bda8efbaf0d4f392283d4eedc71ac5143a1e46a395aa2907de1506f4a9f37df76d482a2a705a0b0e5553de205b5c21eef3c38baecea87d7880c7c

data/.rubocop.yml

@@ -5,7 +5,7 @@ Metrics/AbcSize:
   Max: 20
 
 Metrics/BlockLength:
-  Max: 50
+  Max: 100
 
 Metrics/LineLength:
   Max: 120

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    secretsanta (1.0.3)
+    secretsanta (1.1.0)
       dotenv (~> 2.5)
       twilio-ruby (~> 5.17)
 

data/README.md

@@ -49,10 +49,9 @@ follows:
       "number": "+1 (123) 456-7890",
       "disallow": [
         "Jane Doe"
-      ],
-      "is_assigned": false,
-      "has_assignment": false
+      ]
     }
+  ]
 }
 ```
 

data/bin/secretsanta

@@ -52,7 +52,7 @@ begin
   raise OptionParser::MissingArgument if options.to_h.values.any?(&:nil?)
 
   begin
-    puts SecretSanta.notify_participants!(options)
+    puts SecretSanta.new(options).notify_participants!
   rescue SecretSanta::Error => e
     puts e
     exit 1

data/lib/secretsanta.rb

@@ -2,63 +2,71 @@
 
 require 'twilio-ruby'
 
-require_relative 'secretsanta/version'
-
-module SecretSanta
+class SecretSanta
   class Error < StandardError; end
 
-  module_function
+  VERSION = '1.1.0'
+
+  def initialize(options)
+    @dry_run = options.dry_run
+    @from_number = options.from_number
+    @participants = options.participants
+    @sms = Twilio::REST::Client.new(options.twilio_account_sid, options.twilio_auth_token) unless @dry_run
+  end
 
-  def notify_participants!(options)
-    client = Twilio::REST::Client.new(options.twilio_account_sid, options.twilio_auth_token)
-    pairs = generate_pairs(options.participants)
+  def notify_participants!
+    pairs = generate_pairs
 
-    return pairs if options.dry_run
+    return pairs if @dry_run
 
     pairs.each do |pair|
-      client.messages.create(
+      @sms.messages.create(
         body: "Happy holidays! You have been assigned to give a gift to #{pair.recipient_name} this year.",
-        from: options.from_number,
+        from: @from_number,
         to: pair.sender_number
       )
     rescue Twilio::Rest::TwilioError => e
       puts e.message
     end
 
-    "\nAll participants have been notified - happy holidays! 🎅 🎄 🎁\n\n"
+    "\nAll participants have been notified. Happy holidays! 🎅 🎄 🎁\n\n"
   end
 
-  def generate_pairs(participants)
+  def generate_pairs
+    raise Error, SecretSanta.error_message if impossible?
+
     [].tap do |list|
       loop do
-        participants.each do |participant|
-          index = rand 0..participants.length - 1
-          recipient = participants[index]
+        @participants.each do |sender|
+          recipient = @participants.sample
 
-          next if try_again?(participant, recipient)
+          next if try_again?(sender, recipient)
 
-          list << { sender_number: participant[:number], recipient_name: recipient[:name] }
+          list << { sender_number: sender[:number], recipient_name: recipient[:name] }
 
-          participant[:has_assignment] = true
-          participants[index][:is_assigned] = true
+          sender[:has_assignment] = true
+          recipient[:is_assigned] = true
         end
 
-        break if done?(participants)
+        break if done?
       end
     end
   end
 
-  def try_again?(sender, recipient)
-    disallowed = !sender[:disallow].nil? && sender[:disallow].include?(recipient[:name])
+  def done?
+    @participants.all? { |p| p[:has_assignment] && p[:is_assigned] }
+  end
 
-    return true if disallowed || sender[:has_assignment] || recipient[:is_assigned]
+  def impossible?
+    @participants.one? || invalid_hash?
   end
 
-  def done?(participants)
-    participants.all? { |p| p[:has_assignment] && p[:is_assigned] }
+  def try_again?(sender, recipient)
+    sender[:has_assignment] || recipient[:is_assigned] || sender[:number] == recipient[:number] ||
+      !sender[:disallow].nil? && sender[:disallow].include?(recipient[:name])
   end
 
-  def help_text
+  def self.help_text
     <<~HEREDOC
       SecretSanta, version #{VERSION}
 
@@ -72,4 +80,24 @@ module SecretSanta
 
     HEREDOC
   end
+
+  def self.error_message
+    <<~HEREDOC
+      Looks like something is wrong with your participants file. Make sure that it:
+
+        1. Follows the format specified in README.md
+        2. Contains enough participants so that everyone can be matched
+        3. Doesn't have too many blacklisted participants (see "disallow" array in README.md)
+    HEREDOC
+  end
+
+  private
+
+  def invalid_hash?
+    @participants.each do |participant|
+      return true unless %i[name number].all? { |k| participant.key? k }
+    end
+
+    false
+  end
 end

data/secretsanta.gemspec

@@ -2,7 +2,7 @@
 
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'secretsanta/version'
+require 'secretsanta'
 
 Gem::Specification.new do |spec|
   spec.name          = 'secretsanta'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: secretsanta
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
 platform: ruby
 authors:
 - Ty-Lucas Kelley
@@ -143,7 +143,6 @@ files:
 - bin/secretsanta
 - bin/setup
 - lib/secretsanta.rb
-- lib/secretsanta/version.rb
 - secretsanta.gemspec
 homepage: https://github.com/tylucaskelley/secret-santa
 licenses:

data/lib/secretsanta/version.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-module SecretSanta
-  VERSION = '1.0.3'
-end