secret_sharing 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTU5NTYxM2RmYzRmOTdlMzVlYzczNTg1ODc2NDBmYTcwOGNiNWY2Yg==
+    ZGRmOTk3Y2EyYTJhY2FiODk2YWYwODNlNWZlMzI5ZTJlY2M0MDk3Yg==
   data.tar.gz: !binary |-
-    NjA3MGFiOGNiYzlhOGQ0MWIxYjNkM2VlNDVkMGZiYmQ2MzgyZTgzZA==
+    ZTVkODUxZjRkMGUzZWYyMzRkYzFiNTYyNWU2OWUyMzJjYzhkNjU3OA==
 SHA512:
   metadata.gz: !binary |-
-    NGM2YjkzZDQyMGYyNGU5NzhhMGUxZjAxMTVmZTg4MGJjNTRkNTI1NGJmYzkw
-    NzAwN2Y4NGQ3MmJkZWNlN2NiNjhkM2FkYTExZDFlNTNjMDM4MDYyNDdjNWNi
-    MmYyOGUwNTU1ZDE0MTAzZmU4NzUzZGViMmM2OTRiYTUxN2M4NTQ=
+    MjY5OTQ3ZTU4NjA1MzhkMmY0MzkwM2U0NTVkYmJjOTg3MDMyZjIyNmUwZWUw
+    OGRmZDAzZWFjYzBiMDlkNzdhZmMyMjU5N2Y5MzNmOTA3ZTc2YTY3Zjg4ZDFk
+    NDRhYmZmZTc4NjFkY2FlOGRlZmQ1ZmZhZjdjOGI5MmRjYWE5NGM=
   data.tar.gz: !binary |-
-    NzRmYjIwMzk2MWJmYTUxY2YxMjIzYzUyOWMwMDVhZGIwZGI5NTIxOTlhNDdl
-    OWNjYzczNzJkMmJhOTBjYzk2Yjc3ZWVmMmFmNjI4ZmI3ZWZhM2M0Y2RiNjIz
-    MDBkYTU0NGE3NGU3MTg1MmQyYmE4ZmE5MmZmMzI1MjQzNjI3ZWQ=
+    Y2YwZjQ1YjVjMGJlOGU2YzVlZTA4NTJhZWEzMDFiYjRlNzU0NGQ1M2ViNjZj
+    NTQ0MTc4NjNmYjI1NWIyNTkwOWYzYmE2ZjBkOGRhMDQ3MTdjZTk2Zjk0YmY4
+    NTEyYzg1NzU2NDhkN2YwMTE2ZGQ0ZjE5MzY2Y2U1NjQ1ZTQ0MTQ=

data/Gemfile

@@ -1,8 +1,13 @@
 source 'https://rubygems.org'
+gemspec
 
-gem 'rake',  group: [:development, :test]
-gem 'rspec', group: [:development, :test]
-gem 'yard',  group: :development
-gem 'rubocop',   require: false, group: :development
-gem 'simplecov', require: false, group: [:development, :test]
-gem 'coveralls', require: false, group: [:development, :test]
+group :development, :test do
+  gem 'rake'
+  gem 'rspec'
+  gem 'mutant'
+  gem 'mutant-rspec'
+  gem 'yard'
+  gem 'rubocop',   require: false
+  gem 'simplecov', require: false
+  gem 'coveralls', require: false
+end

data/README.md

@@ -4,7 +4,7 @@
 [![Code Climate](https://codeclimate.com/github/duse-io/secret_sharing_ruby/badges/gpa.svg)](https://codeclimate.com/github/duse-io/secret_sharing_ruby)
 [![Inline docs](http://inch-ci.org/github/duse-io/secret_sharing_ruby.svg?branch=master)](http://inch-ci.org/github/duse-io/secret_sharing_ruby)
 
-# SecretSharing
+# secret_sharing
 
 > **Warning:** This implementation has not been tested in production nor has it
 > been examined by a security audit. All uses are your own responsibility.
@@ -25,32 +25,46 @@ Or install it yourself as:
 
     $ gem install secret_sharing
 
-## Usage
+## Implementation details
 
-	require 'secret_sharing'
-	shares = SecretSharing.split_secret('secret', 2, 3) # => [...]
-	length = shares.length # => 3
-	secret = SecretSharing.recover_secret(shares[0..1]) # => 'my secret'
+This implementation of shamir's secret sharing has initially been developed to
+be used in [duse](https://duse.io/), however, it is designed to be used in any
+other context just as well.
+
+The representation of a share is simply `x-hex(y)`. We chose this
+representation, mainly to make it easier for this library to become compatible
+with other implementations, if we choose to.
 
-This implementation can also handle non-ascii characters, however, the charset
-will be visible in the calculated shares. Thus splitting ascii only strings is
-"more" secure. (but always remember, shamir's secret sharing alone is not
-secure)
+For better approximation and equal length of the resulting shares, a zero
+padding has been added. For example, if there are ten or more shares, then all
+single digit shares have a prepending zero.
 
-## Compatible libraries
+* `01-574060c9`
+* `02-1fe7479f`
+* ...
+* `10-651e7e4b`
 
-Since this implementation is special in some ways most [Shamir’s Secret
-Sharing](http://de.wikipedia.org/wiki/Shamir%E2%80%99s_Secret_Sharing)
-libraries are not compatible. The only library that is compatible as of now is
-[duse-io/secret-sharing-dart](https://github.com/duse-io/secret-sharing-dart).
+Also, when generating a random polynomial, we make sure the coefficients are
+random, but never zero. If we would allow the coefficients to be zero, it could
+result in a lower threshold than intended. For example, if the threshold is
+three, then the degree of the polynomial would be two so in the form of
+`f(x)=a0 + a1*x + a2*x^2`. If `a2` would be zero than the polynomial would be
+of dergree one, which would result in a real threshold of two rather than
+three.
 
-We do have [integration
-tests](https://github.com/duse-io/lib-integration-tests) that make sure the
-libraries work with each other.
+## Usage
+
+	require 'secret_sharing'
+	shares = SecretSharing.split_secret('my secret', 2, 3)
+	# => ["1-437b3d6cce8e7b77adb75", "2-86f673fa74e31127903f6", "3-ca71aa881b37a6d772c77"]
+	length = shares.length
+	# => 3
+	secret = SecretSharing.recover_secret(shares[0..1])
+	# => 'my secret'
 
 ## Contributing
 
-1. Fork it ( https://github.com/duse-io/secret_sharing/fork )
+1. Fork it ( https://github.com/duse-io/secret_sharing_ruby/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/secret_sharing.rb

@@ -30,7 +30,7 @@ module SecretSharing
                                            num_shares)
 
     points.map do |point|
-      Share.new(point).to_s(Math.log10(points.length).floor + 1)
+      Share.new(point).to_s(Math.log10(points.length) + 1)
     end
   end
 

data/lib/secret_sharing/polynomial.rb

@@ -43,16 +43,15 @@ module SecretSharing
       (1..num_points).map do |x|
         y = intercept
         (1...@coefficients.length).each do |i|
-          exponentiation = x**i % prime
-          term = (@coefficients[i] * exponentiation) % prime
-          y = (y + term) % prime
+          y = (y + @coefficients[i] * x ** i) % prime
         end
         Point.new(x, y)
       end
     end
 
     # Generate a random polynomial with a specific degree, defined x=0 value
-    # and an upper limit for the coefficients of the polynomial.
+    # and an upper limit for the coefficients of the polynomial. All
+    # coefficients generated are >= 1.
     #
     # Example
     #
@@ -66,7 +65,7 @@ module SecretSharing
       fail ArgumentError, 'Degree must be a non-negative number' if degree < 0
 
       coefficients = (0...degree).reduce([intercept]) do |accumulator|
-        accumulator << SecureRandom.random_number(upper_bound)
+        accumulator << SecureRandom.random_number(upper_bound - 1) + 1
       end
       new coefficients
     end
@@ -83,13 +82,11 @@ module SecretSharing
     # @param num_points [Integer] number of points to generate
     # @return [Polynomial] the generated polynomial
     def self.points_from_secret(secret_int, point_threshold, num_points)
-      prime = SecretSharing::Prime.large_enough_prime([secret_int, num_points].max)
+      prime = Prime.large_enough_prime(secret_int)
       fail ArgumentError, 'Threshold must be at least 2' if point_threshold < 2
       fail ArgumentError, 'Threshold must be less than the total number of points' if point_threshold > num_points
 
-      polynomial = SecretSharing::Polynomial.random(point_threshold - 1,
-                                                    secret_int,
-                                                    prime)
+      polynomial = random(point_threshold - 1, secret_int, prime)
       polynomial.points(num_points, prime)
     rescue Prime::CannotFindLargeEnoughPrime
       raise ArgumentError, 'Secret is too long'
@@ -97,8 +94,8 @@ module SecretSharing
 
     # Modular lagrange interpolation
     def self.modular_lagrange_interpolation(points)
-      y_values = Point.transpose(points)[1]
-      prime = SecretSharing::Prime.large_enough_prime(y_values.max)
+      _, y_values = Point.transpose(points)
+      prime = Prime.large_enough_prime(y_values.max)
       points.reduce(0) do |f_x, point|
         numerator, denominator = lagrange_fraction(points, point, prime)
         lagrange_polynomial = numerator * mod_inverse(denominator, prime)
@@ -121,7 +118,7 @@ module SecretSharing
     # inverse modulo
     def self.mod_inverse(k, prime)
       k = k % prime
-      r = egcd(prime, k.abs)[2]
+      r = egcd(prime, k.abs).last
       (prime + r) % prime
     end
 

data/lib/secret_sharing/version.rb

@@ -1,4 +1,4 @@
 module SecretSharing
   # gem version
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/secret_sharing.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ['flower-pot']
   spec.email         = ['fbranczyk@gmail.com']
   spec.summary       = 'Ruby implementation of sharmir\'s secret sharing'
-  spec.description   = 'Divide, share and reconstruct secrets.'
+  spec.description   = 'Split and reconstruct secrets using the shamir\'s secret sharing algorithm'
   spec.homepage      = 'https://github.com/duse-io/secret_sharing_ruby'
   spec.license       = 'MIT'
 

data/spec/polynomial_spec.rb

@@ -59,7 +59,13 @@ RSpec.describe SecretSharing::Polynomial do
     it 'randomly generates coefficients' do
       allow(SecureRandom).to receive(:random_number).and_return(3, 5, 2)
       polynomial = SecretSharing::Polynomial.random(3, 5, 10)
-      expect(polynomial.coefficients).to eq [5, 3, 5 ,2]
+      expect(polynomial.coefficients).to eq [5, 4, 6 ,3]
+    end
+
+    it 'ensures, that a coefficient is >= 1' do
+      allow(SecureRandom).to receive(:random_number).and_return(0, 0, 0)
+      polynomial = SecretSharing::Polynomial.random(3, 5, 10)
+      expect(polynomial.coefficients).to eq [5, 1, 1 ,1]
     end
 
     it 'uses the intercept as the first coefficient' do
@@ -79,11 +85,36 @@ RSpec.describe SecretSharing::Polynomial do
       expect(points.length).to eq 4
     end
 
-    it 'requires threshold points to reconstruct' do
-      points = SecretSharing::Polynomial.points_from_secret(234234, 2, 3)
-      points = points[0, 2]
-      secret = SecretSharing::Polynomial.modular_lagrange_interpolation(points)
+    it 'generates points according to the threshold parameter' do
+      points = SecretSharing::Polynomial.points_from_secret(10, 2, 4)
+      required_points = points[0, 2]
+      result = SecretSharing::Polynomial.modular_lagrange_interpolation(required_points)
+      expect(result).to eq 10
+    end
+
+    it 'allows threshold and total number of points to be equal' do
+      points = SecretSharing::Polynomial.points_from_secret(10, 2, 2)
+      result = SecretSharing::Polynomial.modular_lagrange_interpolation(points)
+      expect(result).to eq 10
+    end
+
+    it 'requires threshold points or more to reconstruct' do
+      points = SecretSharing::Polynomial.points_from_secret(234234, 3, 4)
+      required_points = points[0, 3]
+      secret = SecretSharing::Polynomial.modular_lagrange_interpolation(required_points)
       expect(secret).to eq 234234
+
+      required_points = points[0, 4]
+      secret = SecretSharing::Polynomial.modular_lagrange_interpolation(required_points)
+      expect(secret).to eq 234234
+
+      required_points = points[0, 2]
+      secret = SecretSharing::Polynomial.modular_lagrange_interpolation(required_points)
+      expect(secret).not_to eq 234234
+
+      required_points = points[0, 1]
+      secret = SecretSharing::Polynomial.modular_lagrange_interpolation(required_points)
+      expect(secret).not_to eq 234234
     end
 
     it 'errors when the secret is to long' do
@@ -111,4 +142,12 @@ RSpec.describe SecretSharing::Polynomial do
       )
     end
   end
+
+  describe '.egcd' do
+    context 'a=240 b=46' do
+      it 'returns a quotient of 2, s=-9 and t=47' do
+        expect(SecretSharing::Polynomial.egcd(240, 46)).to eq [2, -9, 47]
+      end
+    end
+  end
 end

data/spec/secret_sharing_spec.rb

@@ -37,4 +37,14 @@ RSpec.describe SecretSharing do
       expect(SecretSharing.recover_secret(shares)).to eq 'secret'
     end
   end
+
+  context 'threshold 2 out of 11 shares' do
+    subject(:shares) { SecretSharing.split_secret('secret', 2, 11) }
+
+    it 'adds zero padding for shares 1 to 9' do
+      shares[0, 9].each_with_index do |share, index|
+        expect(share).to start_with "0#{index+1}"
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -58,4 +58,7 @@ RSpec.configure do |config|
   config.around :each do |block|
     Timeout.timeout(1, &block)
   end
+
+  config.order = :random
+  Kernel.srand config.seed
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: secret_sharing
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - flower-pot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-23 00:00:00.000000000 Z
+date: 2015-04-25 00:00:00.000000000 Z
 dependencies: []
-description: Divide, share and reconstruct secrets.
+description: Split and reconstruct secrets using the shamir's secret sharing algorithm
 email:
 - fbranczyk@gmail.com
 executables: []