secret_config 0.7.1 → 0.8.0

data/test/providers/file_test.rb

@@ -1,10 +1,10 @@
-require_relative '../test_helper'
+require_relative "../test_helper"
 
 module Providers
   class FileTest < Minitest::Test
     describe SecretConfig::Providers::File do
       let :file_name do
-        File.join(File.dirname(__FILE__), '..', 'config', 'application.yml')
+        File.join(File.dirname(__FILE__), "..", "config", "application.yml")
       end
 
       let :path do
@@ -27,8 +27,8 @@ module Providers
         }
       end
 
-      describe '#each' do
-        it 'file' do
+      describe "#each" do
+        it "file" do
           file_provider = SecretConfig::Providers::File.new(file_name: file_name)
           paths         = {}
           file_provider.each(path) { |key, value| paths[key] = value }

data/test/providers/ssm_test.rb

@@ -1,10 +1,10 @@
-require_relative '../test_helper'
+require_relative "../test_helper"
 
 module Providers
   class SsmTest < Minitest::Test
     describe SecretConfig::Providers::Ssm do
       let :file_name do
-        File.join(File.dirname(__FILE__), '..', 'config', 'application.yml')
+        File.join(File.dirname(__FILE__), "..", "config", "application.yml")
       end
 
       let :path do
@@ -15,7 +15,7 @@ module Providers
         {
           "/test/my_application/mongo/database"               => "secret_config_test",
           "/test/my_application/mongo/primary"                => "127.0.0.1:27017",
-          "/test/my_application/mongo/secondary"              => "127.0.0.1:27018",
+          "/test/my_application/mongo/secondary"              => "%{hostname}:27018",
           "/test/my_application/mysql/database"               => "secret_config_test",
           "/test/my_application/mysql/password"               => "secret_configrules",
           "/test/my_application/mysql/username"               => "secret_config",
@@ -28,21 +28,43 @@ module Providers
       end
 
       before do
-        unless ENV['AWS_ACCESS_KEY_ID']
+        unless ENV["AWS_ACCESS_KEY_ID"]
           skip "Skipping AWS SSM Parameter Store tests because env var 'AWS_ACCESS_KEY_ID' is not defined."
         end
       end
 
-      describe '#each' do
-        it 'fetches all keys in path' do
-          ssm   = SecretConfig::Providers::Ssm.new
+      describe "#each" do
+        let :ssm_provider do
+          SecretConfig::Providers::Ssm.new
+        end
+
+        let :ssm_extended_provider do
+          SecretConfig::Providers::Ssm.new(credentials: ::Aws::AssumeRoleCredentials.new(
+            role_arn:          "arn:aws:iam::#{ENV['SECRET_CONFIG_ACCOUNT_ID']}:role/secret_config_test",
+            role_session_name: "SecretConfigSession-#{SecureRandom.uuid}"
+          ))
+        end
+
+        def fill_paths(provider)
           paths = {}
-          ssm.each(path) { |key, value| paths[key] = value }
 
-          if paths.empty?
-            upload_settings(ssm) unless paths.key?("/test/my_application/mongo/database")
-            ssm.each(path) { |key, value| paths[key] = value }
+          provider.each(path) { |key, value| paths[key] = value }
+
+          upload_settings(provider) if paths.empty?
+
+          paths
+        end
+
+        it "fetches all keys in path" do
+          paths = fill_paths(ssm_provider)
+
+          expected.each_pair do |key, value|
+            assert_equal paths[key], value, "Path: #{key}"
           end
+        end
+
+        it "provider with extended credentials fetches all keys in path" do
+          paths = fill_paths(ssm_extended_provider)
 
           expected.each_pair do |key, value|
             assert_equal paths[key], value, "Path: #{key}"
@@ -52,7 +74,10 @@ module Providers
 
       def upload_settings(ssm)
         file_provider = SecretConfig::Providers::File.new(file_name: file_name)
-        file_provider.each(path) { |key, value| ap key; ssm.set(key, value) }
+        file_provider.each(path) do |key, value|
+          ap key
+          ssm.set(key, value)
+        end
       end
     end
   end

data/test/registry_test.rb

@@ -1,10 +1,10 @@
-require_relative 'test_helper'
-require 'socket'
+require_relative "test_helper"
+require "socket"
 
 class RegistryTest < Minitest::Test
   describe SecretConfig::Registry do
     let :file_name do
-      File.join(File.dirname(__FILE__), 'config', 'application.yml')
+      File.join(File.dirname(__FILE__), "config", "application.yml")
     end
 
     let :path do
@@ -28,97 +28,122 @@ class RegistryTest < Minitest::Test
         "/test/my_application/mysql/password"               => "secret_configrules",
         "/test/my_application/mysql/username"               => "secret_config",
         "/test/my_application/mysql/host"                   => "127.0.0.1",
+        "/test/my_application/mysql/ports"                  => "12345,5343,26815",
+        "/test/my_application/mysql/ports2"                 => "    12345, 5343 ,  26815",
+        "/test/my_application/mysql/hostnames"              => "primary.example.net,secondary.example.net,backup.example.net",
+        "/test/my_application/mysql/hostnames2"             => "   primary.example.net,  secondary.example.net ,  backup.example.net",
         "/test/my_application/secrets/secret_key_base"      => "somereallylongteststring",
         "/test/my_application/symmetric_encryption/key"     => "QUJDREVGMTIzNDU2Nzg5MEFCQ0RFRjEyMzQ1Njc4OTA=",
-        "/test/my_application/symmetric_encryption/version" => 2,
+        "/test/my_application/symmetric_encryption/version" => "2",
         "/test/my_application/symmetric_encryption/iv"      => "QUJDREVGMTIzNDU2Nzg5MA=="
       }
     end
 
-    describe '#configuration' do
-      it 'returns a copy of the config' do
+    describe "#configuration" do
+      it "returns a copy of the config" do
         assert_equal "127.0.0.1", registry.configuration.dig("mysql", "host")
       end
 
-      it 'filters passwords' do
+      it "filters passwords" do
         assert_equal SecretConfig::FILTERED, registry.configuration.dig("mysql", "password")
       end
 
-      it 'filters key' do
+      it "filters key" do
         assert_equal SecretConfig::FILTERED, registry.configuration.dig("symmetric_encryption", "key")
       end
     end
 
-    describe '#key?' do
-      it 'has key' do
-        expected.each_pair do |key, value|
+    describe "#key?" do
+      it "has key" do
+        expected.each_pair do |key, _value|
           key = key.sub("#{path}/", "")
           assert registry.key?(key), "Path: #{key}"
         end
       end
 
-      it 'returns false with missing relative key' do
+      it "returns false with missing relative key" do
         refute registry.key?("invalid/path")
       end
 
-      it 'returns nil with missing full key' do
+      it "returns nil with missing full key" do
         refute registry.key?("/test/invalid/path")
       end
     end
 
-    describe '#[]' do
-      it 'returns values' do
+    describe "#[]" do
+      it "returns values" do
         expected.each_pair do |key, value|
           key = key.sub("#{path}/", "")
           assert_equal value, registry[key], "Path: #{key}"
         end
       end
 
-      it 'returns nil with missing relative key' do
+      it "returns nil with missing relative key" do
         assert_nil registry["invalid/path"]
       end
 
-      it 'returns nil with missing full key' do
+      it "returns nil with missing full key" do
         assert_nil registry["/test/invalid/path"]
       end
     end
 
-    describe '#fetch' do
-      it 'returns values' do
+    describe "#fetch" do
+      it "returns values" do
         expected.each_pair do |key, value|
           key = key.sub("#{path}/", "")
           assert_equal value, registry.fetch(key), "Path: #{key}"
         end
       end
 
-      it 'exception missing relative key' do
+      it "exception missing relative key" do
         assert_raises SecretConfig::MissingMandatoryKey do
           registry.fetch("invalid/path")
         end
       end
 
-      it 'returns nil with missing full key' do
+      it "returns nil with missing full key" do
         assert_raises SecretConfig::MissingMandatoryKey do
           registry.fetch("/test/invalid/path")
         end
       end
 
-      it 'returns default with missing key' do
+      it "returns default with missing key" do
         assert_equal "default_value", registry.fetch("/test/invalid/path", default: "default_value")
       end
 
-      it 'returns default with false value' do
+      it "returns default with false value" do
         assert_equal false, registry.fetch("/test/invalid/path", default: false, type: :boolean)
       end
 
-      it 'converts to integer' do
+      it "converts to integer" do
         assert_equal 2, registry.fetch("symmetric_encryption/version", type: :integer)
       end
 
-      it 'decodes Base 64' do
+      describe "uses separator to extract an array" do
+        it "of strings" do
+          value = registry.fetch("mysql/hostnames", separator: ",")
+          assert_equal ["primary.example.net", "secondary.example.net", "backup.example.net"], value
+        end
+
+        it "of strings with spaces" do
+          value = registry.fetch("mysql/hostnames2", separator: ",")
+          assert_equal ["primary.example.net", "secondary.example.net", "backup.example.net"], value
+        end
+
+        it "of integers" do
+          value = registry.fetch("mysql/ports", type: :integer, separator: ",")
+          assert_equal([12345, 5343, 26815], value)
+        end
+
+        it "of integers with spaces" do
+          value = registry.fetch("mysql/ports2", type: :integer, separator: ",")
+          assert_equal([12345, 5343, 26815], value)
+        end
+      end
+
+      it "decodes Base 64" do
         assert_equal "ABCDEF1234567890ABCDEF1234567890", registry.fetch("symmetric_encryption/key", encoding: :base64)
       end
     end
   end
 end
-

data/test/secret_config_test.rb

@@ -15,19 +15,19 @@ class SecretConfigTest < Minitest::Test
       SecretConfig.use :file, path: path, file_name: file_name
     end
 
-    describe "#configuration" do
+    describe ".configuration" do
       it "returns a copy of the config" do
         assert_equal "127.0.0.1", SecretConfig.configuration.dig("mysql", "host")
       end
     end
 
-    describe "#key?" do
+    describe ".key?" do
       it "has key" do
         assert SecretConfig.key?("mysql/database")
       end
     end
 
-    describe "#[]" do
+    describe ".[]" do
       it "returns values" do
         assert_equal "secret_config_test", SecretConfig["mysql/database"]
       end
@@ -37,7 +37,7 @@ class SecretConfigTest < Minitest::Test
       end
     end
 
-    describe "#fetch" do
+    describe ".fetch" do
       after do
         ENV["MYSQL_DATABASE"]      = nil
         SecretConfig.check_env_var = true
@@ -66,5 +66,36 @@ class SecretConfigTest < Minitest::Test
         assert_equal "secret_config_test", SecretConfig.fetch("mysql/database")
       end
     end
+
+    describe ".configure" do
+      before do
+        SecretConfig.use :file, path: path, file_name: file_name
+      end
+
+      it "#fetch" do
+        database = nil
+        SecretConfig.configure("mysql") do |config|
+          database = config.fetch("database")
+        end
+        assert_equal "secret_config_test", database
+      end
+
+      it "#[]" do
+        database = nil
+        SecretConfig.configure("mysql") do |config|
+          database = config["database"]
+        end
+        assert_equal "secret_config_test", database
+      end
+
+      it "#key?" do
+        database = nil
+        SecretConfig.configure("mysql") do |config|
+          database = config.key?("database")
+        end
+        assert_equal true, database
+      end
+    end
+
   end
 end

data/test/setting_interpolator_test.rb

@@ -1,10 +1,10 @@
-require_relative 'test_helper'
+require_relative "test_helper"
 module SecretConfig
   class SettingInterpolatorTest < Minitest::Test
     describe SettingInterpolator do
       let(:interpolator) { SettingInterpolator.new }
 
-      describe '#parse' do
+      describe "#parse" do
         it "handles good key" do
           string   = "Set a date of %{date} here."
           expected = string.gsub("%{date}", Date.today.strftime("%Y%m%d"))
@@ -30,21 +30,21 @@ module SecretConfig
       end
 
       describe "#date" do
-        it 'interpolates date only' do
+        it "interpolates date only" do
           string   = "%{date}"
           expected = Date.today.strftime("%Y%m%d")
           actual   = interpolator.parse(string)
           assert_equal expected, actual, string
         end
 
-        it 'interpolates date' do
+        it "interpolates date" do
           string   = "Set a date of %{date} here."
           expected = string.gsub("%{date}", Date.today.strftime("%Y%m%d"))
           actual   = interpolator.parse(string)
           assert_equal expected, actual, string
         end
 
-        it 'interpolates date with custom format' do
+        it "interpolates date with custom format" do
           string   = "Set a custom %{date:%m%d%Y} here."
           expected = string.gsub("%{date:%m%d%Y}", Date.today.strftime("%m%d%Y"))
           actual   = interpolator.parse(string)
@@ -53,7 +53,7 @@ module SecretConfig
       end
 
       describe "#time" do
-        it 'interpolates time only' do
+        it "interpolates time only" do
           string = "%{time}"
           time   = Time.now
           Time.stub(:now, time) do
@@ -63,7 +63,7 @@ module SecretConfig
           end
         end
 
-        it 'interpolates time' do
+        it "interpolates time" do
           string = "Set a time of %{time} here."
           time   = Time.now
           Time.stub(:now, time) do
@@ -73,7 +73,7 @@ module SecretConfig
           end
         end
 
-        it 'interpolates time with custom format' do
+        it "interpolates time with custom format" do
           string   = "Set a custom time of %{time:%H%M} here."
           expected = string.gsub("%{time:%H%M}", Time.now.strftime("%H%M"))
           actual   = interpolator.parse(string)
@@ -86,20 +86,20 @@ module SecretConfig
           ENV["TEST_SETTING"] = "Secret"
         end
 
-        it 'fetches existing ENV var' do
+        it "fetches existing ENV var" do
           string = "%{env:TEST_SETTING}"
           actual = interpolator.parse(string)
           assert_equal "Secret", actual, string
         end
 
-        it 'fetches existing ENV var into a larger string' do
+        it "fetches existing ENV var into a larger string" do
           string   = "Hello %{env:TEST_SETTING}. How are you?"
           actual   = interpolator.parse(string)
           expected = string.gsub("%{env:TEST_SETTING}", "Secret")
           assert_equal expected, actual, string
         end
 
-        it 'handles missing ENV var' do
+        it "handles missing ENV var" do
           string = "%{env:OTHER_TEST_SETTING}"
           actual = interpolator.parse(string)
           assert_equal "", actual, string
@@ -107,21 +107,21 @@ module SecretConfig
       end
 
       describe "#hostname" do
-        it 'returns hostname' do
+        it "returns hostname" do
           string = "%{hostname}"
           actual = interpolator.parse(string)
           assert_equal Socket.gethostname, actual, string
         end
 
-        it 'returns short hostname' do
+        it "returns short hostname" do
           string = "%{hostname:short}"
           actual = interpolator.parse(string)
-          assert_equal Socket.gethostname.split('.')[0], actual, string
+          assert_equal Socket.gethostname.split(".")[0], actual, string
         end
       end
 
       describe "#pid" do
-        it 'returns process id' do
+        it "returns process id" do
           string = "%{pid}"
           actual = interpolator.parse(string)
           assert_equal $$.to_s, actual, string
@@ -129,7 +129,7 @@ module SecretConfig
       end
 
       describe "#random" do
-        it 'interpolates random 32 byte string' do
+        it "interpolates random 32 byte string" do
           string = "%{random}"
           random = SecureRandom.urlsafe_base64(32)
           SecureRandom.stub(:urlsafe_base64, random) do
@@ -138,7 +138,7 @@ module SecretConfig
           end
         end
 
-        it 'interpolates custom length random string' do
+        it "interpolates custom length random string" do
           string = "%{random:64}"
           random = SecureRandom.urlsafe_base64(64)
           SecureRandom.stub(:urlsafe_base64, random) do