secondrotation-channel_advisor 0.0.4 → 0.0.5

data/lib/channel_advisor/message_code.rb

@@ -23,7 +23,7 @@ module ChannelAdvisor
       when 5: NoSkuValue
       when 8: TooManySkus
       else
-        raise ArgumentError.new("Unknown code: #{code}")
+        MessageCode.new(code, 'Unknown Error')
       end
     end
   end

data/lib/channel_advisor/service_proxy.rb

@@ -35,6 +35,9 @@ module ChannelAdvisor
 
           define_method(method_name) do |*args|
             args = args.unshift(configatron.channel_advisor.account_id)
+            
+            verify_mode = configatron.channel_advisor.ssl_config.retrieve('verify_mode', OpenSSL::SSL::VERIFY_PEER)
+            self.client.streamhandler.client.ssl_config.verify_mode = verify_mode
 
             request_class = service_module.const_get(class_name)
             request = request_class.new(*args)

data/spec/lib/channel_advisor/message_code_spec.rb

@@ -28,10 +28,10 @@ describe ChannelAdvisor::MessageCode do
     message_code.code.should == 0
   end
 
-  it "raises an error if the code is unknown" do
-    lambda {
-      ChannelAdvisor::MessageCode.get('49')
-    }.should raise_error(ArgumentError, 'Unknown code: 49')
+  it "returns an unknown code if the code is not defined" do
+    message_code = ChannelAdvisor::MessageCode.get('12')
+    message_code.code.should == 12
+    message_code.message.should == 'Unknown Error'
   end
 
   it "uses the class values for get" do

data/spec/lib/channel_advisor/service_proxy_spec.rb

@@ -8,9 +8,43 @@ describe ChannelAdvisor::ServiceProxy do
       configatron.channel_advisor.account_id = 'test_account_id'
       @client = mock(ChannelAdvisor::InventoryServiceSOAP::InventoryServiceSoap)
       @client.should_receive(:headerhandler).and_return([])
+
+      @ssl_config = mock(Object)
+      @ssl_config.stub!(:verify_mode=)
+      @streamhandler_client = mock(Object)
+      @streamhandler_client.stub!(:ssl_config).and_return(@ssl_config)
+      @streamhandler = mock(Object)
+      @streamhandler.stub!(:client).and_return(@streamhandler_client)
+      @client.stub!(:streamhandler).and_return(@streamhandler)
+
       ChannelAdvisor::InventoryServiceSOAP::InventoryServiceSoap.should_receive(:new).and_return(@client)
     end
 
+    describe 'SSL config' do
+      before(:each) do
+        mock_result = mock(Object, :status => 'Success', :resultData => {})
+        response = mock(ChannelAdvisor::InventoryServiceSOAP::GetFilteredSkuListResponse,
+          :getFilteredSkuListResult => mock_result
+        )
+        @client.should_receive(:getFilteredSkuList).and_return(response)
+      end
+
+      it "sets the default SSL verify mode to VERIFY_PEER" do
+        @ssl_config.should_receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_PEER)
+        inventory = ChannelAdvisor::InventoryService.new
+        inventory.getFilteredSkuList
+      end
+
+      it "sets the SSL verify mode from a configatron parameter" do
+        configatron.temp do
+          configatron.channel_advisor.ssl_config.verify_mode = OpenSSL::SSL::VERIFY_NONE
+          @ssl_config.should_receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_NONE)
+          inventory = ChannelAdvisor::InventoryService.new
+          inventory.getFilteredSkuList
+        end
+      end
+    end
+
     it "handles getFilteredSkuList request" do
       criteria = ChannelAdvisor::InventoryServiceSOAP::InventoryItemCriteria.new
       criteria.skuStartsWith = 'SR123'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: secondrotation-channel_advisor
 version: !ruby/object:Gem::Version 
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors: 
 - Second Rotation, Inc.
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-24 00:00:00 -07:00
+date: 2009-09-10 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency