sec_id 7.1.1 → 8.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be4a59e18a04226f78492df3eb2ec1318af8e7c99044005bda0f7b9652ac7a33
-  data.tar.gz: 6edd9226b4cc7b293a7fe1950f32aa0673ea0b44507b36ecc253da98f372d3c2
+  metadata.gz: d50c9163daf21728a883a7c9ae03215677c655ef2c8590b917b58306ab31efb1
+  data.tar.gz: 2a9ad832edc6be71a8bb4659909d1adfc6740e804aea2acad909b8373575a017
 SHA512:
-  metadata.gz: b4b95d04179e0aee0ff4c45dbc2e169a024d3933a2c8234de2319422d19773d34247d83b8f457317af93d536ac431406fca9455a454cc7159ae2a9bad8982955
-  data.tar.gz: f479c160b3229763197b1ac1fe3b7d67f8a6fc3281d3607adf59fece50e89cc8dd2160eb2d4f94d32954d136bc2e8c8998b19bfcdf1e24f4e32a2a035f9e972a
+  metadata.gz: 4a6b95868dd3d59b5bc3d48f6e7ce4b44b50d1c24389906505e5708cf4b6add66b6facc667dfe72348203a9c5e0fe35be9ef57978ed9600a4bfe9f53f5a9658a
+  data.tar.gz: 7592379ce4c9915548aa4e732f2065f41d455e6099e37b3a0a1dfeb48e36b3552c6f4b01bd089d4e505f7e5b73be940b832f965a8c8cc7060ed10e67171ed88f

data/CHANGELOG.md

@@ -8,6 +8,38 @@ and [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/).
 
 ## [Unreleased]
 
+## [8.0.1] - 2026-10-30
+
+This patch release contains a breaking API change as an explicit exception to Semantic Versioning. The v7 bridge removal was scheduled for 8.0.0 but was omitted.
+
+### Removed
+
+- **BREAKING:** Remove deprecated instance methods `check_digit` and `calculate_check_digit`, and class methods `check_digit` and `has_check_digit?`. Use `checksum`, `calculate_checksum`, and `has_checksum?`.
+- **BREAKING:** Remove the `SecID::InvalidCheckDigitError` alias. Rescue `SecID::InvalidChecksumError` instead.
+- **BREAKING:** Remove the `:check_digit` key from `to_h`, `as_json`, and pattern matching. Use `:checksum`.
+- Remove the unused `SecID::Deprecation` warning helper and the bridge's RBS declarations.
+
+## [8.0.0] - 2026-10-30
+
+Ruby 3.3 or later is now required. Dropping Ruby 3.2 support is the breaking change that requires this major release.
+
+The deprecated v7 check-digit methods, error alias, and component key remain available in 8.0.0.
+
+### Added
+
+- Lefthook Git hooks for staged secret scanning, Ruby autocorrection, whitespace, commit messages, tests, types, and documentation coverage.
+- CI checks library CRAP scores with crap4ruby and fresh test coverage, with a maximum score of 10.
+
+### Changed
+
+- **BREAKING:** Drop support for Ruby 3.2 and require Ruby 3.3 or later.
+- Reduce detector allocations by sorting candidate types once and stopping parsing at the first valid match. Unsupported input lengths no longer grow the detector cache.
+- Reduce LEI and IBAN checksum allocations by reusing decimal expansions and preserving IBAN numeric characters.
+- Reduce scanner allocations by sorting candidate types once, stopping at the first valid type, and reusing the validated instance.
+- Reduce temporary allocations in ISIN, CUSIP, CEI, and FIGI checksum calculations by processing ASCII bytes directly.
+- Refresh development dependencies, all four lockfiles, and GitHub Actions for frozen CI installs.
+- RBS: `SecID::CFI::AttributeSet#to_h` and `#as_json` are now typed `Hash[Symbol, Hash[Symbol, untyped]]` instead of `Hash[untyped, untyped]` (Steep 2.1 tuple inference)
+
 ## [7.1.1] - 2026-07-31
 
 Documentation and packaging only. No identifier, checksum, or public method changed.
@@ -285,7 +317,9 @@ Gem metadata only: corrected the gemspec description and README wording. No libr
 
 - ISIN numbers support: `SecID::ISIN`
 
-[Unreleased]: https://github.com/svyatov/sec_id/compare/v7.1.1...HEAD
+[Unreleased]: https://github.com/svyatov/sec_id/compare/v8.0.1...HEAD
+[8.0.1]: https://github.com/svyatov/sec_id/compare/v8.0.0...v8.0.1
+[8.0.0]: https://github.com/svyatov/sec_id/compare/v7.1.1...v8.0.0
 [7.1.1]: https://github.com/svyatov/sec_id/compare/v7.1.0...v7.1.1
 [7.1.0]: https://github.com/svyatov/sec_id/compare/v7.0.0...v7.1.0
 [7.0.0]: https://github.com/svyatov/sec_id/compare/v6.1.0...v7.0.0

data/MIGRATION.md

@@ -1,4 +1,23 @@
-# Upgrading to SecID 7.0
+# Migration guide
+
+## Upgrading to SecID 8.0.1
+
+Version 8.0.1 removes the deprecated v7 bridge that remained in 8.0.0. This is an explicit exception to Semantic Versioning: the patch release contains a breaking API change.
+
+Replace these names before upgrading:
+
+| Removed | Replacement |
+|---|---|
+| Instance `check_digit` | `checksum` |
+| Instance `calculate_check_digit` | `calculate_checksum` |
+| Class `check_digit(id)` | `checksum(id)` |
+| Class `has_check_digit?` | `has_checksum?` |
+| `SecID::InvalidCheckDigitError` | `SecID::InvalidChecksumError` |
+| `:check_digit` in `to_h`, `as_json`, and pattern matching | `:checksum` |
+
+The `SecID::Deprecation` warning helper is also removed. The canonical checksum API, `restore`, `restore!`, and checksum calculations are unchanged.
+
+## Upgrading to SecID 7.0
 
 This guide covers all breaking changes when upgrading from SecID 6.x to 7.0. They are all one
 mechanical rename: the **check-digit** concept became **checksum** across the public API —
@@ -25,7 +44,7 @@ deprecation warnings changed.
 `restore` / `restore!` and the `Checkable` concern name are unchanged.
 
 **Bridge:** the old method names, the `InvalidCheckDigitError` constant, and the `:check_digit`
-components key all keep working through v7 (the methods warn on use); they are removed in v8.
+components key all keep working through v7 and 8.0.0 (the methods warn on use); they are removed in 8.0.1.
 **The one exception is the error code** — `:invalid_check_digit` flips hard to `:invalid_checksum`
 at v7 with no bridge, so an error-code matcher must be updated immediately.
 
@@ -56,7 +75,7 @@ SecID::ISIN.has_checksum?
 ```
 
 The old names still work through v7 but emit a deprecation warning on every call and are removed
-in v8. See step 6 to silence them if you cannot migrate every call site yet.
+in 8.0.1. See step 6 to silence them on older releases if you cannot migrate every call site yet.
 
 ### 3. Rename the rescued error class
 
@@ -70,7 +89,7 @@ rescue SecID::InvalidChecksumError => e
 
 `SecID::InvalidCheckDigitError` remains as a constant alias of `SecID::InvalidChecksumError`
 through v7 (it is the *same class object*, so `rescue` under either name catches the same error),
-and is removed in v8.
+and is removed in 8.0.1.
 
 The constant alias emits **no** deprecation warning at runtime (it is a plain constant, not a
 warned method), so `-W` output won't reveal your rescue sites — find them statically:
@@ -100,15 +119,15 @@ SecID.explain('US5949181040', types: [:isin])[:candidates].first[:errors]
 If you use the opt-in ActiveModel/Rails validator with `details: true`, the surfaced reason
 follows the same flip: an invalid checksum now reports `:invalid_checksum`.
 
-### 5. Migrate pattern matches and `to_h` readers before v8
+### 5. Migrate pattern matches and `to_h` readers before 8.0.1
 
 `components` (and therefore `to_h` and `deconstruct_keys`) carries **both** `:checksum` and the
 deprecated `:check_digit` key through v7, so existing pattern matches keep working. The
-`:check_digit` key is removed in v8 — migrate to `:checksum` before then.
+`:check_digit` key is removed in 8.0.1. Migrate to `:checksum` before then.
 
 ```ruby
 # Both work through v7, binding the same value:
-isin => { check_digit: }   # deprecated, removed in v8
+isin => { check_digit: }   # deprecated, removed in 8.0.1
 isin => { checksum: }      # canonical
 
 isin.to_h[:components]

data/README.md

@@ -6,7 +6,7 @@ A Ruby toolkit for securities identifiers: validate, parse, normalize, detect, c
 
 - **Nothing to call, nothing to sign up for.** SecID validates all 16 identifier standards offline. No registry lookup, no API key, no network call anywhere in [`lib/`](lib/).
 - **9 of the 16 carry a checksum.** SecID validates it, restores a missing one, and repairs a wrong one.
-- **Zero runtime dependencies.** Runs on Ruby 3.2 or newer.
+- **Zero runtime dependencies.** Runs on Ruby 3.3 or newer.
 - **Rails, if you want it.** An opt-in ActiveModel validator adds `validates :isin, sec_id: true`. It stays off the default require path, so the dependency count stays at zero.
 - **Typed.** Ships RBS signatures for the whole public API, checked by Steep in strict mode.
 
@@ -50,14 +50,16 @@ A Ruby toolkit for securities identifiers: validate, parse, normalize, detect, c
 
 ## Supported Ruby versions
 
-Ruby 3.2+ is required.
+Ruby 3.3+ is required.
+
+Version 8.0.1 removes the deprecated check-digit aliases retained in 8.0.0. This patch release contains a breaking API change; see the [migration guide](MIGRATION.md#upgrading-to-secid-801).
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'sec_id', '~> 7.1'
+gem 'sec_id', '~> 8.0'
 ```
 
 And then execute:
@@ -922,10 +924,26 @@ committed signatures fall out of sync with the tables.
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies.
+Install [Betterleaks](https://github.com/betterleaks/betterleaks) and make its `betterleaks` command available on your `PATH`.
+After checking out the repo, run `bin/setup` to install dependencies and Git hooks.
 Then run `bundle exec rake` to run RuboCop, validate the RBS signatures, and run the specs.
 `bin/console` gives you an interactive prompt to experiment in.
 
+Pre-commit scans staged changes for secrets and whitespace errors, and safely corrects staged Ruby files with RuboCop.
+Corrected Ruby files are staged automatically.
+Pre-push runs static type checks, type coverage, specs, runtime signature checks, and documentation coverage.
+Commit messages must follow Conventional Commits.
+Put personal hook overrides in the ignored `lefthook-local.yml` file.
+
+Run all pre-push jobs manually with `bundle exec lefthook run pre-push`.
+
+CI checks library methods with [crap4ruby](https://github.com/svyatov/crap4ruby), using fresh test coverage and a maximum CRAP score of 10.
+Run the same check locally:
+
+```sh
+COVERAGE=1 bundle exec rake spec crap
+```
+
 To use your working copy from another project, point its Gemfile at the checkout:
 `gem 'sec_id', path: '/path/to/sec_id'`.
 
@@ -941,6 +959,12 @@ One person actively maintains SecID. They read bug reports and pull requests, an
 
 Bug reports and pull requests are welcome on [GitHub](https://github.com/svyatov/sec_id). See [CONTRIBUTING.md](CONTRIBUTING.md) for development setup, code style, and PR guidelines.
 
+For checksum throughput and allocation comparisons, run `ruby -Ilib benchmark/checksums.rb`. It covers Luhn checksums, LEI, and IBAN, including numeric and letter-heavy inputs. It prints repeated samples as JSON with garbage collection enabled. Run the same script with `-I/path/to/baseline/lib` to compare another checkout on the same Ruby version.
+
+For scanner comparisons, run `ruby -Ilib benchmark/scanner.rb`. It measures paragraphs, dense identifiers, noise, type filters, ambiguous identifiers, and compound patterns. JSON output includes matches to check correctness alongside timings and allocations. Use the same baseline option to compare another checkout.
+
+For detection and parsing comparisons, run `ruby -Ilib benchmark/detector.rb`. It measures valid identifiers, ambiguous inputs, invalid checksums, and unsupported lengths. JSON output includes results, timings, and allocations with garbage collection enabled. Use the same baseline option to compare another checkout.
+
 This project follows the [Contributor Covenant Code of Conduct](CODE_OF_CONDUCT.md).
 
 ## Changelog

data/lib/sec_id/base.rb

@@ -95,14 +95,6 @@ module SecID
 
         @has_checksum = ancestors.include?(SecID::Checkable)
       end
-
-      # @deprecated Use {.has_checksum?}. Kept as a v7 bridge; removed in v8.
-      #
-      # @return [Boolean]
-      def has_check_digit?
-        SecID::Deprecation.warn(old: 'has_check_digit?', new: 'has_checksum?')
-        has_checksum?
-      end
     end
 
     # @api private
@@ -142,7 +134,7 @@ module SecID
         full_id: full_id,
         normalized: valid? ? normalized : nil,
         valid: valid?,
-        components: components_with_deprecation_bridge
+        components: components
       }
     end
 
@@ -165,7 +157,7 @@ module SecID
     #   in SecID::ISIN[country_code:, nsin:] then [country_code, nsin]
     #   in nil then :invalid
     #   end #=> ['US', '594918104']
-    def deconstruct_keys(_keys) = components_with_deprecation_bridge
+    def deconstruct_keys(_keys) = components
 
     protected
 
@@ -176,17 +168,6 @@ module SecID
 
     private
 
-    # Mirrors the canonical `:checksum` components key onto the deprecated `:check_digit`
-    # key for the v7 bridge, when a checksum is present. The mirror reads `:checksum`, so the
-    # deprecated `check_digit` reader never fires internally. Removed in v8 (revert `to_h` and
-    # `deconstruct_keys` to call `components` directly).
-    #
-    # @return [Hash] the parsed components, with `:check_digit` added when `:checksum` is present
-    def components_with_deprecation_bridge
-      parsed = components
-      parsed.key?(:checksum) ? parsed.merge(check_digit: parsed[:checksum]) : parsed
-    end
-
     # @return [Hash]
     def components
       {}

data/lib/sec_id/bic/country_codes.rb

@@ -10,7 +10,7 @@ module SecID
     #
     # @api private
     # @see https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2
-    # rubocop:disable Metrics/CollectionLiteralLength
+    # rubocop:disable-next Metrics/CollectionLiteralLength
     COUNTRY_CODES = Set.new(
       %w[
         AD AE AF AG AI AL AM AO AQ AR AS AT AU AW AX AZ
@@ -41,6 +41,5 @@ module SecID
         XK
       ]
     ).freeze
-    # rubocop:enable Metrics/CollectionLiteralLength
   end
 end

data/lib/sec_id/cei.rb

@@ -55,7 +55,7 @@ module SecID
     # @raise [InvalidFormatError] if the CEI format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_double_add_double(reversed_digits_single(identifier)))
+      mod10(luhn_sum_single(identifier))
     end
 
     # Generates a random CEI body: 1 letter + 1 digit + 7 alphanumeric characters.

data/lib/sec_id/cfi/attribute_set.rb

@@ -36,8 +36,11 @@ module SecID
       end
 
       # @return [Hash{Symbol => Hash}]
+      # @raise [ArgumentError] if a field has no meaning (category/group fields; never the case for attributes)
       def to_h
-        @fields.to_h { |field| [field.meaning, field.to_h] }
+        @fields.to_h do |field|
+          [field.meaning || raise(ArgumentError, "attribute field #{field.code} has no meaning"), field.to_h]
+        end
       end
 
       # @return [Hash{Symbol => Hash}]

data/lib/sec_id/cfi/tables.rb

@@ -21,7 +21,7 @@ module SecID
     # +:not_applicable+, so it is never listed in a value map.
     #
     # @api private
-    # rubocop:disable Metrics/ModuleLength
+    # rubocop:disable-next Metrics/ModuleLength
     module Tables
       # Marker for a pure not-applicable attribute position (accepts only +X+).
       NA = nil
@@ -1028,6 +1028,5 @@ module SecID
         GROUPS.dig(category_code, group_code)
       end
     end
-    # rubocop:enable Metrics/ModuleLength
   end
 end

data/lib/sec_id/concerns/checkable.rb

@@ -22,26 +22,12 @@ module SecID
   #
   #     def calculate_checksum
   #       validate_format_for_calculation!
-  #       mod10(luhn_sum_standard(reversed_digits_multi(identifier)))
+  #       mod10(luhn_sum_standard(identifier))
   #     end
   #   end
   #
   # @see https://en.wikipedia.org/wiki/Luhn_algorithm
   module Checkable
-    # Character-to-digit mapping for Luhn algorithm variants.
-    # Maps alphanumeric characters to digit arrays for multi-digit expansion.
-    # Used by ISIN for checksum calculation.
-    CHAR_TO_DIGITS = {
-      '0' => 0,      '1' => 1,      '2' => 2,      '3' => 3,      '4' => 4,
-      '5' => 5,      '6' => 6,      '7' => 7,      '8' => 8,      '9' => 9,
-      'A' => [1, 0], 'B' => [1, 1], 'C' => [1, 2], 'D' => [1, 3], 'E' => [1, 4],
-      'F' => [1, 5], 'G' => [1, 6], 'H' => [1, 7], 'I' => [1, 8], 'J' => [1, 9],
-      'K' => [2, 0], 'L' => [2, 1], 'M' => [2, 2], 'N' => [2, 3], 'O' => [2, 4],
-      'P' => [2, 5], 'Q' => [2, 6], 'R' => [2, 7], 'S' => [2, 8], 'T' => [2, 9],
-      'U' => [3, 0], 'V' => [3, 1], 'W' => [3, 2], 'X' => [3, 3], 'Y' => [3, 4], 'Z' => [3, 5],
-      '*' => [3, 6], '@' => [3, 7], '#' => [3, 8]
-    }.freeze
-
     # Character-to-digit mapping for single-digit conversion.
     # Maps alphanumeric characters to values 0-38 (A=10, B=11, ..., Z=35, *=36, @=37, #=38).
     # Used by CUSIP, FIGI, SEDOL, LEI, and IBAN for checksum calculations.
@@ -56,6 +42,15 @@ module SecID
       '*' => 36, '@' => 37, '#' => 38
     }.freeze
 
+    # ASCII byte lookup avoids allocating a String for each checksum character.
+    BYTE_TO_DIGIT = CHAR_TO_DIGIT.transform_keys(&:ord).freeze
+
+    # Decimal expansions reused by LEI and IBAN without allocating replacement strings.
+    DECIMAL_VALUES = CHAR_TO_DIGIT.transform_values { |value| value.to_s.freeze }.freeze
+
+    # Doubled decimal digits with their digits summed, for expanded ISIN Luhn.
+    LUHN_DOUBLE = [0, 2, 4, 6, 8, 1, 3, 5, 7, 9].freeze
+
     # Extends the including identifier class with the concern's class methods and checksum reader.
     #
     # @param base [Class] the identifier class including this concern
@@ -92,16 +87,6 @@ module SecID
       def checksum(id)
         new(id).calculate_checksum
       end
-
-      # @deprecated Use {.checksum}. Kept as a v7 bridge; removed in v8.
-      #
-      # @param id [String] the identifier to calculate the checksum for
-      # @return [Integer, String] the calculated checksum
-      # @raise [InvalidFormatError] if the identifier format is invalid
-      def check_digit(id)
-        SecID::Deprecation.warn(old: 'check_digit', new: 'checksum')
-        checksum(id)
-      end
     end
 
     # Validates format and checksum.
@@ -143,80 +128,48 @@ module SecID
       "#{identifier}#{checksum&.to_s&.rjust(checksum_width, '0')}"
     end
 
-    # @deprecated Use {#checksum}. Kept as a v7 bridge; removed in v8.
-    #
-    # @return [Integer, String]
-    def check_digit
-      SecID::Deprecation.warn(old: 'check_digit', new: 'checksum')
-      checksum
-    end
-
-    # @deprecated Use {#calculate_checksum}. Kept as a v7 bridge; removed in v8.
-    #
-    # @return [Integer, String]
-    # @raise [InvalidFormatError] if the identifier format is invalid
-    def calculate_check_digit
-      SecID::Deprecation.warn(old: 'calculate_check_digit', new: 'calculate_checksum')
-      calculate_checksum
-    end
-
     private
 
-    # CUSIP/CEI style: "Double Add Double" algorithm.
-    # Processes pairs of digits, doubling the first (even-positioned from right),
-    # then summing both digit's div10mod10 values.
-    #
-    # @param digits [Array<Integer>] reversed array of digit values
-    # @return [Integer] the Luhn sum
-    def luhn_sum_double_add_double(digits)
-      digits.each_slice(2).reduce(0) do |sum, (even, odd)|
-        double_even = (even || 0) * 2
-        sum + div10mod10(double_even) + div10mod10(odd || 0)
-      end
-    end
-
-    # FIGI style: index-based doubling algorithm.
-    # Doubles odd-indexed digits (from right), then sums div10mod10 values.
+    # CUSIP/CEI double the rightmost body character; FIGI starts one position left.
+    # Input must already have passed the identifier's ASCII format validation.
     #
-    # @param digits [Array<Integer>] reversed array of digit values
+    # @param id [String] validated identifier body
+    # @param double_first [Boolean] whether to double the rightmost value
     # @return [Integer] the Luhn sum
-    def luhn_sum_indexed(digits)
-      digits.each_with_index.reduce(0) do |sum, (digit, index)|
-        digit *= 2 if index.odd?
-        sum + div10mod10(digit)
+    def luhn_sum_single(id, double_first: true)
+      # @type var id: String
+      sum = 0
+      double = double_first
+      (id.bytesize - 1).downto(0) do |index|
+        value = BYTE_TO_DIGIT.fetch(id.getbyte(index))
+        value *= 2 if double
+        sum += div10mod10(value)
+        double = !double
       end
+      sum
     end
 
-    # ISIN style: standard Luhn with subtract-9 for values > 9.
-    # Processes pairs of digits, doubling the first (even-positioned from right),
-    # subtracting 9 if result > 9.
+    # ISIN expands letters into two decimal digits before applying Luhn.
+    # A letter consumes two positions, so only a numeric character flips parity.
     #
-    # @param digits [Array<Integer>] reversed array of digit values
+    # @param id [String] validated identifier body
     # @return [Integer] the Luhn sum
-    def luhn_sum_standard(digits)
-      digits.each_slice(2).reduce(0) do |sum, (even, odd)|
-        double_even = (even || 0) * 2
-        double_even -= 9 if double_even > 9
-        sum + double_even + (odd || 0)
+    def luhn_sum_standard(id)
+      # @type var id: String
+      sum = 0
+      double = true
+      (id.bytesize - 1).downto(0) do |index|
+        value = BYTE_TO_DIGIT.fetch(id.getbyte(index))
+        units = value % 10
+        sum += double ? LUHN_DOUBLE.fetch(units) : units
+        if value >= 10
+          tens = value / 10
+          sum += double ? tens : LUHN_DOUBLE.fetch(tens)
+        else
+          double = !double
+        end
       end
-    end
-
-    # Converts identifier characters to reversed digit array using single-digit mapping.
-    # Used by CUSIP, CEI, FIGI, and SEDOL.
-    #
-    # @param id [String] the identifier string
-    # @return [Array<Integer>] reversed array of digit values
-    def reversed_digits_single(id)
-      id.each_char.map { |c| CHAR_TO_DIGIT.fetch(c) }.reverse!
-    end
-
-    # Converts identifier characters to reversed digit array using multi-digit mapping.
-    # Used by ISIN where letters expand to two digits.
-    #
-    # @param id [String] the identifier string
-    # @return [Array<Integer>] reversed array of digit values
-    def reversed_digits_multi(id)
-      id.each_char.flat_map { |c| CHAR_TO_DIGITS.fetch(c) }.reverse!
+      sum
     end
 
     # Returns error codes including checksum validation.

data/lib/sec_id/cusip.rb

@@ -61,7 +61,7 @@ module SecID
     # @raise [InvalidFormatError] if the CUSIP format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_double_add_double(reversed_digits_single(identifier)))
+      mod10(luhn_sum_single(identifier))
     end
 
     # Generates a random CUSIP body: 8 alphanumeric characters.

data/lib/sec_id/detector.rb

@@ -19,7 +19,7 @@ module SecID
   class Detector
     # @param identifier_list [Array<Class>] registered identifier classes
     def initialize(identifier_list)
-      @classes = identifier_list.dup.freeze
+      @classes = identifier_list.sort_by(&:detection_priority).freeze
       precompute
     end
 
@@ -33,7 +33,7 @@ module SecID
 
       upcased = input.upcase
       candidates = filter_candidates(upcased)
-      validate_and_sort(input, candidates)
+      valid_types(input, candidates)
     end
 
     # Returns whether any registered type matches, short-circuiting on the first
@@ -57,8 +57,11 @@ module SecID
       return if input.empty?
 
       candidates = filter_candidates(input.upcase)
-      matches = candidates.filter_map { |klass| (i = klass.new(input)).valid? ? i : nil }
-      matches.min_by { |instance| instance.class.detection_priority }
+      candidates.each do |klass|
+        instance = klass.new(input)
+        return instance if instance.valid?
+      end
+      nil
     end
 
     private
@@ -74,14 +77,13 @@ module SecID
       stage3_charset(upcased, candidates)
     end
 
-    # Validates candidates and returns sorted symbol keys.
+    # Validates candidates in precomputed specificity order.
     #
     # @param input [String]
     # @param candidates [Array<Class>]
     # @return [Array<Symbol>]
-    def validate_and_sort(input, candidates)
+    def valid_types(input, candidates)
       matches = candidates.select { |klass| klass.valid?(input) }
-      matches.sort_by!(&:detection_priority)
       matches.map!(&:type_key)
     end
 
@@ -105,11 +107,12 @@ module SecID
     #
     # @return [void]
     def build_length_table
-      @candidates_by_length = Hash.new { |h, k| h[k] = [] }
+      @candidates_by_length = {}
       @classes.each do |klass|
-        klass.length_values.each { |len| @candidates_by_length[len] << klass }
+        klass.length_values.each { |len| (@candidates_by_length[len] ||= []) << klass }
       end
       @candidates_by_length.each_value(&:freeze)
+      @candidates_by_length.default = [].freeze
     end
 
     # Stage 1: route strings with special characters to the only types that accept them.
@@ -130,7 +133,7 @@ module SecID
     # @param length [Integer]
     # @return [Array<Class>]
     def stage2_length(length)
-      @candidates_by_length[length] || []
+      @candidates_by_length[length]
     end
 
     # Stage 3: filter candidates by character set.

data/lib/sec_id/figi.rb

@@ -69,7 +69,7 @@ module SecID
     # @raise [InvalidFormatError] if the FIGI format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_indexed(reversed_digits_single(identifier)))
+      mod10(luhn_sum_single(identifier, double_first: false))
     end
 
     # Generates a random FIGI body: non-reserved 2-char prefix + 'G' + 8-char random part.

data/lib/sec_id/iban/country_rules.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module SecID
-  # rubocop:disable Metrics/ClassLength
+  # rubocop:disable-next Metrics/ClassLength
   class IBAN < Base
     # Country-specific BBAN rules for EU/EEA countries
     # Each entry defines:
@@ -265,5 +265,4 @@ module SecID
       'XK' => 16  # Kosovo
     }.freeze
   end
-  # rubocop:enable Metrics/ClassLength
 end

data/lib/sec_id/iban.rb

@@ -226,7 +226,7 @@ module SecID
 
     # @return [String] the numeric string representation
     def numeric_string_for_check
-      "#{bban}#{country_code}00".each_char.map { |char| CHAR_TO_DIGIT.fetch(char) }.join
+      "#{bban}#{country_code}00".gsub(/[^0-9]/) { |char| DECIMAL_VALUES.fetch(char) }
     end
   end
 end

data/lib/sec_id/isin.rb

@@ -86,7 +86,7 @@ module SecID
     # @raise [InvalidFormatError] if the ISIN format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_standard(reversed_digits_multi(identifier)))
+      mod10(luhn_sum_standard(identifier))
     end
 
     # Generates a random ISIN body: 2-letter country code + 9-character NSIN.

data/lib/sec_id/lei.rb

@@ -90,7 +90,7 @@ module SecID
 
     # @return [String] the numeric string representation
     def numeric_identifier
-      identifier.each_char.map { |char| CHAR_TO_DIGIT.fetch(char) }.join
+      identifier.each_char.with_object(+'') { |char, numeric| numeric << DECIMAL_VALUES.fetch(char) }
     end
   end
 end

data/lib/sec_id/scanner.rb

@@ -73,7 +73,7 @@ module SecID
       @classes.each do |klass|
         klass.length_values.each { |len| @candidates_by_length[len] << klass }
       end
-      @candidates_by_length.each_value(&:freeze)
+      @candidates_by_length.each_value { |classes| classes.sort_by!(&:detection_priority).freeze }
     end
 
     # @param input [String]
@@ -118,18 +118,23 @@ module SecID
       return unless best
 
       end_pos = start_pos + raw.length
-      Match.new(type: best.type_key, raw: raw, range: start_pos...end_pos, identifier: best.new(cleaned))
+      Match.new(type: best.class.type_key, raw: raw, range: start_pos...end_pos, identifier: best)
     end
 
-    # @return [Class, nil]
+    # @return [Base, nil]
     def best_match(cleaned, classes)
       return if classes.empty?
 
-      candidates = (@candidates_by_length[cleaned.length] || []) & classes
-      return if candidates.empty?
+      candidates = @candidates_by_length[cleaned.length]
+      return unless candidates
 
-      validated = candidates.select { |k| cleaned.match?(k::VALID_CHARS_REGEX) && k.valid?(cleaned) }
-      validated.min_by(&:detection_priority)
+      candidates.each do |klass|
+        next unless classes.include?(klass) && cleaned.match?(klass::VALID_CHARS_REGEX)
+
+        instance = klass.new(cleaned)
+        return instance if instance.valid?
+      end
+      nil
     end
   end
 end

data/lib/sec_id/version.rb

@@ -2,5 +2,5 @@
 
 module SecID
   # Current gem version.
-  VERSION = '7.1.1'
+  VERSION = '8.0.1'
 end

data/lib/sec_id.rb

@@ -17,10 +17,6 @@ module SecID
   # Raised when the checksum does not match the calculated value.
   class InvalidChecksumError < Error; end
 
-  # @deprecated Use {InvalidChecksumError}. Kept as a v7 bridge (same class object,
-  #   so `rescue` under either name keeps working); removed in v8.
-  InvalidCheckDigitError = InvalidChecksumError
-
   # Raised for type-specific structural errors (invalid prefix, category, group, BBAN, or date).
   class InvalidStructureError < Error; end
 
@@ -233,7 +229,6 @@ module SecID
   end
 end
 
-require 'sec_id/deprecation'
 require 'sec_id/deep_freeze'
 require 'sec_id/errors'
 require 'sec_id/concerns/normalizable'

data/sec_id.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/svyatov/sec_id'
   spec.license       = 'MIT'
 
-  spec.required_ruby_version = '>= 3.2.0'
+  spec.required_ruby_version = '>= 3.3.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir['lib/**/*.rb'] + Dir['sig/**/*'] +

data/sig/sec_id/base.rbs

@@ -47,9 +47,6 @@ module SecID
     # module-level `SecID.suggest` can call it on any registered class object.
     def self.suggest: (SecID::input str) -> Array[Suggestion]
 
-    # @deprecated v7 bridge alias for `has_checksum?`; removed in v8.
-    def self.has_check_digit?: () -> bool
-
     def self.inherited: (singleton(Base) subclass) -> void
 
     def initialize: (SecID::input _sec_id_number) -> void
@@ -75,7 +72,6 @@ module SecID
 
     private
 
-    def components_with_deprecation_bridge: () -> Hash[Symbol, untyped]
     def components: () -> Hash[Symbol, untyped]
     def parse: (SecID::input sec_id_number) -> (::MatchData | ::Hash[Symbol, untyped])
 

data/sig/sec_id/cei.rbs

@@ -17,10 +17,6 @@ module SecID
     def initialize: (SecID::input cei) -> void
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
 
     private

data/sig/sec_id/cfi/attribute_set.rbs

@@ -12,8 +12,8 @@ module SecID
               | () -> Enumerator[Field, self]
       def []: (Symbol meaning) -> Field?
       def empty?: () -> bool
-      def to_h: () -> Hash[untyped, untyped]
-      def as_json: (*untyped) -> Hash[Symbol, untyped]
+      def to_h: () -> Hash[Symbol, Hash[Symbol, untyped]]
+      def as_json: (*untyped) -> Hash[Symbol, Hash[Symbol, untyped]]
 
       # Per-meaning readers — the union of every attribute meaning. Each instance
       # only answers the meanings actually present; an absent one raises

data/sig/sec_id/concerns/checkable.rbs

@@ -1,8 +1,10 @@
 module SecID
   # Provides checksum validation and calculation for identifiers with a checksum.
   module Checkable : SecID::Base
-    CHAR_TO_DIGITS: Hash[String, Integer | Array[Integer]]
     CHAR_TO_DIGIT: Hash[String, Integer]
+    BYTE_TO_DIGIT: Hash[Integer, Integer]
+    DECIMAL_VALUES: Hash[String, String]
+    LUHN_DOUBLE: Array[Integer]
 
     def self.included: (Module base) -> void
 
@@ -15,8 +17,6 @@ module SecID
       def restore!: (SecID::input id_without_checksum) -> Base
       def checksum: (SecID::input id) -> (Integer | String)
 
-      # @deprecated v7 bridge alias for `checksum`; removed in v8.
-      def check_digit: (SecID::input id) -> (Integer | String)
     end
 
     def valid?: () -> bool
@@ -25,19 +25,12 @@ module SecID
     def calculate_checksum: () -> (Integer | String)
     def to_s: () -> String
 
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def check_digit: () -> (Integer | String)?
-
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> (Integer | String)
-
     private
 
-    def luhn_sum_double_add_double: (Array[Integer] digits) -> Integer
-    def luhn_sum_indexed: (Array[Integer] digits) -> Integer
-    def luhn_sum_standard: (Array[Integer] digits) -> Integer
-    def reversed_digits_single: (untyped id) -> Array[Integer]
-    def reversed_digits_multi: (untyped id) -> Array[Integer]
+    # Readers are nilable before validation. The callers validate first; local
+    # annotations keep the byte traversal typed without adding runtime guards.
+    def luhn_sum_single: (untyped id, ?double_first: bool) -> Integer
+    def luhn_sum_standard: (untyped id) -> Integer
     def error_codes: () -> Array[Symbol]
     def checksum_width: () -> Integer
     def validation_message: (Symbol code) -> String?

data/sig/sec_id/cusip.rbs

@@ -18,10 +18,6 @@ module SecID
     def to_pretty_s: () -> String?
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
     def to_isin: (String country_code) -> ISIN
     def cins?: () -> bool

data/sig/sec_id/detector.rbs

@@ -11,7 +11,7 @@ module SecID
     private
 
     def filter_candidates: (String upcased) -> Array[singleton(Base)]
-    def validate_and_sort: (String input, Array[untyped] candidates) -> Array[Symbol]
+    def valid_types: (String input, Array[untyped] candidates) -> Array[Symbol]
     def precompute: () -> void
     def build_discriminator_sets: () -> void
     def build_length_table: () -> void

data/sig/sec_id/dti.rbs

@@ -17,10 +17,6 @@ module SecID
     def initialize: (SecID::input dti) -> void
     def calculate_checksum: () -> String
     def self.checksum: (SecID::input id) -> String
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> String
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> String
     private def self.generate_body: (Random random) -> String
 
     private

data/sig/sec_id/figi.rbs

@@ -19,10 +19,6 @@ module SecID
     def to_pretty_s: () -> String?
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
 
     private

data/sig/sec_id/iban.rbs

@@ -28,10 +28,6 @@ module SecID
     def restore: () -> String
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
     def valid_bban_format?: () -> bool
     def country_rule: () -> rule?

data/sig/sec_id/isin.rbs

@@ -21,10 +21,6 @@ module SecID
     def to_pretty_s: () -> String?
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
     def to_cusip: () -> CUSIP
     def cgs?: () -> bool

data/sig/sec_id/lei.rbs

@@ -22,10 +22,6 @@ module SecID
     def to_pretty_s: () -> String?
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
 
     private

data/sig/sec_id/scanner.rbs

@@ -33,7 +33,7 @@ module SecID
     def scan_text: (String input, Array[singleton(Base)] target_classes) { (Match) -> void } -> void
     def identify_candidate: (untyped match_data, Array[singleton(Base)] target_classes) -> Match?
     def try_classes: (String raw, String cleaned, Integer start_pos, Array[singleton(Base)] classes) -> Match?
-    def best_match: (String cleaned, Array[singleton(Base)] classes) -> singleton(Base)?
+    def best_match: (String cleaned, Array[singleton(Base)] classes) -> Base?
 
     @classes: Array[singleton(Base)]
     @fisn_classes: Array[singleton(Base)]

data/sig/sec_id/sedol.rbs

@@ -21,10 +21,6 @@ module SecID
     def to_isin: (?String country_code) -> ISIN
     def calculate_checksum: () -> Integer
     def self.checksum: (SecID::input id) -> Integer
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> Integer
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> Integer
     private def self.generate_body: (Random random) -> String
 
     private

data/sig/sec_id/upi.rbs

@@ -16,10 +16,6 @@ module SecID
     def initialize: (SecID::input upi) -> void
     def calculate_checksum: () -> String
     def self.checksum: (SecID::input id) -> String
-    # @deprecated v7 bridge alias for `calculate_checksum`; removed in v8.
-    def calculate_check_digit: () -> String
-    # @deprecated v7 bridge alias for `checksum`; removed in v8.
-    def self.check_digit: (SecID::input id) -> String
     private def self.generate_body: (Random random) -> String
 
     private

data/sig/sec_id.rbs

@@ -11,9 +11,6 @@ module SecID
   class InvalidChecksumError < Error
   end
 
-  # @deprecated v7 bridge constant alias for `InvalidChecksumError` (same class object); removed in v8.
-  InvalidCheckDigitError: singleton(InvalidChecksumError)
-
   # Raised for type-specific structural errors.
   class InvalidStructureError < Error
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sec_id
 version: !ruby/object:Gem::Version
-  version: 7.1.1
+  version: 8.0.1
 platform: ruby
 authors:
 - Leonid Svyatov
@@ -46,7 +46,6 @@ files:
 - lib/sec_id/concerns/validatable.rb
 - lib/sec_id/cusip.rb
 - lib/sec_id/deep_freeze.rb
-- lib/sec_id/deprecation.rb
 - lib/sec_id/detector.rb
 - lib/sec_id/dti.rb
 - lib/sec_id/errors.rb
@@ -85,7 +84,6 @@ files:
 - sig/sec_id/concerns/validatable.rbs
 - sig/sec_id/cusip.rbs
 - sig/sec_id/deep_freeze.rbs
-- sig/sec_id/deprecation.rbs
 - sig/sec_id/detector.rbs
 - sig/sec_id/dti.rbs
 - sig/sec_id/errors.rbs
@@ -119,14 +117,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: 'A Ruby toolkit for securities identifiers: validate, parse, normalize, detect,
   convert, generate, classify, and repair.'

data/lib/sec_id/deprecation.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-module SecID
-  # Emits standardized, silenceable deprecation warnings for the v7 → v8 rename
-  # bridge. Stateless: warns on every call with no per-call-site dedup, so the
-  # migration signal is never suppressed by default.
-  #
-  # The warning is written via {Kernel#warn} at Ruby's default verbosity — it is
-  # visible unless the process runs with `-W0` / `$VERBOSE = nil`. No `category:`
-  # is passed, because `Warning[:deprecated]` defaults to `false` and would hide
-  # the bridge warning the rename relies on.
-  module Deprecation
-    # Emits a standardized deprecation warning for a renamed API name.
-    #
-    # @param old [String] the deprecated name
-    # @param new [String] the canonical replacement name
-    # @param removed_in [String] the version that removes the deprecated name
-    # @return [void]
-    def self.warn(old:, new:, removed_in: 'v8')
-      Kernel.warn(
-        "SecID: `#{old}` is deprecated and will be removed in #{removed_in}; use `#{new}` instead.",
-        uplevel: 2
-      )
-    end
-  end
-end

data/sig/sec_id/deprecation.rbs

@@ -1,6 +0,0 @@
-module SecID
-  # Emits standardized, silenceable deprecation warnings for the v7 → v8 rename bridge.
-  module Deprecation
-    def self.warn: (old: String, new: String, ?removed_in: String) -> void
-  end
-end