sec_id 7.1.1 → 8.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be4a59e18a04226f78492df3eb2ec1318af8e7c99044005bda0f7b9652ac7a33
-  data.tar.gz: 6edd9226b4cc7b293a7fe1950f32aa0673ea0b44507b36ecc253da98f372d3c2
+  metadata.gz: 070e9688322c11aee220661a15bdc3a6feffeeda6a4d5859620e1e49ef948d0e
+  data.tar.gz: 218328185fb31b121fc9fa36cbb2f0d20d7f81542e41e0cab9a453b4e66f366a
 SHA512:
-  metadata.gz: b4b95d04179e0aee0ff4c45dbc2e169a024d3933a2c8234de2319422d19773d34247d83b8f457317af93d536ac431406fca9455a454cc7159ae2a9bad8982955
-  data.tar.gz: f479c160b3229763197b1ac1fe3b7d67f8a6fc3281d3607adf59fece50e89cc8dd2160eb2d4f94d32954d136bc2e8c8998b19bfcdf1e24f4e32a2a035f9e972a
+  metadata.gz: 027535125c743f70d1748956f39530df76f9c537de9b2547d800c55e34ded2d8125c5a3b067edf16016c1aa88eca73ea7cb9567372f1a1875868549969fb620f
+  data.tar.gz: 8f3345512540d6a5bfd2edbe436a44948e5c4a45a87a7637462467642b4fcacb590c4f37f675c71d8a38bf8f96f054af9191c2ff84c8798bc0bceff8b8d4a295

data/CHANGELOG.md

@@ -8,6 +8,24 @@ and [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/).
 
 ## [Unreleased]
 
+## [8.0.0] - 2026-10-30
+
+### Added
+
+- Lefthook Git hooks for staged secret scanning, Ruby autocorrection, whitespace, commit messages, tests, types, and documentation coverage.
+- CI checks library CRAP scores with crap4ruby and fresh test coverage, with a maximum score of 10.
+
+### Changed
+
+- Reduce detector allocations by sorting candidate types once and stopping parsing at the first valid match. Unsupported input lengths no longer grow the detector cache.
+- Reduce LEI and IBAN checksum allocations by reusing decimal expansions and preserving IBAN numeric characters.
+- Reduce scanner allocations by sorting candidate types once, stopping at the first valid type, and reusing the validated instance.
+- Reduce temporary allocations in ISIN, CUSIP, CEI, and FIGI checksum calculations by processing ASCII bytes directly.
+- Refresh development dependencies, all four lockfiles, and GitHub Actions for frozen CI installs.
+
+- **BREAKING:** Minimum Ruby version raised from 3.2 to 3.3 (Ruby 3.2 reached EOL on 2026-03-31)
+- RBS: `SecID::CFI::AttributeSet#to_h` and `#as_json` are now typed `Hash[Symbol, Hash[Symbol, untyped]]` instead of `Hash[untyped, untyped]` (Steep 2.1 tuple inference)
+
 ## [7.1.1] - 2026-07-31
 
 Documentation and packaging only. No identifier, checksum, or public method changed.
@@ -285,7 +303,8 @@ Gem metadata only: corrected the gemspec description and README wording. No libr
 
 - ISIN numbers support: `SecID::ISIN`
 
-[Unreleased]: https://github.com/svyatov/sec_id/compare/v7.1.1...HEAD
+[Unreleased]: https://github.com/svyatov/sec_id/compare/v8.0.0...HEAD
+[8.0.0]: https://github.com/svyatov/sec_id/compare/v7.1.1...v8.0.0
 [7.1.1]: https://github.com/svyatov/sec_id/compare/v7.1.0...v7.1.1
 [7.1.0]: https://github.com/svyatov/sec_id/compare/v7.0.0...v7.1.0
 [7.0.0]: https://github.com/svyatov/sec_id/compare/v6.1.0...v7.0.0

data/README.md

@@ -6,7 +6,7 @@ A Ruby toolkit for securities identifiers: validate, parse, normalize, detect, c
 
 - **Nothing to call, nothing to sign up for.** SecID validates all 16 identifier standards offline. No registry lookup, no API key, no network call anywhere in [`lib/`](lib/).
 - **9 of the 16 carry a checksum.** SecID validates it, restores a missing one, and repairs a wrong one.
-- **Zero runtime dependencies.** Runs on Ruby 3.2 or newer.
+- **Zero runtime dependencies.** Runs on Ruby 3.3 or newer.
 - **Rails, if you want it.** An opt-in ActiveModel validator adds `validates :isin, sec_id: true`. It stays off the default require path, so the dependency count stays at zero.
 - **Typed.** Ships RBS signatures for the whole public API, checked by Steep in strict mode.
 
@@ -50,14 +50,14 @@ A Ruby toolkit for securities identifiers: validate, parse, normalize, detect, c
 
 ## Supported Ruby versions
 
-Ruby 3.2+ is required.
+Ruby 3.3+ is required.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'sec_id', '~> 7.1'
+gem 'sec_id', '~> 8.0'
 ```
 
 And then execute:
@@ -922,10 +922,26 @@ committed signatures fall out of sync with the tables.
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies.
+Install [Betterleaks](https://github.com/betterleaks/betterleaks) and make its `betterleaks` command available on your `PATH`.
+After checking out the repo, run `bin/setup` to install dependencies and Git hooks.
 Then run `bundle exec rake` to run RuboCop, validate the RBS signatures, and run the specs.
 `bin/console` gives you an interactive prompt to experiment in.
 
+Pre-commit scans staged changes for secrets and whitespace errors, and safely corrects staged Ruby files with RuboCop.
+Corrected Ruby files are staged automatically.
+Pre-push runs static type checks, type coverage, specs, runtime signature checks, and documentation coverage.
+Commit messages must follow Conventional Commits.
+Put personal hook overrides in the ignored `lefthook-local.yml` file.
+
+Run all pre-push jobs manually with `bundle exec lefthook run pre-push`.
+
+CI checks library methods with [crap4ruby](https://github.com/svyatov/crap4ruby), using fresh test coverage and a maximum CRAP score of 10.
+Run the same check locally:
+
+```sh
+COVERAGE=1 bundle exec rake spec crap
+```
+
 To use your working copy from another project, point its Gemfile at the checkout:
 `gem 'sec_id', path: '/path/to/sec_id'`.
 
@@ -941,6 +957,12 @@ One person actively maintains SecID. They read bug reports and pull requests, an
 
 Bug reports and pull requests are welcome on [GitHub](https://github.com/svyatov/sec_id). See [CONTRIBUTING.md](CONTRIBUTING.md) for development setup, code style, and PR guidelines.
 
+For checksum throughput and allocation comparisons, run `ruby -Ilib benchmark/checksums.rb`. It covers Luhn checksums, LEI, and IBAN, including numeric and letter-heavy inputs. It prints repeated samples as JSON with garbage collection enabled. Run the same script with `-I/path/to/baseline/lib` to compare another checkout on the same Ruby version.
+
+For scanner comparisons, run `ruby -Ilib benchmark/scanner.rb`. It measures paragraphs, dense identifiers, noise, type filters, ambiguous identifiers, and compound patterns. JSON output includes matches to check correctness alongside timings and allocations. Use the same baseline option to compare another checkout.
+
+For detection and parsing comparisons, run `ruby -Ilib benchmark/detector.rb`. It measures valid identifiers, ambiguous inputs, invalid checksums, and unsupported lengths. JSON output includes results, timings, and allocations with garbage collection enabled. Use the same baseline option to compare another checkout.
+
 This project follows the [Contributor Covenant Code of Conduct](CODE_OF_CONDUCT.md).
 
 ## Changelog

data/lib/sec_id/bic/country_codes.rb

@@ -10,7 +10,7 @@ module SecID
     #
     # @api private
     # @see https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2
-    # rubocop:disable Metrics/CollectionLiteralLength
+    # rubocop:disable-next Metrics/CollectionLiteralLength
     COUNTRY_CODES = Set.new(
       %w[
         AD AE AF AG AI AL AM AO AQ AR AS AT AU AW AX AZ
@@ -41,6 +41,5 @@ module SecID
         XK
       ]
     ).freeze
-    # rubocop:enable Metrics/CollectionLiteralLength
   end
 end

data/lib/sec_id/cei.rb

@@ -55,7 +55,7 @@ module SecID
     # @raise [InvalidFormatError] if the CEI format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_double_add_double(reversed_digits_single(identifier)))
+      mod10(luhn_sum_single(identifier))
     end
 
     # Generates a random CEI body: 1 letter + 1 digit + 7 alphanumeric characters.

data/lib/sec_id/cfi/attribute_set.rb

@@ -36,8 +36,11 @@ module SecID
       end
 
       # @return [Hash{Symbol => Hash}]
+      # @raise [ArgumentError] if a field has no meaning (category/group fields; never the case for attributes)
       def to_h
-        @fields.to_h { |field| [field.meaning, field.to_h] }
+        @fields.to_h do |field|
+          [field.meaning || raise(ArgumentError, "attribute field #{field.code} has no meaning"), field.to_h]
+        end
       end
 
       # @return [Hash{Symbol => Hash}]

data/lib/sec_id/cfi/tables.rb

@@ -21,7 +21,7 @@ module SecID
     # +:not_applicable+, so it is never listed in a value map.
     #
     # @api private
-    # rubocop:disable Metrics/ModuleLength
+    # rubocop:disable-next Metrics/ModuleLength
     module Tables
       # Marker for a pure not-applicable attribute position (accepts only +X+).
       NA = nil
@@ -1028,6 +1028,5 @@ module SecID
         GROUPS.dig(category_code, group_code)
       end
     end
-    # rubocop:enable Metrics/ModuleLength
   end
 end

data/lib/sec_id/concerns/checkable.rb

@@ -22,26 +22,12 @@ module SecID
   #
   #     def calculate_checksum
   #       validate_format_for_calculation!
-  #       mod10(luhn_sum_standard(reversed_digits_multi(identifier)))
+  #       mod10(luhn_sum_standard(identifier))
   #     end
   #   end
   #
   # @see https://en.wikipedia.org/wiki/Luhn_algorithm
   module Checkable
-    # Character-to-digit mapping for Luhn algorithm variants.
-    # Maps alphanumeric characters to digit arrays for multi-digit expansion.
-    # Used by ISIN for checksum calculation.
-    CHAR_TO_DIGITS = {
-      '0' => 0,      '1' => 1,      '2' => 2,      '3' => 3,      '4' => 4,
-      '5' => 5,      '6' => 6,      '7' => 7,      '8' => 8,      '9' => 9,
-      'A' => [1, 0], 'B' => [1, 1], 'C' => [1, 2], 'D' => [1, 3], 'E' => [1, 4],
-      'F' => [1, 5], 'G' => [1, 6], 'H' => [1, 7], 'I' => [1, 8], 'J' => [1, 9],
-      'K' => [2, 0], 'L' => [2, 1], 'M' => [2, 2], 'N' => [2, 3], 'O' => [2, 4],
-      'P' => [2, 5], 'Q' => [2, 6], 'R' => [2, 7], 'S' => [2, 8], 'T' => [2, 9],
-      'U' => [3, 0], 'V' => [3, 1], 'W' => [3, 2], 'X' => [3, 3], 'Y' => [3, 4], 'Z' => [3, 5],
-      '*' => [3, 6], '@' => [3, 7], '#' => [3, 8]
-    }.freeze
-
     # Character-to-digit mapping for single-digit conversion.
     # Maps alphanumeric characters to values 0-38 (A=10, B=11, ..., Z=35, *=36, @=37, #=38).
     # Used by CUSIP, FIGI, SEDOL, LEI, and IBAN for checksum calculations.
@@ -56,6 +42,15 @@ module SecID
       '*' => 36, '@' => 37, '#' => 38
     }.freeze
 
+    # ASCII byte lookup avoids allocating a String for each checksum character.
+    BYTE_TO_DIGIT = CHAR_TO_DIGIT.transform_keys(&:ord).freeze
+
+    # Decimal expansions reused by LEI and IBAN without allocating replacement strings.
+    DECIMAL_VALUES = CHAR_TO_DIGIT.transform_values { |value| value.to_s.freeze }.freeze
+
+    # Doubled decimal digits with their digits summed, for expanded ISIN Luhn.
+    LUHN_DOUBLE = [0, 2, 4, 6, 8, 1, 3, 5, 7, 9].freeze
+
     # Extends the including identifier class with the concern's class methods and checksum reader.
     #
     # @param base [Class] the identifier class including this concern
@@ -162,61 +157,46 @@ module SecID
 
     private
 
-    # CUSIP/CEI style: "Double Add Double" algorithm.
-    # Processes pairs of digits, doubling the first (even-positioned from right),
-    # then summing both digit's div10mod10 values.
-    #
-    # @param digits [Array<Integer>] reversed array of digit values
-    # @return [Integer] the Luhn sum
-    def luhn_sum_double_add_double(digits)
-      digits.each_slice(2).reduce(0) do |sum, (even, odd)|
-        double_even = (even || 0) * 2
-        sum + div10mod10(double_even) + div10mod10(odd || 0)
-      end
-    end
-
-    # FIGI style: index-based doubling algorithm.
-    # Doubles odd-indexed digits (from right), then sums div10mod10 values.
+    # CUSIP/CEI double the rightmost body character; FIGI starts one position left.
+    # Input must already have passed the identifier's ASCII format validation.
     #
-    # @param digits [Array<Integer>] reversed array of digit values
+    # @param id [String] validated identifier body
+    # @param double_first [Boolean] whether to double the rightmost value
     # @return [Integer] the Luhn sum
-    def luhn_sum_indexed(digits)
-      digits.each_with_index.reduce(0) do |sum, (digit, index)|
-        digit *= 2 if index.odd?
-        sum + div10mod10(digit)
+    def luhn_sum_single(id, double_first: true)
+      # @type var id: String
+      sum = 0
+      double = double_first
+      (id.bytesize - 1).downto(0) do |index|
+        value = BYTE_TO_DIGIT.fetch(id.getbyte(index))
+        value *= 2 if double
+        sum += div10mod10(value)
+        double = !double
       end
+      sum
     end
 
-    # ISIN style: standard Luhn with subtract-9 for values > 9.
-    # Processes pairs of digits, doubling the first (even-positioned from right),
-    # subtracting 9 if result > 9.
+    # ISIN expands letters into two decimal digits before applying Luhn.
+    # A letter consumes two positions, so only a numeric character flips parity.
     #
-    # @param digits [Array<Integer>] reversed array of digit values
+    # @param id [String] validated identifier body
     # @return [Integer] the Luhn sum
-    def luhn_sum_standard(digits)
-      digits.each_slice(2).reduce(0) do |sum, (even, odd)|
-        double_even = (even || 0) * 2
-        double_even -= 9 if double_even > 9
-        sum + double_even + (odd || 0)
+    def luhn_sum_standard(id)
+      # @type var id: String
+      sum = 0
+      double = true
+      (id.bytesize - 1).downto(0) do |index|
+        value = BYTE_TO_DIGIT.fetch(id.getbyte(index))
+        units = value % 10
+        sum += double ? LUHN_DOUBLE.fetch(units) : units
+        if value >= 10
+          tens = value / 10
+          sum += double ? tens : LUHN_DOUBLE.fetch(tens)
+        else
+          double = !double
+        end
       end
-    end
-
-    # Converts identifier characters to reversed digit array using single-digit mapping.
-    # Used by CUSIP, CEI, FIGI, and SEDOL.
-    #
-    # @param id [String] the identifier string
-    # @return [Array<Integer>] reversed array of digit values
-    def reversed_digits_single(id)
-      id.each_char.map { |c| CHAR_TO_DIGIT.fetch(c) }.reverse!
-    end
-
-    # Converts identifier characters to reversed digit array using multi-digit mapping.
-    # Used by ISIN where letters expand to two digits.
-    #
-    # @param id [String] the identifier string
-    # @return [Array<Integer>] reversed array of digit values
-    def reversed_digits_multi(id)
-      id.each_char.flat_map { |c| CHAR_TO_DIGITS.fetch(c) }.reverse!
+      sum
     end
 
     # Returns error codes including checksum validation.

data/lib/sec_id/cusip.rb

@@ -61,7 +61,7 @@ module SecID
     # @raise [InvalidFormatError] if the CUSIP format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_double_add_double(reversed_digits_single(identifier)))
+      mod10(luhn_sum_single(identifier))
     end
 
     # Generates a random CUSIP body: 8 alphanumeric characters.

data/lib/sec_id/detector.rb

@@ -19,7 +19,7 @@ module SecID
   class Detector
     # @param identifier_list [Array<Class>] registered identifier classes
     def initialize(identifier_list)
-      @classes = identifier_list.dup.freeze
+      @classes = identifier_list.sort_by(&:detection_priority).freeze
       precompute
     end
 
@@ -33,7 +33,7 @@ module SecID
 
       upcased = input.upcase
       candidates = filter_candidates(upcased)
-      validate_and_sort(input, candidates)
+      valid_types(input, candidates)
     end
 
     # Returns whether any registered type matches, short-circuiting on the first
@@ -57,8 +57,11 @@ module SecID
       return if input.empty?
 
       candidates = filter_candidates(input.upcase)
-      matches = candidates.filter_map { |klass| (i = klass.new(input)).valid? ? i : nil }
-      matches.min_by { |instance| instance.class.detection_priority }
+      candidates.each do |klass|
+        instance = klass.new(input)
+        return instance if instance.valid?
+      end
+      nil
     end
 
     private
@@ -74,14 +77,13 @@ module SecID
       stage3_charset(upcased, candidates)
     end
 
-    # Validates candidates and returns sorted symbol keys.
+    # Validates candidates in precomputed specificity order.
     #
     # @param input [String]
     # @param candidates [Array<Class>]
     # @return [Array<Symbol>]
-    def validate_and_sort(input, candidates)
+    def valid_types(input, candidates)
       matches = candidates.select { |klass| klass.valid?(input) }
-      matches.sort_by!(&:detection_priority)
       matches.map!(&:type_key)
     end
 
@@ -105,11 +107,12 @@ module SecID
     #
     # @return [void]
     def build_length_table
-      @candidates_by_length = Hash.new { |h, k| h[k] = [] }
+      @candidates_by_length = {}
       @classes.each do |klass|
-        klass.length_values.each { |len| @candidates_by_length[len] << klass }
+        klass.length_values.each { |len| (@candidates_by_length[len] ||= []) << klass }
       end
       @candidates_by_length.each_value(&:freeze)
+      @candidates_by_length.default = [].freeze
     end
 
     # Stage 1: route strings with special characters to the only types that accept them.
@@ -130,7 +133,7 @@ module SecID
     # @param length [Integer]
     # @return [Array<Class>]
     def stage2_length(length)
-      @candidates_by_length[length] || []
+      @candidates_by_length[length]
     end
 
     # Stage 3: filter candidates by character set.

data/lib/sec_id/figi.rb

@@ -69,7 +69,7 @@ module SecID
     # @raise [InvalidFormatError] if the FIGI format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_indexed(reversed_digits_single(identifier)))
+      mod10(luhn_sum_single(identifier, double_first: false))
     end
 
     # Generates a random FIGI body: non-reserved 2-char prefix + 'G' + 8-char random part.

data/lib/sec_id/iban/country_rules.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module SecID
-  # rubocop:disable Metrics/ClassLength
+  # rubocop:disable-next Metrics/ClassLength
   class IBAN < Base
     # Country-specific BBAN rules for EU/EEA countries
     # Each entry defines:
@@ -265,5 +265,4 @@ module SecID
       'XK' => 16  # Kosovo
     }.freeze
   end
-  # rubocop:enable Metrics/ClassLength
 end

data/lib/sec_id/iban.rb

@@ -226,7 +226,7 @@ module SecID
 
     # @return [String] the numeric string representation
     def numeric_string_for_check
-      "#{bban}#{country_code}00".each_char.map { |char| CHAR_TO_DIGIT.fetch(char) }.join
+      "#{bban}#{country_code}00".gsub(/[^0-9]/) { |char| DECIMAL_VALUES.fetch(char) }
     end
   end
 end

data/lib/sec_id/isin.rb

@@ -86,7 +86,7 @@ module SecID
     # @raise [InvalidFormatError] if the ISIN format is invalid
     def calculate_checksum
       validate_format_for_calculation!
-      mod10(luhn_sum_standard(reversed_digits_multi(identifier)))
+      mod10(luhn_sum_standard(identifier))
     end
 
     # Generates a random ISIN body: 2-letter country code + 9-character NSIN.

data/lib/sec_id/lei.rb

@@ -90,7 +90,7 @@ module SecID
 
     # @return [String] the numeric string representation
     def numeric_identifier
-      identifier.each_char.map { |char| CHAR_TO_DIGIT.fetch(char) }.join
+      identifier.each_char.with_object(+'') { |char, numeric| numeric << DECIMAL_VALUES.fetch(char) }
     end
   end
 end

data/lib/sec_id/scanner.rb

@@ -73,7 +73,7 @@ module SecID
       @classes.each do |klass|
         klass.length_values.each { |len| @candidates_by_length[len] << klass }
       end
-      @candidates_by_length.each_value(&:freeze)
+      @candidates_by_length.each_value { |classes| classes.sort_by!(&:detection_priority).freeze }
     end
 
     # @param input [String]
@@ -118,18 +118,23 @@ module SecID
       return unless best
 
       end_pos = start_pos + raw.length
-      Match.new(type: best.type_key, raw: raw, range: start_pos...end_pos, identifier: best.new(cleaned))
+      Match.new(type: best.class.type_key, raw: raw, range: start_pos...end_pos, identifier: best)
     end
 
-    # @return [Class, nil]
+    # @return [Base, nil]
     def best_match(cleaned, classes)
       return if classes.empty?
 
-      candidates = (@candidates_by_length[cleaned.length] || []) & classes
-      return if candidates.empty?
+      candidates = @candidates_by_length[cleaned.length]
+      return unless candidates
 
-      validated = candidates.select { |k| cleaned.match?(k::VALID_CHARS_REGEX) && k.valid?(cleaned) }
-      validated.min_by(&:detection_priority)
+      candidates.each do |klass|
+        next unless classes.include?(klass) && cleaned.match?(klass::VALID_CHARS_REGEX)
+
+        instance = klass.new(cleaned)
+        return instance if instance.valid?
+      end
+      nil
     end
   end
 end

data/lib/sec_id/version.rb

@@ -2,5 +2,5 @@
 
 module SecID
   # Current gem version.
-  VERSION = '7.1.1'
+  VERSION = '8.0.0'
 end

data/sec_id.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/svyatov/sec_id'
   spec.license       = 'MIT'
 
-  spec.required_ruby_version = '>= 3.2.0'
+  spec.required_ruby_version = '>= 3.3.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir['lib/**/*.rb'] + Dir['sig/**/*'] +

data/sig/sec_id/cfi/attribute_set.rbs

@@ -12,8 +12,8 @@ module SecID
               | () -> Enumerator[Field, self]
       def []: (Symbol meaning) -> Field?
       def empty?: () -> bool
-      def to_h: () -> Hash[untyped, untyped]
-      def as_json: (*untyped) -> Hash[Symbol, untyped]
+      def to_h: () -> Hash[Symbol, Hash[Symbol, untyped]]
+      def as_json: (*untyped) -> Hash[Symbol, Hash[Symbol, untyped]]
 
       # Per-meaning readers — the union of every attribute meaning. Each instance
       # only answers the meanings actually present; an absent one raises

data/sig/sec_id/concerns/checkable.rbs

@@ -1,8 +1,10 @@
 module SecID
   # Provides checksum validation and calculation for identifiers with a checksum.
   module Checkable : SecID::Base
-    CHAR_TO_DIGITS: Hash[String, Integer | Array[Integer]]
     CHAR_TO_DIGIT: Hash[String, Integer]
+    BYTE_TO_DIGIT: Hash[Integer, Integer]
+    DECIMAL_VALUES: Hash[String, String]
+    LUHN_DOUBLE: Array[Integer]
 
     def self.included: (Module base) -> void
 
@@ -33,11 +35,10 @@ module SecID
 
     private
 
-    def luhn_sum_double_add_double: (Array[Integer] digits) -> Integer
-    def luhn_sum_indexed: (Array[Integer] digits) -> Integer
-    def luhn_sum_standard: (Array[Integer] digits) -> Integer
-    def reversed_digits_single: (untyped id) -> Array[Integer]
-    def reversed_digits_multi: (untyped id) -> Array[Integer]
+    # Readers are nilable before validation. The callers validate first; local
+    # annotations keep the byte traversal typed without adding runtime guards.
+    def luhn_sum_single: (untyped id, ?double_first: bool) -> Integer
+    def luhn_sum_standard: (untyped id) -> Integer
     def error_codes: () -> Array[Symbol]
     def checksum_width: () -> Integer
     def validation_message: (Symbol code) -> String?

data/sig/sec_id/detector.rbs

@@ -11,7 +11,7 @@ module SecID
     private
 
     def filter_candidates: (String upcased) -> Array[singleton(Base)]
-    def validate_and_sort: (String input, Array[untyped] candidates) -> Array[Symbol]
+    def valid_types: (String input, Array[untyped] candidates) -> Array[Symbol]
     def precompute: () -> void
     def build_discriminator_sets: () -> void
     def build_length_table: () -> void

data/sig/sec_id/scanner.rbs

@@ -33,7 +33,7 @@ module SecID
     def scan_text: (String input, Array[singleton(Base)] target_classes) { (Match) -> void } -> void
     def identify_candidate: (untyped match_data, Array[singleton(Base)] target_classes) -> Match?
     def try_classes: (String raw, String cleaned, Integer start_pos, Array[singleton(Base)] classes) -> Match?
-    def best_match: (String cleaned, Array[singleton(Base)] classes) -> singleton(Base)?
+    def best_match: (String cleaned, Array[singleton(Base)] classes) -> Base?
 
     @classes: Array[singleton(Base)]
     @fisn_classes: Array[singleton(Base)]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sec_id
 version: !ruby/object:Gem::Version
-  version: 7.1.1
+  version: 8.0.0
 platform: ruby
 authors:
 - Leonid Svyatov
@@ -119,14 +119,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: 'A Ruby toolkit for securities identifiers: validate, parse, normalize, detect,
   convert, generate, classify, and repair.'