searchlight 1.2.0 → 1.2.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmFhNGNkYmJmZDdmMjc5NjJjODI3NzZmN2Q0ODY5NjkyNzYwZjhiZQ==
+    ODNkY2NkZGFiNWQ2NzViZGEyNjE4MWY1OWE2ODcwZTY4YTFkMjVjMA==
   data.tar.gz: !binary |-
-    YzRlZTAyZTZiN2UzOTM3NWU1YTAyZGRkNDM1YjUwMTA0NTAxMGU4ZQ==
+    YTZlMGY2Njg4OTJmM2RmYTZkM2FhY2UxYWE3YzVlMDZmNjU2ODg4OQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZTY3MjgyOGI3Y2FjYTFhMzlhZGVhMGQyYmNiYTRmZDI1Nzc3MzY2YjU1Mzcw
-    M2Y4YjFmNDg3YmEzZmUyNWM0ZGYwOTNkZTYyODkyZGNmZTU4NTUyMWQwNmQ3
-    M2U3NDBkOTM4OTRhZGFiNTNhMDQxOTdlYmFiZTEwMTQ1MzlmYjI=
+    ZjhlNjgyNDExZjJhZDc1OGIwOTBlYzA2MTE3YmJmOGI3ZWUyNjFhODA2MzRk
+    NDU1YWMyMDRkNTg1MWU4MGFjMDRjMDE3NzkwZGJiNDcxMmZhODk5MjkzN2Q5
+    YTU2NmQyZDkyMmQ1ZmVlNzRmYWViYzRkMjYzYmJlZGRjNTdhODY=
   data.tar.gz: !binary |-
-    MDRkNDY3N2Y4Mzc4Mjc2NGZjOGYxYWZlMjc3MjZmYzM4ZmFlYTE0NzMyYWIy
-    YTQwZjhiNjQwM2I3OTI3Zjk3NTA4MzQ1ZTM1NTE3Mzk4NTliMDc1NWVkODRm
-    YzZmZTg0YmUzZDgzMDI3YjYzN2RmZjFiYTBiM2EwMmIyNTUyNzc=
+    M2VjMWJlZDRjZDQ2ZTBkZTg1YzBmMWJlNzk4NjA0YzJmZTNhNTVkMzE2OTUz
+    MWRjNmQ2YjU1NmZjNzE3NTA1ZjQwZTY5ODEwMTFjNjMzNTQ3NDM3MzJiZjBl
+    MjVmOTMzM2FkY2RkNjE3YzBjODExNjJmMjg0MmM1NDM4ZTVhZjY=

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 Searchlight does its best to use [semantic versioning](http://semver.org).
 
+## v1.2.1
+
+Bugfix for v1.2.0 - screen out from options any collections containing only blank values
+
 ## v1.2.0
 
 - Provide `options` accessor that returns all options considered non-blank

data/lib/searchlight/search.rb

@@ -64,7 +64,10 @@ module Searchlight
 
     # Note that false is not blank
     def is_blank?(value)
-      (value.respond_to?(:empty?) && value.empty?) || value.nil? || value.to_s.strip == ''
+      return true if value.respond_to?(:all?) && value.all? { |v| is_blank?(v) }
+      return true if value.respond_to?(:empty?) && value.empty?
+      return true if value.nil? || value.to_s.strip == ''
+      false
     end
 
     MissingSearchTarget = Class.new(Searchlight::Error)

data/lib/searchlight/version.rb

@@ -1,3 +1,3 @@
 module Searchlight
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/searchlight/search_spec.rb

@@ -25,7 +25,7 @@ describe Searchlight::Search do
 
       let(:allowed_options) { [:name, :description, :categories, :nicknames] }
 
-      context "when non-empty options are provided" do
+      context "when all options are usable" do
 
         let(:provided_options) { {name: 'Roy', description: 'Ornry', categories: %w[mammal moonshiner], nicknames: %w[Slim Bubba]} }
 
@@ -37,11 +37,10 @@ describe Searchlight::Search do
 
       context "when some provided options are empty" do
 
-        let(:provided_options) { {name: 'Roy', description: '', categories: %w[mammal moonshiner], nicknames: []} }
+        let(:provided_options) { {name: 'Roy', description: '', categories: ['', ''], nicknames: []} }
 
         it "does not add them to the options accessor" do
-          expect(search.options).to eq(name: 'Roy', categories: %w[mammal moonshiner])
-
+          expect(search.options).to eq(name: 'Roy')
         end
 
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: searchlight
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Nathan Long