searchable-by 0.5.2 → 0.5.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21e09cdcdb1a9bebd3df6bb7a28d4f4cfc566a478b757390ea7f71445f195edd
-  data.tar.gz: 3bad5ea302c2c46bceee3a966b298799c133d1c2db0ffecf6a4bd38bf5393ccc
+  metadata.gz: 9577dc443c9400afd9bb866e8a53a351cf1e56420ce28b140c184e6647689411
+  data.tar.gz: 6a84939c7bb80af91d31b6d6bb3fd65acd672a4b41fbc25dbe08664e74d1f58d
 SHA512:
-  metadata.gz: be511c786fae03cf6f37f392bc122446101ddb7dee1ed7af52bd1d21b92e4512d8493687baa9fa842aef5460f1b6d750f83f7ad9e54b30a2c74a42a8b14971b7
-  data.tar.gz: 8029a6c09870555dcf1d9235127ae1d8312e1cb226b93cf7428176f74efee991235158b2faf12b2b0dd7b7a83f7cfc705ffdfa9e2bb032edbcc8a65a6a0e2bd3
+  metadata.gz: 86367f8084de15d5d8e11568c1dadd5beddb090bf4dc4c334133197e15906e0bced5396a5c95f9434e6902d2ae0752698590f1b2fc1eacba26cb49a66a3e5697
+  data.tar.gz: ac9f4157b9a1705b50c95c9e1e3ee4f9c19b5ea7be9fec12a5a42df53eb0a2761a0c90c902dce641f15628ac48f2b3be4e1b504cfb36bebd6db00620dda4d787

data/.rubocop.yml

@@ -1,10 +1,13 @@
-require: rubocop-performance
-inherit_from:
-  - https://gitlab.com/bsm/misc/raw/master/rubocop/default.yml
+inherit_gem:
+  rubocop-bsm:
+    - default.yml
+inherit_mode:
+  merge:
+    - Exclude
 
 AllCops:
-  TargetRubyVersion: "2.4"
+  TargetRubyVersion: "2.6"
 
 Naming/FileName:
   Exclude:
-    - lib/searchable-by.rb
+    - lib/searchable-by.rb

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
+  - 3.0
+  - 2.7
   - 2.6
-  - 2.5
-  - 2.4
 cache: bundler
 before_install:
   - gem install bundler

data/Gemfile.lock

@@ -1,65 +1,86 @@
 PATH
   remote: .
   specs:
-    searchable-by (0.5.2)
+    searchable-by (0.5.8)
       activerecord
       activesupport
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activemodel (5.2.3)
-      activesupport (= 5.2.3)
-    activerecord (5.2.3)
-      activemodel (= 5.2.3)
-      activesupport (= 5.2.3)
-      arel (>= 9.0)
-    activesupport (5.2.3)
+    activemodel (6.1.1)
+      activesupport (= 6.1.1)
+    activerecord (6.1.1)
+      activemodel (= 6.1.1)
+      activesupport (= 6.1.1)
+    activesupport (6.1.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    arel (9.0.0)
-    ast (2.4.0)
-    concurrent-ruby (1.1.5)
-    diff-lcs (1.3)
-    i18n (1.6.0)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
+    concurrent-ruby (1.1.8)
+    diff-lcs (1.4.4)
+    i18n (1.8.8)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.3)
-    minitest (5.11.3)
-    parallel (1.17.0)
-    parser (2.6.3.0)
-      ast (~> 2.4.0)
+    minitest (5.14.3)
+    parallel (1.20.1)
+    parser (3.0.0.0)
+      ast (~> 2.4.1)
+    rack (2.2.3)
     rainbow (3.0.0)
-    rake (12.3.3)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.4)
+    rake (13.0.3)
+    regexp_parser (2.0.3)
+    rexml (3.2.4)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.2)
-    rubocop (0.73.0)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    rubocop (1.9.1)
       parallel (~> 1.10)
-      parser (>= 2.6)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-performance (1.4.0)
-      rubocop (>= 0.71.0)
-    ruby-progressbar (1.10.1)
-    sqlite3 (1.4.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.6.0)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    rubocop-bsm (0.5.4)
+      rubocop (~> 1.0)
+      rubocop-performance
+      rubocop-rails
+      rubocop-rake
+      rubocop-rspec
+    rubocop-performance (1.9.2)
+      rubocop (>= 0.90.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rails (2.9.1)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.90.0, < 2.0)
+    rubocop-rake (0.5.1)
+      rubocop
+    rubocop-rspec (2.2.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
+    sqlite3 (1.4.2)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.0.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
@@ -69,9 +90,9 @@ DEPENDENCIES
   rake
   rspec
   rubocop
-  rubocop-performance
+  rubocop-bsm
   searchable-by!
   sqlite3
 
 BUNDLED WITH
-   2.0.1
+   2.2.3

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright 2019 Black Square Media Ltd
+Copyright 2020 Black Square Media Ltd
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/README.md

@@ -14,8 +14,11 @@ class Post < ActiveRecord::Base
 
   # Limit the number of terms per query to 3.
   searchable_by max_terms: 3 do
-    # Allow to search strings.
-    column :title
+    # Allow to search strings with custom match type.
+    column :title,
+      match: :prefix,       # Use btree index-friendly prefix match, e.g. `ILIKE 'term%'` instead of default `ILIKE '%term%'`.
+      match_phrase: :exact, # For phrases use exact match type, e.g. searching for `"My Post"` will query `WHERE LOWER(title) = 'my post'`.
+      min_length: 3         # Return no-match if search term is too short (useful for trigram indexes).
 
     # ... and integers.
     column :id, type: :integer

data/lib/searchable_by.rb

@@ -1,132 +1,12 @@
 require 'active_record'
-require 'shellwords'
 
-module ActiveRecord
-  module SearchableBy
-    class Column
-      attr_reader :attr, :type
-      attr_accessor :node
+module SearchableBy
+  autoload :Column, 'searchable_by/column'
+  autoload :Concern, 'searchable_by/concern'
+  autoload :Config, 'searchable_by/config'
+  autoload :Util, 'searchable_by/util'
 
-      def initialize(attr, type: :string)
-        @attr = attr
-        @type = type.to_sym
-      end
-    end
-
-    class Config
-      attr_reader :columns, :scoping
-      attr_accessor :max_terms
-
-      def initialize
-        @columns = []
-        @max_terms = 5
-        scope { all }
-      end
-
-      def initialize_copy(other)
-        @columns = other.columns.dup
-        super
-      end
-
-      def column(*attrs, &block)
-        opts = attrs.extract_options!
-        attrs.each do |attr|
-          columns.push Column.new(attr, opts)
-        end
-        columns.push Column.new(block, opts) if block
-        columns
-      end
-
-      def scope(&block)
-        @scoping = block
-      end
-    end
-
-    def self.norm_values(query)
-      values = Shellwords.split(query.to_s)
-      values.flatten!
-      values.reject!(&:blank?)
-      values.uniq!
-      values
-    end
-
-    def self.build_clauses(columns, values)
-      clauses = values.map do |value|
-        negate = value[0] == '-'
-        value.slice!(0) if negate || value[0] == '+'
-
-        grouping = columns.map do |column|
-          build_condition(column, value)
-        end
-        grouping.compact!
-        next if grouping.empty?
-
-        clause = grouping.inject(&:or)
-        clause = clause.not if negate
-        clause
-      end
-      clauses.compact!
-      clauses
-    end
-
-    def self.build_condition(column, value)
-      case column.type
-      when :int, :integer
-        begin
-          column.node.not_eq(nil).and(column.node.eq(Integer(value)))
-        rescue ArgumentError
-          nil
-        end
-      else
-        value = value.dup
-        value.gsub!('%', '\%')
-        value.gsub!('_', '\_')
-        column.node.not_eq(nil).and(column.node.matches("%#{value}%"))
-      end
-    end
-
-    module ClassMethods
-      def self.extended(base) # :nodoc:
-        base.class_attribute :_searchable_by_config, instance_accessor: false, instance_predicate: false
-        base._searchable_by_config = Config.new
-        super
-      end
-
-      def inherited(base) # :nodoc:
-        base._searchable_by_config = _searchable_by_config.dup
-        super
-      end
-
-      def searchable_by(max_terms: 5, &block)
-        _searchable_by_config.instance_eval(&block)
-        _searchable_by_config.max_terms = max_terms if max_terms
-      end
-
-      # @param [String] query the search query
-      # @return [ActiveRecord::Relation] the scoped relation
-      def search_by(query)
-        columns = _searchable_by_config.columns
-        return all if columns.empty?
-
-        values = SearchableBy.norm_values(query).first(_searchable_by_config.max_terms)
-        return all if values.empty?
-
-        columns.each do |col|
-          col.node ||= col.attr.is_a?(Proc) ? col.attr.call : arel_table[col.attr]
-        end
-        clauses = SearchableBy.build_clauses(columns, values)
-        return all if clauses.empty?
-
-        scope = instance_exec(&_searchable_by_config.scoping)
-        clauses.each do |clause|
-          scope = scope.where(clause)
-        end
-        scope
-      end
-    end
-  end
-
-  class Base
-    extend SearchableBy::ClassMethods
-  end
+  Value = Struct.new(:term, :negate, :phrase)
 end
+
+ActiveRecord::Base.extend SearchableBy::Concern if defined?(::ActiveRecord::Base)

data/lib/searchable_by/column.rb

@@ -0,0 +1,54 @@
+module SearchableBy
+  class Column
+    attr_reader :attr, :type, :match, :match_phrase, :min_length
+    attr_accessor :node
+
+    def initialize(attr, type: :string, match: :all, match_phrase: nil, min_length: 0)
+      @attr  = attr
+      @type  = type.to_sym
+      @match = match
+      @match_phrase = match_phrase || match
+      @min_length = min_length
+    end
+
+    def build_condition(value)
+      return Arel::Nodes::False.new if value.term.length < min_length # no-match
+
+      scope = node.not_eq(nil)
+
+      case type
+      when :int, :integer
+        int_condition(scope, value)
+      else
+        str_condition(scope, value)
+      end
+    end
+
+    private
+
+    def int_condition(scope, value)
+      scope.and(node.eq(Integer(value.term)))
+    rescue ArgumentError
+      nil
+    end
+
+    def str_condition(scope, value)
+      term = value.term.dup
+      type = value.phrase ? match_phrase : match
+
+      case type
+      when :exact
+        term.downcase!
+        scope.and(node.lower.eq(term))
+      when :prefix
+        term.gsub!('%', '\%')
+        term.gsub!('_', '\_')
+        scope.and(node.matches("#{term}%"))
+      else
+        term.gsub!('%', '\%')
+        term.gsub!('_', '\_')
+        scope.and(node.matches("%#{term}%"))
+      end
+    end
+  end
+end

data/lib/searchable_by/concern.rb

@@ -0,0 +1,43 @@
+module SearchableBy
+  module Concern
+    def self.extended(base) # :nodoc:
+      base.class_attribute :_searchable_by_config, instance_accessor: false, instance_predicate: false
+      base._searchable_by_config = Config.new
+      super
+    end
+
+    def inherited(base) # :nodoc:
+      base._searchable_by_config = _searchable_by_config.dup
+      super
+    end
+
+    def searchable_by(max_terms: nil, **options, &block)
+      _searchable_by_config.instance_eval(&block)
+      _searchable_by_config.max_terms = max_terms if max_terms
+      _searchable_by_config.options.update(options) unless options.empty?
+      _searchable_by_config
+    end
+
+    # @param [String] query the search query
+    # @return [ActiveRecord::Relation] the scoped relation
+    def search_by(query)
+      columns = _searchable_by_config.columns
+      return all if columns.empty?
+
+      values = Util.norm_values(query).first(_searchable_by_config.max_terms)
+      return all if values.empty?
+
+      columns.each do |col|
+        col.node ||= col.attr.is_a?(Proc) ? col.attr.call : arel_table[col.attr]
+      end
+      clauses = Util.build_clauses(columns, values)
+      return all if clauses.empty?
+
+      scope = instance_exec(&_searchable_by_config.scoping)
+      clauses.each do |clause|
+        scope = scope.where(clause)
+      end
+      scope
+    end
+  end
+end

data/lib/searchable_by/config.rb

@@ -0,0 +1,31 @@
+module SearchableBy
+  class Config
+    attr_reader :columns, :scoping, :options
+    attr_accessor :max_terms
+
+    def initialize
+      @columns = []
+      @max_terms = 5
+      @options = {}
+      scope { all }
+    end
+
+    def initialize_copy(other)
+      @columns = other.columns.dup
+      super
+    end
+
+    def column(*attrs, &block)
+      opts = attrs.extract_options!
+      attrs.each do |attr|
+        columns.push Column.new(attr, **@options, **opts)
+      end
+      columns.push Column.new(block, **@options, **opts) if block
+      columns
+    end
+
+    def scope(&block)
+      @scoping = block
+    end
+  end
+end

data/lib/searchable_by/util.rb

@@ -0,0 +1,46 @@
+module SearchableBy
+  module Util
+    def self.norm_values(query)
+      values = []
+      query  = query.to_s.dup
+
+      # capture any phrases inside double quotes
+      # exclude from search if preceded by '-'
+      query.gsub!(/([\-+]?)"+([^"]*)"+/) do |_|
+        term = Regexp.last_match(2)
+        negate = Regexp.last_match(1) == '-'
+
+        values.push Value.new(term, negate, true) unless term.blank?
+        ''
+      end
+
+      # for the remaining terms remove sign if precedes
+      # exclude term from search if sign preceding is '-'
+      query.split.each do |term|
+        negate = term[0] == '-'
+        term.slice!(0) if negate || term[0] == '+'
+
+        values.push Value.new(term, negate, false) unless term.blank?
+      end
+
+      values.uniq!
+      values
+    end
+
+    def self.build_clauses(columns, values)
+      clauses = values.map do |value|
+        grouping = columns.map do |column|
+          column.build_condition(value)
+        end
+        grouping.compact!
+        next if grouping.empty?
+
+        clause = grouping.inject(&:or)
+        clause = clause.not if value.negate
+        clause
+      end
+      clauses.compact!
+      clauses
+    end
+  end
+end

data/searchable-by.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'searchable-by'
-  s.version     = '0.5.2'
+  s.version     = '0.5.8'
   s.authors     = ['Dimitrij Denissenko']
   s.email       = ['dimitrij@blacksquaremedia.com']
   s.summary     = 'Generate search scopes'
@@ -8,10 +8,10 @@ Gem::Specification.new do |s|
   s.homepage    = 'https://github.com/bsm/sortable-by'
   s.license     = 'MIT'
 
-  s.files         = `git ls-files -z`.split("\x0").reject {|f| f.match(%r{^spec/}) }
+  s.files         = `git ls-files -z`.split("\x0").reject {|f| f.start_with?('spec/') }
   s.test_files    = `git ls-files -z -- spec/*`.split("\x0")
   s.require_paths = ['lib']
-  s.required_ruby_version = '>= 2.4'
+  s.required_ruby_version = '>= 2.6'
 
   s.add_dependency 'activerecord'
   s.add_dependency 'activesupport'
@@ -20,6 +20,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'rubocop'
-  s.add_development_dependency 'rubocop-performance'
+  s.add_development_dependency 'rubocop-bsm'
   s.add_development_dependency 'sqlite3'
 end

data/spec/searchable_by/util_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe SearchableBy::Util do
+  context 'with norm_values' do
+    def norm(str)
+      described_class.norm_values(str).each_with_object({}) do |val, acc|
+        acc[val.term] = val.negate
+      end
+    end
+
+    it 'tokenises strings' do
+      expect(norm(nil)).to eq({})
+      expect(norm('""')).to eq({})
+      expect(norm('-+""')).to eq({})
+      expect(norm('simple words')).to eq('simple' => false, 'words' => false)
+      expect(norm(" with   \t spaces\n")).to eq('with' => false, 'spaces' => false)
+      expect(norm('with with duplicates with')).to eq('with' => false, 'duplicates' => false)
+      expect(norm('with "full term"')).to eq('full term' => false, 'with' => false)
+      expect(norm('"""odd double quotes around"""')).to eq('odd double quotes around' => false)
+      expect(norm('""even double quotes around""')).to eq('even double quotes around' => false)
+      expect(norm('with\'apostrophe')).to eq("with'apostrophe" => false)
+      expect(norm('with -minus')).to eq('minus' => true, 'with' => false)
+      expect(norm('with +plus')).to eq('plus' => false, 'with' => false)
+      expect(norm('with-minus')).to eq('with-minus' => false)
+      expect(norm('with+plus')).to eq('with+plus' => false)
+      expect(norm('with -"minus before"')).to eq('minus before' => true, 'with' => false)
+      expect(norm('with "-minus within"')).to eq('-minus within' => false, 'with' => false)
+      expect(norm('with +"plus before"')).to eq('plus before' => false, 'with' => false)
+      expect(norm('with "+plus within"')).to eq('+plus within' => false, 'with' => false)
+      expect(norm('+plus "in other term"')).to eq('in other term' => false, 'plus' => false)
+      expect(norm('with_blank \'\'')).to eq('with_blank' => false, '\'\'' => false)
+      expect(norm('with_blank_doubles ""')).to eq('with_blank_doubles' => false)
+    end
+  end
+end

data/spec/searchable_by_spec.rb

@@ -1,49 +1,77 @@
 require 'spec_helper'
 
-describe ActiveRecord::SearchableBy do
-
-  it 'should ignore bad inputs' do
+describe SearchableBy do
+  it 'ignores bad inputs' do
     expect(Post.search_by(nil).count).to eq(5)
     expect(Post.search_by('').count).to eq(5)
   end
 
-  it 'should configure correctly' do
+  it 'configures correctly' do
     expect(AbstractModel._searchable_by_config.columns.size).to eq(1)
     expect(Post._searchable_by_config.columns.size).to eq(5)
   end
 
-  it 'should generate SQL' do
+  it 'generates SQL' do
     sql = Post.search_by('123').to_sql
-    expect(sql).to include(%("posts"."id" = 123))
-    expect(sql).to include(%("posts"."title" LIKE '%123%'))
+    expect(sql).to include(%("posts"."id" IS NOT NULL AND "posts"."id" = 123))
+    expect(sql).to include(%("posts"."title" IS NOT NULL AND "posts"."title" LIKE '123%'))
+    expect(sql).to include(%("posts"."body" IS NOT NULL AND "posts"."body" LIKE '%123%'))
+    expect(sql).to include(%("users"."name" IS NOT NULL AND LOWER("users"."name") = '123'))
 
     sql = Post.search_by('foo%bar').to_sql
     expect(sql).not_to include(%("posts"."id"))
-    expect(sql).to include(%("posts"."title" LIKE '%foo\\%bar%'))
+    expect(sql).to include(%("posts"."title" LIKE 'foo\\%bar%'))
+    expect(sql).to include(%("posts"."body" LIKE '%foo\\%bar%'))
+  end
+
+  it 'searches' do
+    expect(Post.search_by('ALICE').pluck(:title)).to match_array(%w[ax1 ax2 ab1])
+    expect(Post.search_by('bOb').pluck(:title)).to match_array(%w[bx1 bx2 ab1])
+  end
+
+  it 'searches across multiple words' do
+    expect(Post.search_by('ALICE your').pluck(:title)).to match_array(%w[ax2])
   end
 
-  it 'should search' do
-    expect(Post.search_by('ALICE').pluck(:title)).to match_array(%w[a1 a2 ab])
-    expect(Post.search_by('bOb').pluck(:title)).to match_array(%w[b1 b2 ab])
+  it 'supports search markers' do
+    expect(Post.search_by('aLiCe -your').pluck(:title)).to match_array(%w[ax1 ab1])
+    expect(Post.search_by('+alice "your recipe"').pluck(:title)).to match_array(%w[ax2])
+    expect(Post.search_by('bob -"her recipe"').pluck(:title)).to match_array(%w[bx2 ab1])
+    expect(Post.search_by('bob +"her recipe"').pluck(:title)).to match_array(%w[bx1])
   end
 
-  it 'should search across multiple words' do
-    expect(Post.search_by('ALICE your').pluck(:title)).to match_array(%w[a2])
+  it 'respects match options' do
+    # name uses match: :exact
+    expect(Post.search_by('alice').pluck(:title)).to match_array(%w[ax1 ax2 ab1])
+    expect(Post.search_by('ali').pluck(:title)).to be_empty
+    expect(Post.search_by('lice').pluck(:title)).to be_empty
+    expect(Post.search_by('li').pluck(:title)).to be_empty
+
+    # title uses match: :prefix
+    expect(Post.search_by('ax').pluck(:title)).to match_array(%w[ax1 ax2])
+    expect(Post.search_by('bx').pluck(:title)).to match_array(%w[bx1 bx2])
+    expect(Post.search_by('ab').pluck(:title)).to match_array(%w[ab1])
+    expect(Post.search_by('ba').pluck(:title)).to be_empty
+
+    # title uses match_phrase: :exact
+    expect(Post.search_by('"ab"').pluck(:title)).to be_empty
+    expect(Post.search_by('"ab1"').pluck(:title)).to match_array(%w[ab1])
+
+    # body uses match: :all (default)
+    expect(Post.search_by('recip').pluck(:title)).to match_array(%w[ax1 ax2 bx1 bx2 ab1])
   end
 
-  it 'should support search markers' do
-    expect(Post.search_by('aLiCe -your').pluck(:title)).to match_array(%w[a1 ab])
-    expect(Post.search_by('+alice "your recipe"').pluck(:title)).to match_array(%w[a2])
-    expect(Post.search_by('bob -"her recipe"').pluck(:title)).to match_array(%w[b2 ab])
-    expect(Post.search_by('bob +"her recipe"').pluck(:title)).to match_array(%w[b1])
+  it 'supports min term length' do
+    expect(User.search_by('+ir')).to be_empty
+    expect(User.search_by('irs')).to match_array([USERS[:a]])
   end
 
-  it 'should search within scopes' do
-    expect(Post.where(title: 'a1').search_by('ALICE').pluck(:title)).to match_array(%w[a1])
-    expect(Post.where(title: 'a1').search_by('bOb').pluck(:title)).to match_array(%w[])
+  it 'searches within scopes' do
+    expect(Post.where(title: 'ax1').search_by('ALICE').pluck(:title)).to match_array(%w[ax1])
+    expect(Post.where(title: 'ax1').search_by('bOb').pluck(:title)).to be_empty
   end
 
-  it 'should search integers' do
-    expect(Post.search_by(POSTS[:ab].id.to_s).count).to eq(1)
+  it 'searches integers' do
+    expect(Post.search_by(POSTS[:ab1].id.to_s).count).to eq(1)
   end
 end

data/spec/spec_helper.rb

@@ -2,12 +2,13 @@ ENV['RACK_ENV'] ||= 'test'
 require 'searchable-by'
 require 'rspec'
 
-ActiveRecord::Base.configurations['test'] = { 'adapter' => 'sqlite3', 'database' => ':memory:' }
+ActiveRecord::Base.configurations = { 'test' => { 'adapter' => 'sqlite3', 'database' => ':memory:' } }
 ActiveRecord::Base.establish_connection :test
 
 ActiveRecord::Base.connection.instance_eval do
   create_table :users do |t|
     t.string  :name
+    t.string  :bio
   end
   create_table :posts do |t|
     t.integer :author_id, null: false
@@ -27,6 +28,10 @@ end
 
 class User < AbstractModel
   has_many :posts, foreign_key: :author_id
+
+  searchable_by do
+    column :bio, min_length: 3
+  end
 end
 
 class Post < AbstractModel
@@ -34,8 +39,9 @@ class Post < AbstractModel
   belongs_to :reviewer, class_name: 'User'
 
   searchable_by do
-    column :title, :body
-    column { User.arel_table[:name] }
+    column :title, match: :prefix, match_phrase: :exact
+    column :body
+    column proc { User.arel_table[:name] }, match: :exact
     column { User.arel_table.alias('reviewers_posts')[:name] }
 
     scope do
@@ -45,14 +51,14 @@ class Post < AbstractModel
 end
 
 USERS = {
-  a: User.create!(name: 'Alice'),
-  b: User.create!(name: 'Bob'),
+  a: User.create!(name: 'Alice', bio: 'First user'),
+  b: User.create!(name: 'Bob', bio: 'Second user'),
 }.freeze
 
 POSTS = {
-  a1: USERS[:a].posts.create!(title: 'a1', body: 'my recipe '),
-  a2: USERS[:a].posts.create!(title: 'a2', body: 'your recipe'),
-  b1: USERS[:b].posts.create!(title: 'b1', body: 'her recipe'),
-  b2: USERS[:b].posts.create!(title: 'b2', body: 'our recipe'),
-  ab: USERS[:a].posts.create!(title: 'ab', reviewer: USERS[:b], body: 'their recipe'),
+  ax1: USERS[:a].posts.create!(title: 'ax1', body: 'my recipe '),
+  ax2: USERS[:a].posts.create!(title: 'ax2', body: 'your recipe'),
+  bx1: USERS[:b].posts.create!(title: 'bx1', body: 'her recipe'),
+  bx2: USERS[:b].posts.create!(title: 'bx2', body: 'our recipe'),
+  ab1: USERS[:a].posts.create!(title: 'ab1', reviewer: USERS[:b], body: 'their recipe'),
 }.freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: searchable-by
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.8
 platform: ruby
 authors:
 - Dimitrij Denissenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-26 00:00:00.000000000 Z
+date: 2021-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-performance
+  name: rubocop-bsm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -139,7 +139,12 @@ files:
 - Rakefile
 - lib/searchable-by.rb
 - lib/searchable_by.rb
+- lib/searchable_by/column.rb
+- lib/searchable_by/concern.rb
+- lib/searchable_by/config.rb
+- lib/searchable_by/util.rb
 - searchable-by.gemspec
+- spec/searchable_by/util_spec.rb
 - spec/searchable_by_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/bsm/sortable-by
@@ -154,17 +159,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Generate search scopes
 test_files:
+- spec/searchable_by/util_spec.rb
 - spec/searchable_by_spec.rb
 - spec/spec_helper.rb