search_object_graphql 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49fd6817f69aa33a15ce7cc2e768bd239020c3f7f6b6e385e1f12d3c9d5c30ff
-  data.tar.gz: c6c4a8d82f1d5afa85519a1e8aee726b321495b2305e63fa0d5e986db75066fb
+  metadata.gz: c82b2028e4c0234e7f8109dbe66cb37746efc7c39e17d7e31a02b10f3e975c5e
+  data.tar.gz: b9d2f3bb799b65943fbcd3d777a75e9a1c3348dd7a33b0064212e373f6bd7422
 SHA512:
-  metadata.gz: a71588bac7cc2fba645d1e4007bfeed111749c0016d4a2de7e832990ff33f37e1656c08a47fd3a52f18664e594bbefee3939d1412aa3fc5d679dd9c3d875d533
-  data.tar.gz: 4c9bfd49332eafbd37b10be48bc58c65bfffa0546dc7c394a7b77e3e146769ee77083f39bbd40f101302ad7ffb967d8b7e0054b6512c35febdcedc0e00c94855
+  metadata.gz: a321cd52dfab7394ab746afa2b4d288be0a1beeec9eaa4286989fd0d63a4427f3153aa8aec2ebc42431daea0513b2604d6e123512a22e1cd394ef00ed330dc1c
+  data.tar.gz: 0e6a7c3a3a8a3695b4b2797aa0bcb26c5b98d3bd0bc8d91a605d2e26bafe6c58d001eb260d81fcc88d53c0f3b28f945bd6387ce3860bcd48412f781e38c4be1f

data/.rubocop.yml

@@ -49,3 +49,9 @@ RSpec/ExampleLength:
 # Disables "Too many expectations."
 RSpec/MultipleExpectations:
   Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false

data/.travis.yml

@@ -1,8 +1,9 @@
 language: ruby
 rvm:
-  - 2.4.1
   - 2.5.2
   - 2.6.0
+  - 2.7.1
+  - 3.0.0
 script:
   - bundle exec rubocop
   - bundle exec rspec spec

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 
-## Version 1.0.0 (unreleased)
+## Version 1.0.1
+
+* __[fix]__ `camelize` defaults to false when not specified (@haines)
+
+## Version 1.0.0
 
 * __[break]__ Removed support for defining types via `type` method (@rstankov)
 * __[break]__ Require `GraphQL::Schema::Resolver` inheritance (@rstankov)

data/lib/search_object/plugin/graphql.rb

@@ -29,15 +29,15 @@ module SearchObject
       module ClassMethods
         def option(name, options = {}, &block)
           type = options.fetch(:type) { raise MissingTypeDefinitionError, name }
-          options[:enum] = type.values.map { |value, enum_value| enum_value.value || value } if type.respond_to?(:values)
 
-          argument(
-            name.to_s,
-            options[:type],
-            required: options[:required] || false,
-            description: options[:description],
-            camelize: options[:camelize]
-          )
+          argument_options = { required: options[:required] || false }
+          argument_options[:camelize] = options[:camelize] if options.include?(:camelize)
+          argument_options[:default_value] = options[:default] if options.include?(:default)
+          argument_options[:description] = options[:description] if options.include?(:description)
+
+          argument(name.to_s, type, **argument_options)
+
+          options[:enum] = type.values.map { |value, enum_value| enum_value.value || value } if type.respond_to?(:values)
 
           super(name, options, &block)
         end

data/lib/search_object/plugin/graphql/version.rb

@@ -3,7 +3,7 @@
 module SearchObject
   module Plugin
     module Graphql
-      VERSION = '1.0.0'
+      VERSION = '1.0.1'
     end
   end
 end

data/spec/search_object/plugin/graphql_spec.rb

@@ -217,6 +217,42 @@ describe SearchObject::Plugin::Graphql do
       )
     end
 
+    it 'sets default_value on the argument' do
+      schema = define_search_class_and_return_schema do
+        type PostType, null: true
+
+        option('option', type: types.String, default: 'default') { [] }
+      end
+
+      result = schema.execute <<~GRAPHQL
+        {
+          __type(name: "Query") {
+            name
+            fields {
+              args {
+                name
+                defaultValue
+              }
+            }
+          }
+        }
+      GRAPHQL
+
+      expect(result).to eq(
+        'data' => {
+          '__type' => {
+            'name' => 'Query',
+            'fields' => [{
+              'args' => [{
+                'name' => 'option',
+                'defaultValue' => '"default"'
+              }]
+            }]
+          }
+        }
+      )
+    end
+
     it 'accepts "required"' do
       schema = define_search_class_and_return_schema do
         option(:id, type: types.String, required: true) do |_scope, value|
@@ -299,6 +335,40 @@ describe SearchObject::Plugin::Graphql do
       )
     end
 
+    it 'does not override the default camelize option' do
+      schema = define_search_class_and_return_schema do
+        type PostType, null: true
+
+        option('option_field', type: types.String)
+      end
+
+      result = schema.execute <<~GRAPHQL
+        {
+          __type(name: "Query") {
+            name
+            fields {
+              args {
+                name
+              }
+            }
+          }
+        }
+      GRAPHQL
+
+      expect(result.to_h).to eq(
+        'data' => {
+          '__type' => {
+            'name' => 'Query',
+            'fields' => [{
+              'args' => [{
+                'name' => 'optionField'
+              }]
+            }]
+          }
+        }
+      )
+    end
+
     it 'raises error when no type is given' do
       expect { define_search_class { option :name } }.to raise_error described_class::MissingTypeDefinitionError
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: search_object_graphql
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Radoslav Stankov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-14 00:00:00.000000000 Z
+date: 2021-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql