search_object 1.0 → 1.1.0

data/spec/spec_helper_active_record.rb

@@ -12,7 +12,7 @@ ActiveRecord::Schema.define do
     t.string :category_name
     t.integer :price
 
-    t.timestamps
+    t.timestamps null: true
   end
 end
 

data/spec/support/kaminari_setup.rb

@@ -4,4 +4,3 @@ require 'kaminari'
 Kaminari::Hooks.init
 require 'kaminari/models/active_record_extension'
 ::ActiveRecord::Base.send :include, Kaminari::ActiveRecordExtension
-

data/spec/support/paging_shared_example.rb

@@ -1,4 +1,4 @@
-shared_examples_for "a paging plugin" do
+shared_examples_for 'a paging plugin' do
   after do
     Product.delete_all
   end
@@ -8,9 +8,7 @@ shared_examples_for "a paging plugin" do
     Class.new do
       include SearchObject.module(plugin_name)
 
-      if block_given?
-        instance_eval &block
-      end
+      instance_eval(&block) if block_given?
     end
   end
 
@@ -29,8 +27,13 @@ shared_examples_for "a paging plugin" do
     search_class.new page: page, per_page: per_page
   end
 
-  describe "#results" do
-    it "paginates results" do
+  it 'can be inherited' do
+    child_class = Class.new(search_class)
+    expect(child_class.new.per_page).to eq 2
+  end
+
+  describe '#results' do
+    it 'paginates results' do
       6.times { |i| Product.create name: "product_#{i}" }
       search = search_with_page 2, 2
 
@@ -38,75 +41,75 @@ shared_examples_for "a paging plugin" do
     end
   end
 
-  describe "#page" do
-    it "treats nil page as 0" do
+  describe '#page' do
+    it 'treats nil page as 0' do
       search = search_with_page nil
       expect(search.page).to eq 0
     end
 
-    it "treats negative page numbers as positive" do
-      search = search_with_page -1
+    it 'treats negative page numbers as positive' do
+      search = search_with_page(-1)
       expect(search.page).to eq 0
     end
   end
 
-  describe "#per_page" do
-    it "returns the class defined per page" do
+  describe '#per_page' do
+    it 'returns the class defined per page' do
       search = search_class.new
       expect(search.per_page).to eq 2
     end
 
-    it "can be overwritten as option" do
+    it 'can be overwritten as option' do
       search = search_class.new per_page: 3
       expect(search.per_page).to eq 3
     end
 
-    it "respects min per page" do
+    it 'respects min per page' do
       search = search_class.new per_page: 1
       expect(search.per_page).to eq 2
     end
 
-    it "respects max per page" do
+    it 'respects max per page' do
       search = search_class.new per_page: 100
       expect(search.per_page).to eq 10
     end
   end
 
-  describe "#count" do
-    it "gives the real count" do
+  describe '#count' do
+    it 'gives the real count' do
       10.times { |i| Product.create name: "product_#{i}" }
       search = search_with_page 1
       expect(search.count).to eq 10
     end
   end
 
-  describe ".per_page" do
-    it "doesn't accept 0" do
-      expect { define_search_class { per_page 0 } }.to raise_error SearchObject::InvalidNumberError
+  describe '.per_page' do
+    it 'does not accept 0' do
+      expect { define_search_class { per_page(0) } }.to raise_error SearchObject::InvalidNumberError
     end
 
-    it "doesn't accept negative number" do
-      expect { define_search_class { per_page -1 } }.to raise_error SearchObject::InvalidNumberError
+    it 'does not accept negative number' do
+      expect { define_search_class { per_page(-1) } }.to raise_error SearchObject::InvalidNumberError
     end
   end
 
-  describe ".min_per_page" do
-    it "doesn't accept 0" do
-      expect { define_search_class { min_per_page 0 } }.to raise_error SearchObject::InvalidNumberError
+  describe '.min_per_page' do
+    it 'does not accept 0' do
+      expect { define_search_class { min_per_page(0) } }.to raise_error SearchObject::InvalidNumberError
     end
 
-    it "doesn't accept negative number" do
-      expect { define_search_class { min_per_page -1 } }.to raise_error SearchObject::InvalidNumberError
+    it 'does not accept negative number' do
+      expect { define_search_class { min_per_page(-1) } }.to raise_error SearchObject::InvalidNumberError
     end
   end
 
-  describe ".max_per_page" do
-    it "doesn't accept 0" do
-      expect { define_search_class { max_per_page 0 } }.to raise_error SearchObject::InvalidNumberError
+  describe '.max_per_page' do
+    it 'does not accept 0' do
+      expect { define_search_class { max_per_page(0) } }.to raise_error SearchObject::InvalidNumberError
     end
 
-    it "doesn't accept negative number" do
-      expect { define_search_class { max_per_page -1 } }.to raise_error SearchObject::InvalidNumberError
+    it 'does not accept negative number' do
+      expect { define_search_class { max_per_page(-1) } }.to raise_error SearchObject::InvalidNumberError
     end
   end
 end

metadata

@@ -1,139 +1,167 @@
 --- !ruby/object:Gem::Specification
 name: search_object
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: 1.1.0
 platform: ruby
 authors:
 - Radoslav Stankov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-09 00:00:00.000000000 Z
+date: 2015-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.12.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.12.3
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: will_paginate
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: kaminari
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Search object DSL
@@ -143,9 +171,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .rubocop.yml
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -156,6 +185,7 @@ files:
 - example/Gemfile
 - example/README.md
 - example/Rakefile
+- example/app/assets/images/favicon.png
 - example/app/assets/javascripts/application.js
 - example/app/assets/stylesheets/application.css.scss
 - example/app/assets/stylesheets/reset.css
@@ -224,17 +254,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: Provides DSL for creating search objects
@@ -251,4 +281,3 @@ test_files:
 - spec/spec_helper_active_record.rb
 - spec/support/kaminari_setup.rb
 - spec/support/paging_shared_example.rb
-has_rdoc: