search_flip 3.7.2 → 4.0.0.beta

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8c5d0e833c92cf4584fe620634d0c2633cc82248a5cae91c256799d280057f5
-  data.tar.gz: 62f5f4944c3a1dc823f75f9bcede05c69ab103d19ae19cfec8f3c518a3829723
+  metadata.gz: b023bc6411647eaecfcb8f5b0fe535379974a0824d49699dd74ef867a67c69eb
+  data.tar.gz: 5dc4a0439f9442811f3966e86b0c6b09d09c54450a04234c3738ae0ab7935900
 SHA512:
-  metadata.gz: 5480c57d7d814d96903aab184a82831d4f78d3613249eb8c6951992deaf873bba00ee3d5f8053050775973ac70cb2fc4665b7b15503634b53e853b8d0c29b198
-  data.tar.gz: 648f80a25a38e6ec50ab3ecec25a4b6dee92902804c6ee82409d7084c27527cea9788458f5e674dcbf2d0eea5aef401a13e3f1a3b23bd2e6ef1c5659e3a915d3
+  metadata.gz: a5fc637e8c016531df22af678adcae60a4f4169e5f1d2215d52be0a0dff1111b849cb4d79ca36d6cbf315c8516bc51d543852ab5026339d59cb1f5d08ba356f7
+  data.tar.gz: 7cf9d55a9aca5d6d63401750d40bc656fcc345101d8ce92a300c24649e38810d399d43ff225611bbdd91a257d6cb15eee26a6c811974b987e92e72e67eded704

data/.github/workflows/test.yml

@@ -11,18 +11,16 @@ jobs:
         - elasticsearch:5.4
         - docker.elastic.co/elasticsearch/elasticsearch:6.7.0
         - docker.elastic.co/elasticsearch/elasticsearch:7.0.0
-        - docker.elastic.co/elasticsearch/elasticsearch:7.11.2
-        - docker.elastic.co/elasticsearch/elasticsearch:8.1.1
+        - docker.elastic.co/elasticsearch/elasticsearch:7.9.0
         ruby:
+        - 2.5
         - 2.6
         - 2.7
-        - 3.0
     services:
       elasticsearch:
         image: ${{ matrix.elasticsearch }}
         env:
           discovery.type: single-node
-          xpack.security.enabled: false
         ports:
           - 9200:9200
     steps:
@@ -30,7 +28,7 @@ jobs:
     - uses: actions/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
-    - run: gem install bundler
     - run: bundle
+    - run: sleep 10
     - run: bundle exec rspec
     - run: bundle exec rubocop

data/.rubocop.yml

@@ -1,15 +1,11 @@
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.5
-  SuggestExtensions: false
+  TargetRubyVersion: 2.4
 
-Gemspec/RequireMFA:
+Gemspec/RequiredRubyVersion:
   Enabled: false
 
-Layout/EmptyLineBetweenDefs:
-  EmptyLineBetweenClassDefs: false
-
-Gemspec/RequiredRubyVersion:
+Style/CaseLikeIf:
   Enabled: false
 
 Style/ExplicitBlockArgument:

data/CHANGELOG.md

@@ -1,46 +1,13 @@
 
 # CHANGELOG
 
-## v3.7.2
+## v4.0.0
 
-* Fix wrong AWS signatures by generating the json before passing it to http-rb
-
-## v3.7.1
-
-* Fix thread-safety issue of http-rb
-
-## v3.7.0
-
-* Add `SearchFlip::Connection#bulk` to allow more clean bulk indexing to
-  multiple indices at once
-
-## v3.6.0
-
-* Support Elasticsearch v8
-
-## v3.5.0
-
-* Add `SearchFlip::Criteria#http_timeout` to allow specifying timeouts on
-  a query level
-
-## v3.4.0
-
-* Expose `Http#timeout` via `SearchFlip::HTTPClient`
-
-## v3.3.0
-
-* Update httprb
-* Changed oj default options
-* Allow to set oj json options
-
-## v3.2.1
-
-* Fix `refresh` having a empty body breaking in elasticsearch 7.11
-
-## v3.2.0
-
-* Fix `index_scope` not being passed in `each_record` without block
-* Added `SearchFlip::Criteria#match_none`
+* [BREAKING] For performance reasons, `SearchFlip::Result` now no longer
+  inherits `Hashie::Mash`
+  * It no longer supports symbol based access like `result[:id]`
+  * It no longer supports question mark methods like `result.title?`
+  * It no longer supports method based assignment like `result.some_key = "value"`
 
 ## v3.1.2
 

data/README.md

@@ -9,7 +9,7 @@
 Using SearchFlip it is dead-simple to create index classes that correspond to
 [Elasticsearch](https://www.elastic.co/) indices and to manipulate, query and
 aggregate these indices using a chainable, concise, yet powerful DSL. Finally,
-SearchFlip supports Elasticsearch 2.x, 5.x, 6.x, 7.x and 8.x. Check section
+SearchFlip supports Elasticsearch 2.x, 5.x, 6.x, 7.x. Check section
 [Feature Support](#feature-support) for version dependent features.
 
 ```ruby
@@ -51,7 +51,7 @@ CommentIndex.search("hello world").where(available: true).sort(id: "desc").aggre
 
 ```
 
-Finally, SearchFlip comes with a minimal set of dependencies.
+Finally, SearchFlip comes with a minimal set of dependencies (http-rb and oj only).
 
 ## Reference Docs
 
@@ -418,14 +418,6 @@ Simply matches all documents:
 CommentIndex.match_all
 ```
 
-* `match_none`
-
-Simply matches none documents at all:
-
-```ruby
-CommentIndex.match_none
-```
-
 * `all`
 
 Simply returns the criteria as is or an empty criteria when called on the index
@@ -482,8 +474,8 @@ end
 ```
 
 Generally, aggregation results returned by Elasticsearch are returned as a
-`SearchFlip::Result`, which basically is a `Hashie::Mash`, such that you can
-access them via:
+`SearchFlip::Result`, which basically is a Hash with method-like access, such
+that you can access them via:
 
 ```ruby
 query.aggregations(:username)["mrkamel"].revenue.value
@@ -698,14 +690,6 @@ Specify a timeout to limit query processing time:
 CommentIndex.timeout("3s").execute
 ```
 
-* `http_timeout`
-
-Specify a http timeout for the request which will be send to Elasticsearch:
-
-```ruby
-CommentIndex.http_timeout(3).execute
-```
-
 * `terminate_after`
 
 Activate early query termination to stop query processing after the specified
@@ -764,7 +748,7 @@ end
 This allows to use different clusters per index e.g. when migrating indices to
 new versions of Elasticsearch.
 
-You can specify basic auth, additional headers, request timeouts, etc via:
+You can specify basic auth, additional headers, etc via:
 
 ```ruby
 http_client = SearchFlip::HTTPClient.new
@@ -781,9 +765,6 @@ http_client = http_client.via("proxy.host", 8080)
 # Custom headers
 http_client = http_client.headers(key: "value")
 
-# Timeouts
-http_client = http_client.timeout(20)
-
 SearchFlip::Connection.new(base_url: "...", http_client: http_client)
 ```
 
@@ -893,52 +874,57 @@ Thus, if your ORM supports `.find_each`, `#id` and `#where` you are already
 good to go. Otherwise, simply add your custom implementation of those methods
 that work with whatever ORM you use.
 
-## JSON
+## Date and Timestamps in JSON
 
-SearchFlip is using the [Oj gem](https://github.com/ohler55/oj) to generate
-JSON. More concretely, SearchFlip is using:
+Elasticsearch requires dates and timestamps to have one of the formats listed
+here: [https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html#strict-date-time](https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html#strict-date-time).
+
+However, `JSON.generate` in ruby by default outputs something like:
 
 ```ruby
-Oj.dump({ key: "value" }, mode: :custom, use_to_json: true, time_format: :xmlschema, bigdecimal_as_decimal: false)
+JSON.generate(time: Time.now.utc)
+# => "{\"time\":\"2018-02-22 18:19:33 UTC\"}"
 ```
 
-The `use_to_json` option is used for maximum compatibility, most importantly
-when using rails `ActiveSupport::TimeWithZone` timestamps, which `oj` can not
-serialize natively. However, `use_to_json` adds performance overhead. You can
-change the json options via:
+This format is not compatible with Elasticsearch by default. If you're on
+Rails, ActiveSupport adds its own `#to_json` methods to `Time`, `Date`, etc.
+However, ActiveSupport checks whether they are used in combination with
+`JSON.generate` or not and adapt:
 
 ```ruby
-SearchFlip::Config[:json_options] = {
-  mode: :custom,
-  use_to_json: false,
-  time_format: :xmlschema,
-  bigdecimal_as_decimal: false
-}
+Time.now.utc.to_json
+=> "\"2018-02-22T18:18:22.088Z\""
+
+JSON.generate(time: Time.now.utc)
+=> "{\"time\":\"2018-02-22 18:18:59 UTC\"}"
 ```
 
-However, you then have to convert timestamps manually for indexation via e.g.:
+SearchFlip is using the [Oj gem](https://github.com/ohler55/oj) to generate
+JSON. More concretely, SearchFlip is using:
 
 ```ruby
-class MyIndex
-  # ...
+Oj.dump({ key: "value" }, mode: :custom, use_to_json: true)
+```
 
-  def self.serialize(model)
-    {
-      # ...
+This mitigates the issues if you're on Rails:
 
-      created_at: model.created_at.to_time
-    }
-  end
-end
+```ruby
+Oj.dump(Time.now, mode: :custom, use_to_json: true)
+# => "\"2018-02-22T18:21:21.064Z\""
 ```
 
-Please check out the oj docs for more details.
+However, if you're not on Rails, you need to add `#to_json` methods to `Time`,
+`Date` and `DateTime` to get proper serialization. You can either add them on
+your own, via other libraries or by simply using:
+
+```ruby
+require "search_flip/to_json"
+```
 
 ## Feature Support
 
 * for Elasticsearch 2.x, the delete-by-query plugin is required to delete
   records via queries
-* `#match_none` is only available with Elasticsearch >= 5
 * `#track_total_hits` is only available with Elasticsearch >= 7
 
 ## Keeping your Models and Indices in Sync

data/UPDATING.md

@@ -1,6 +1,46 @@
 
 # Updating from previous SearchFlip versions
 
+## Update 3.x to 4.x
+
+**[BREAKING]** For performance reasons, `SearchFlip::Result` no longer
+inherits `Hashie::Mash`
+
+* It no longer supports symbol based access like `result[:id]`
+
+2.x:
+
+```ruby
+CommentIndex.match_all.results.first[:id]
+CommentIndex.aggregate(:tags).aggregations(:tags).values.first[:doc_count]
+```
+
+3.x
+
+```ruby
+CommentIndex.match_all.results.first["id"] # or .id
+CommentIndex.aggregate(:tags).aggregations(:tags).values.first["doc_count"] # or .doc_count
+```
+
+* It no longer supports question mark methods like `result.title?`
+
+2.x:
+
+```ruby
+CommentIndex.match_all.results.first.is_published?
+```
+
+3.x
+
+```ruby
+CommentIndex.match_all.results.first.is_published == true
+```
+
+* It no longer supports method based assignment like `result.some_key = "value"`.
+
+However, this should not have any practical implications, as changing the
+results is not considered to be a common use case.
+
 ## Update 2.x to 3.x
 
 * **[BREAKING]**  No longer pass multiple arguments to `#must`, `#must_not`,

data/docker-compose.yml

@@ -4,6 +4,5 @@ services:
     image: $ES_IMAGE
     environment:
       - discovery.type=single-node
-      - xpack.security.enabled=false
     ports:
       - 9200:9200

data/lib/search_flip/aws_sigv4_plugin.rb

@@ -37,6 +37,7 @@ module SearchFlip
       }
 
       signature_request[:body] = options[:body] if options.key?(:body)
+      signature_request[:body] = options[:json].respond_to?(:to_str) ? options[:json] : JSON.generate(options[:json]) if options[:json]
 
       signature = signer.sign_request(signature_request)
 

data/lib/search_flip/bulk.rb

@@ -143,7 +143,7 @@ module SearchFlip
 
       return if options[:raise] == false
 
-      parsed_response = SearchFlip::JSON.parse(response.to_s)
+      parsed_response = response.parse
 
       return unless parsed_response["errors"]
 

data/lib/search_flip/config.rb

@@ -5,12 +5,6 @@ module SearchFlip
     bulk_limit: 1_000,
     bulk_max_mb: 100,
     auto_refresh: false,
-    instrumenter: NullInstrumenter.new,
-    json_options: {
-      mode: :custom,
-      use_to_json: true,
-      time_format: :xmlschema,
-      bigdecimal_as_decimal: false
-    }
+    instrumenter: NullInstrumenter.new
   }
 end

data/lib/search_flip/connection.rb

@@ -28,11 +28,7 @@ module SearchFlip
 
     def version
       @version_mutex.synchronize do
-        @version ||= begin
-          response = http_client.headers(accept: "application/json").get("#{base_url}/")
-
-          SearchFlip::JSON.parse(response.to_s)["version"]["number"]
-        end
+        @version ||= http_client.headers(accept: "application/json").get("#{base_url}/").parse["version"]["number"]
       end
     end
 
@@ -44,9 +40,7 @@ module SearchFlip
     # @return [Hash] The raw response
 
     def cluster_health
-      response = http_client.headers(accept: "application/json").get("#{base_url}/_cluster/health")
-
-      SearchFlip::JSON.parse(response.to_s)
+      http_client.headers(accept: "application/json").get("#{base_url}/_cluster/health").parse
     end
 
     # Uses the Elasticsearch Multi Search API to execute multiple search requests
@@ -64,7 +58,7 @@ module SearchFlip
     def msearch(criterias)
       payload = criterias.flat_map do |criteria|
         [
-          SearchFlip::JSON.generate(index: criteria.target.index_name_with_prefix, **(version.to_i < 8 ? { type: criteria.target.type_name } : {})),
+          SearchFlip::JSON.generate(index: criteria.target.index_name_with_prefix, type: criteria.target.type_name),
           SearchFlip::JSON.generate(criteria.request)
         ]
       end
@@ -96,11 +90,10 @@ module SearchFlip
     # @return [Hash] The raw response
 
     def update_aliases(payload)
-      response = http_client
+      http_client
         .headers(accept: "application/json", content_type: "application/json")
         .post("#{base_url}/_aliases", body: SearchFlip::JSON.generate(payload))
-
-      SearchFlip::JSON.parse(response.to_s)
+        .parse
     end
 
     # Sends an analyze request to Elasticsearch. Raises
@@ -112,11 +105,10 @@ module SearchFlip
     # @return [Hash] The raw response
 
     def analyze(request, params = {})
-      response = http_client
+      http_client
         .headers(accept: "application/json")
         .post("#{base_url}/_analyze", json: request, params: params)
-
-      SearchFlip::JSON.parse(response.to_s)
+        .parse
     end
 
     # Fetches information about the specified index aliases. Raises
@@ -132,11 +124,10 @@ module SearchFlip
     # @return [Hash] The raw response
 
     def get_aliases(index_name: "*", alias_name: "*")
-      response = http_client
+      http_client
         .headers(accept: "application/json", content_type: "application/json")
         .get("#{base_url}/#{index_name}/_alias/#{alias_name}")
-
-      SearchFlip::JSON.parse(response.to_s)
+        .parse
     end
 
     # Returns whether or not the associated Elasticsearch alias already
@@ -168,11 +159,10 @@ module SearchFlip
     # @return [Array] The raw response
 
     def get_indices(name = "*", params: {})
-      response = http_client
+      http_client
         .headers(accept: "application/json", content_type: "application/json")
         .get("#{base_url}/_cat/indices/#{name}", params: params)
-
-      SearchFlip::JSON.parse(response.to_s)
+        .parse
     end
 
     alias_method :cat_indices, :get_indices
@@ -269,11 +259,10 @@ module SearchFlip
     # @return [Hash] The index settings
 
     def get_index_settings(index_name)
-      response = http_client
+      http_client
         .headers(accept: "application/json")
         .get("#{index_url(index_name)}/_settings")
-
-      SearchFlip::JSON.parse(response.to_s)
+        .parse
     end
 
     # Sends a refresh request to Elasticsearch. Raises
@@ -283,7 +272,7 @@ module SearchFlip
     # @return [Boolean] Returns true or raises SearchFlip::ResponseError
 
     def refresh(index_names = nil)
-      http_client.post("#{index_names ? index_url(Array(index_names).join(",")) : base_url}/_refresh")
+      http_client.post("#{index_names ? index_url(Array(index_names).join(",")) : base_url}/_refresh", json: {})
 
       true
     end
@@ -300,8 +289,8 @@ module SearchFlip
     # @return [Boolean] Returns true or raises SearchFlip::ResponseError
 
     def update_mapping(index_name, mapping, type_name: nil)
-      url = type_name && version.to_i < 8 ? type_url(index_name, type_name) : index_url(index_name)
-      params = type_name && version.to_f >= 6.7 && version.to_i < 8 ? { include_type_name: true } : {}
+      url = type_name ? type_url(index_name, type_name) : index_url(index_name)
+      params = type_name && version.to_f >= 6.7 ? { include_type_name: true } : {}
 
       http_client.put("#{url}/_mapping", params: params, json: mapping)
 
@@ -318,12 +307,10 @@ module SearchFlip
     # @return [Hash] The current type mapping
 
     def get_mapping(index_name, type_name: nil)
-      url = type_name && version.to_i < 8 ? type_url(index_name, type_name) : index_url(index_name)
-      params = type_name && version.to_f >= 6.7 && version.to_i < 8 ? { include_type_name: true } : {}
-
-      response = http_client.headers(accept: "application/json").get("#{url}/_mapping", params: params)
+      url = type_name ? type_url(index_name, type_name) : index_url(index_name)
+      params = type_name && version.to_f >= 6.7 ? { include_type_name: true } : {}
 
-      SearchFlip::JSON.parse(response.to_s)
+      http_client.headers(accept: "application/json").get("#{url}/_mapping", params: params).parse
     end
 
     # Deletes the specified index from Elasticsearch. Raises
@@ -355,51 +342,6 @@ module SearchFlip
       raise e
     end
 
-    # Initiates and yields a bulk object, such that index, import, create,
-    # update and delete requests can be appended to the bulk request. Please
-    # note that you need to manually pass the desired index name as well as
-    # type name (depending on the Elasticsearch version) when using #bulk on a
-    # connection object or Elasticsearch will return an error. After the bulk
-    # requests are successfully processed all existing indices will
-    # subsequently be refreshed when auto_refresh is enabled.
-    #
-    # @see SearchFlip::Config See SearchFlip::Config for auto_refresh
-    #
-    # @example
-    #   connection = SearchFlip::Connection.new
-    #
-    #   connection.bulk ignore_errors: [409] do |bulk|
-    #     bulk.create comment.id, CommentIndex.serialize(comment),
-    #       _index: CommentIndex.index_name, version: comment.version, version_type: "external_gte"
-    #
-    #     bulk.delete product.id, _index: ProductIndex.index_name, routing: product.user_id
-    #
-    #     # ...
-    #   end
-    #
-    # @param options [Hash] Specifies options regarding the bulk indexing
-    # @option options ignore_errors [Array] Specifies an array of http status
-    #   codes that shouldn't raise any exceptions, like eg 409 for conflicts,
-    #   ie when optimistic concurrency control is used.
-    # @option options raise [Boolean] Prevents any exceptions from being
-    #   raised. Please note that this only applies to the bulk response, not to
-    #   the request in general, such that connection errors, etc will still
-    #   raise.
-
-    def bulk(options = {})
-      default_options = {
-        http_client: http_client,
-        bulk_limit: bulk_limit,
-        bulk_max_mb: bulk_max_mb
-      }
-
-      SearchFlip::Bulk.new("#{base_url}/_bulk", default_options.merge(options)) do |indexer|
-        yield indexer
-      end
-
-      refresh if SearchFlip::Config[:auto_refresh]
-    end
-
     # Returns the full Elasticsearch type URL, ie base URL, index name with
     # prefix and type name.
     #

data/lib/search_flip/criteria.rb

@@ -26,8 +26,7 @@ module SearchFlip
 
     attr_accessor :target, :profile_value, :source_value, :suggest_values, :includes_values,
       :eager_load_values, :preload_values, :failsafe_value, :scroll_args, :terminate_after_value,
-      :timeout_value, :preference_value, :search_type_value, :routing_value, :track_total_hits_value,
-      :http_timeout_value
+      :timeout_value, :preference_value, :search_type_value, :routing_value, :track_total_hits_value
 
     # Creates a new criteria while merging the attributes (constraints,
     # settings, etc) of the current criteria with the attributes of another one
@@ -48,7 +47,7 @@ module SearchFlip
         [
           :profile_value, :failsafe_value, :terminate_after_value, :timeout_value, :offset_value,
           :limit_value, :scroll_args, :source_value, :preference_value, :search_type_value,
-          :routing_value, :track_total_hits_value, :explain_value, :http_timeout_value
+          :routing_value, :track_total_hits_value, :explain_value
         ].each do |name|
           criteria.send(:"#{name}=", other.send(name)) unless other.send(name).nil?
         end
@@ -149,22 +148,6 @@ module SearchFlip
       end
     end
 
-    # Specifies a http timeout, such that a SearchFlip::TimeoutError will be
-    # thrown when the request times out.
-    #
-    # @example
-    #   ProductIndex.http_timeout(3).search("hello world")
-    #
-    # @param value [Fixnum] The timeout value
-    #
-    # @return [SearchFlip::Criteria] A newly created extended criteria
-
-    def http_timeout(value)
-      fresh.tap do |criteria|
-        criteria.http_timeout_value = value
-      end
-    end
-
     # Specifies early query termination, such that the processing will be
     # stopped after the specified number of results has been accumulated.
     #
@@ -347,15 +330,10 @@ module SearchFlip
       dupped_request.delete(:from)
       dupped_request.delete(:size)
 
-      http_request = connection.http_client
-      http_request = http_request.timeout(http_timeout_value) if http_timeout_value
-
       if connection.version.to_i >= 5
-        url = connection.version.to_i < 8 ? target.type_url : target.index_url
-
-        http_request.post("#{url}/_delete_by_query", params: request_params.merge(params), json: dupped_request)
+        connection.http_client.post("#{target.type_url}/_delete_by_query", params: request_params.merge(params), json: dupped_request)
       else
-        http_request.delete("#{target.type_url}/_query", params: request_params.merge(params), json: dupped_request)
+        connection.http_client.delete("#{target.type_url}/_query", params: request_params.merge(params), json: dupped_request)
       end
 
       target.refresh if SearchFlip::Config[:auto_refresh]
@@ -523,8 +501,8 @@ module SearchFlip
     end
 
     # Executes the search request for the current criteria, ie sends the
-    # request to Elasticsearch and returns the response. Connection, timeout
-    # and response errors will be rescued if you specify the criteria to be
+    # request to Elasticsearch and returns the response. Connection and
+    # response errors will be rescued if you specify the criteria to be
     # #failsafe, such that an empty response is returned instead.
     #
     # @example
@@ -612,7 +590,6 @@ module SearchFlip
 
     def execute!
       http_request = connection.http_client.headers(accept: "application/json")
-      http_request = http_request.timeout(http_timeout_value) if http_timeout_value
 
       http_response =
         if scroll_args && scroll_args[:id]
@@ -622,21 +599,17 @@ module SearchFlip
             json: { scroll: scroll_args[:timeout], scroll_id: scroll_args[:id] }
           )
         elsif scroll_args
-          url = connection.version.to_i < 8 ? target.type_url : target.index_url
-
           http_request.post(
-            "#{url}/_search",
+            "#{target.type_url}/_search",
             params: request_params.merge(scroll: scroll_args[:timeout]),
             json: request
           )
         else
-          url = connection.version.to_i < 8 ? target.type_url : target.index_url
-
-          http_request.post("#{url}/_search", params: request_params, json: request)
+          http_request.post("#{target.type_url}/_search", params: request_params, json: request)
         end
 
       SearchFlip::Response.new(self, SearchFlip::JSON.parse(http_response.to_s))
-    rescue SearchFlip::ConnectionError, SearchFlip::TimeoutError, SearchFlip::ResponseError => e
+    rescue SearchFlip::ConnectionError, SearchFlip::ResponseError => e
       raise e unless failsafe_value
 
       SearchFlip::Response.new(self, "took" => 0, "hits" => { "total" => 0, "hits" => [] })

data/lib/search_flip/filterable.rb

@@ -235,22 +235,6 @@ module SearchFlip
       filter(match_all: options)
     end
 
-    # Adds a match none filter to the criteria, which simply matches none
-    # documents at all. Check out the Elasticsearch docs for further details.
-    #
-    # @example Basic usage
-    #   CommentIndex.match_none
-    #
-    # @example Filter chaining
-    #   query = CommentIndex.search("...")
-    #   query = query.match_none unless current_user.admin?
-    #
-    # @return [SearchFlip::Criteria] A newly created extended criteria
-
-    def match_none
-      filter(match_none: {})
-    end
-
     # Adds an exists filter to the criteria, which selects all documents for
     # which the specified field has a non-null value.
     #