search_cop 1.0.5 → 1.0.6

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 
 # Changelog
 
+Version 1.0.5:
+
+* Fixes a bug regarding quotation
+
 Version 1.0.4:
 
 * Fix for Rails 4.2 regression regarding reflection access

data/README.md

@@ -130,7 +130,7 @@ Book.where(:available => true).search("Harry Potter").order("books.id desc").pag
 By default, i.e. if you don't tell SearchCop about your fulltext indices,
 SearchCop will use `LIKE '%...%'` queries. Unfortunately, unless you
 create a [trigram index](http://www.postgresql.org/docs/9.1/static/pgtrgm.html)
-(postgres only), theses queries can not use SQL indices, such that every row
+(postgres only), these queries can not use SQL indices, such that every row
 needs to be scanned by your RDBMS when you search for `Book.search("Harry
 Potter")` or similar. To avoid the penalty of `LIKE` queries, SearchCop
 can exploit the fulltext index capabilities of MySQL and PostgreSQL. To use
@@ -160,7 +160,7 @@ Book.search("Harry Potter")
 # PostgreSQL: ... WHERE (to_tsvector('simple', books.title) @@ to_tsquery('simple', 'Harry') OR to_tsvector('simple', books.author) @@ to_tsquery('simple', 'Harry')) AND (to_tsvector('simple', books.title) @@ to_tsquery('simple', 'Potter') OR to_tsvector('simple', books.author) @@ to_tsquery('simple', 'Potter'))
 ```
 
-Obviously, theses queries won't always return the same results as wildcard
+Obviously, these queries won't always return the same results as wildcard
 `LIKE` queries, because we search for words instead of sub-strings. However,
 fulltext indices will usually of course provide better performance.
 

data/lib/search_cop/version.rb

@@ -1,3 +1,3 @@
 module SearchCop
-  VERSION = "1.0.5"
+  VERSION = "1.0.6"
 end

data/lib/search_cop_grammar/attributes.rb

@@ -178,11 +178,11 @@ module SearchCopGrammar
       def parse(value)
         return value .. value unless value.is_a?(::String)
 
-        if value =~ /^[0-9]{4,}$/
+        if value =~ /^[0-9]{4}$/
           ::Time.new(value).beginning_of_year .. ::Time.new(value).end_of_year
-        elsif value =~ /^([0-9]{4,})(\.|-|\/)([0-9]{1,2})$/
+        elsif value =~ /^([0-9]{4})(\.|-|\/)([0-9]{1,2})$/
           ::Time.new($1, $3, 15).beginning_of_month .. ::Time.new($1, $3, 15).end_of_month
-        elsif value =~ /^([0-9]{1,2})(\.|-|\/)([0-9]{4,})$/
+        elsif value =~ /^([0-9]{1,2})(\.|-|\/)([0-9]{4})$/
           ::Time.new($3, $1, 15).beginning_of_month .. ::Time.new($3, $1, 15).end_of_month
         elsif value !~ /:/
           time = ::Time.parse(value)
@@ -222,11 +222,11 @@ module SearchCopGrammar
       def parse(value)
         return value .. value unless value.is_a?(::String)
 
-        if value =~ /^[0-9]{4,}$/
+        if value =~ /^[0-9]{4}$/
           ::Date.new(value.to_i).beginning_of_year .. ::Date.new(value.to_i).end_of_year
-        elsif value =~ /^([0-9]{4,})(\.|-|\/)([0-9]{1,2})$/
+        elsif value =~ /^([0-9]{4})(\.|-|\/)([0-9]{1,2})$/
           ::Date.new($1.to_i, $3.to_i, 15).beginning_of_month .. ::Date.new($1.to_i, $3.to_i, 15).end_of_month
-        elsif value =~ /^([0-9]{1,2})(\.|-|\/)([0-9]{4,})$/
+        elsif value =~ /^([0-9]{1,2})(\.|-|\/)([0-9]{4})$/
           ::Date.new($3.to_i, $1.to_i, 15).beginning_of_month .. ::Date.new($3.to_i, $1.to_i, 15).end_of_month
         else
           date = ::Date.parse(value)

data/test/date_test.rb

@@ -66,6 +66,12 @@ class DateTest < SearchCop::TestCase
     refute_includes Product.search("created_on <= 2014-05-01"), product
   end
 
+  def test_no_overflow
+    assert_nothing_raised do
+      Product.search("created_on: 1000000").to_a
+    end
+  end
+
   def test_incompatible_datatype
     assert_raises SearchCop::IncompatibleDatatype do
       Product.unsafe_search "created_on: Value"

data/test/datetime_test.rb

@@ -67,6 +67,12 @@ class DatetimeTest < SearchCop::TestCase
     refute_includes Product.search("created_at <= 2014-05-01"), product
   end
 
+  def test_no_overflow
+    assert_nothing_raised do
+      Product.search("created_at: 1000000").to_a
+    end
+  end
+
   def test_incompatible_datatype
     assert_raises SearchCop::IncompatibleDatatype do
       Product.unsafe_search "created_at: Value"

data/test/test_helper.rb

@@ -149,6 +149,10 @@ class SearchCop::TestCase
     assert value
   end
 
+  def assert_nothing_raised
+    yield
+  end
+
   def quote_table_name(name)
     ActiveRecord::Base.connection.quote_table_name name
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: search_cop
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-14 00:00:00.000000000 Z
+date: 2015-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: treetop