seams 0.1.0 → 0.2.0

data/lib/generators/seams/billing/templates/spec/fixtures/stripe/payment_intent_payment_failed.json.tt

@@ -4,6 +4,7 @@
   "type": "payment_intent.payment_failed",
   "livemode": false,
   "created": 1731000000,
+  "api_version": "2026-08-26.dahlia",
   "data": {
     "object": {
       "id": "pi_test_123",

data/lib/generators/seams/billing/templates/spec/fixtures/stripe/payment_intent_succeeded.json.tt

@@ -4,6 +4,7 @@
   "type": "payment_intent.succeeded",
   "livemode": false,
   "created": 1730900000,
+  "api_version": "2026-08-26.dahlia",
   "data": {
     "object": {
       "id": "pi_test_123",

data/lib/generators/seams/billing/templates/spec/gateways/stripe_spec.rb.tt

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require "rails_helper"
+require "webmock/rspec"
+require_relative "../../support/stripe_helpers"
 
 RSpec.describe Billing::Gateways::Stripe do
   let(:fake_client) { instance_double(Billing::Stripe::Client) }
@@ -15,7 +17,7 @@ RSpec.describe Billing::Gateways::Stripe do
       }
     end
 
-    it "delegates to the Faraday client with the documented param shape" do
+    it "delegates to the Stripe client with the documented param shape" do
       expect(fake_client).to receive(:create_subscription).with(
         customer: "cus_x", items: [{ price: "price_x" }]
       ).and_return(response)
@@ -24,6 +26,23 @@ RSpec.describe Billing::Gateways::Stripe do
       expect(result).to include(id: "sub_x", status: "active", plan_ref: "price_x", current_period_end: 1_700_000_000)
     end
 
+    # The real client returns ::Stripe::Subscription, which has no
+    # #dig. Build one from the stripe-ruby 19 (API 2026-08-26.dahlia)
+    # shape so the normaliser is exercised against the SDK type.
+    it "normalises a ::Stripe::Subscription from the SDK (period on the item)" do
+      sdk_sub = ::Stripe::Subscription.construct_from(
+        id: "sub_x", object: "subscription", status: "active",
+        items: { object: "list", data: [
+          { id: "si_x", object: "subscription_item", current_period_end: 1_700_000_000,
+            price: { id: "price_x", object: "price" } }
+        ] }
+      )
+      allow(fake_client).to receive(:create_subscription).and_return(sdk_sub)
+
+      result = gateway.create_subscription(customer_ref: "cus_x", plan_ref: "price_x")
+      expect(result).to eq(id: "sub_x", status: "active", current_period_end: 1_700_000_000, plan_ref: "price_x")
+    end
+
     it "lets Billing::GatewayError raised by the client propagate" do
       allow(fake_client).to receive(:create_subscription).and_raise(Billing::GatewayError, "bad")
       expect { gateway.create_subscription(customer_ref: "x", plan_ref: "y") }
@@ -44,6 +63,13 @@ RSpec.describe Billing::Gateways::Stripe do
       expect(event[:object]).to eq("id" => "sub_x")
     end
 
+    it "raises Billing::WebhookError on a signed v2 thin event (stripe-ruby 19 ArgumentError)" do
+      thin    = %({"id":"evt_2","object":"v2.core.event","type":"v1.billing.meter.error_report_triggered"})
+      sig     = OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new("sha256"), secret, "#{timestamp}.#{thin}")
+      expect { gateway.verify_webhook(payload: thin, signature: "t=#{timestamp},v1=#{sig}", secret: secret) }
+        .to raise_error(Billing::WebhookError, /not a v1 event/)
+    end
+
     it "raises Billing::WebhookError on a bad signature" do
       bad_header = "t=#{timestamp},v1=deadbeef"
       expect { gateway.verify_webhook(payload: payload, signature: bad_header, secret: secret) }
@@ -51,3 +77,23 @@ RSpec.describe Billing::Gateways::Stripe do
     end
   end
 end
+
+RSpec.describe Billing::Stripe::Client do
+  include StripeHelpers
+
+  let(:client) { described_class.new(api_key: "sk_test_fake") }
+
+  it "re-raises a Stripe auth failure as Billing::GatewayError (code :gateway_auth)" do
+    stub_stripe_failure(:post, "/v1/customers", status: 401, error_message: "Invalid API Key provided")
+    expect { client.create_customer(email: "a@example.com") }
+      .to raise_error(Billing::GatewayError, /\AStripe authentication error: /) { |e|
+        expect(e.cause).to be_a(::Stripe::AuthenticationError)
+      }
+  end
+
+  it "re-raises any other Stripe API error as Billing::GatewayError" do
+    stub_stripe_failure(:get, "/v1/invoices/in_missing", status: 404, error_message: "No such invoice")
+    expect { client.retrieve_invoice("in_missing") }
+      .to raise_error(Billing::GatewayError, /\AStripe InvalidRequestError: No such invoice/)
+  end
+end

data/lib/generators/seams/billing/templates/spec/runtime/webhook_handlers_spec.rb.tt

@@ -233,13 +233,51 @@ RSpec.describe "Billing webhook handlers (runtime)", type: :integration do
 
       invoice = Billing::Invoice.find_by(gateway_ref: "in_test_123")
       expect(invoice.status).to eq("paid")
-      expect(invoice.paid_at).not_to be_nil
+      # status_transitions.paid_at from the payload, not "now".
+      expect(invoice.paid_at).to be_within(1.second).of(Time.at(1_730_500_000))
       expect(invoice.amount_cents).to eq(1299)
       expect(invoice.account_id).to eq(TEST_ACCOUNT_ID)
+      expect(invoice.subscription_ref).to eq("sub_test_123")
       expect(captured.size).to eq(1)
     end
   end
 
+  # Fixtures carry the stripe-ruby 19 / 2026-08-26.dahlia shapes. A
+  # webhook endpoint pinned to an API version before 2025-03-31.basil
+  # still sends the old fields; the handlers read those too.
+  describe "payloads from API versions before 2025-03-31.basil" do
+    it "reads invoice.subscription when invoice.parent is absent" do
+      seed_account_on("cus_test_123")
+      full   = stripe_event_fixture("invoice_created").deep_dup
+      object = full[:data][:object]
+      object.delete(:parent)
+      object[:subscription] = "sub_legacy_123"
+
+      Billing::Webhooks::Handlers::InvoiceCreatedHandler.new(
+        event: { id: full[:id], type: full[:type], livemode: false, object: object, raw: full.to_json },
+        gateway: gateway
+      ).call
+
+      expect(Billing::Invoice.find_by(gateway_ref: "in_test_123").subscription_ref).to eq("sub_legacy_123")
+    end
+
+    it "reads subscription.current_period_end when items carry no period" do
+      seed_account_on("cus_test_123")
+      full   = stripe_event_fixture("customer_subscription_created").deep_dup
+      object = full[:data][:object]
+      object[:items][:data][0].delete(:current_period_end)
+      object[:current_period_end] = 1_700_000_000
+
+      Billing::Webhooks::Handlers::SubscriptionCreatedHandler.new(
+        event: { id: full[:id], type: full[:type], livemode: false, object: object, raw: full.to_json },
+        gateway: gateway
+      ).call
+
+      subscription = Billing::Subscription.find_by(gateway_ref: "sub_test_123")
+      expect(subscription.current_period_end).to be_within(1.second).of(Time.at(1_700_000_000))
+    end
+  end
+
   describe Billing::Webhooks::Handlers::InvoicePaymentFailedHandler do
     it "leaves the invoice in 'open' + publishes invoice.failed.billing" do
       seed_account_on("cus_test_123")