sdr-client 0.91.0 → 0.94.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8233c4bc5f385175264ff828603971ecf6f0e65e5ed5d973ce8eed2bf42be8e
-  data.tar.gz: 63cbe0407ada26d325730ad992a74964ae83cc3390a2a2ccd3b446b070c78969
+  metadata.gz: 803573f6b3fd95009062083305ecae6b1cd7aa673542c4323eccf1a1ffd5e111
+  data.tar.gz: 3169e6f1c5cc8ef6157bbd3cb7dff82aa35f2e2cc1e920ee4fead78bee56b5aa
 SHA512:
-  metadata.gz: 3b7fa91c363c8d88d53f168e17e9627cb773bdea6d51c2e3891e1ed5fdbcd57db731e9f021e7edc40b2426834e3d1c962627769126d605ba1f99134069dcdbb7
-  data.tar.gz: fbdbc1fafad4c9c1a47379fe697b8573b44cbd368b4a76ccdb7998898a93c3e9898286c8abf4b46326bd1c30ceed9ea1608fb3ba748e5cc44bb4415b8bb4581a
+  metadata.gz: 6055e3448f616c954db166a3292a40e1becdb3d43c588e5d66d34855d207623901a04bca1f19702ecce1162ee305efd6d42d80347f62db69de18720b0ea55988
+  data.tar.gz: 3195d9440212b3a460f6a1950341908a734d7053d94c75a36528730bcb09b53c0fc029090277d08a31c41859f80ba81e280f0fd92fe1c4e916972824ab823cda

data/.rubocop.yml

@@ -14,7 +14,7 @@ Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
     - 'sdr-client.gemspec'
-  IgnoredMethods:
+  AllowedMethods:
     - 'OptionParser.new'
 
 Metrics/ClassLength:
@@ -175,3 +175,10 @@ RSpec/Capybara/SpecificMatcher: # new in 2.12
   Enabled: true
 RSpec/Rails/HaveHttpStatus: # new in 2.12
   Enabled: true
+
+Lint/RequireRangeParentheses: # new in 1.32
+  Enabled: true
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude`
-# on 2022-05-05 05:53:08 UTC using RuboCop version 1.28.2.
+# on 2022-09-08 16:31:29 UTC using RuboCop version 1.36.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -19,7 +19,7 @@ Lint/NoReturnInBeginEndBlocks:
     - 'lib/sdr_client/deposit/model_process.rb'
 
 # Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
   Exclude:
@@ -27,20 +27,20 @@ Lint/UnusedMethodArgument:
     - 'lib/sdr_client/deposit/image_file_set_strategy.rb'
 
 # Offense count: 4
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max.
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
     - 'lib/sdr_client/cli.rb'
     - 'lib/sdr_client/update.rb'
 
 # Offense count: 1
-# Configuration parameters: IgnoredMethods, Max.
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, Max.
 Metrics/CyclomaticComplexity:
   Exclude:
     - 'lib/sdr_client/update.rb'
 
 # Offense count: 12
-# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/MethodLength:
   Exclude:
     - 'lib/sdr_client/cli.rb'
@@ -59,13 +59,12 @@ RSpec/ExampleLength:
     - 'spec/sdr_client/model_deposit_spec.rb'
     - 'spec/sdr_client/update_spec.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Exclude:
     - 'spec/sdr_client/client_spec.rb'
-    - 'spec/sdr_client/deposit/find_spec.rb'
     - 'spec/sdr_client/model_deposit_spec.rb'
 
 # Offense count: 1
@@ -75,17 +74,18 @@ RSpec/MessageSpies:
   Exclude:
     - 'spec/sdr_client/deposit_spec.rb'
 
-# Offense count: 12
+# Offense count: 13
 # Configuration parameters: Max.
 RSpec/MultipleExpectations:
   Exclude:
     - 'spec/sdr_client/connection_spec.rb'
     - 'spec/sdr_client/deposit/metadata_builder_spec.rb'
     - 'spec/sdr_client/deposit_spec.rb'
+    - 'spec/sdr_client/find_spec.rb'
     - 'spec/sdr_client/login_spec.rb'
     - 'spec/sdr_client/model_deposit_spec.rb'
 
-# Offense count: 32
+# Offense count: 36
 # Configuration parameters: AllowSubject, Max.
 RSpec/MultipleMemoizedHelpers:
   Exclude:
@@ -106,7 +106,7 @@ RSpec/NamedSubject:
     - 'spec/sdr_client/deposit/process_spec.rb'
     - 'spec/sdr_client/login_spec.rb'
 
-# Offense count: 16
+# Offense count: 19
 # Configuration parameters: Max.
 RSpec/NestedGroups:
   Exclude:
@@ -117,28 +117,28 @@ RSpec/NestedGroups:
     - 'spec/sdr_client/update_spec.rb'
 
 # Offense count: 19
-# This cop supports safe auto-correction (--auto-correct).
+# This cop supports safe autocorrection (--autocorrect).
 Style/KeywordParametersOrder:
   Exclude:
     - 'lib/sdr_client/deposit.rb'
     - 'lib/sdr_client/deposit/request.rb'
 
 # Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
+# This cop supports safe autocorrection (--autocorrect).
 Style/MultilineTernaryOperator:
   Exclude:
     - 'lib/sdr_client/update.rb'
 
 # Offense count: 2
-# This cop supports unsafe auto-correction (--auto-correct-all).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Mode.
 Style/StringConcatenation:
   Exclude:
     - 'lib/sdr_client/deposit/create_resource.rb'
     - 'spec/sdr_client/deposit_spec.rb'
 
-# Offense count: 29
-# This cop supports safe auto-correction (--auto-correct).
+# Offense count: 33
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
 # URISchemes: http, https
 Layout/LineLength:

data/Gemfile.lock

@@ -1,26 +1,26 @@
 PATH
   remote: .
   specs:
-    sdr-client (0.91.0)
+    sdr-client (0.94.0)
       activesupport
-      cocina-models (~> 0.83.0)
+      cocina-models (~> 0.84.0)
       dry-monads
       faraday (>= 0.16)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.3.1)
+    activesupport (7.0.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
+    addressable (2.8.1)
+      public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
     attr_extras (6.2.5)
     byebug (11.1.3)
-    cocina-models (0.83.0)
+    cocina-models (0.84.4)
       activesupport
       deprecation
       dry-struct (~> 1.0)
@@ -79,14 +79,12 @@ GEM
     json (2.6.2)
     jsonpath (1.1.2)
       multi_json
-    mini_portile2 (2.8.0)
-    minitest (5.16.2)
+    minitest (5.16.3)
     multi_json (1.15.0)
-    nokogiri (1.13.8)
-      mini_portile2 (~> 2.8.0)
-      racc (~> 1.4)
     nokogiri (1.13.8-x86_64-darwin)
       racc (~> 1.4)
+    nokogiri (1.13.8-x86_64-linux)
+      racc (~> 1.4)
     openapi3_parser (0.9.2)
       commonmarker (~> 0.17)
     openapi_parser (0.15.0)
@@ -96,7 +94,7 @@ GEM
       ast (~> 2.4.1)
     patience_diff (1.2.0)
       optimist (~> 3.0)
-    public_suffix (4.0.7)
+    public_suffix (5.0.0)
     racc (1.6.0)
     rainbow (3.1.1)
     rake (13.0.6)
@@ -119,7 +117,7 @@ GEM
       rspec-core (>= 2, < 4, != 2.12.0)
     rss (0.2.9)
       rexml
-    rubocop (1.35.0)
+    rubocop (1.36.0)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.1.2.1)
@@ -151,13 +149,14 @@ GEM
     tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.2.0)
-    webmock (3.17.1)
+    webmock (3.18.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
     zeitwerk (2.6.0)
 
 PLATFORMS
+  x86_64-darwin-19
   x86_64-darwin-21
   x86_64-linux
 

data/lib/sdr_client/deposit/update_dro_with_file_identifiers.rb

@@ -24,7 +24,7 @@ module SdrClient
       def self.updated_structural(structural, signed_ids)
         structural[:contains].each do |file_set|
           file_set[:structural][:contains].each do |file|
-            file[:externalIdentifier] = signed_ids[file[:filename]]
+            file[:externalIdentifier] = signed_ids[file[:filename]] if signed_ids.key?(file[:filename])
           end
         end
         structural

data/lib/sdr_client/find.rb

@@ -6,6 +6,11 @@ module SdrClient
   # The namespace for the "get" command
   module Find
     DRO_PATH = '/v1/resources/%<id>s'
+
+    # Raised when find returns an unsuccessful response
+    class Failed < StandardError; end
+
+    # @raise [Failed] if the find operation fails
     # @return [String] JSON for the given Cocina object or an error
     def self.run(druid, url:, logger: Logger.new($stdout))
       connection = Connection.new(url: url)
@@ -13,7 +18,9 @@ module SdrClient
       logger.info("Retrieving metadata from: #{path}")
       response = connection.get(path)
       unless response.success?
-        logger.error("There was an HTTP #{response.status} error making the request: #{response.body}")
+        error_message = "There was an HTTP #{response.status} error making the request: #{response.body}"
+        logger.error(error_message)
+        raise Failed, error_message
       end
       response.body
     end

data/lib/sdr_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SdrClient
-  VERSION = '0.91.0'
+  VERSION = '0.94.0'
 end

data/sdr-client.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'activesupport'
-  spec.add_dependency 'cocina-models', '~> 0.83.0'
+  spec.add_dependency 'cocina-models', '~> 0.84.0'
   spec.add_dependency 'dry-monads'
   spec.add_dependency 'faraday', '>= 0.16'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sdr-client
 version: !ruby/object:Gem::Version
-  version: 0.91.0
+  version: 0.94.0
 platform: ruby
 authors:
 - Justin Coyne
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-17 00:00:00.000000000 Z
+date: 2022-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.83.0
+        version: 0.84.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.83.0
+        version: 0.84.0
 - !ruby/object:Gem::Dependency
   name: dry-monads
   requirement: !ruby/object:Gem::Requirement