sdr-client 0.28.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8218f375715174e3c821a50017c93d6ea7608dec9e6d8eb3079da95687079ccf
-  data.tar.gz: bcf2362444e2fcaff1da53670d421d2886a37c2e0cad1a49c312bf8d41d7decb
+  metadata.gz: d7915d64ec8b5b9da302a842d19f37892e37d87b3db42dd82425235a452fd7ee
+  data.tar.gz: 9df81b46cbadb0ae2f787b070f87341a94e5a5c8956adde7e4397a17674931cf
 SHA512:
-  metadata.gz: c864d1c6642d3625a3d02e7d19cce2f434835baa67dd8d71e6060ed2ab45676eb7b4b7f930e1d2dac74cf640da29832fdab2e4c006e5cbed9723568274364972
-  data.tar.gz: aaa132697e45bad33b362b3bb7c9eb431c2f718115c7cab985619376b29f62b1b9451c2e3a4276f6ab29b415e943ddced44527340c3d2526ba1d4459948a919a
+  metadata.gz: 17f1fc289f19810041b138a4ca2b6298362c4a7e9fa5fb42cdfc42b7f7292163689715c943ef056e12c541fc50de63e2c115b9f7ab78bcda69f093339b535a82
+  data.tar.gz: cef601f676e20c11264cafb4299f1bcdcad51d8b534961712e0e0d6ea78e3a3a809e581da2ea0d1e12775f2e7d0a0ec1a0035d61c1d0c85b20a4798845a5be40

data/.circleci/config.yml

@@ -0,0 +1,35 @@
+version: 2.1
+
+jobs:
+  build:
+    docker:
+      - image: circleci/ruby:2.7.1
+        environment:
+          CC_TEST_REPORTER_ID: 859fcfe88b00c026d15dce30e838e2299face8088b49fe62bc3a02d1507ce3d5
+          RAILS_ENV: test
+    steps:
+      - checkout
+      - run:
+          name: Install Bundler
+          command: gem install bundler
+      - run:
+          name: Which bundler?
+          command: bundle -v
+      - run:
+          name: Bundle Install
+          command: bundle check || bundle install
+      - run:
+          name: Lint using rubocop
+          command: bundle exec rubocop
+      - run:
+          name: Setup Code Climate test-reporter
+          command: |
+            curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+            chmod +x ./cc-test-reporter
+            ./cc-test-reporter before-build
+      - run:
+          name: rspec
+          command: bundle exec rspec
+      - run:
+          name: upload test coverage report to Code Climate
+          command: ./cc-test-reporter after-build --coverage-input-type simplecov --exit-code $?

data/.rubocop.yml

@@ -1,4 +1,3 @@
-
 inherit_from: .rubocop_todo.yml
 
 AllCops:
@@ -7,11 +6,6 @@ AllCops:
     - 'bin/console'
     - 'vendor/**/*'
 
-Layout/LineLength:
-  Max: 120
-  Exclude:
-    - 'spec/sdr_client/deposit/process_spec.rb'
-
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
@@ -21,4 +15,4 @@ Metrics/BlockLength:
 
 Naming/FileName:
   Exclude:
-    - 'lib/sdr-client.rb'
+    - 'lib/sdr-client.rb'

data/.rubocop_todo.yml

@@ -1,17 +1,29 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-04-27 08:24:29 -0400 using RuboCop version 0.82.0.
+# on 2020-06-24 17:02:25 -0700 using RuboCop version 0.79.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 2
-# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 16
 
-# Offense count: 7
+# Offense count: 8
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 15
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'exe/sdr'
+
+# Offense count: 187
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 1228

data/README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://travis-ci.org/sul-dlss/sdr-client.svg?branch=master)](https://travis-ci.org/sul-dlss/sdr-client)
+[![CircleCI](https://circleci.com/gh/sul-dlss/sdr-client.svg?style=svg)](https://circleci.com/gh/sul-dlss/sdr-client)
 [![Maintainability](https://api.codeclimate.com/v1/badges/1210855d46d4f424bf30/maintainability)](https://codeclimate.com/github/sul-dlss/sdr-client/maintainability)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/1210855d46d4f424bf30/test_coverage)](https://codeclimate.com/github/sul-dlss/sdr-client/test_coverage)
 [![Gem Version](https://badge.fury.io/rb/sdr-client.svg)](https://badge.fury.io/rb/sdr-client)

data/lib/sdr_client.rb

@@ -5,6 +5,7 @@ require 'faraday'
 require 'active_support'
 require 'active_support/core_ext/object/json'
 require 'active_support/core_ext/hash/indifferent_access'
+require 'active_support/core_ext/file/atomic'
 require 'cocina/models'
 
 require 'sdr_client/version'

data/lib/sdr_client/credentials.rb

@@ -9,15 +9,19 @@ module SdrClient
     def self.write(body)
       json = JSON.parse(body)
       Dir.mkdir(credentials_path, 0o700) unless Dir.exist?(credentials_path)
-      File.open(credentials_file, 'w', 0o600) do |file|
+      File.atomic_write(credentials_file) do |file|
         file.write(json.fetch('token'))
       end
+      File.chmod(0o600, credentials_file)
     end
 
     def self.read
       raise NoCredentialsError unless ::File.exist?(credentials_file)
 
-      IO.readlines(credentials_file, chomp: true).first
+      creds = IO.readlines(credentials_file, chomp: true).first if ::File.exist?(credentials_file)
+      raise NoCredentialsError if creds.nil?
+
+      creds
     end
 
     def self.credentials_path

data/lib/sdr_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SdrClient
-  VERSION = '0.28.0'
+  VERSION = '0.29.0'
 end

data/sdr-client.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'activesupport'
-  spec.add_dependency 'cocina-models', '~> 0.33.0'
+  spec.add_dependency 'cocina-models', '~> 0.34.1'
   spec.add_dependency 'dry-monads'
   spec.add_dependency 'faraday', '>= 0.16'
 
@@ -37,6 +37,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.79.0'
   spec.add_development_dependency 'rubocop-rspec', '~> 1.37.1'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'simplecov', '~> 0.17.0' # CodeClimate cannot use SimpleCov >= 0.18.0 for generating test coverage
   spec.add_development_dependency 'webmock', '~> 3.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sdr-client
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors:
 - Justin Coyne
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-16 00:00:00.000000000 Z
+date: 2020-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.33.0
+        version: 0.34.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.33.0
+        version: 0.34.1
 - !ruby/object:Gem::Dependency
   name: dry-monads
   requirement: !ruby/object:Gem::Requirement
@@ -140,16 +140,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.17.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.17.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -173,12 +173,12 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".github/pull_request_template.md"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -234,7 +234,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: The CLI for https://github.com/sul-dlss/sdr-api

data/.travis.yml

@@ -1,20 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.6.4
-before_install: gem install bundler -v 2.1.2
-
-before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-
-env:
-  global:
-    - CC_TEST_REPORTER_ID=859fcfe88b00c026d15dce30e838e2299face8088b49fe62bc3a02d1507ce3d5
-notifications:
-  email: false