sdr-client 0.27.0 → 0.28.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b57004bc33af516fb892a3d1cd317c1549319e97e4ca4ccc7c9ea82a00f81c0
-  data.tar.gz: 808661eb382c5a6f3098a96a473fa8396f29d413e290d822d32739f9fe34db49
+  metadata.gz: 6db2cf36687c4acd4edf26d6046299958450211f89a4e29984d4955c84c891a9
+  data.tar.gz: f614d2ae6ecf2a6ac35775d9b20f6ac800c805c1aa8e8700052ffef3531b214d
 SHA512:
-  metadata.gz: 343d5374e9e2b12731ff06111d71646fcca815c030e67e4fd29b65477440b9bc1fde6a04b2d597ccb17c37ec56ff5a6cdc4010ad05bfaba30c7eed569ecf94b3
-  data.tar.gz: 356c88775241392487f41a31733169625f43f745e6e0c9e432a464e581b6c366a13148cd22495877972db75808e402efbf5929761adac1ad4445b35c12bc3fa9
+  metadata.gz: 36b84aec31d944071d118a997cc16a48149c562812da2173af9927db31ae92c4e8d44d0ad9d55e43ef434f9f5d9be6898fecebffc967d44ff0350caa0c2ba4b5
+  data.tar.gz: 744e993e54fa8dc5cffff643cd619879d4b4c65d63431f7892ca77bd79da63d353cb3d299a029f516bec2c3e16dcb534de112a664c2435f2d01f0130318bdd9d

data/.rubocop.yml

@@ -1,4 +1,3 @@
-
 inherit_from: .rubocop_todo.yml
 
 AllCops:
@@ -7,11 +6,6 @@ AllCops:
     - 'bin/console'
     - 'vendor/**/*'
 
-Layout/LineLength:
-  Max: 120
-  Exclude:
-    - 'spec/sdr_client/deposit/process_spec.rb'
-
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
@@ -21,4 +15,4 @@ Metrics/BlockLength:
 
 Naming/FileName:
   Exclude:
-    - 'lib/sdr-client.rb'
+    - 'lib/sdr-client.rb'

data/.rubocop_todo.yml

@@ -1,17 +1,29 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-04-27 08:24:29 -0400 using RuboCop version 0.82.0.
+# on 2020-06-24 17:02:25 -0700 using RuboCop version 0.79.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 2
-# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 16
 
-# Offense count: 7
+# Offense count: 8
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 15
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'exe/sdr'
+
+# Offense count: 187
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 1228

data/exe/sdr

@@ -31,8 +31,8 @@ deposit_options = OptionParser.new do |opts|
 
   opts.on('--type TYPE', 'The object type to create. ' \
           'One of: "image", "book", "document", "map", "manuscript", "media", ' \
-          '"three_dimensional", "collection", or "admin_policy"') do |type|
-    if %w[image book document map manuscript media three_dimensional collection admin_policy].include?(type)
+          '"three_dimensional", "object", "collection", or "admin_policy"') do |type|
+    if %w[image book document map manuscript media three_dimensional object collection admin_policy].include?(type)
       options[:type] = "http://cocina.sul.stanford.edu/models/#{type}.jsonld"
     end
   end

data/lib/sdr_client.rb

@@ -5,6 +5,7 @@ require 'faraday'
 require 'active_support'
 require 'active_support/core_ext/object/json'
 require 'active_support/core_ext/hash/indifferent_access'
+require 'active_support/core_ext/file/atomic'
 require 'cocina/models'
 
 require 'sdr_client/version'

data/lib/sdr_client/credentials.rb

@@ -9,15 +9,19 @@ module SdrClient
     def self.write(body)
       json = JSON.parse(body)
       Dir.mkdir(credentials_path, 0o700) unless Dir.exist?(credentials_path)
-      File.open(credentials_file, 'w', 0o600) do |file|
+      File.atomic_write(credentials_file) do |file|
         file.write(json.fetch('token'))
       end
+      File.chmod(0o600, credentials_file)
     end
 
     def self.read
       raise NoCredentialsError unless ::File.exist?(credentials_file)
 
-      IO.readlines(credentials_file, chomp: true).first
+      creds = IO.readlines(credentials_file, chomp: true).first if ::File.exist?(credentials_file)
+      raise NoCredentialsError if creds.nil?
+
+      creds
     end
 
     def self.credentials_path

data/lib/sdr_client/deposit/file_metadata_builder_operations/mime_type.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'digest'
+require 'shellwords'
 
 module SdrClient
   module Deposit
@@ -9,7 +9,8 @@ module SdrClient
       class MimeType
         NAME = 'mime_type'
         def self.for(file_path:, **)
-          `file --mime-type -b #{file_path}`.chomp
+          argv = Shellwords.escape(file_path)
+          `file --mime-type -b #{argv}`.chomp
         end
       end
     end

data/lib/sdr_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SdrClient
-  VERSION = '0.27.0'
+  VERSION = '0.28.4'
 end

data/sdr-client.gemspec

@@ -37,6 +37,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.79.0'
   spec.add_development_dependency 'rubocop-rspec', '~> 1.37.1'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'simplecov', '~> 0.17.0' # CodeClimate cannot use SimpleCov >= 0.18.0 for generating test coverage
   spec.add_development_dependency 'webmock', '~> 3.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sdr-client
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.28.4
 platform: ruby
 authors:
 - Justin Coyne
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-11 00:00:00.000000000 Z
+date: 2020-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -140,16 +140,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.17.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.17.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement