sdk-reforge 1.9.1 → 1.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c9d01ab174a9a1de737bd5791203b24fe2b4e4edc029497233e704a3475f17f
-  data.tar.gz: 21a6556498ae0131164663d297890669b100ae3dccdaf6575a7e17b996ef988b
+  metadata.gz: 46d6f6afa160400b4319eb454fd5271462d1dc8264570c549327652a4debb1c3
+  data.tar.gz: 4a88ea9de1cdfef5dc0e8eff6f8d7b210808ffed6236efb8ec150d138d6923cd
 SHA512:
-  metadata.gz: 2c6b7c7f36252e0e9434dc77a82ffc043c39f6085b405440a988ae2b8145ca127b90eaceca1b07d63ffa66d5cded48477d53fb9b2178a9afc5825966ec2d4724
-  data.tar.gz: f662153d281cce2fa52dbc4e8e7ad0c5864c896168a403900ca621f9e691a1e84c72c70186342b613bda714638c368c8e51074a5388f8d1a2ab542d47eff1755
+  metadata.gz: 569a9c836b3c0d85f06387235f3909343233ee2d5c8ab9c5d888d5f7780a16cac6c70b78fafa89e9cf3653890c16c1eb86a5461afedce5d96edcf904c1d8a42a
+  data.tar.gz: 1dd174148278acbc0625ee85081c39ca3d975d710ee837813c4ab3587f117796a341c27d63fd548e16a423d040421efb9096e62809d9922818d9a5ed6de508b2

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+
+## 1.9.2 - 2025-10-02
+
+- Fix bug in row index calculation for the evaluation summary data
+
 ## 1.9.1 - 2025-10-01
 
 - Fix entrypoint

data/VERSION

@@ -1 +1 @@
-1.9.1
+1.9.2

data/lib/reforge/criteria_evaluator.rb

@@ -227,11 +227,23 @@ module Reforge
         row.values.each_with_index do |conditional_value, value_index|
           next unless all_criteria_match?(conditional_value, properties)
 
+          # we compute the row index here as if the @config.rows were sorted with the default environment (id=0) last. the client would only ever see one or two rows
+          # 2 rows if there's a default env rule and a targed env rule
+          # 1 row if there's only a default env rule or only a target env rule
+          config_row_index = if @config.rows.length == 1
+                               0
+                             elsif row.project_env_id != 0
+                               0
+                             else
+                               1
+                             end
+
+
           return Reforge::Evaluation.new(
             config: @config,
             value: conditional_value.value,
             value_index: value_index,
-            config_row_index: index,
+            config_row_index: config_row_index,
             context: properties,
             resolver: @resolver
           )

data/sdk-reforge.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: sdk-reforge 1.9.1 ruby lib
+# stub: sdk-reforge 1.9.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "sdk-reforge".freeze
-  s.version = "1.9.1"
+  s.version = "1.9.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jeff Dwyer".freeze]
-  s.date = "2025-10-01"
+  s.date = "2025-10-02"
   s.description = "Feature Flags, Live Config as a service".freeze
   s.email = "jeff.dwyer@reforge.com.cloud".freeze
   s.extra_rdoc_files = [

data/test/support/common_helpers.rb

@@ -137,7 +137,21 @@ module CommonHelpers
   def assert_summary(client, data)
     raise 'Evaluation summary aggregator not enabled' unless client.evaluation_summary_aggregator
 
-    assert_equal data, client.evaluation_summary_aggregator.data
+    actual = client.evaluation_summary_aggregator.data
+
+    # Compare keys first (order independent)
+    assert_equal data.keys.sort_by(&:to_s), actual.keys.sort_by(&:to_s), "Summary keys mismatch"
+
+    # Then compare each nested hash (order independent)
+    data.each do |key, expected_counters|
+      actual_counters = actual[key]
+
+      # Convert to sets for order-independent comparison
+      expected_set = expected_counters.to_a.to_set
+      actual_set = actual_counters.to_a.to_set
+
+      assert_equal expected_set, actual_set, "Counter mismatch for #{key}"
+    end
   end
 
   def assert_example_contexts(client, data)

data/test/test_client.rb

@@ -106,7 +106,7 @@ class TestClient < Minitest::Test
       [KEY, :CONFIG] => {
         {
           config_id: config.id,
-          config_row_index: 1,
+          config_row_index: 0,
           selected_value: DESIRED_VALUE_CONFIG,
           conditional_value_index: 0,
           weighted_value_index: nil,
@@ -131,7 +131,7 @@ class TestClient < Minitest::Test
       [KEY, :CONFIG] => {
         {
           config_id: config.id,
-          config_row_index: 1,
+          config_row_index: 0,
           selected_value: DESIRED_VALUE_CONFIG,
           conditional_value_index: 0,
           weighted_value_index: nil,
@@ -181,7 +181,7 @@ class TestClient < Minitest::Test
       [KEY, :CONFIG] => {
         {
           config_id: config.id,
-          config_row_index: 1,
+          config_row_index: 0,
           selected_value: PrefabProto::ConfigValue.new(string: 'abc'),
           conditional_value_index: 0,
           weighted_value_index: 0,
@@ -190,7 +190,7 @@ class TestClient < Minitest::Test
 
         {
           config_id: config.id,
-          config_row_index: 1,
+          config_row_index: 0,
           selected_value: PrefabProto::ConfigValue.new(string: 'def'),
           conditional_value_index: 0,
           weighted_value_index: 1,
@@ -199,7 +199,7 @@ class TestClient < Minitest::Test
 
         {
           config_id: config.id,
-          config_row_index: 1,
+          config_row_index: 0,
           selected_value: PrefabProto::ConfigValue.new(string: 'ghi'),
           conditional_value_index: 0,
           weighted_value_index: 2,
@@ -278,9 +278,9 @@ class TestClient < Minitest::Test
           weighted_value_index: nil, selected_index: nil } => 1
       },
       [KEY, :NOT_SET_CONFIG_TYPE] => {
-        { config_id: 0, config_row_index: 0, conditional_value_index: 0, selected_value: DEFAULT_VALUE_CONFIG,
+        { config_id: 0, config_row_index: 1, conditional_value_index: 0, selected_value: DEFAULT_VALUE_CONFIG,
           weighted_value_index: nil, selected_index: nil } => 2,
-        { config_id: 0, config_row_index: 1, conditional_value_index: 0, selected_value: DESIRED_VALUE_CONFIG,
+        { config_id: 0, config_row_index: 0, conditional_value_index: 0, selected_value: DESIRED_VALUE_CONFIG,
           weighted_value_index: nil, selected_index: nil } => 1
       }
     }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: sdk-reforge
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.9.2
 platform: ruby
 authors:
 - Jeff Dwyer
 bindir: bin
 cert_chain: []
-date: 2025-10-01 00:00:00.000000000 Z
+date: 2025-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby