scss_lint 0.57.1 → 0.58.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: adfca59ecf233f95713f55a90aea77f6cbf10a2546a0598225809b2381db2d83
-  data.tar.gz: 14dfb730615d12c3395af9a36c14beb0e35a897ad24ab9e4e5387d3fd25b85b5
+  metadata.gz: 92e61fd011e43d17184d85050c0ade3bc1c523df0460690cd9bfb981a4e1e3eb
+  data.tar.gz: 57f90d69091f7da90fd470991011c28098622346f49e5ccdf42c44118e6f7c0c
 SHA512:
-  metadata.gz: 673054a1230b817a048cf21ac011b7bc79b95cce16ae507821a09318a0c6d87ce1e857d4c24198a14d7d0333fa53c9ddcb95ced7049eb3c10ee3b169a05328cd
-  data.tar.gz: c8428851d3399867f6e519419695b2cec1f496d12fad8e95f923789797ac1df990f7be17a56e98e1c954faa777ebe62e0caa3f4be1b7a2fcf7d944ab9b7be1d4
+  metadata.gz: ca68ec7818ecde8761f172cb23d0054280e6473a74f49b75dd3a424b8eede6effc2d8132006531da5c01800f8bc7d78661096d1ce151b8911d71d923da3a1ffd
+  data.tar.gz: 86824a7d4e3b21fb298a5a4e21668fa1c045a4691cfa0e0f967f279b49002fbf386919693d9f4dd3107db62fa8b1962389e3b01a99c2d6db5a7ceae6329d6fb6

data/MIT-LICENSE

@@ -1,5 +1,4 @@
-Copyright (c) 2014-2015 Brigade
-http://www.brigade.com/
+Copyright (c) Shane da Silva
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/data/properties.txt

@@ -125,6 +125,7 @@ break-before
 break-inside
 buffered-rendering
 caption-side
+caret-color
 clear
 clip
 clip-path
@@ -155,6 +156,8 @@ counter-increment
 counter-reset
 crop
 cursor
+cx
+cy
 direction
 display
 dominant-baseline
@@ -198,6 +201,7 @@ font-stretch
 font-style
 font-variant
 font-variant-ligatures
+font-variant-numeric
 font-weight
 glyph-orientation-horizontal
 glyph-orientation-vertical
@@ -390,11 +394,13 @@ perspective-origin
 perspective-origin-x
 perspective-origin-y
 phonemes
+place-content
 pointer-events
 position
 print-color-adjust
 punctuation-trim
 quotes
+r
 region-break-after
 region-break-before
 region-break-inside
@@ -412,7 +418,10 @@ ruby-align
 ruby-overhang
 ruby-position
 ruby-span
+rx
+ry
 scroll-behavior
+scrollbar-width
 shape-image-threshold
 shape-inside
 shape-margin
@@ -524,5 +533,7 @@ word-wrap
 wrap-flow
 wrap-through
 writing-mode
+x
+y
 z-index
 zoom

data/data/pseudo-elements.txt

@@ -29,6 +29,7 @@
 -moz-viewport
 -moz-viewport-scroll
 -moz-xul-anonymous-block
+-ms-backdrop
 -ms-browse
 -ms-check
 -ms-clear
@@ -54,6 +55,7 @@
 -webkit-datetime-edit-month-field
 -webkit-datetime-edit-text
 -webkit-datetime-edit-year-field
+-webkit-details-marker
 -webkit-file-upload-button
 -webkit-full-page-media
 -webkit-inner-spin-button

data/lib/scss_lint/cli.rb

@@ -31,8 +31,8 @@ module SCSSLint
     def run(args)
       options = SCSSLint::Options.new.parse(args)
       act_on_options(options)
-    rescue StandardError => ex
-      handle_runtime_exception(ex, options)
+    rescue StandardError => e
+      handle_runtime_exception(e, options)
     end
 
   private
@@ -205,9 +205,9 @@ module SCSSLint
       Array(options[:required_paths]).each do |path|
         require path
       end
-    rescue LoadError => ex
+    rescue LoadError => e
       raise SCSSLint::Exceptions::RequiredLibraryMissingError,
-            "Required library not found: #{ex.message}"
+            "Required library not found: #{e.message}"
     end
 
     def load_reporters(options)

data/lib/scss_lint/config.rb

@@ -64,9 +64,9 @@ module SCSSLint
             else
               {}
             end
-        rescue StandardError => ex
+        rescue StandardError => e
           raise SCSSLint::Exceptions::InvalidConfiguration,
-                "Invalid configuration: #{ex.message}"
+                "Invalid configuration: #{e.message}"
         end
 
         options = convert_single_options_to_arrays(options)
@@ -94,8 +94,6 @@ module SCSSLint
       # Merge options from wildcard linters into individual linter configs
       def merge_wildcard_linter_options(options)
         options = options.dup
-
-        # rubocop:disable Performance/HashEachMethods (FALSE POSITIVE)
         # Cannot use `each_key` because the cycle adds new keys during iteration
         options.fetch('linters', {}).keys.each do |class_name|
           next unless class_name.include?('*')
@@ -103,7 +101,6 @@ module SCSSLint
           wildcard_options = options['linters'].delete(class_name)
           apply_options_to_matching_linters(class_name, options, wildcard_options)
         end
-        # rubocop:enable Performance/HashEachMethods
 
         options
       end

data/lib/scss_lint/constants.rb

@@ -5,6 +5,6 @@ module SCSSLint
   SCSS_LINT_HOME = File.realpath(File.join(File.dirname(__FILE__), '..', '..')).freeze
   SCSS_LINT_DATA = File.join(SCSS_LINT_HOME, 'data').freeze
 
-  REPO_URL = 'https://github.com/brigade/scss-lint'.freeze
+  REPO_URL = 'https://github.com/sds/scss-lint'.freeze
   BUG_REPORT_URL = "#{REPO_URL}/issues".freeze
 end

data/lib/scss_lint/engine.rb

@@ -34,12 +34,12 @@ module SCSSLint
                         .lines
       @tree = @engine.to_tree
       find_any_control_commands
-    rescue Encoding::UndefinedConversionError, Sass::SyntaxError, ArgumentError => error
-      if error.is_a?(Encoding::UndefinedConversionError) ||
-         error.message.match(/invalid.*(byte sequence|character)/i)
+    rescue Encoding::UndefinedConversionError, Sass::SyntaxError, ArgumentError => e
+      if e.is_a?(Encoding::UndefinedConversionError) ||
+         e.message.match(/invalid.*(byte sequence|character)/i)
         raise FileEncodingError,
-              "Unable to parse SCSS file: #{error}",
-              error.backtrace
+              "Unable to parse SCSS file: #{e}",
+              e.backtrace
       else
         raise
       end

data/lib/scss_lint/linter.rb

@@ -75,7 +75,7 @@ module SCSSLint
                  line_source.length - range.start_pos.offset + 1
                end
 
-      # Workaround for https://github.com/brigade/scss-lint/issues/887 to acount for
+      # Workaround for https://github.com/sds/scss-lint/issues/887 to acount for
       # https://github.com/sass/sass/issues/2284.
       length = 1 if length < 1
 

data/lib/scss_lint/linter/color_variable.rb

@@ -18,13 +18,10 @@ module SCSSLint
 
     def visit_script_string(node)
       return if literal_string?(node)
-
-      # rubocop:disable Performance/HashEachMethods (FALSE POSITIVE v0.50.0)
       remove_quoted_strings(node.value)
         .scan(/(^|\s)(#[a-f0-9]+|[a-z]+)(?=\s|$)/i)
         .select { |_, word| color?(word) }
         .each   { |_, color| record_lint(node, color) }
-      # rubocop:enable Performance/HashEachMethods
     end
 
     def visit_script_funcall(node)

data/lib/scss_lint/linter/disable_linter_reason.rb

@@ -7,7 +7,7 @@ module SCSSLint
       # No lint if the first line of the comment is not a command (because then
       # either this comment has no commands, or the first line serves as a the
       # reason for a command on a later line).
-      if comment_lines(node).first.match(COMMAND_REGEX)
+      if comment_lines(node).first.match?(COMMAND_REGEX)
         visit_command_comment(node)
       else
         @previous_comment = node
@@ -21,7 +21,7 @@ module SCSSLint
       end
 
       # Not a "disable linter reason" if the last line of the previous comment is a command.
-      if comment_lines(@previous_comment).last.match(COMMAND_REGEX)
+      if comment_lines(@previous_comment).last.match?(COMMAND_REGEX)
         report_lint(node)
         return
       end
@@ -48,7 +48,7 @@ module SCSSLint
       (?<action>disable)\s+
       (?<linters>.*?)
       \s*(?:\*/|\n) # Comment end marker or end of line
-    }x
+    }x.freeze
 
     def comment_lines(node)
       node.value.join.split("\n")

data/lib/scss_lint/linter/hex_length.rb

@@ -4,7 +4,7 @@ module SCSSLint
   class Linter::HexLength < Linter
     include LinterRegistry
 
-    HEX_REGEX = /(#(\h{3}|\h{6}))(?!\h)/
+    HEX_REGEX = /(#(\h{3}|\h{6}))(?!\h)/.freeze
 
     def visit_script_color(node)
       return unless hex = source_from_range(node.source_range)[HEX_REGEX, 1]

data/lib/scss_lint/linter/hex_notation.rb

@@ -3,7 +3,7 @@ module SCSSLint
   class Linter::HexNotation < Linter
     include LinterRegistry
 
-    HEX_REGEX = /(#(\h{3}|\h{6}))(?!\h)/
+    HEX_REGEX = /(#(\h{3}|\h{6}))(?!\h)/.freeze
 
     def visit_script_color(node)
       return unless hex = source_from_range(node.source_range)[HEX_REGEX, 1]

data/lib/scss_lint/linter/hex_validation.rb

@@ -13,10 +13,10 @@ module SCSSLint
 
   private
 
-    HEX_REGEX = /(#(\h{3}|\h{6}|\h{8}))(?!\h)/
+    HEX_REGEX = /(#(\h{3}|\h{6}|\h{8}))(?!\h)/.freeze
 
     def check_hex(hex, node)
-      return if HEX_REGEX.match(hex)
+      return if HEX_REGEX.match?(hex)
       add_lint(node, "Colors must have either three or six digits: `#{hex}`")
     end
   end

data/lib/scss_lint/linter/indentation.rb

@@ -98,7 +98,7 @@ module SCSSLint
 
     def visit_import(node)
       previous_node(node)
-      return unless engine.lines[node.line - 1] =~ /@import/
+      return unless engine.lines[node.line - 1].match?(/@import/)
       check_indentation(node)
     end
 

data/lib/scss_lint/linter/leading_zero.rb

@@ -22,7 +22,7 @@ module SCSSLint
 
   private
 
-    NUMBER_WITH_LEADING_ZERO_REGEX = /^-?(0?\.\d+)/
+    NUMBER_WITH_LEADING_ZERO_REGEX = /^-?(0?\.\d+)/.freeze
 
     CONVENTIONS = {
       'exclude_zero' => {

data/lib/scss_lint/linter/length_variable.rb

@@ -23,7 +23,7 @@ module SCSSLint
         (?:#{LENGTH_UNITS.join('|')}) # unit!
       )
       (?:$|[\s+\-/*()]) # math or space separated, or end of string
-    }x
+    }x.freeze
 
     def visit_prop(node)
       return if allowed_prop?(node)

data/lib/scss_lint/linter/property_units.rb

@@ -15,7 +15,7 @@ module SCSSLint
        )
        ([a-z%]+)   # [1: units] letters or percent sign, e.g. px or %
       )
-    /ix
+    /ix.freeze
 
     def visit_root(_node)
       @globally_allowed_units = config['global'].to_set

data/lib/scss_lint/linter/selector_depth.rb

@@ -47,7 +47,7 @@ module SCSSLint
       # combinator, as these "combine" simple sequences such that they do not
       # increase depth.
       depth = simple_sequences.size -
-        separators.count { |item| item == '~' || item == '+' }
+        separators.count { |item| %w[~ +].include?(item) }
 
       depth +=
         if parent_selectors > 0

data/lib/scss_lint/linter/shorthand.rb

@@ -64,7 +64,7 @@ module SCSSLint
       (\S+\s+\S+(\s+\S+){0,2})   # Two to four values separated by spaces
       (\s+!\w+)?                 # Ignore `!important` priority overrides
       \z
-    /x
+    /x.freeze
 
     # @param prop [String]
     # @param script_string [Sass::Script::Value::String]

data/lib/scss_lint/linter/space_around_operator.rb

@@ -13,7 +13,7 @@ module SCSSLint
       # (only selectors?), the source ranges are offset by two (probably not
       # accounting for the `#{`. Slide everything to the left by 2, and maybe
       # things will look sane this time.
-      unless operation_sources.operator_source =~ Sass::Script::Lexer::REGULAR_EXPRESSIONS[:op]
+      unless operation_sources.operator_source.match?(Sass::Script::Lexer::REGULAR_EXPRESSIONS[:op])
         operation_sources.adjust_for_interpolation
         operation_sources.adjust_sources
       end

data/lib/scss_lint/linter/space_between_parens.rb

@@ -29,7 +29,7 @@ module SCSSLint
 
   private
 
-    TRAILING_WHITESPACE = /\s*$/
+    TRAILING_WHITESPACE = /\s*$/.freeze
 
     def check(node, source) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
       @spaces = config['spaces']
@@ -90,7 +90,7 @@ module SCSSLint
       # those parens may be part of a parent function call. We don't care about
       # such parens. This depends on whether the preceding character is part of
       # a function name.
-      return original_source if character_at(range.start_pos, left_offset - 1) =~ /[A-Za-z0-9_]/
+      return original_source if character_at(range.start_pos, left_offset - 1).match?(/[A-Za-z0-9_]/)
 
       range.start_pos.offset += left_offset
       range.end_pos.offset += right_offset

data/lib/scss_lint/linter/string_quotes.rb

@@ -45,7 +45,7 @@ module SCSSLint
       \s*\)?\s*;?\s*  # Sometimes the Sass parser includes a trailing ) or ;
       (//.*)?         # Exclude any trailing comments that might have snuck in
       \z
-    }x
+    }x.freeze
 
     def extract_string_without_quotes(source)
       return unless match = STRING_WITHOUT_QUOTES_REGEX.match(source)
@@ -66,7 +66,7 @@ module SCSSLint
         if string =~ /(?<! \\) \\'/x && string !~ /"/
           add_lint(node, 'Use double-quoted strings when writing single ' \
                          'quotes to avoid having to escape the single quotes')
-        elsif string =~ /(?<! \\) \\"/x
+        elsif string.match?(/(?<! \\) \\"/x)
           add_lint(node, "Don't escape double quotes in single-quoted strings")
         end
       elsif string !~ /"/

data/lib/scss_lint/linter/trailing_semicolon.rb

@@ -45,7 +45,7 @@ module SCSSLint
 
     def visit_import(node)
       # Ignore all but the last import for comma-separated @imports
-      return if source_from_range(node.source_range) =~ /,\s*$/
+      return if source_from_range(node.source_range).match?(/,\s*$/)
       check_semicolon(node)
     end
 

data/lib/scss_lint/linter/trailing_whitespace.rb

@@ -5,7 +5,7 @@ module SCSSLint
 
     def visit_root(_node)
       engine.lines.each_with_index do |line, index|
-        next unless line =~ /[ \t]+$/
+        next unless line.match?(/[ \t]+$/)
 
         add_lint(index + 1, 'Line contains trailing whitespace')
       end

data/lib/scss_lint/linter/trailing_zero.rb

@@ -22,7 +22,7 @@ module SCSSLint
 
   private
 
-    FRACTIONAL_DIGIT_REGEX = /^-?(\d*\.\d+)/
+    FRACTIONAL_DIGIT_REGEX = /^-?(\d*\.\d+)/.freeze
 
     def check_for_trailing_zeros(node, original_number)
       return unless match = /^(\d*\.(?:[0-9]*[1-9]|[1-9])*)0+$/.match(original_number)

data/lib/scss_lint/linter/unnecessary_mantissa.rb

@@ -8,7 +8,7 @@ module SCSSLint
 
     def visit_script_string(node)
       return unless node.type == :identifier
-      return if node.value =~ /^'|"/
+      return if node.value.match?(/^'|"/)
       return if url_literal?(node)
 
       node.value.scan(REAL_NUMBER_REGEX) do |number, integer, mantissa, units|
@@ -35,7 +35,7 @@ module SCSSLint
         (?<mantissa>\d+)
         (?<units>\w*)
       )\b
-    /ix
+    /ix.freeze
 
     MESSAGE_FORMAT = '`%s` should be written without the mantissa as `%s%s`'.freeze
 

data/lib/scss_lint/linter/url_format.rb

@@ -49,8 +49,8 @@ module SCSSLint
       if uri.scheme || uri.host
         add_lint(node, "URL `#{url}` should not contain protocol or domain")
       end
-    rescue URI::Error => ex
-      add_lint(node, "Invalid URL `#{url}`: #{ex}")
+    rescue URI::Error => e
+      add_lint(node, "Invalid URL `#{url}`: #{e}")
     end
   end
 end

data/lib/scss_lint/linter/url_quotes.rb

@@ -20,8 +20,8 @@ module SCSSLint
   private
 
     def check(node, string)
-      return unless string =~ /^\s*url\(\s*[^"']/
-      return if string =~ /^\s*url\(\s*data:/ # Ignore data URIs
+      return unless string.match?(/^\s*url\(\s*[^"']/)
+      return if string.match?(/^\s*url\(\s*data:/) # Ignore data URIs
 
       add_lint(node, 'URLs should be enclosed in quotes')
     end

data/lib/scss_lint/linter/vendor_prefix.rb

@@ -27,7 +27,7 @@ module SCSSLint
   private
 
     def check_identifier(node, identifier)
-      return unless identifier =~ /^[_-]/
+      return unless identifier.match?(/^[_-]/)
 
       # Strip vendor prefix to check against identifiers.
       # (Also strip closing parentheticals from values like linear-gradient.)

data/lib/scss_lint/linter/zero_unit.rb

@@ -35,7 +35,7 @@ module SCSSLint
       (?<!\.|\#)    # Ignore zeroes following `#` (colors) or `.` (decimals)
       (0[a-z]+)     # Zero followed by letters indicating some sort of unit
       \b
-    /ix
+    /ix.freeze
 
     MESSAGE_FORMAT = '`%s` should be written without units as `0`'.freeze
 

data/lib/scss_lint/options.rb

@@ -27,10 +27,10 @@ module SCSSLint
       @options[:files] = args
 
       @options
-    rescue OptionParser::InvalidOption => ex
+    rescue OptionParser::InvalidOption => e
       raise SCSSLint::Exceptions::InvalidCLIOption,
-            ex.message,
-            ex.backtrace
+            e.message,
+            e.backtrace
     end
 
   private

data/lib/scss_lint/rake_task.rb

@@ -73,7 +73,7 @@ module SCSSLint
       end
     end
 
-    def run_cli(task_args) # rubocop:disable AbcSize
+    def run_cli(task_args)
       cli_args = ['--config', config] if config
 
       logger = quiet ? SCSSLint::Logger.silent : SCSSLint::Logger.new(STDOUT)

data/lib/scss_lint/runner.rb

@@ -33,18 +33,18 @@ module SCSSLint
       @linters.each do |linter|
         begin
           run_linter(linter, engine, file[:path])
-        rescue StandardError => error
+        rescue StandardError => e
           raise SCSSLint::Exceptions::LinterError,
                 "#{linter.class} raised unexpected error linting file #{file[:path]}: " \
-                "'#{error.message}'",
-                error.backtrace
+                "'#{e.message}'",
+                e.backtrace
         end
       end
-    rescue Sass::SyntaxError => ex
-      @lints << Lint.new(Linter::Syntax.new, ex.sass_filename, Location.new(ex.sass_line),
-                         "Syntax Error: #{ex}", :error)
-    rescue FileEncodingError => ex
-      @lints << Lint.new(Linter::Encoding.new, file[:path], Location.new, ex.to_s, :error)
+    rescue Sass::SyntaxError => e
+      @lints << Lint.new(Linter::Syntax.new, e.sass_filename, Location.new(e.sass_line),
+                         "Syntax Error: #{e}", :error)
+    rescue FileEncodingError => e
+      @lints << Lint.new(Linter::Encoding.new, file[:path], Location.new, e.to_s, :error)
     end
 
     # For stubbing in tests.

data/lib/scss_lint/utils.rb

@@ -1,7 +1,7 @@
 module SCSSLint
   # Collection of helpers used across a variety of linters.
   module Utils
-    COLOR_REGEX = /^#[a-f0-9]{3,6}$/i
+    COLOR_REGEX = /^#[a-f0-9]{3,6}$/i.freeze
 
     # Returns whether the given string is a color literal (keyword or hex code).
     #

data/lib/scss_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.57.1'.freeze
+  VERSION = '0.58.0'.freeze
 end

data/spec/scss_lint/plugins/linter_dir_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SCSSLint::Plugins::LinterDir do
-  let(:plugin_directory) { File.expand_path('../../fixtures/plugins', __FILE__) }
+  let(:plugin_directory) { File.expand_path('../fixtures/plugins', __dir__) }
   let(:subject) { described_class.new(plugin_directory) }
 
   describe '#load' do

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.57.1
+  version: 0.58.0
 platform: ruby
 authors:
-- Brigade Engineering
 - Shane da Silva
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-27 00:00:00.000000000 Z
+date: 2019-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -53,7 +52,6 @@ dependencies:
         version: 3.5.5
 description: Configurable tool for writing clean and consistent SCSS
 email:
-- eng@brigade.com
 - shane@dasilva.io
 executables:
 - scss-lint
@@ -260,7 +258,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/matchers/report_lint.rb
-homepage: https://github.com/brigade/scss-lint
+homepage: https://github.com/sds/scss-lint
 licenses:
 - MIT
 metadata: {}
@@ -272,15 +270,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: SCSS lint tool