scss_lint 0.48.0 → 0.49.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 836d64855e532ba7edb008a354400fdb3a752b40
-  data.tar.gz: 9712c133bc9cf2ff5b9bc5081fc27ab2a258263b
+  metadata.gz: 881e2595ce6e859e53e9148db36e2f3d11bcb429
+  data.tar.gz: e28e168aa7ec435017b415278fe3fc68c8b911ca
 SHA512:
-  metadata.gz: 8da6137c2915033192ede52347dd8ed2384a134afb192f8f053957da5d6043ea24b100d93f8acf6391bbef92e88d36aa6d97e258413056996b4aef0538de090e
-  data.tar.gz: e043ed88d75c13b5343f18c2cab961853016bfce1533a721ed8cc7f323fe2bd37d24d50cb90ba5b76931f4fb94a3be67f9b009183c28d8967e9a5b6e27663846
+  metadata.gz: f27ed9d01d9a7920c3d88d0d9345b8ba107978fd536d90618d406af9cc8209221cc220054d1f118320af98927fce38b91144c4af1c4686d2a09b7dda2394aaaa
+  data.tar.gz: c6cfb9ba3bf3a0957cbd756b7e0cf9b4702432a94275214b97c98fd2884e63bc225adaec713148d41fae2b0078e070ed6e77ded6d3c4c4139b0cb8e4aaa0b3ec

data/config/default.yml

@@ -168,7 +168,7 @@ linters:
 
   Shorthand:
     enabled: true
-    allowed_shorthands: [1, 2, 3]
+    allowed_shorthands: [1, 2, 3, 4]
 
   SingleLinePerProperty:
     enabled: true

data/data/property-sort-orders/smacss.txt

@@ -45,6 +45,7 @@ padding-left
 
 float
 clear
+clip
 
 columns
 column-gap
@@ -106,6 +107,7 @@ outline-width
 
 background
 background-attachment
+background-clip
 background-color
 background-image
 background-repeat

data/lib/scss_lint/linter/debug_statement.rb

@@ -4,7 +4,7 @@ module SCSSLint
     include LinterRegistry
 
     def visit_debug(node)
-      add_lint(node, 'Remove @debug line')
+      add_lint(node, 'Remove `@debug` line')
     end
   end
 end

data/lib/scss_lint/linter/else_placement.rb

@@ -36,10 +36,10 @@ module SCSSLint
       if same_line_preferred?
         unless curly_on_same_line
           add_lint(else_node,
-                   '@else should be placed on same line as previous curly brace')
+                   '`@else` should be placed on same line as previous curly brace')
         end
       elsif curly_on_same_line
-        add_lint(else_node, '@else should be placed on its own line')
+        add_lint(else_node, '`@else` should be placed on its own line')
       end
     end
 

data/lib/scss_lint/linter/extend_directive.rb

@@ -4,7 +4,7 @@ module SCSSLint
     include LinterRegistry
 
     def visit_extend(node)
-      add_lint(node, 'Do not use the @extend directive (@include a @mixin ' \
+      add_lint(node, 'Do not use the `@extend` directive (`@include` a `@mixin` ' \
                      'instead)')
     end
   end

data/lib/scss_lint/linter/length_variable.rb

@@ -0,0 +1,107 @@
+module SCSSLint
+  # Ensures length literals are used only in variable declarations.
+  class Linter::LengthVariable < Linter
+    include LinterRegistry
+
+    LENGTH_UNITS = [
+      'ch', 'em', 'ex', 'rem',                 # Font-relative lengths
+      'cm', 'in', 'mm', 'pc', 'pt', 'px', 'q', # Absolute lengths
+      'vh', 'vw', 'vmin', 'vmax'               # Viewport-percentage lengths
+    ].freeze
+
+    LENGTH_RE = %r{
+      (?:^|[\s+\-/*()]) # math or space separated, or beginning of string
+      ( # capture whole length
+        0 # unitless zero
+        |
+        [-+]? # optional sign
+        (?:
+          \.\d+ # with leading decimal, e.g. .5
+          |
+          \d+(\.\d+)? # whole or maybe with trailing decimal
+        )
+        (?:#{LENGTH_UNITS.join('|')}) # unit!
+      )
+      (?:$|[\s+\-/*()]) # math or space separated, or end of string
+    }x
+
+    def visit_prop(node)
+      return if allowed_prop?(node)
+      lint_lengths(node)
+    end
+
+    def visit_mixindef(node)
+      lint_lengths(node)
+    end
+
+    def visit_media(node)
+      lint_lengths(node)
+    end
+
+    def visit_mixin(node)
+      lint_lengths(node)
+    end
+
+  private
+
+    def lint_lengths(node)
+      lengths = extract_lengths(node)
+      lengths = [lengths].flatten.compact.uniq
+      lengths -= config['allowed_lengths'] if config['allowed_lengths']
+      lengths.each do |length|
+        record_lint(node, length) unless lengths.empty?
+      end
+    end
+
+    def record_lint(node, length)
+      add_lint node, "Length literals like `#{length}` should only be used in " \
+                     'variable declarations; they should be referred to via ' \
+                     'variables everywhere else.'
+    end
+
+    def allowed_prop?(node)
+      config['allowed_properties'] && config['allowed_properties'].include?(node.name.first.to_s)
+    end
+
+    # Though long, This method is clear enough in a boring, dispatch kind of way.
+    # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
+    def extract_lengths(node)
+      case node
+      when Sass::Tree::PropNode
+        extract_lengths(node.value)
+      when Sass::Script::Tree::Literal
+        extract_lengths_from_string(node.value)
+      when String
+        extract_lengths_from_string(node)
+      when Sass::Script::Tree::Funcall,
+           Sass::Tree::MixinNode,
+           Sass::Tree::MixinDefNode
+        extract_lengths_from_list(*node.args)
+      when Sass::Script::Tree::ListLiteral
+        extract_lengths_from_list(*node.elements)
+      when Sass::Tree::MediaNode
+        extract_lengths_from_list(*node.query)
+      when Array
+        extract_lengths_from_list(*node)
+      when Sass::Script::Tree::Interpolation
+        extract_lengths_from_list(node.before, node.mid, node.after)
+      when Sass::Script::Tree::Operation
+        extract_lengths_from_list(node.operand1, node.operand2)
+      when Sass::Script::Tree::UnaryOperation
+        extract_lengths(node.operand)
+      when Sass::Script::Tree::Variable
+        nil
+      end
+    end
+    # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
+
+    def extract_lengths_from_string(string)
+      matchdata = string.to_s.match(LENGTH_RE)
+      matchdata && matchdata.captures
+    end
+
+    def extract_lengths_from_list(*values)
+      values.map { |v| extract_lengths(v) }
+    end
+  end
+end

data/lib/scss_lint/linter/name_format.rb

@@ -3,13 +3,34 @@ module SCSSLint
   class Linter::NameFormat < Linter
     include LinterRegistry
 
+    CSS_FUNCTION_WHITELIST = %w[
+      rotateX rotateY rotateZ
+      scaleX scaleY scaleZ
+      skewX skewY
+      translateX translateY translateZ
+      linear-gradient repeating-linear-gradient
+      radial-gradient repeating-radial-gradient
+    ].to_set.freeze
+
+    SCSS_FUNCTION_WHITELIST = %w[
+      adjust-hue adjust-color scale-color change-color ie-hex-str
+      str-length str-insert str-index str-slice to-upper-case to-lower-case
+      list-separator
+      map-get map-merge map-remove map-keys map-values map-has-key
+      selector-nest selector-append selector-extend selector-replace
+      selector-unify is-superselector simple-selectors selector-parse
+      feature-exists variable-exists global-variable-exists function-exists
+      mixin-exists type-of
+      unique-id
+    ].to_set.freeze
+
     def visit_function(node)
       check_name(node, 'function')
       yield # Continue into content block of this function definition
     end
 
     def visit_mixin(node)
-      check_name(node, 'mixin') unless FUNCTION_WHITELIST.include?(node.name)
+      check_name(node, 'mixin') unless whitelist?(node.name)
       yield # Continue into content block of this mixin's block
     end
 
@@ -19,7 +40,7 @@ module SCSSLint
     end
 
     def visit_script_funcall(node)
-      check_name(node, 'function') unless FUNCTION_WHITELIST.include?(node.name)
+      check_name(node, 'function') unless whitelist?(node.name)
       yield # Continue linting any arguments of this function call
     end
 
@@ -34,13 +55,10 @@ module SCSSLint
 
   private
 
-    FUNCTION_WHITELIST = %w[
-      rotateX rotateY rotateZ
-      scaleX scaleY scaleZ
-      skewX skewY
-      translateX translateY translateZ
-      linear-gradient
-    ].to_set
+    def whitelist?(name)
+      CSS_FUNCTION_WHITELIST.include?(name) ||
+        SCSS_FUNCTION_WHITELIST.include?(name)
+    end
 
     def check_name(node, node_type, node_text = node.name)
       node_text = trim_underscore_prefix(node_text)

data/lib/scss_lint/linter/property_sort_order.rb

@@ -105,9 +105,9 @@ module SCSSLint
         # we don't care, but at least one line that isn't another property).
         next if first[:node].line < second[:node].line - 1
 
-        add_lint second[:node], "Property #{second[:name]} should be " \
-                                'separated from the previous group of ' \
-                                "properties ending with #{first[:name]}"
+        add_lint second[:node], "Property `#{second[:name]}` should have an " \
+                                'empty line separating it from the previous ' \
+                                "group of properties ending with `#{first[:name]}`"
       end
     end
 
@@ -163,7 +163,7 @@ module SCSSLint
           file = File.open(File.join(SCSS_LINT_DATA,
                                      'property-sort-orders',
                                      "#{config['order']}.txt"))
-          file.read.split("\n").reject { |line| line =~ /^(#|\s*$)/ }
+          file.read.split("\n").reject { |line| line =~ /^\s*#/ }
         rescue Errno::ENOENT
           raise SCSSLint::Exceptions::LinterError,
                 "Preset property sort order '#{config['order']}' does not exist"

data/lib/scss_lint/linter/shorthand.rb

@@ -68,6 +68,9 @@ module SCSSLint
     # @param node [Sass::Script::Value::String]
     # @param values [Array<String>]
     def check_shorthand(prop, node, values)
+      add_lint(node, "Shorthands of length `#{values.count}` are not allowed. " \
+                     "Value was `#{values.join(' ')}`") unless allowed?(values.count)
+
       return unless (2..4).member?(values.count)
 
       shortest_form = condensed_shorthand(*values)

data/lib/scss_lint/linter/space_around_operator.rb

@@ -94,8 +94,7 @@ module SCSSLint
       end
 
       def adjust_for_interpolation
-        @source = normalize_source(
-          @linter.source_fm_range(slide_to_the_left(@node.source_range)))
+        @source = normalize_source(@linter.source_fm_range(slide_to_the_left(@node.source_range)))
         @left_range = slide_to_the_left(@node.operand1.source_range)
         @right_range = slide_to_the_left(@node.operand2.source_range)
       end

data/lib/scss_lint/linter/trailing_zero.rb

@@ -25,7 +25,7 @@ module SCSSLint
     FRACTIONAL_DIGIT_REGEX = /^-?(\d*\.\d+)/
 
     def check_for_trailing_zeros(node, original_number)
-      return unless match = /^(\d*\.\d*)0+$/.match(original_number)
+      return unless match = /^(\d*\.(?:[0-9]*[1-9]|[1-9])*)0+$/.match(original_number)
 
       fixed_number = match[1]
 

data/lib/scss_lint/reporter/default_reporter.rb

@@ -12,7 +12,11 @@ module SCSSLint
   private
 
     def location(lint)
-      "#{log.cyan(lint.filename)}:#{log.magenta(lint.location.line.to_s)}"
+      [
+        log.cyan(lint.filename),
+        log.magenta(lint.location.line.to_s),
+        log.magenta(lint.location.column.to_s),
+      ].join(':')
     end
 
     def type(lint)

data/lib/scss_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.48.0'.freeze
+  VERSION = '0.49.0'.freeze
 end

data/spec/scss_lint/linter/indentation_spec.rb

@@ -274,7 +274,8 @@ describe SCSSLint::Linter::Indentation do
 
   context 'when indentation in non-nested code is allowed' do
     let(:linter_config) do
-      { 'allow_non_nested_indentation' => true,
+      {
+        'allow_non_nested_indentation' => true,
         'character' => 'space',
         'width' => 2,
       }

data/spec/scss_lint/linter/length_variable_spec.rb

@@ -0,0 +1,388 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::LengthVariable do
+  context 'when a length literal is used in a variable declaration' do
+    let(:scss) { <<-SCSS }
+      $my-length: 10px;
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a length calculation containing literals is used in a variable declaration' do
+    let(:scss) { <<-SCSS }
+      $my-length: 10px / 2;
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a length literal is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: 10px;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a negative length literal is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: -10px;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a length literal is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: my-func(10px);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a length literal is used in a mixin' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include my-mixin(10px);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a length literal is used in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        text-shadow: 10px 10px black;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a length literal is used as a mixin default argument' do
+    let(:scss) { <<-SCSS }
+      @mixin checkbox ($length: 10px) {
+        width: $length;
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when a number is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        z-index: 9000;
+        transition-duration: 250ms;
+        line-height: 1;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a non-length keyword is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: auto;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: $my-length;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: my-func($my-length);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable operated with a literal' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: $my-length + 10px;
+        height: $my-length - 10px;
+        top: $my-length * 10px;
+        bottom: $my-length - 10px;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+    it { should report_lint line: 5 }
+  end
+
+  context 'when a variable unary operation' do
+    let(:scss) { <<-SCSS }
+      p {
+        top: -$my-length;
+        bottom: +$my-length;
+      }
+    SCSS
+
+    it { should_not report_lint line: 2 }
+    it { should_not report_lint line: 3 }
+  end
+
+  context 'when a variable is used in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: $my-length solid black;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property contains "auto"' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: auto;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a length literal is used in a map declaration' do
+    let(:scss) { <<-SCSS }
+      $margins: (
+        small:  4px,
+        medium: 8px,
+        large:  16px
+      );
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a string with a length is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: my-func('10px');
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is interpolated in a multiline comment' do
+    let(:scss) { <<-SCSS }
+      $a: 0;
+
+      /*!
+       * test \#{a}
+       */
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when using calc' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: calc(100em + 5px);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when using calc with no spacing' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: calc(100em+5px);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when using calc with all interpolations' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: calc(\#{$my-width} + \#{$my-spacing});
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is interpolated' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: calc(\#{$my-length} + 5px)
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a literal is interpolated' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: calc(\#{10px} + $my-length)
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a string is interpolated' do ## analogous to the ColorVariable linter
+    let(:scss) { <<-SCSS }
+      p {
+        width: calc(\#{'10px'} + $my-length)
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when disambiguating with brackets' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: (-10px) (-10px);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'in the awkward looking font shorthand' do
+    let(:scss) { <<-SCSS }
+      strong { font: bold 10px/14px sans-serif; }
+      em { font: bold $my-font-size/14px sans-serif; }
+      blockquote { font: bold 10px/$my-line-height sans-serif; }
+      p { font: bold $my-font-size/1 sans-serif; }
+    SCSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should_not report_lint line: 4 }
+  end
+
+  context 'when a length is used in a media query' do
+    let(:scss) { <<-SCSS }
+      @media (min-width:100px) {
+        p { color: red; }
+      }
+      @media (max-width: 100px ) {
+        p { color: blue; }
+      }
+      @media (max-width: 100px*5) {
+        p { color: orange; }
+      }
+      @media (min-device-pixel-ratio: 2) {
+        p { color: green; }
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 4 }
+    it { should report_lint line: 7 }
+    it { should_not report_lint line: 10 }
+  end
+
+  context 'when length is allowed' do
+    let(:linter_config) { { 'allowed_lengths' => %w[100px 0 5px] } }
+    context 'when using an allowed length' do
+      let(:scss) { <<-SCSS }
+        p {
+          width: 100px;
+          border-width: 0;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when using an allowed length in a calculation' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: -(5px);
+          border-width: $my-variable + 5px;
+          width: calc(100px + \#{$my-margin});
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when using a similar disallowed length' do
+      let(:scss) { <<-SCSS }
+        p {
+          width: 101px;
+          margin: 100em;
+          border-width: 0;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should_not report_lint line: 4 }
+    end
+  end
+
+  context 'when using a length with an allowed property' do
+    let(:linter_config) { { 'allowed_properties' => ['text-shadow', 'box-shadow'] } }
+    let(:scss) { <<-SCSS }
+      p {
+        text-shadow: 10px 10px 5px blue;
+        box-shadow: 10px 10px 5px red;
+        width: $my-variable;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a length calculation containing literals is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        width: 10px + 10px;
+      }
+      a {
+        width: 10px - 10px;
+      }
+      i {
+        width: 10px / 4;
+      }
+      span {
+        width: 10px * 2;
+      }
+      .class {
+        width: -10px + 11;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 5 }
+    it { should report_lint line: 8 }
+    it { should report_lint line: 11 }
+    it { should report_lint line: 14 }
+  end
+end

data/spec/scss_lint/linter/property_sort_order_spec.rb

@@ -405,6 +405,33 @@ describe SCSSLint::Linter::PropertySortOrder do
 
         it { should report_lint line: 3 }
       end
+
+      context 'and `separate_groups` is enabled' do
+        let(:linter_config) { super().merge('separate_groups' => true) }
+
+        context 'and the properties are not separated' do
+          let(:scss) { <<-SCSS }
+            p {
+              visibility: hidden;
+              margin: 0;
+            }
+          SCSS
+
+          it { should report_lint }
+        end
+
+        context 'and the properties are separated' do
+          let(:scss) { <<-SCSS }
+            p {
+              visibility: hidden;
+
+              margin: 0;
+            }
+          SCSS
+
+          it { should_not report_lint }
+        end
+      end
     end
   end
 

data/spec/scss_lint/linter/shorthand_spec.rb

@@ -194,5 +194,16 @@ describe SCSSLint::Linter::Shorthand do
 
       it { should_not report_lint }
     end
+
+    context 'is fine but length is not allowed' do
+      let(:allowed) { [1, 2, 3] }
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 1px 2px 3px 4px;
+        }
+      SCSS
+
+      it { should report_lint }
+    end
   end
 end

data/spec/scss_lint/linter/trailing_zero_spec.rb

@@ -47,6 +47,16 @@ describe SCSSLint::Linter::TrailingZero do
     it { should_not report_lint }
   end
 
+  context 'when a unitless fractional value with multiple trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        line-height: .600;
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
   context 'when a negative unitless fractional value with no trailing zero exists' do
     let(:scss) { <<-SCSS }
       p {

data/spec/scss_lint/reporter/default_reporter_spec.rb

@@ -15,12 +15,13 @@ describe SCSSLint::Reporter::DefaultReporter do
 
     context 'when there are lints' do
       let(:filenames)    { ['some-filename.scss', 'other-filename.scss'] }
-      let(:lines)        { [502, 724] }
+      let(:locations)    { [[502, 3], [724, 6]] }
       let(:descriptions) { ['Description of lint 1', 'Description of lint 2'] }
       let(:severities)   { [:warning] * 2 }
       let(:lints) do
         filenames.each_with_index.map do |filename, index|
-          location = SCSSLint::Location.new(lines[index])
+          line, column = locations[index]
+          location = SCSSLint::Location.new(line, column, 10)
           SCSSLint::Lint.new(nil, filename, location, descriptions[index],
                              severities[index])
         end
@@ -41,8 +42,14 @@ describe SCSSLint::Reporter::DefaultReporter do
       end
 
       it 'prints the line number for each lint' do
-        lines.each do |line|
-          subject.report_lints.scan(line.to_s).count.should == 1
+        locations.each do |location|
+          subject.report_lints.scan(location[0].to_s).count.should == 1
+        end
+      end
+
+      it 'prints the column number for each lint' do
+        locations.each do |location|
+          subject.report_lints.scan(location[1].to_s).count.should == 1
         end
       end
 

data/spec/scss_lint/reporter/stats_reporter_spec.rb

@@ -44,7 +44,7 @@ describe SCSSLint::Reporter::StatsReporter do
       end
 
       it 'prints the total lints and total lines' do
-        subject.report_lints.should match /2  total +\(across 1/
+        subject.report_lints.should match(/2  total +\(across 1/)
       end
     end
 
@@ -74,7 +74,7 @@ describe SCSSLint::Reporter::StatsReporter do
       end
 
       it 'prints the total lints and total lines' do
-        subject.report_lints.should match /3  total +\(across 1/
+        subject.report_lints.should match(/3  total +\(across 1/)
       end
     end
 
@@ -108,7 +108,7 @@ describe SCSSLint::Reporter::StatsReporter do
       end
 
       it 'prints the total lints and total lines' do
-        subject.report_lints.should match /6  total +\(across 3/
+        subject.report_lints.should match(/6  total +\(across 3/)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.48.0
+  version: 0.49.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-16 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -37,14 +37,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.15
+        version: 3.4.20
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.15
+        version: 3.4.20
 description: Configurable tool for writing clean and consistent SCSS
 email:
 - eng@brigade.com
@@ -100,6 +100,7 @@ files:
 - lib/scss_lint/linter/important_rule.rb
 - lib/scss_lint/linter/indentation.rb
 - lib/scss_lint/linter/leading_zero.rb
+- lib/scss_lint/linter/length_variable.rb
 - lib/scss_lint/linter/mergeable_selector.rb
 - lib/scss_lint/linter/name_format.rb
 - lib/scss_lint/linter/nesting_depth.rb
@@ -188,6 +189,7 @@ files:
 - spec/scss_lint/linter/important_rule_spec.rb
 - spec/scss_lint/linter/indentation_spec.rb
 - spec/scss_lint/linter/leading_zero_spec.rb
+- spec/scss_lint/linter/length_variable_spec.rb
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/name_format_spec.rb
 - spec/scss_lint/linter/nesting_depth_spec.rb
@@ -268,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: SCSS lint tool
@@ -303,6 +305,7 @@ test_files:
 - spec/scss_lint/linter/important_rule_spec.rb
 - spec/scss_lint/linter/indentation_spec.rb
 - spec/scss_lint/linter/leading_zero_spec.rb
+- spec/scss_lint/linter/length_variable_spec.rb
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/name_format_spec.rb
 - spec/scss_lint/linter/nesting_depth_spec.rb
@@ -363,3 +366,4 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/matchers/report_lint.rb
+has_rdoc: