scss_lint 0.44.0 → 0.45.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a86d234a01ef87070b4fd7889111970e80def37
-  data.tar.gz: 2a461b84b74cc8728e64dc9366a67be4df308c10
+  metadata.gz: 3c80256e0f694ade8ef5c0651dfc3cd95d1ed76a
+  data.tar.gz: ea61d9083a223c299df36c0bc827e92716b941e5
 SHA512:
-  metadata.gz: a0badb74dbb5f26d727b38dd71319b8429c35f23602bb73c30a7d197100a4d16f61df75604a4b19992aa1237d1d226b5941e786efe7c459bbde18f4a71b36a76
-  data.tar.gz: 4059abd1bac9430f32af1f7b125fe22a5a3ae24b146e026283648a4bfb7623453df0eb111cc9659b6f6e1866e3248425574617cef14662f5e1e32732851dc962
+  metadata.gz: bdd1c5afb4507f544ec533ee8387506edcf1ad30e8466b0d01a0faaec2db376c4413fbd7b822fac687ba6c7ffd9672ad8103fdf2796a8521c6ae08815511269d
+  data.tar.gz: 22a40913e53ebf7e82b181aca67af574a26d5a00ce10b7b090c77f7ba1756e084b038d634b0ff4dc244bd0561922a02f2a780b0f073aa4419e93a7638fea54b9

data/config/default.yml

@@ -184,6 +184,10 @@ linters:
   SpaceAfterPropertyName:
     enabled: true
 
+  SpaceAfterVariableColon:
+    enabled: false
+    style: one_space # or 'no_space', 'at_least_one_space' or 'one_space_or_newline'
+
   SpaceAfterVariableName:
     enabled: true
 

data/data/property-sort-orders/recess.txt

@@ -121,6 +121,9 @@ content
 quotes
 outline
 outline-offset
+outline-width
+outline-style
+outline-color
 opacity
 filter
 visibility

data/lib/scss_lint/config.rb

@@ -8,7 +8,7 @@ module SCSSLint
     FILE_NAME = '.scss-lint.yml'.freeze
     DEFAULT_FILE = File.join(SCSS_LINT_HOME, 'config', 'default.yml')
 
-    attr_reader :options, :warnings
+    attr_reader :options, :warnings, :file
 
     class << self
       def default
@@ -20,7 +20,7 @@ module SCSSLint
       def load(file, options = {})
         config_options = load_options_hash_from_file(file)
 
-        config = new(config_options)
+        config = new(config_options, file)
 
         # Need to call this before merging with the default configuration so
         # that plugins can override the default configuration while still being
@@ -201,9 +201,10 @@ module SCSSLint
       end
     end
 
-    def initialize(options)
+    def initialize(options, file = Config.user_file)
       @options = options
       @warnings = []
+      @file = file
 
       validate_linters
     end

data/lib/scss_lint/engine.rb

@@ -24,8 +24,12 @@ module SCSSLint
       end
 
       # Need to force encoding to avoid Windows-related bugs.
+      # Need to encode with universal newline to avoid other Windows-related bugs.
       # Need `to_a` for Ruby 1.9.3.
-      @lines = @contents.force_encoding('UTF-8').lines.to_a
+      encoding = 'UTF-8'
+      @lines = @contents.force_encoding(encoding)
+                        .encode(encoding, universal_newline: true)
+                        .lines.to_a
       @tree = @engine.to_tree
       find_any_control_commands
     rescue Encoding::UndefinedConversionError, Sass::SyntaxError, ArgumentError => error

data/lib/scss_lint/file_finder.rb

@@ -47,7 +47,7 @@ module SCSSLint
         end
       end
 
-      files.uniq
+      files.uniq.sort
     end
 
     # @param file [String]

data/lib/scss_lint/linter/border_zero.rb

@@ -23,17 +23,17 @@ module SCSSLint
 
     def visit_prop(node)
       return unless BORDER_PROPERTIES.include?(node.name.first.to_s)
-      check_border(node, node.value.to_sass.strip)
+      check_border(node, node.name.first.to_s, node.value.to_sass.strip)
     end
 
   private
 
-    def check_border(node, border)
-      return unless %w[0 none].include?(border)
-      return if @preference[0] == border
+    def check_border(node, border_property, border_value)
+      return unless %w[0 none].include?(border_value)
+      return if @preference[0] == border_value
 
-      add_lint(node, "`border: #{@preference[0]}` is preferred over " \
-                     "`border: #{@preference[1]}`")
+      add_lint(node, "`#{border_property}: #{@preference[0]}` is preferred over " \
+                     "`#{border_property}: #{@preference[1]}`")
     end
   end
 end

data/lib/scss_lint/linter/single_line_per_property.rb

@@ -4,6 +4,8 @@ module SCSSLint
     include LinterRegistry
 
     def visit_rule(node)
+      yield # Continue linting children
+
       single_line = single_line_rule_set?(node)
       return if single_line && config['allow_single_line_rule_sets']
 

data/lib/scss_lint/linter/space_after_variable_colon.rb

@@ -0,0 +1,62 @@
+module SCSSLint
+  # Checks for spaces following the colon that separates a variable's name from
+  # its value.
+  class Linter::SpaceAfterVariableColon < Linter
+    include LinterRegistry
+
+    def visit_variable(node)
+      whitespace = whitespace_after_colon(node)
+
+      case config['style']
+      when 'no_space'
+        check_for_no_spaces(node, whitespace)
+      when 'one_space'
+        check_for_one_space(node, whitespace)
+      when 'at_least_one_space'
+        check_for_at_least_one_space(node, whitespace)
+      when 'one_space_or_newline'
+        check_for_one_space_or_newline(node, whitespace)
+      end
+    end
+
+  private
+
+    def check_for_no_spaces(node, whitespace)
+      return if whitespace == []
+      add_lint(node, 'Colon after variable should not be followed by any spaces')
+    end
+
+    def check_for_one_space(node, whitespace)
+      return if whitespace == [' ']
+      add_lint(node, 'Colon after variable should be followed by one space')
+    end
+
+    def check_for_at_least_one_space(node, whitespace)
+      return if whitespace.uniq == [' ']
+      add_lint(node, 'Colon after variable should be followed by at least one space')
+    end
+
+    def check_for_one_space_or_newline(node, whitespace)
+      return if whitespace == [' '] || whitespace == ["\n"]
+      return if whitespace[0] == "\n" && whitespace[1..-1].uniq == [' ']
+      add_lint(node, 'Colon after variable should be followed by one space or a newline')
+    end
+
+    def whitespace_after_colon(node)
+      whitespace = []
+      offset = 0
+      start_pos = node.source_range.start_pos
+
+      # Find the colon after the variable name
+      offset = offset_to(start_pos, ':', offset) + 1
+
+      # Count spaces after the colon
+      while [' ', "\t", "\n"].include? character_at(start_pos, offset)
+        whitespace << character_at(start_pos, offset)
+        offset += 1
+      end
+
+      whitespace
+    end
+  end
+end

data/lib/scss_lint/linter/trailing_semicolon.rb

@@ -19,9 +19,8 @@ module SCSSLint
       # `node.expr` will give us everything except the last right paren, and
       # the semicolon if it exists. In these cases, use the source range of
       # `node` as above.
-      if (node.expr.is_a?(Sass::Script::Tree::ListLiteral) ||
-          node.expr.is_a?(Sass::Script::Tree::MapLiteral)) &&
-         !node_on_single_line?(node)
+      if node.expr.is_a?(Sass::Script::Tree::ListLiteral) ||
+          node.expr.is_a?(Sass::Script::Tree::MapLiteral)
         return check_semicolon(node)
       end
 

data/lib/scss_lint/plugins.rb

@@ -26,7 +26,7 @@ module SCSSLint
 
     def plugin_directories
       Array(@config['plugin_directories']).map do |directory|
-        LinterDir.new(directory)
+        LinterDir.new(File.join(File.dirname(@config.file), directory))
       end
     end
   end

data/lib/scss_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.44.0'.freeze
+  VERSION = '0.45.0'.freeze
 end

data/spec/scss_lint/file_finder_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'fileutils'
 
 describe SCSSLint::FileFinder do
   let(:config) { SCSSLint::Config.default }
@@ -21,12 +22,12 @@ describe SCSSLint::FileFinder do
 
       context 'and there are SCSS files under the current directory' do
         before do
-          `touch blah.scss`
-          `mkdir -p more`
-          `touch more/more.scss`
+          FileUtils.touch('blah.scss')
+          FileUtils.mkdir_p('more')
+          FileUtils.touch(File.join('more', 'more.scss'))
         end
 
-        it { should == ['blah.scss', 'more/more.scss'] }
+        it { should == ['blah.scss', File.join('more', 'more.scss')] }
       end
 
       context 'and a default set of files is specified in the config' do
@@ -45,7 +46,7 @@ describe SCSSLint::FileFinder do
 
       context 'and those files exist' do
         before do
-          `touch test.txt`
+          FileUtils.touch('test.txt')
         end
 
         it { should == ['test.txt'] }
@@ -66,10 +67,10 @@ describe SCSSLint::FileFinder do
 
         context 'and they contain SCSS files' do
           before do
-            `touch some-dir/test.scss`
+            FileUtils.touch(File.join('some-dir', 'test.scss'))
           end
 
-          it { should == ['some-dir/test.scss'] }
+          it { should == [File.join('some-dir', 'test.scss')] }
 
           context 'and those SCSS files are excluded by the config' do
             before do
@@ -82,19 +83,20 @@ describe SCSSLint::FileFinder do
 
         context 'and they contain CSS files' do
           before do
-            `touch some-dir/test.css`
+            FileUtils.touch(File.join('some-dir', 'test.css'))
           end
 
-          it { should == ['some-dir/test.css'] }
+          it { should == [File.join('some-dir', 'test.css')] }
         end
 
         context 'and they contain more directories with files with recognized extensions' do
           before do
             `mkdir -p some-dir/more-dir`
-            `touch some-dir/more-dir/test.scss`
+            FileUtils.mkdir_p(File.join('some-dir', 'more-dir'))
+            FileUtils.touch(File.join('some-dir', 'more-dir', 'test.scss'))
           end
 
-          it { should == ['some-dir/more-dir/test.scss'] }
+          it { should == [File.join('some-dir', 'more-dir', 'test.scss')] }
 
           context 'and those SCSS files are excluded by the config' do
             before do
@@ -107,7 +109,7 @@ describe SCSSLint::FileFinder do
 
         context 'and they contain no SCSS files' do
           before do
-            `touch some-dir/test.txt`
+            FileUtils.touch(File.join('some-dir', 'test.txt'))
           end
 
           it 'raises an error' do

data/spec/scss_lint/linter/border_zero_spec.rb

@@ -11,6 +11,8 @@ describe SCSSLint::Linter::BorderZero do
   end
 
   context 'when a property' do
+    let(:lint_description) { subject.lints.first.description }
+
     context 'contains a normal border' do
       let(:scss) { <<-SCSS }
         p {
@@ -39,6 +41,10 @@ describe SCSSLint::Linter::BorderZero do
       SCSS
 
       it { should report_lint line: 2 }
+
+      it 'should report lint with the border property in the description' do
+        lint_description.should == '`border: 0` is preferred over `border: none`'
+      end
     end
 
     context 'has a border-top of none' do
@@ -49,6 +55,10 @@ describe SCSSLint::Linter::BorderZero do
       SCSS
 
       it { should report_lint line: 2 }
+
+      it 'should report lint with the border-top property in the description' do
+        lint_description.should == '`border-top: 0` is preferred over `border-top: none`'
+      end
     end
 
     context 'has a border-right of none' do
@@ -59,6 +69,10 @@ describe SCSSLint::Linter::BorderZero do
       SCSS
 
       it { should report_lint line: 2 }
+
+      it 'should report lint with the border-right property in the description' do
+        lint_description.should == '`border-right: 0` is preferred over `border-right: none`'
+      end
     end
 
     context 'has a border-bottom of none' do
@@ -69,6 +83,10 @@ describe SCSSLint::Linter::BorderZero do
       SCSS
 
       it { should report_lint line: 2 }
+
+      it 'should report lint with the border-bottom property in the description' do
+        lint_description.should == '`border-bottom: 0` is preferred over `border-bottom: none`'
+      end
     end
 
     context 'has a border-left of none' do
@@ -79,6 +97,10 @@ describe SCSSLint::Linter::BorderZero do
       SCSS
 
       it { should report_lint line: 2 }
+
+      it 'should report lint with the border-left property in the description' do
+        lint_description.should == '`border-left: 0` is preferred over `border-left: none`'
+      end
     end
   end
 

data/spec/scss_lint/linter/indentation_spec.rb

@@ -19,6 +19,11 @@ describe SCSSLint::Linter::Indentation do
     SCSS
 
     it { should_not report_lint }
+
+    context 'with carriage returns for newlines' do
+      let(:scss) { "p {\r  margin: 0;\r}" }
+      it { should_not report_lint }
+    end
   end
 
   context 'when lines in a rule set are not properly indented' do
@@ -33,6 +38,13 @@ describe SCSSLint::Linter::Indentation do
     it { should report_lint line: 2 }
     it { should_not report_lint line: 3 }
     it { should report_lint line: 4 }
+
+    context 'with carriage returns for newlines' do
+      let(:scss) { "p {\rmargin: 0;\r  padding: 1em;}" }
+      it { should_not report_lint line: 1 }
+      it { should report_lint line: 2 }
+      it { should_not report_lint line: 3 }
+    end
   end
 
   context 'when selector of a nested rule set is not properly indented' do

data/spec/scss_lint/linter/single_line_per_property_spec.rb

@@ -70,4 +70,24 @@ describe SCSSLint::Linter::SingleLinePerProperty do
       it { should report_lint }
     end
   end
+
+  context 'when a nested single line rule set contains a single property' do
+    let(:scss) { <<-SCSS }
+      .my-selector {
+        p { color: #fff; }
+      }
+    SCSS
+
+    context 'and single line rule sets are allowed' do
+      let(:linter_config) { { 'allow_single_line_rule_sets' => true } }
+
+      it { should_not report_lint }
+    end
+
+    context 'and single line rule sets are not allowed' do
+      let(:linter_config) { { 'allow_single_line_rule_sets' => false } }
+
+      it { should report_lint }
+    end
+  end
 end

data/spec/scss_lint/linter/space_after_variable_colon_spec.rb

@@ -0,0 +1,186 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceAfterVariableColon do
+  let(:linter_config) { { 'style' => style } }
+
+  context 'when one space is preferred' do
+    let(:style) { 'one_space' }
+
+    context 'when the colon after a variable is not followed by space' do
+      let(:scss) { '$my-color:#fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a variable is followed by more than one space' do
+      let(:scss) { '$my-color:  #fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a variable is followed by a space' do
+      let(:scss) { '$my-color: #fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is surrounded by spaces' do
+      let(:scss) { '$my-color : #fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is followed by a space and a newline' do
+      let(:scss) { <<-SCSS }
+        $my-color:\s
+        #fff;
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a property is followed by a tab' do
+      let(:scss) { <<-SCSS }
+        $my-color:\t#fff;
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when no spaces are allowed' do
+    let(:style) { 'no_space' }
+
+    context 'when the colon after a variable is not followed by space' do
+      let(:scss) { '$my-color:#fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when colon after variable is not followed by space and the semicolon is missing' do
+      let(:scss) { '$my-color:#fff' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is followed by a space' do
+      let(:scss) { '$my-color: #fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a property is surrounded by spaces' do
+      let(:scss) { '$my-color : #fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a property is followed by multiple spaces' do
+      let(:scss) { '$my-color:  #fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a property is followed by a newline' do
+      let(:scss) { <<-SCSS }
+        $my-color:
+        #fff;
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a property is followed by a tab' do
+      let(:scss) { <<-SCSS }
+        $my-color:\t#fff;
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when at least one space is preferred' do
+    let(:style) { 'at_least_one_space' }
+
+    context 'when the colon after a variable is not followed by space' do
+      let(:scss) { '$my-color:#fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when colon after variable is not followed by space and the semicolon is missing' do
+      let(:scss) { '$my-color:#fff' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a variable is followed by a space' do
+      let(:scss) { '$my-color: #fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is surrounded by spaces' do
+      let(:scss) { '$my-color : #fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is followed by multiple spaces' do
+      let(:scss) { '$my-color:  #fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is followed by multiple spaces and a tab' do
+      let(:scss) { <<-SCSS }
+        $my-color:  \t#fff;
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when one space or newline is preferred' do
+    let(:style) { 'one_space_or_newline' }
+
+    context 'when the colon after a variabl is not followed by space' do
+      let(:scss) { '$my-color:#fff;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when the colon after a variable is followed by a space' do
+      let(:scss) { '$my-color: #fff;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is followed by a newline and spaces' do
+      let(:scss) { <<-SCSS }
+        $my-color:
+              #fff;
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is followed by a newline and no spaces' do
+      let(:scss) { <<-SCSS }
+        $my-color:
+#fff;
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a variable is followed by a space and then a newline' do
+      let(:scss) { <<-SCSS }
+        $my-color:\s
+#fff;
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+end

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -442,62 +442,226 @@ describe SCSSLint::Linter::TrailingSemicolon do
     end
   end
 
-  context 'when a variable declaration contains a multiline map' do
-    context 'with a trailing comma' do
+  context 'when a variable declaration contains a list' do
+    context 'with parentheses' do
       context 'and ends with a semicolon' do
-        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2,\n);" }
+        let(:scss) { '$foo: (1 2);' }
 
         it { should_not report_lint }
       end
 
       context 'and is missing a semicolon' do
-        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2,\n)" }
+        let(:scss) { '$foo: (1 2)' }
 
         it { should report_lint }
       end
+
+      context 'and a nested list' do
+        context 'with parentheses' do
+          context 'on a single line' do
+            context 'and ends with a semicolon' do
+              let(:scss) { '$foo: (1 (2 3));' }
+
+              it { should_not report_lint }
+            end
+
+            context 'and is missing a semicolon' do
+              let(:scss) { '$foo: (1 (2 3))' }
+
+              it { should report_lint }
+            end
+          end
+
+          context 'over multiple lines' do
+            context 'and ends with a semicolon' do
+              let(:scss) { <<-SCSS }
+                  $foo: (1
+                      (2 3)
+                    );
+                SCSS
+              it { should_not report_lint }
+            end
+
+            context 'and is missing a semicolon' do
+              let(:scss) { <<-SCSS }
+                  $foo: (1
+                      (2 3)
+                    )
+                SCSS
+
+              it { should report_lint }
+            end
+          end
+        end
+
+        context 'without parentheses' do
+          context 'and ends with a semicolon' do
+            let(:scss) { <<-SCSS }
+              $foo: (10
+                  20 21 22
+                30);
+            SCSS
+
+            it { should_not report_lint }
+          end
+
+          context 'and is missing a semicolon' do
+            let(:scss) { <<-SCSS }
+              $foo: (10
+                  20 21 22
+                30)
+            SCSS
+
+            it { should report_lint }
+          end
+        end
+      end
     end
 
-    context 'without a trailing comma' do
+    context 'without parentheses' do
       context 'and ends with a semicolon' do
-        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2\n);" }
+        let(:scss) { '$foo: 1 2;' }
 
         it { should_not report_lint }
       end
 
       context 'and is missing a semicolon' do
-        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2\n)" }
+        let(:scss) { '$foo: 1 2' }
 
         it { should report_lint }
       end
+
+      context 'and a nested list' do
+        context 'with parentheses' do
+          context 'on a single line' do
+            context 'and ends with a semicolon' do
+              let(:scss) { '$foo: 1 (2 3);' }
+
+              it { should_not report_lint }
+            end
+
+            context 'and is missing a semicolon' do
+              let(:scss) { '$foo: 1 (2 3)' }
+
+              it { should report_lint }
+            end
+          end
+
+          context 'over multiple lines' do
+            context 'and ends with a semicolon' do
+              let(:scss) { <<-SCSS }
+                  $foo: 1
+                      (2 3);
+                SCSS
+              it { should_not report_lint }
+            end
+
+            context 'and is missing a semicolon' do
+              let(:scss) { <<-SCSS }
+                  $foo: 1
+                      (2 3)
+                SCSS
+
+              it { should report_lint }
+            end
+          end
+        end
+
+        context 'without parentheses' do
+          context 'and ends with a semicolon' do
+            let(:scss) { <<-SCSS }
+              $foo: 1,
+                  2 3;
+            SCSS
+
+            it { should_not report_lint }
+          end
+
+          context 'and is missing a semicolon' do
+            let(:scss) { <<-SCSS }
+              $foo: 1,
+                  2 3
+            SCSS
+
+            it { should report_lint }
+          end
+        end
+      end
     end
+  end
 
-    context 'and a nested list' do
+  context 'when a variable declaration contains a map' do
+    context 'on a single line' do
       context 'and ends with a semicolon' do
-        let(:scss) { <<-SCSS }
-          $foo: (
-            "a": (
-              "b",
-              "c"
-            )
-          );
-        SCSS
+        let(:scss) { '$foo: ("a": ("b": "c"));' }
 
         it { should_not report_lint }
       end
 
       context 'and is missing a semicolon' do
-        let(:scss) { <<-SCSS }
-          $foo: (
-            "a": (
-              "b",
-              "c"
-            )
-          )
-        SCSS
+        let(:scss) { '$foo: ("a": ("b": "c"))' }
 
         it { should report_lint }
       end
     end
+
+    context 'over multiple lines' do
+      context 'with a trailing comma' do
+        context 'and ends with a semicolon' do
+          let(:scss) { "$foo: (\n  one: 1,\ntwo: 2,\n);" }
+
+          it { should_not report_lint }
+        end
+
+        context 'and is missing a semicolon' do
+          let(:scss) { "$foo: (\n  one: 1,\ntwo: 2,\n)" }
+
+          it { should report_lint }
+        end
+      end
+
+      context 'without a trailing comma' do
+        context 'and ends with a semicolon' do
+          let(:scss) { "$foo: (\n  one: 1,\ntwo: 2\n);" }
+
+          it { should_not report_lint }
+        end
+
+        context 'and is missing a semicolon' do
+          let(:scss) { "$foo: (\n  one: 1,\ntwo: 2\n)" }
+
+          it { should report_lint }
+        end
+      end
+
+      context 'and a nested list' do
+        context 'and ends with a semicolon' do
+          let(:scss) { <<-SCSS }
+            $foo: (
+              "a": (
+                "b",
+                "c"
+              )
+            );
+          SCSS
+
+          it { should_not report_lint }
+        end
+
+        context 'and is missing a semicolon' do
+          let(:scss) { <<-SCSS }
+            $foo: (
+              "a": (
+                "b",
+                "c"
+              )
+            )
+          SCSS
+
+          it { should report_lint }
+        end
+      end
+    end
   end
 
   context 'with an @extend directive' do

data/spec/scss_lint/plugins_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 module SCSSLint
   describe Plugins do
-    let(:subject) { described_class.new(Config.new(config_options)) }
+    let(:subject) { described_class.new(Config.new(config_options, Config.user_file)) }
 
     describe '#load' do
       context 'when gem plugins are specified' do
@@ -22,9 +22,10 @@ module SCSSLint
       context 'when directory plugins are specified' do
         let(:config_options) { { 'plugin_directories' => ['some_dir'] } }
         let(:plugin) { double(load: nil) }
+        let(:plugin_dir) { File.join(File.dirname(Config.user_file), 'some_dir') }
 
         before do
-          Plugins::LinterDir.stub(:new).with('some_dir').and_return(plugin)
+          Plugins::LinterDir.stub(:new).with(plugin_dir).and_return(plugin)
         end
 
         it 'loads the plugin' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.44.0
+  version: 0.45.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,22 +9,28 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-22 00:00:00.000000000 Z
+date: 2016-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '11'
 - !ruby/object:Gem::Dependency
   name: sass
   requirement: !ruby/object:Gem::Requirement
@@ -126,6 +132,7 @@ files:
 - lib/scss_lint/linter/space_after_comma.rb
 - lib/scss_lint/linter/space_after_property_colon.rb
 - lib/scss_lint/linter/space_after_property_name.rb
+- lib/scss_lint/linter/space_after_variable_colon.rb
 - lib/scss_lint/linter/space_after_variable_name.rb
 - lib/scss_lint/linter/space_around_operator.rb
 - lib/scss_lint/linter/space_before_brace.rb
@@ -210,6 +217,7 @@ files:
 - spec/scss_lint/linter/space_after_comma_spec.rb
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
+- spec/scss_lint/linter/space_after_variable_colon_spec.rb
 - spec/scss_lint/linter/space_after_variable_name_spec.rb
 - spec/scss_lint/linter/space_around_operator_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
@@ -320,6 +328,7 @@ test_files:
 - spec/scss_lint/linter/space_after_comma_spec.rb
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
+- spec/scss_lint/linter/space_after_variable_colon_spec.rb
 - spec/scss_lint/linter/space_after_variable_name_spec.rb
 - spec/scss_lint/linter/space_around_operator_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb