scss_lint 0.42.2 → 0.43.0

data/spec/scss_lint/linter/comment_spec.rb

@@ -76,4 +76,20 @@ describe SCSSLint::Linter::Comment do
 
     it { should report_lint }
   end
+
+  context 'when multi-line comments are preferred' do
+    let(:linter_config) { { 'style' => 'loud' } }
+
+    context 'and silent comments are present' do
+      let(:scss) { '// A silent comment' }
+
+      it { should report_lint }
+    end
+
+    context 'and loud comments are present' do
+      let(:scss) { '/* A loud comment */' }
+
+      it { should_not report_lint }
+    end
+  end
 end

data/spec/scss_lint/linter/empty_line_between_blocks_spec.rb

@@ -102,6 +102,68 @@ describe SCSSLint::Linter::EmptyLineBetweenBlocks do
     it { should_not report_lint }
   end
 
+  context 'when at-roots are defined' do
+    context 'and there is no blank line between them' do
+      let(:scss) { <<-SCSS }
+        div {
+          @at-root {
+            p {
+            }
+          }
+          @at-root {
+            p {
+            }
+          }
+        }
+      SCSS
+
+      it { should report_lint line: 5 }
+    end
+
+    context 'and there is a blank line between them' do
+      let(:scss) { <<-SCSS }
+        div {
+          @at-root {
+            p {
+            }
+          }
+
+          @at-root {
+            p {
+            }
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when media blocks are defined' do
+    context 'and there is no blank line between them' do
+      let(:scss) { <<-SCSS }
+        @media screen {
+        }
+        @media print {
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and there is a blank line between them' do
+      let(:scss) { <<-SCSS }
+        @media screen {
+        }
+
+        @media print {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
   context 'when mixins are defined' do
     context 'and there is no blank line between them' do
       let(:scss) { <<-SCSS }

data/spec/scss_lint/linter/indentation_spec.rb

@@ -287,6 +287,7 @@ describe SCSSLint::Linter::Indentation do
         .component {}
           .component__image {}
           .component__text {}
+            $some-variable: 0;
             .component-subblock {}
             .component-subblock__text {}
           .component-category {}
@@ -324,15 +325,6 @@ describe SCSSLint::Linter::Indentation do
       it { should report_lint line: 4 }
     end
 
-    context 'and a non-nested non-ruleset is incorrectly indented' do
-      let(:scss) { <<-SCSS }
-        p {}
-          $var: one;
-      SCSS
-
-      it { should report_lint line: 2 }
-    end
-
     context 'and a nested non-ruleset is correctly indented' do
       let(:scss) { <<-SCSS }
         .one {

data/spec/scss_lint/linter/leading_zero_spec.rb

@@ -177,6 +177,18 @@ describe SCSSLint::Linter::LeadingZero do
     it { should report_lint count: 1, line: 1 }
   end
 
+  context 'when a leading zero exists in interpolation in a comment' do
+    let(:scss) { <<-SCSS }
+      .outer {
+        .inner {
+          /* \#{0.5} */
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
   context 'when leading zeros are preferred' do
     let(:linter_config) { { 'style' => 'include_zero' } }
 

data/spec/scss_lint/linter/mergeable_selector_spec.rb

@@ -241,6 +241,21 @@ describe SCSSLint::Linter::MergeableSelector do
     it { should report_lint }
   end
 
+  context 'when there are two parent selectors in a single selector' do
+    let(:scss) { <<-SCSS }
+      .b-some {
+        &__image {
+          width: 100%;
+        }
+        &__image + &__buttons {
+          margin-top: 14px;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
   context 'when force_nesting is enabled' do
     let(:linter_config) { { 'force_nesting' => true } }
 
@@ -280,4 +295,48 @@ describe SCSSLint::Linter::MergeableSelector do
       it { should_not report_lint }
     end
   end
+
+  context 'when a whitelist list is defined' do
+    let(:linter_config) { { 'whitelist' => ['polyfill-rule'] } }
+
+    context 'when a rule is found in the whitelist' do
+      let(:scss) { <<-SCSS }
+        polyfill-rule { content: '.foo'; color: red; }
+        polyfill-rule { content: '.foo'; color: red; }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a rule is not found in the whitelist' do
+      let(:scss) { <<-SCSS }
+        .foo polyfill-rule { content: '.foo'; color: red; }
+        .foo polyfill-rule { content: '.foo'; color: red; }
+      SCSS
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when a single whitelist selector is defined' do
+    let(:linter_config) { { 'whitelist' => 'polyfill-rule' } }
+
+    context 'when a rule is found in the whitelist' do
+      let(:scss) { <<-SCSS }
+        polyfill-rule { content: '.foo'; color: red; }
+        polyfill-rule { content: '.foo'; color: red; }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a rule is not found in the whitelist' do
+      let(:scss) { <<-SCSS }
+        .foo polyfill-rule { content: '.foo'; color: red; }
+        .foo polyfill-rule { content: '.foo'; color: red; }
+      SCSS
+
+      it { should report_lint }
+    end
+  end
 end

data/spec/scss_lint/linter/property_spelling_spec.rb

@@ -55,6 +55,34 @@ describe SCSSLint::Linter::PropertySpelling do
     end
   end
 
+  context 'when disabled properties are specified' do
+    let(:linter_config) do
+      {
+        'disabled_properties' => ['margin'],
+      }
+    end
+
+    context 'with a non-existent property' do
+      let(:scss) { <<-SCSS }
+        p {
+          peanut-butter: jelly-time;
+        }
+      SCSS
+
+      it { should report_lint }
+    end
+
+    context 'with a property listed as an disabled property' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 0;
+        }
+      SCSS
+
+      it { should report_lint }
+    end
+  end
+
   context 'with valid nested properties' do
     let(:scss) { <<-SCSS }
       p {

data/spec/scss_lint/linter/pseudo_element_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::PseudoElement do
+  context 'when a pseudo-element has two colons' do
+    let(:scss) { <<-SCSS }
+      ::before {}
+      p::before {}
+      p#nav::before {}
+      p div::before {}
+      p::before div {}
+      p, div::before {}
+      p::before, div {}
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a pseudo-element has one colon' do
+    let(:scss) { <<-SCSS }
+      :before {}
+      p:before {}
+      p#nav:before {}
+      p div:before {}
+      p:before div {}
+      p, div:before {}
+      p:before, div {}
+    SCSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+    it { should report_lint line: 5 }
+    it { should report_lint line: 6 }
+    it { should report_lint line: 7 }
+  end
+
+  context 'when a pseudo-selector has one colon' do
+    let(:scss) { <<-SCSS }
+      :hover {}
+      p:hover {}
+      p#nav:hover {}
+      p div:hover {}
+      p:hover div {}
+      p, div:hover {}
+      p:hover, div {}
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a pseudo-selector has two colons' do
+    let(:scss) { <<-SCSS }
+      ::hover {}
+      p::hover {}
+      p#nav::hover {}
+      p div::hover {}
+      p::hover div {}
+      p, div::hover {}
+      p::hover, div {}
+    SCSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+    it { should report_lint line: 5 }
+    it { should report_lint line: 6 }
+    it { should report_lint line: 7 }
+  end
+end

data/spec/scss_lint/linter/single_line_per_selector_spec.rb

@@ -148,6 +148,33 @@ describe SCSSLint::Linter::SingleLinePerSelector do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 1 }
+  end
+
+  context 'when a selector sequence spans multiple lines in the middle of a comma sequence' do
+    let(:scss) { <<-SCSS }
+      .one,
+      .two,
+      .a
+      .b,
+      .other {
+      }
+    SCSS
+
+    it { should report_lint line: 3 }
+  end
+
+  context 'when a lot of selectors are on a single line over multiple lines' do
+    let(:scss) { <<-SCSS }
+      html, body,
+      h1, h2, h3, h4 {
+        border: 0;
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 2 }
+    it { should_not report_lint line: 3 }
+    it { should_not report_lint line: 4 }
   end
 end

data/spec/scss_lint/linter/space_after_variable_name_spec.rb

@@ -10,4 +10,16 @@ describe SCSSLint::Linter::SpaceAfterVariableName do
   it { should_not report_lint line: 1 }
   it { should report_lint line: 2 }
   it { should report_lint line: 3 }
+
+  context 'when a map contains aligned colons' do
+    let(:scss) { <<-SCSS }
+      $map: (
+        'one'   : 350px,
+        'two'   : 450px,
+        'three' : 560px,
+      );
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/space_around_operator_spec.rb

@@ -242,6 +242,57 @@ describe SCSSLint::Linter::SpaceAroundOperator do
     end
   end
 
+  context 'when at least one space is preferred' do
+    let(:style) { 'at_least_one_space' }
+
+    context 'when values with single-spaced infix operators exist' do
+      let(:scss) { <<-SCSS }
+        $x: 2px + 2px;
+
+        p {
+          margin: 5px + 5px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when numeric values with infix operators exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 5px+5px;
+          margin: 5px  +  5px;
+          margin: 4px*2;
+          margin: 20px%3;
+          font-family: sans-+serif;
+        }
+
+        $x: 10px+10px;
+        $x: 20px-10px;
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 4 }
+      it { should report_lint line: 5 }
+      it { should report_lint line: 6 }
+      it { should_not report_lint line: 7 }
+      it { should report_lint line: 9 }
+      it { should report_lint line: 10 }
+    end
+
+    context 'when expression spread over two lines' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 7px +
+              7px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
   context 'when no space is preferred' do
     let(:style) { 'no_space' }
 

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -470,6 +470,34 @@ describe SCSSLint::Linter::TrailingSemicolon do
         it { should report_lint }
       end
     end
+
+    context 'and a nested list' do
+      context 'and ends with a semicolon' do
+        let(:scss) { <<-SCSS }
+          $foo: (
+            "a": (
+              "b",
+              "c"
+            )
+          );
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and is missing a semicolon' do
+        let(:scss) { <<-SCSS }
+          $foo: (
+            "a": (
+              "b",
+              "c"
+            )
+          )
+        SCSS
+
+        it { should report_lint }
+      end
+    end
   end
 
   context 'with an @extend directive' do