scss_lint 0.41.0 → 0.42.0

data/spec/scss_lint/linter/space_around_operator_spec.rb

@@ -151,6 +151,30 @@ describe SCSSLint::Linter::SpaceAroundOperator do
       it { should report_lint line: 2 }
     end
 
+    context 'when a selector contains an interpolated infix operator, well spaced' do
+      let(:scss) { <<-SCSS }
+        @for $i from 1 through 25 {
+          .progress-bar[aria-valuenow="\#{$i / 25 * 100}"] {
+            opacity: 0;
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a selector contains an interpolated infix operator, badly spaced' do
+      let(:scss) { <<-SCSS }
+        @for $i from 1 through 25 {
+          .progress-bar[aria-valuenow="\#{$i/25*100}"] {
+            opacity: 0;
+          }
+        }
+      SCSS
+
+      it { should report_lint line: 2, count: 2 }
+    end
+
     context 'when values with non-evaluated operations exist' do
       let(:scss) { <<-SCSS }
         $my-variable: 10px;
@@ -207,6 +231,7 @@ describe SCSSLint::Linter::SpaceAroundOperator do
       it { should report_lint line: 6 }
     end
   end
+
   context 'when one space is preferred' do
     let(:style) { 'no_space' }
 

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -301,4 +301,54 @@ describe SCSSLint::Linter::TrailingSemicolon do
 
     it { should_not report_lint }
   end
+
+  context 'when variable declaration is followed by a comment and semicolon' do
+    let(:scss) { '$foo: bar // comment;' }
+
+    it { should report_lint }
+  end
+
+  context 'when a variable declaration contains parentheses' do
+    context 'and ends with a semicolon' do
+      let(:scss) { '$foo: ($expr);' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and is missing a semicolon' do
+      let(:scss) { '$foo: ($expr)' }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when a variable declaration contains a multiline map' do
+    context 'with a trailing comma' do
+      context 'and ends with a semicolon' do
+        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2,\n);" }
+
+        it { should_not report_lint }
+      end
+
+      context 'and is missing a semicolon' do
+        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2,\n)" }
+
+        it { should report_lint }
+      end
+    end
+
+    context 'without a trailing comma' do
+      context 'and ends with a semicolon' do
+        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2\n);" }
+
+        it { should_not report_lint }
+      end
+
+      context 'and is missing a semicolon' do
+        let(:scss) { "$foo: (\n  one: 1,\ntwo: 2\n)" }
+
+        it { should report_lint }
+      end
+    end
+  end
 end

data/spec/scss_lint/linter/variable_for_property_spec.rb

@@ -88,6 +88,16 @@ describe SCSSLint::Linter::VariableForProperty do
       it { should report_lint line: 3 }
     end
 
+    context 'when configured property value is used with !important' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black !important;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
     context 'when property specifies `currentColor`' do
       let(:scss) { <<-SCSS }
         p {

data/spec/scss_lint/rake_task_spec.rb

@@ -3,14 +3,14 @@ require 'scss_lint/rake_task'
 require 'tempfile'
 
 describe SCSSLint::RakeTask do
-  before(:all) do
-    SCSSLint::RakeTask.new
-  end
-
   before do
     STDOUT.stub(:write) # Silence console output
   end
 
+  after(:each) do
+    Rake::Task['scss_lint'].clear if Rake::Task.task_defined?('scss_lint')
+  end
+
   let(:file) do
     Tempfile.new(%w[scss-file .scss]).tap do |f|
       f.write(scss)
@@ -25,19 +25,68 @@ describe SCSSLint::RakeTask do
     end
   end
 
-  context 'when SCSS document is valid with no lints' do
+  context 'basic RakeTask' do
+    before(:each) do
+      SCSSLint::RakeTask.new
+    end
+
+    context 'when SCSS document is valid with no lints' do
+      let(:scss) { '' }
+
+      it 'does not call Kernel.exit' do
+        expect { run_task }.not_to raise_error
+      end
+    end
+
+    context 'when SCSS document is invalid' do
+      let(:scss) { '.class {' }
+
+      it 'calls Kernel.exit with the status code' do
+        expect { run_task }.to raise_error SystemExit
+      end
+    end
+  end
+
+  context 'configured RakeTask with a config file' do
     let(:scss) { '' }
 
-    it 'does not call Kernel.exit' do
+    let(:config_file) do
+      config = Tempfile.new(%w[foo .yml])
+      config.write('')
+      config.close
+      config.path
+    end
+
+    it 'passes config files to the CLI' do
+      SCSSLint::RakeTask.new.tap do |t|
+        t.config = config_file
+      end
+
+      cli = double(SCSSLint::CLI)
+      SCSSLint::CLI.should_receive(:new) { cli }
+      args = ['--config', config_file, file.path]
+      cli.should_receive(:run).with(args) { 0 }
+
       expect { run_task }.not_to raise_error
     end
   end
 
-  context 'when SCSS document is invalid' do
-    let(:scss) { '.class {' }
+  context 'configured RakeTask with args' do
+    let(:scss) { '' }
+
+    it 'passes args to the CLI' do
+      formatter_args = ['--formatter', 'JSON']
+
+      SCSSLint::RakeTask.new.tap do |t|
+        t.args = formatter_args
+      end
 
-    it 'calls Kernel.exit with the status code' do
-      expect { run_task }.to raise_error SystemExit
+      cli = double(SCSSLint::CLI)
+      SCSSLint::CLI.should_receive(:new) { cli }
+      args = formatter_args + [file.path]
+      cli.should_receive(:run).with(args) { 0 }
+
+      expect { run_task }.not_to raise_error
     end
   end
 end

data/spec/scss_lint/reporter/clean_files_reporter_spec.rb

@@ -45,13 +45,13 @@ describe SCSSLint::Reporter::CleanFilesReporter do
 
       it 'prints the file for each lint' do
         clean_files.each do |file|
-          subject.report_lints.scan(/#{file}/).count.should == 1
+          subject.report_lints.scan(file).count.should == 1
         end
       end
 
       it 'does not print clean files' do
         dirty_files.each do |file|
-          subject.report_lints.scan(/#{file}/).count.should == 0
+          subject.report_lints.scan(file).count.should == 0
         end
       end
     end

data/spec/scss_lint/reporter/default_reporter_spec.rb

@@ -35,19 +35,19 @@ describe SCSSLint::Reporter::DefaultReporter do
 
       it 'prints the filename for each lint' do
         filenames.each do |filename|
-          subject.report_lints.scan(/#{filename}/).count.should == 1
+          subject.report_lints.scan(filename).count.should == 1
         end
       end
 
       it 'prints the line number for each lint' do
         lines.each do |line|
-          subject.report_lints.scan(/#{line}/).count.should == 1
+          subject.report_lints.scan(line.to_s).count.should == 1
         end
       end
 
       it 'prints the description for each lint' do
         descriptions.each do |description|
-          subject.report_lints.scan(/#{description}/).count.should == 1
+          subject.report_lints.scan(description).count.should == 1
         end
       end
 

data/spec/scss_lint/reporter/files_reporter_spec.rb

@@ -31,7 +31,7 @@ describe SCSSLint::Reporter::FilesReporter do
 
       it 'prints the filename for each lint' do
         filenames.each do |filename|
-          subject.report_lints.scan(/#{filename}/).count.should == 1
+          subject.report_lints.scan(filename).count.should == 1
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.41.0
+  version: 0.42.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-24 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -62,6 +62,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- MIT-LICENSE
 - bin/scss-lint
 - config/default.yml
 - data/prefixed-identifiers/base.txt