scss_lint 0.39.0 → 0.40.0

data/spec/scss_lint/linter/property_units_spec.rb

@@ -50,6 +50,36 @@ describe SCSSLint::Linter::PropertyUnits do
 
         it { should report_lint line: 2 }
       end
+
+      context 'and some of the units are allowed but others are not allowed' do
+        let(:scss) { <<-SCSS }
+          p {
+            margin: 1rem 1rem 16px 1rem;
+          }
+        SCSS
+
+        it { should report_lint line: 2 }
+      end
+
+      context 'and it contains a quoted string with unit-like characterstics' do
+        let(:scss) { <<-SCSS }
+          p {
+            font: italic 1rem "A 1a";
+          }
+        SCSS
+
+        it { should_not report_lint }
+
+        context 'and it contains other unallowed units' do
+          let(:scss) { <<-SCSS }
+            p {
+              font: italic 1px "A 1a";
+            }
+          SCSS
+
+          it { should report_lint }
+        end
+      end
     end
   end
 
@@ -226,4 +256,14 @@ describe SCSSLint::Linter::PropertyUnits do
 
     it { should_not report_lint }
   end
+
+  context 'when property contains a string in quotes that looks like a value with weird units' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: "This is 12a";
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/space_after_variable_name_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe SCSSLint::SpaceAfterVariableName do
+  let(:scss) { <<-SCSS }
+    $none: #fff;
+    $one : #fff;
+    $two  : #fff;
+   SCSS
+
+  it { should_not report_lint line: 1 }
+  it { should report_lint line: 2 }
+  it { should report_lint line: 3 }
+end

data/spec/scss_lint/linter/trailing_whitespace_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::TrailingWhitespace do
+  context 'when lines contain trailing spaces' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;\s\s
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when lines contain trailing tabs' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;\t\t
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when lines does not contain trailing whitespace' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter_spec.rb

@@ -7,6 +7,11 @@ describe SCSSLint::Linter do
 
     module SCSSLint
       class Linter::Fake < SCSSLint::Linter
+        def visit_root(_node)
+          add_lint(engine.lines.count, 'final new line') unless engine.lines[-1][-1] == "\n"
+          yield
+        end
+
         def visit_prop(node)
           return unless node.value.to_sass.strip == 'fail1'
           add_lint(node, 'everything offends me')
@@ -47,7 +52,7 @@ describe SCSSLint::Linter do
     end
 
     context 'when a disable is present at the top level' do
-      let(:scss) { <<-SCSS }
+      let(:scss) { <<-SCSS.strip }
         // scss-lint:disable Fake
         p {
           border: fail1;
@@ -271,6 +276,10 @@ describe SCSSLint::Linter do
         .good-selector {
           border: fail1;
         }
+
+        p {
+          color: #FFF;
+        }
       SCSS
 
       it { should_not report_lint line: 1 }
@@ -279,6 +288,10 @@ describe SCSSLint::Linter do
 
     context 'when /* control comment appears in the middle of a comma sequence' do
       let(:scss) { <<-SCSS }
+        p {
+          color: #FFF;
+        }
+
         .badClass, /* scss-lint:disable Fake */
         .good-selector {
           border: fail1;
@@ -286,7 +299,7 @@ describe SCSSLint::Linter do
       SCSS
 
       it { should_not report_lint line: 1 }
-      it { should report_lint line: 3 }
+      it { should report_lint line: 7 }
     end
   end
 end

data/spec/scss_lint/plugins/linter_dir_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe SCSSLint::Plugins::LinterDir do
+  let(:plugin_directory) { File.expand_path('../../fixtures/plugins', __FILE__) }
+  let(:subject) { described_class.new(plugin_directory) }
+
+  describe '#config' do
+    it 'returns empty configuration' do
+      subject.config.should == SCSSLint::Config.new({})
+    end
+  end
+
+  describe '#load' do
+    it 'requires each file in the plugin directory' do
+      subject.should_receive(:require)
+        .with(File.join(plugin_directory, 'linter_plugin.rb')).once
+
+      subject.load
+    end
+  end
+end

data/spec/scss_lint/plugins/linter_gem_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+module SCSSLint
+  describe Plugins::LinterGem do
+    let(:subject) { described_class.new('a_gem') }
+
+    describe '#load' do
+      let(:gem_dir) { '/gem_dir' }
+      let(:config_file) { File.join(gem_dir, '.scss-lint.yml') }
+      let(:config_file_exists) { false }
+
+      before do
+        File.stub(:exist?).with(config_file).and_return(config_file_exists)
+      end
+
+      context 'when the gem does not exist' do
+        it 'raises an exception' do
+          expect { subject.load }.to raise_error Exceptions::PluginGemLoadError
+        end
+      end
+
+      context 'when the gem exists' do
+        before do
+          subject.stub(:require).with('a_gem').and_return(true)
+          Gem::Specification.stub(:find_by_name)
+                            .with('a_gem')
+                            .and_return(double(gem_dir: gem_dir))
+        end
+
+        it 'requires the gem' do
+          subject.should_receive(:require).with('a_gem').once
+          subject.load
+        end
+
+        context 'when the gem does not include a configuration file' do
+          it 'loads an empty configuration' do
+            subject.load
+            subject.config.should == Config.new({})
+          end
+        end
+
+        context 'when a config file exists in the gem' do
+          let(:config_file_exists) { true }
+          let(:fake_config) { Config.new('linters' => { 'FakeLinter' => {} }) }
+
+          before do
+            Config.should_receive(:load)
+                  .with(config_file, merge_with_default: false)
+                  .and_return(fake_config)
+          end
+
+          it 'loads the configuration' do
+            subject.load
+            subject.config.should == fake_config
+          end
+        end
+      end
+    end
+  end
+end

data/spec/scss_lint/plugins_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+module SCSSLint
+  describe Plugins do
+    let(:subject) { described_class.new(Config.new(config_options)) }
+
+    describe '#load' do
+      context 'when gem plugins are specified' do
+        let(:config_options) { { 'plugin_gems' => ['a_gem'] } }
+        let(:plugin) { double(load: nil) }
+
+        before do
+          Plugins::LinterGem.stub(:new).with('a_gem').and_return(plugin)
+        end
+
+        it 'loads the plugin' do
+          plugin.should_receive(:load)
+          subject.load
+        end
+      end
+
+      context 'when directory plugins are specified' do
+        let(:config_options) { { 'plugin_directories' => ['some_dir'] } }
+        let(:plugin) { double(load: nil) }
+
+        before do
+          Plugins::LinterDir.stub(:new).with('some_dir').and_return(plugin)
+        end
+
+        it 'loads the plugin' do
+          plugin.should_receive(:load)
+          subject.load
+        end
+      end
+
+      context 'when plugins options are empty lists' do
+        let(:config_options) { { 'plugin_directories' => [], 'plugin_gems' => [] } }
+
+        it 'returns empty array' do
+          subject.load.should == []
+        end
+      end
+
+      context 'when no plugins options are specified' do
+        let(:config_options) { {} }
+
+        it 'returns empty array' do
+          subject.load.should == []
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,13 @@
+if ENV['TRAVIS']
+  # When running in Travis, report coverage stats to Coveralls.
+  require 'coveralls'
+  Coveralls.wear!
+else
+  # Otherwise render coverage information in coverage/index.html and display
+  # coverage percentage in the console.
+  require 'simplecov'
+end
+
 require 'scss_lint'
 
 Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each { |f| require f }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.39.0
+  version: 0.40.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-23 00:00:00.000000000 Z
+date: 2015-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.1.0
 description: Configurable tool for writing clean and consistent SCSS
 email:
 - eng@brigade.com
@@ -94,6 +94,7 @@ files:
 - lib/scss_lint/linter/else_placement.rb
 - lib/scss_lint/linter/empty_line_between_blocks.rb
 - lib/scss_lint/linter/empty_rule.rb
+- lib/scss_lint/linter/extend_directive.rb
 - lib/scss_lint/linter/final_newline.rb
 - lib/scss_lint/linter/hex_length.rb
 - lib/scss_lint/linter/hex_notation.rb
@@ -120,10 +121,12 @@ files:
 - lib/scss_lint/linter/space_after_comma.rb
 - lib/scss_lint/linter/space_after_property_colon.rb
 - lib/scss_lint/linter/space_after_property_name.rb
+- lib/scss_lint/linter/space_after_variable_name.rb
 - lib/scss_lint/linter/space_before_brace.rb
 - lib/scss_lint/linter/space_between_parens.rb
 - lib/scss_lint/linter/string_quotes.rb
 - lib/scss_lint/linter/trailing_semicolon.rb
+- lib/scss_lint/linter/trailing_whitespace.rb
 - lib/scss_lint/linter/trailing_zero.rb
 - lib/scss_lint/linter/unnecessary_mantissa.rb
 - lib/scss_lint/linter/unnecessary_parent_reference.rb
@@ -135,6 +138,9 @@ files:
 - lib/scss_lint/linter_registry.rb
 - lib/scss_lint/location.rb
 - lib/scss_lint/options.rb
+- lib/scss_lint/plugins.rb
+- lib/scss_lint/plugins/linter_dir.rb
+- lib/scss_lint/plugins/linter_gem.rb
 - lib/scss_lint/rake_task.rb
 - lib/scss_lint/reporter.rb
 - lib/scss_lint/reporter/config_reporter.rb
@@ -151,6 +157,7 @@ files:
 - spec/scss_lint/config_spec.rb
 - spec/scss_lint/engine_spec.rb
 - spec/scss_lint/file_finder_spec.rb
+- spec/scss_lint/fixtures/plugins/linter_plugin.rb
 - spec/scss_lint/linter/bang_format_spec.rb
 - spec/scss_lint/linter/bem_depth_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
@@ -164,6 +171,7 @@ files:
 - spec/scss_lint/linter/else_placement_spec.rb
 - spec/scss_lint/linter/empty_line_between_blocks_spec.rb
 - spec/scss_lint/linter/empty_rule_spec.rb
+- spec/scss_lint/linter/extend_directive_spec.rb
 - spec/scss_lint/linter/final_newline_spec.rb
 - spec/scss_lint/linter/hex_length_spec.rb
 - spec/scss_lint/linter/hex_notation_spec.rb
@@ -190,10 +198,12 @@ files:
 - spec/scss_lint/linter/space_after_comma_spec.rb
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
+- spec/scss_lint/linter/space_after_variable_name_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
 - spec/scss_lint/linter/string_quotes_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
+- spec/scss_lint/linter/trailing_whitespace_spec.rb
 - spec/scss_lint/linter/trailing_zero_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
 - spec/scss_lint/linter/unnecessary_parent_reference_spec.rb
@@ -206,6 +216,9 @@ files:
 - spec/scss_lint/linter_spec.rb
 - spec/scss_lint/location_spec.rb
 - spec/scss_lint/options_spec.rb
+- spec/scss_lint/plugins/linter_dir_spec.rb
+- spec/scss_lint/plugins/linter_gem_spec.rb
+- spec/scss_lint/plugins_spec.rb
 - spec/scss_lint/rake_task_spec.rb
 - spec/scss_lint/reporter/config_reporter_spec.rb
 - spec/scss_lint/reporter/default_reporter_spec.rb
@@ -237,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: SCSS lint tool
@@ -246,6 +259,7 @@ test_files:
 - spec/scss_lint/config_spec.rb
 - spec/scss_lint/engine_spec.rb
 - spec/scss_lint/file_finder_spec.rb
+- spec/scss_lint/fixtures/plugins/linter_plugin.rb
 - spec/scss_lint/linter/bang_format_spec.rb
 - spec/scss_lint/linter/bem_depth_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
@@ -259,6 +273,7 @@ test_files:
 - spec/scss_lint/linter/else_placement_spec.rb
 - spec/scss_lint/linter/empty_line_between_blocks_spec.rb
 - spec/scss_lint/linter/empty_rule_spec.rb
+- spec/scss_lint/linter/extend_directive_spec.rb
 - spec/scss_lint/linter/final_newline_spec.rb
 - spec/scss_lint/linter/hex_length_spec.rb
 - spec/scss_lint/linter/hex_notation_spec.rb
@@ -285,10 +300,12 @@ test_files:
 - spec/scss_lint/linter/space_after_comma_spec.rb
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
+- spec/scss_lint/linter/space_after_variable_name_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
 - spec/scss_lint/linter/string_quotes_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
+- spec/scss_lint/linter/trailing_whitespace_spec.rb
 - spec/scss_lint/linter/trailing_zero_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
 - spec/scss_lint/linter/unnecessary_parent_reference_spec.rb
@@ -301,6 +318,9 @@ test_files:
 - spec/scss_lint/linter_spec.rb
 - spec/scss_lint/location_spec.rb
 - spec/scss_lint/options_spec.rb
+- spec/scss_lint/plugins/linter_dir_spec.rb
+- spec/scss_lint/plugins/linter_gem_spec.rb
+- spec/scss_lint/plugins_spec.rb
 - spec/scss_lint/rake_task_spec.rb
 - spec/scss_lint/reporter/config_reporter_spec.rb
 - spec/scss_lint/reporter/default_reporter_spec.rb
@@ -312,3 +332,4 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/matchers/report_lint.rb
+has_rdoc: