scss-lint 0.30.0 → 0.31.0

data/spec/scss_lint/linter/bang_format_spec.rb

@@ -76,4 +76,24 @@ describe SCSSLint::Linter::BangFormat do
 
     it { should_not report_lint }
   end
+
+  context 'when ! appears within a string' do
+    let(:css) { <<-CSS }
+      p:before { content: "!important"; }
+      p:before { content: "imp!ortant"; }
+      p:after { content: '!'; }
+      div:before { content: 'important!'; }
+      div:after { content: '  !  '; }
+      p[attr="foo!bar"] {};
+      p[attr='foo!bar'] {};
+      p[attr="!foobar"] {};
+      p[attr='foobar!'] {};
+      $foo: 'bar!';
+      $foo: "bar!";
+      $foo: "!bar";
+      $foo: "b!ar";
+    CSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/duplicate_property_spec.rb

@@ -173,4 +173,17 @@ describe SCSSLint::Linter::DuplicateProperty do
 
     it { should report_lint line: 3 }
   end
+
+  context 'when property contains a duplicate value in a nested rule set' do
+    let(:css) { <<-CSS }
+      .outer {
+        .inner {
+          color: $some-color;
+          color: $some-color;
+        }
+      }
+    CSS
+
+    it { should report_lint line: 4 }
+  end
 end

data/spec/scss_lint/linter/empty_line_between_blocks_spec.rb

@@ -179,38 +179,39 @@ describe SCSSLint::Linter::EmptyLineBetweenBlocks do
     end
   end
 
-  context 'when a rule set is followed by a comment' do
+  context 'when a rule set is preceded by a comment' do
     let(:css) { <<-CSS }
       a {
       }
+
       // This is a comment
       p {
       }
     CSS
 
-    it { should report_lint line: 2 }
+    it { should_not report_lint }
   end
 
-  context 'when a rule set is preceded by a comment' do
+  context 'when a rule set is immediately followed by a comment' do
     let(:css) { <<-CSS }
       a {
-      }
+      } // A comment
 
-      // This is a comment
-      p {
-      }
+      a {
+      } /* Another comment */
     CSS
 
     it { should_not report_lint }
   end
 
-  context 'when a rule set is immediately followed by a comment' do
+  context 'when rule set is followed by a comment on the next line' do
     let(:css) { <<-CSS }
       a {
-      } // A comment
+      }
+      // A trailing comment (often a control comment)
 
-      a {
-      } /* Another comment */
+      b {
+      }
     CSS
 
     it { should_not report_lint }

data/spec/scss_lint/linter/id_selector_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::IdSelector do
+  context 'when rule is a type' do
+    let(:css) { 'p {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is an ID' do
+    let(:css) { '#identifier {}' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule is a class' do
+    let(:css) { '.class {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with a class' do
+    let(:css) { 'a.class {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with an ID' do
+    let(:css) { 'a#identifier {}' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule is an ID with a pseudo-selector' do
+    let(:css) { '#identifier:active {}' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule contains a nested rule with type and ID' do
+    let(:css) { <<-CSS }
+      p {
+        a#identifier {}
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when rule contains multiple selectors' do
+    context 'when all of the selectors are just IDs, classes, or types' do
+      let(:css) { <<-CSS }
+        #identifier,
+        .class,
+        a {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+end

data/spec/scss_lint/linter/indentation_spec.rb

@@ -142,6 +142,17 @@ describe SCSSLint::Linter::Indentation do
     it { should_not report_lint }
   end
 
+  context 'when @at-root directive with no inline selector contains comment' do
+    let(:css) { <<-CSS }
+      @at-root {
+        // A comment that causes a crash
+        .something-else {}
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
   context 'when the indentation width has been explicitly set' do
     let(:linter_config) { { 'width' => 3 } }
 

data/spec/scss_lint/linter/name_format_spec.rb

@@ -1,167 +1,197 @@
 require 'spec_helper'
 
 describe SCSSLint::Linter::NameFormat do
-  context 'when no variable, functions, or mixin declarations exist' do
-    let(:css) { <<-CSS }
-      p {
-        margin: 0;
-      }
-    CSS
-
-    it { should_not report_lint }
-  end
+  shared_examples 'hyphenated_lowercase' do
+    context 'when no variable, functions, or mixin declarations exist' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+        }
+      CSS
 
-  context 'when a variable name contains a hyphen' do
-    let(:css) { '$content-padding: 10px;' }
+      it { should_not report_lint }
+    end
 
-    it { should_not report_lint }
-  end
+    context 'when a variable name contains a hyphen' do
+      let(:css) { '$content-padding: 10px;' }
 
-  context 'when a variable name contains an underscore' do
-    let(:css) { '$content_padding: 10px;' }
+      it { should_not report_lint }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when a variable name contains an underscore' do
+      let(:css) { '$content_padding: 10px;' }
 
-  context 'when a variable name contains an uppercase character' do
-    let(:css) { '$contentPadding: 10px;' }
+      it { should report_lint line: 1 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when a variable name contains an uppercase character' do
+      let(:css) { '$contentPadding: 10px;' }
 
-  context 'when a function is declared with a capital letter' do
-    let(:css) { <<-CSS }
-      @function badFunction() {
-      }
-    CSS
+      it { should report_lint line: 1 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when a function is declared with a capital letter' do
+      let(:css) { <<-CSS }
+        @function badFunction() {
+        }
+      CSS
 
-  context 'when a function is declared with an underscore' do
-    let(:css) { <<-CSS }
-      @function bad_function() {
-      }
-    CSS
+      it { should report_lint line: 1 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when a function is declared with an underscore' do
+      let(:css) { <<-CSS }
+        @function bad_function() {
+        }
+      CSS
 
-  context 'when a mixin is declared with a capital letter' do
-    let(:css) { <<-CSS }
-      @mixin badMixin() {
-      }
-    CSS
+      it { should report_lint line: 1 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when a mixin is declared with a capital letter' do
+      let(:css) { <<-CSS }
+        @mixin badMixin() {
+        }
+      CSS
 
-  context 'when a mixin is declared with an underscore' do
-    let(:css) { <<-CSS }
-      @mixin bad_mixin() {
-      }
-    CSS
+      it { should report_lint line: 1 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when a mixin is declared with an underscore' do
+      let(:css) { <<-CSS }
+        @mixin bad_mixin() {
+        }
+      CSS
 
-  context 'when no invalid usages exist' do
-    let(:css) { <<-CSS }
-      p {
-        margin: 0;
-      }
-    CSS
+      it { should report_lint line: 1 }
+    end
 
-    it { should_not report_lint }
-  end
+    context 'when no invalid usages exist' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+        }
+      CSS
 
-  context 'when a referenced variable name has a capital letter' do
-    let(:css) { <<-CSS }
-      p {
-        margin: $badVar;
-      }
-    CSS
+      it { should_not report_lint }
+    end
 
-    it { should report_lint line: 2 }
-  end
+    context 'when a referenced variable name has a capital letter' do
+      let(:css) { <<-CSS }
+        p {
+          margin: $badVar;
+        }
+      CSS
 
-  context 'when a referenced variable name has an underscore' do
-    let(:css) { <<-CSS }
-      p {
-        margin: $bad_var;
-      }
-    CSS
+      it { should report_lint line: 2 }
+    end
 
-    it { should report_lint line: 2 }
-  end
+    context 'when a referenced variable name has an underscore' do
+      let(:css) { <<-CSS }
+        p {
+          margin: $bad_var;
+        }
+      CSS
 
-  context 'when a referenced function name has a capital letter' do
-    let(:css) { <<-CSS }
-      p {
-        margin: badFunc();
-      }
-    CSS
+      it { should report_lint line: 2 }
+    end
 
-    it { should report_lint line: 2 }
-  end
+    context 'when a referenced function name has a capital letter' do
+      let(:css) { <<-CSS }
+        p {
+          margin: badFunc();
+        }
+      CSS
 
-  context 'when a referenced function name has an underscore' do
-    let(:css) { <<-CSS }
-      p {
-        margin: bad_func();
-      }
-    CSS
+      it { should report_lint line: 2 }
+    end
 
-    it { should report_lint line: 2 }
-  end
+    context 'when a referenced function name has an underscore' do
+      let(:css) { <<-CSS }
+        p {
+          margin: bad_func();
+        }
+      CSS
 
-  context 'when an included mixin name has a capital letter' do
-    let(:css) { '@include badMixin();' }
+      it { should report_lint line: 2 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when an included mixin name has a capital letter' do
+      let(:css) { '@include badMixin();' }
 
-  context 'when an included mixin name has an underscore' do
-    let(:css) { '@include bad_mixin();' }
+      it { should report_lint line: 1 }
+    end
 
-    it { should report_lint line: 1 }
-  end
+    context 'when an included mixin name has an underscore' do
+      let(:css) { '@include bad_mixin();' }
 
-  context 'when function is a transform function' do
-    %w[rotateX rotateY rotateZ
-       scaleX scaleY scaleZ
-       skewX skewY
-       translateX translateY translateZ].each do |function|
+      it { should report_lint line: 1 }
+    end
+
+    context 'when function is a transform function' do
+      %w[rotateX rotateY rotateZ
+         scaleX scaleY scaleZ
+         skewX skewY
+         translateX translateY translateZ].each do |function|
+        let(:css) { <<-CSS }
+          p {
+            transform: #{function}(2);
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+    end
+
+    context 'when mixin is a transform function' do
       let(:css) { <<-CSS }
         p {
-          transform: #{function}(2);
+          @include translateX(2);
         }
       CSS
 
       it { should_not report_lint }
     end
-  end
 
-  context 'when mixin is a transform function' do
-    let(:css) { <<-CSS }
-      p {
-        @include translateX(2);
-      }
-    CSS
+    context 'when a mixin contains keyword arguments with underscores' do
+      let(:css) { '@include mixin($some_var: 4);' }
 
-    it { should_not report_lint }
+      it { should report_lint }
+    end
+
+    context 'when a mixin contains keyword arguments with hyphens' do
+      let(:css) { '@include mixin($some-var: 4);' }
+
+      it { should_not report_lint }
+    end
   end
 
-  context 'when a mixin contains keyword arguments with underscores' do
-    let(:css) { '@include mixin($some_var: 4);' }
+  context 'when no configuration is specified' do
+    it_behaves_like 'hyphenated_lowercase'
+
+    context 'when a name contains a leading underscore' do
+      let(:css) { <<-CSS }
+        @function _private-method() {
+        }
+      CSS
 
-    it { should report_lint }
+      it { should_not report_lint }
+    end
   end
 
-  context 'when a mixin contains keyword arguments with hyphens' do
-    let(:css) { '@include mixin($some-var: 4);' }
+  context 'when leading underscores are not allowed' do
+    let(:linter_config) { { 'allow_leading_underscore' => false } }
+
+    it_behaves_like 'hyphenated_lowercase'
 
-    it { should_not report_lint }
+    context 'when a name contains a leading underscore' do
+      let(:css) { <<-CSS }
+        @function _private-method() {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
   end
 
   context 'when the BEM convention is specified' do