scss-lint 0.28.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 42f28b5047a9fc0063a953cfe84bf4d7e61939ae
-  data.tar.gz: dbf4ea16dadcdff7fde653b7433478085bf80260
+  metadata.gz: fe908b2051342dce6151d04897242d18a3f9bf0b
+  data.tar.gz: 785752360ba0475386ecc1c8f8d202268293f428
 SHA512:
-  metadata.gz: 0354b7af1ee236a8add0483e6adc97751e687b1f19850cc248cc94a9200fa28c5a1f84244b35b01a812a7f48a6c25056fdb07508d9e3d9b55ba928b7daa2a998
-  data.tar.gz: 321fbeeee64c9d02cd4dddd2176ac1b546f71a4f4b66bb861d089de1490316ffe0ce804395ff02727b78a8c4908fc1cf2c7c30ca198147ec5f3f828af3406efa
+  metadata.gz: cd5a9205186a67350c31d52d0cbd8677510fa5ae270ca0b25fc99dd87768c8b02393ebbbf2d068cc66f19ddf89ff7fb19b467d74a99ea3702fe7ff134352ef0a
+  data.tar.gz: 8063dfc1815c2d3b4a3edb76540635282484e0e56a1ce7b71bf2a60ec493ad5b3948b17b4fae56db6e1df226aa6704802946530aaf6304bd3a5952875b6d1409

data/config/default.yml

@@ -3,9 +3,6 @@ linters:
   BorderZero:
     enabled: true
 
-  CapitalizationInSelector:
-    enabled: true
-
   ColorKeyword:
     enabled: true
 
@@ -82,6 +79,10 @@ linters:
     enabled: true
     max_depth: 3
 
+  SelectorFormat:
+    enabled: true
+    convention: hyphenated_lowercase # or 'snake_case', or 'camel_case', or a regex pattern
+
   Shorthand:
     enabled: true
 
@@ -117,6 +118,9 @@ linters:
   TrailingSemicolon:
     enabled: true
 
+  TrailingZero:
+    enabled: false
+
   UnnecessaryMantissa:
     enabled: true
 

data/data/properties.txt

@@ -1,8 +1,10 @@
+@keyframes
 align-content
 align-items
+align-self
 alignment-adjust
 alignment-baseline
-align-self
+all
 animation
 animation-delay
 animation-direction
@@ -12,8 +14,8 @@ animation-iteration-count
 animation-name
 animation-play-state
 animation-timing-function
-appearance
 app-region
+appearance
 aspect-ratio
 backface-visibility
 background
@@ -123,9 +125,9 @@ column-rule
 column-rule-color
 column-rule-style
 column-rule-width
-columns
 column-span
 column-width
+columns
 content
 counter-increment
 counter-reset
@@ -176,7 +178,9 @@ font-variant-ligatures
 font-weight
 glyph-orientation-horizontal
 glyph-orientation-vertical
+grid
 grid-after
+grid-area
 grid-auto-columns
 grid-auto-flow
 grid-auto-rows
@@ -188,6 +192,7 @@ grid-row
 grid-rows
 grid-start
 grid-template
+grid-template-areas
 hanging-punctuation
 height
 highlight
@@ -207,8 +212,8 @@ image-resolution
 inline-box-align
 isolation
 justify-content
+justify-self
 kerning
-@keyframes
 left
 letter-spacing
 lighting-color
@@ -354,6 +359,7 @@ ruby-align
 ruby-overhang
 ruby-position
 ruby-span
+scroll-behavior
 shape-image-threshold
 shape-inside
 shape-margin
@@ -375,8 +381,8 @@ stroke-miterlimit
 stroke-opacity
 stroke-width
 svg-shadow
-table-layout
 tab-size
+table-layout
 tap-highlight-color
 target
 target-name
@@ -389,8 +395,8 @@ text-combine
 text-decoration
 text-decoration-color
 text-decoration-line
-text-decorations-in-effect
 text-decoration-style
+text-decorations-in-effect
 text-emphasis
 text-emphasis-color
 text-emphasis-position
@@ -425,6 +431,7 @@ text-underline-width
 text-wrap
 top
 touch-action
+touch-action-delay
 transform
 transform-origin
 transform-origin-x
@@ -455,6 +462,7 @@ voice-volume
 white-space
 widows
 width
+will-change
 word-break
 word-spacing
 word-wrap

data/lib/scss_lint/cli.rb

@@ -99,7 +99,7 @@ module SCSSLint
       runner.run(files_to_lint)
       report_lints(runner.lints)
 
-      if runner.lints.any? { |lint| lint.error? }
+      if runner.lints.any?(&:error?)
         halt :error
       elsif runner.lints.any?
         halt :warning

data/lib/scss_lint/config.rb

@@ -36,7 +36,7 @@ module SCSSLint
         @dir_to_config ||= {}
         @dir_to_config[directory] ||=
           begin
-            config_file = possible_config_files(directory).find { |path| path.file? }
+            config_file = possible_config_files(directory).find(&:file?)
             Config.load(config_file.to_s) if config_file
           end
       end

data/lib/scss_lint/linter/declaration_order.rb

@@ -11,7 +11,7 @@ module SCSSLint
 
     def visit_rule(node)
       children = node.children.select { |n| important_node?(n) }
-                              .map { |n| n.class }
+                              .map(&:class)
 
       sorted_children = children.sort do |a, b|
         DECLARATION_ORDER.index(a) <=> DECLARATION_ORDER.index(b)

data/lib/scss_lint/linter/empty_line_between_blocks.rb

@@ -36,8 +36,17 @@ module SCSSLint
     end
 
     def check_following_node(node, type)
-      return unless (following_node = next_node(node)) && (next_start_line = following_node.line)
-      return if engine.lines[next_start_line - 2].strip.empty?
+      return unless (following_node = next_node(node)) &&
+                    (next_start_line = following_node.line)
+
+      # Special case: ignore comments immediately after a closing brace
+      line = engine.lines[next_start_line - 1].strip
+      return if following_node.is_a?(Sass::Tree::CommentNode) &&
+                line =~ %r{\s*\}\s*/(/|\*)}
+
+      # Otherwise check if line before the next node's starting line is blank
+      line = engine.lines[next_start_line - 2].strip
+      return if line.empty?
 
       add_lint(next_start_line - 1, MESSAGE_FORMAT % [type, 'followed'])
     end

data/lib/scss_lint/linter/id_with_extraneous_selector.rb

@@ -13,8 +13,6 @@ module SCSSLint
       end
       return unless can_be_simplified
 
-      # TODO: Sass::Selector::SimpleSequence#source_range sometimes lies about
-      # its line, so reference `#line` directly
       add_lint(seq.line, "Selector `#{seq}` can be simplified to `#{id_sel}`, " \
                          'since IDs should be uniquely identifying')
     end

data/lib/scss_lint/linter/leading_zero.rb

@@ -14,10 +14,8 @@ module SCSSLint
     end
 
     def visit_script_number(node)
-      # TODO: Remove once https://github.com/sass/sass/issues/1343 is fixed
-      return unless source = source_from_range(node.source_range)
-
-      return unless number = source[FRACTIONAL_DIGIT_REGEX, 1]
+      return unless number =
+        source_from_range(node.source_range)[FRACTIONAL_DIGIT_REGEX, 1]
 
       check_number(node, number)
     end

data/lib/scss_lint/linter/property_sort_order.rb

@@ -33,8 +33,9 @@ module SCSSLint
       yield # Continue linting children
     end
 
-    alias_method :visit_rule,  :check_sort_order
+    alias_method :visit_media, :check_sort_order
     alias_method :visit_mixin, :check_sort_order
+    alias_method :visit_rule,  :check_sort_order
 
     def visit_if(node, &block)
       check_sort_order(node, &block)

data/lib/scss_lint/linter/selector_format.rb

@@ -0,0 +1,79 @@
+module SCSSLint
+  # Checks that selector names use a specified convention
+  class Linter::SelectorFormat < Linter
+    include LinterRegistry
+
+    def visit_root(_node)
+      @ignored_names = Array(config['ignored_names']).to_set
+      @ignored_types = Array(config['ignored_types']).to_set
+      yield
+    end
+
+    def visit_attribute(attribute)
+      check(attribute) unless @ignored_types.include?('attribute')
+    end
+
+    def visit_class(klass)
+      check(klass) unless @ignored_types.include?('class')
+    end
+
+    def visit_element(element)
+      check(element) unless @ignored_types.include?('element')
+    end
+
+    def visit_id(id)
+      check(id) unless @ignored_types.include?('id')
+    end
+
+    def visit_placeholder(placeholder)
+      check(placeholder) unless @ignored_types.include?('placeholder')
+    end
+
+    def visit_pseudo(pseudo)
+      check(pseudo) unless @ignored_types.include?('pseudo-selector')
+    end
+
+  private
+
+    def check(node)
+      name = node.name
+
+      return if @ignored_names.include?(name)
+      return unless violation = violated_convention(name)
+
+      add_lint(node, "Selector `#{name}` should be " \
+                     "written #{violation[:explanation]}")
+    end
+
+    CONVENTIONS = {
+      'hyphenated_lowercase' => {
+        explanation: 'in lowercase with hyphens',
+        validator: ->(name) { name !~ /[^\-a-z0-9]/ },
+      },
+      'snake_case' => {
+        explanation: 'in lowercase with underscores',
+        validator: ->(name) { name !~ /[^_a-z0-9]/ },
+      },
+      'camel_case' => {
+        explanation: 'has no spaces with capitalized words except first',
+        validator: ->(name) { name =~ /^[a-z][a-zA-Z0-9]*$/ },
+      },
+      'BEM' => {
+        explanation: 'in BEM (Block Element Modifier) format',
+        validator: ->(name) { name !~ /[A-Z]|-{3}|_{3}|[^_]_[^_]/ },
+      },
+    }
+
+    # Checks the given name and returns the violated convention if it failed.
+    def violated_convention(name_string)
+      convention_name = config['convention'] || 'hyphenated_lowercase'
+
+      convention = CONVENTIONS[convention_name] || {
+        explanation: "must match regex /#{convention_name}/",
+        validator: ->(name) { name =~ /#{convention_name}/ }
+      }
+
+      convention unless convention[:validator].call(name_string)
+    end
+  end
+end

data/lib/scss_lint/linter/trailing_semicolon.rb

@@ -38,6 +38,9 @@ module SCSSLint
         add_lint line,
                  'Declaration should not have a space before ' \
                  'the terminating semicolon'
+      elsif ends_with_multiple_semicolons?(node)
+        line = node.source_range.start_pos.line
+        add_lint line, 'Declaration should be terminated by a single semicolon'
       end
     end
 
@@ -46,6 +49,11 @@ module SCSSLint
       source_from_range(node.source_range) =~ /;$/
     end
 
+    def ends_with_multiple_semicolons?(node)
+      # Look one character past the end to see if there's another semicolon
+      character_at(node.source_range.end_pos, 1) == ';'
+    end
+
     def has_space_before_semicolon?(node)
       source_from_range(node.source_range) =~ /\s;$/
     end

data/lib/scss_lint/linter/trailing_zero.rb

@@ -0,0 +1,41 @@
+module SCSSLint
+  # Checks for unnecessary leading zeros in numeric values with decimal points.
+  class Linter::TrailingZero < Linter
+    include LinterRegistry
+
+    def visit_script_string(node)
+      return unless node.type == :identifier
+
+      non_string_values = remove_quoted_strings(node.value).split
+      non_string_values.each do |value|
+        next unless number = value[FRACTIONAL_DIGIT_REGEX, 1]
+        check_number(node, number)
+      end
+    end
+
+    def visit_script_number(node)
+      return unless number =
+        source_from_range(node.source_range)[FRACTIONAL_DIGIT_REGEX, 1]
+
+      check_number(node, number)
+    end
+
+  private
+
+    FRACTIONAL_DIGIT_REGEX = /^-?(\d*\.\d+)/
+
+    def check_number(node, original_number)
+      return unless match = /^(\d*\.\d*)0+$/.match(original_number)
+
+      fixed_number = match[1]
+
+      # Handle special case of 0 being the only trailing digit
+      fixed_number = fixed_number[0..-2] if fixed_number.end_with?('.')
+      fixed_number = 0 if fixed_number.empty? # Handle ".0" -> "0"
+
+      add_lint(node,
+               "`#{original_number}` should be written without a trailing " \
+               "zero as `#{fixed_number}`")
+    end
+  end
+end

data/lib/scss_lint/linter/unnecessary_parent_reference.rb

@@ -12,6 +12,12 @@ module SCSSLint
     def visit_sequence(sequence)
       return unless sequence_starts_with_parent?(sequence.members.first)
 
+      # Allow concatentation, e.g.
+      # element {
+      #   &.foo {}
+      # }
+      return if sequence.members.first.members.size > 1
+
       # Allow sequences that contain multiple parent references, e.g.
       # element {
       #   & + & { ... }
@@ -36,8 +42,7 @@ module SCSSLint
     def sequence_starts_with_parent?(simple_sequence)
       return unless simple_sequence.is_a?(Sass::Selector::SimpleSequence)
       first = simple_sequence.members.first
-      simple_sequence.members.size == 1 &&
-        first.is_a?(Sass::Selector::Parent) &&
+      first.is_a?(Sass::Selector::Parent) &&
         first.suffix.nil? # Ignore concatenated selectors, like `&-something`
     end
   end

data/lib/scss_lint/linter/url_quotes.rb

@@ -19,6 +19,8 @@ module SCSSLint
 
     def check(node, string)
       return unless string =~ /^\s*url\(\s*[^"']/
+      return if string =~ /^\s*url\(\s*data:/ # Ignore data URIs
+
       add_lint(node, 'URLs should be enclosed in quotes')
     end
   end

data/lib/scss_lint/reporter/json_reporter.rb

@@ -0,0 +1,23 @@
+require 'json'
+
+module SCSSLint
+  # Reports lints in a JSON format.
+  class Reporter::JSONReporter < Reporter
+    def report_lints
+      output = {}
+      lints.group_by(&:filename).each do |filename, file_lints|
+        output[filename] = file_lints.map do |lint|
+          issue = {}
+          issue['linter'] = lint.linter.name if lint.linter
+          issue['line'] = lint.location.line
+          issue['column'] = lint.location.column
+          issue['length'] = lint.location.length
+          issue['severity'] = lint.severity
+          issue['reason'] = lint.description
+          issue
+        end
+      end
+      JSON.pretty_generate(output)
+    end
+  end
+end

data/lib/scss_lint/sass/script.rb

@@ -15,7 +15,7 @@ module Sass::Script
   {
     'Value' => %w[ArgList Bool Color List Map Null Number String],
     'Tree'  => %w[Funcall Interpolation ListLiteral Literal MapLiteral
-                  Operation StringInterpolation UnaryOperation Variable],
+                  Operation Selector StringInterpolation UnaryOperation Variable],
   }.each do |namespace, types|
     types.each do |type|
       node_name = type.downcase

data/lib/scss_lint/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.28.0'
+  VERSION = '0.29.0'
 end

data/spec/scss_lint/linter/empty_line_between_blocks_spec.rb

@@ -204,6 +204,18 @@ describe SCSSLint::Linter::EmptyLineBetweenBlocks do
     it { should_not report_lint }
   end
 
+  context 'when a rule set is immediately followed by a comment' do
+    let(:css) { <<-CSS }
+      a {
+      } // A comment
+
+      a {
+      } /* Another comment */
+    CSS
+
+    it { should_not report_lint }
+  end
+
   context 'when there are multiple placeholder rule sets' do
     context 'with blank lines between them' do
       let(:css) { <<-CSS }

data/spec/scss_lint/linter/property_sort_order_spec.rb

@@ -185,6 +185,17 @@ describe SCSSLint::Linter::PropertySortOrder do
     it { should report_lint line: 3 }
   end
 
+  context 'when @media block contains properties not in sorted order' do
+    let(:css) { <<-CSS }
+      @media screen and (min-width: 500px) {
+        margin: 5px;
+        display: none;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
   context 'when if block contains properties in sorted order' do
     let(:css) { <<-CSS }
       @if $var {

data/spec/scss_lint/linter/selector_format_spec.rb

@@ -0,0 +1,272 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SelectorFormat do
+  context 'when class has alphanumeric chars and is separated by hyphens' do
+    let(:css) { <<-CSS }
+      .foo-bar-77 {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when id has alphanumeric chars and is separated by hyphens' do
+    let(:css) { <<-CSS }
+      #foo-bar-77 {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when element has alphanumeric chars and is separated by hyphens' do
+    let(:css) { <<-CSS }
+      foo-bar-77 {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when placeholder has alphanumeric chars and is separated by hyphens' do
+    let(:css) { <<-CSS }
+      %foo-bar-77 {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when pseudo-selector has alphanumeric chars and is separated by hyphens' do
+    let(:css) { <<-CSS }
+      [foo-bar-77=text] {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when selector has alphanumeric chars and is separated by underscores' do
+    let(:css) { <<-CSS }
+      .foo_bar {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when selector has is in camelCase' do
+    let(:css) { <<-CSS }
+      fooBar77 {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when placeholder has alphanumeric chars and is separated by underscores' do
+    let(:css) { <<-CSS }
+      %foo_bar {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'psuedo-selector has alphanumeric chars and is separated by underscores' do
+    let(:css) { <<-CSS }
+      :foo_bar {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when attribute has alphanumeric chars and is separated by underscores' do
+    let(:css) { <<-CSS }
+      [data_text] {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when attribute selector has alphanumeric chars and is separated by underscores' do
+    let(:css) { <<-CSS }
+      [data-text=some_text] {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when convention is set to snake_case' do
+    let(:linter_config) { { 'convention' => 'snake_case' } }
+
+    context 'when selector has alphanumeric chars and is separated by underscores' do
+      let(:css) { <<-CSS }
+        .foo_bar_77 {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when selector has alphanumeric chars and is separated by hyphens' do
+      let(:css) { <<-CSS }
+        .foo-bar-77 {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when selector has is in camelCase' do
+      let(:css) { <<-CSS }
+        .fooBar77 {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when convention is set to camel_case' do
+    let(:linter_config) { { 'convention' => 'camel_case' } }
+
+    context 'when selector has is in camelCase' do
+      let(:css) { <<-CSS }
+        .fooBar77 {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when selector capitalizes first word' do
+      let(:css) { <<-CSS }
+        .FooBar77 {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when selector has alphanumeric chars and is separated by underscores' do
+      let(:css) { <<-CSS }
+        .foo_bar_77 {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when selector has alphanumeric chars and is separated by hyphens' do
+      let(:css) { <<-CSS }
+        .foo-bar-77 {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when convention is set to use a regex' do
+    let(:linter_config) { { 'convention' => /^[0-9]*$/ } }
+
+    context 'when selector uses regex properly' do
+      let(:css) { <<-CSS }
+        .1337 {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when selector does not use regex properly' do
+      let(:css) { <<-CSS }
+        .leet {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when ignored names are set' do
+    let(:linter_config) { { 'ignored_names' => ['fooBar'] } }
+
+    context 'it ignores exact string matches' do
+      let(:css) { <<-CSS }
+        fooBar {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when ignored types is set to class' do
+    let(:linter_config) { { 'ignored_types' => ['class'] } }
+
+    context 'it ignores all invalid classes' do
+      let(:css) { <<-CSS }
+        .fooBar {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when ignored types is set to id, element, placeholder, pseudo-selector' do
+    let(:linter_config) do
+      { 'ignored_types' => %w[id attribute element placeholder pseudo-selector] }
+    end
+
+    context 'it ignores all invalid ids' do
+      let(:css) { <<-CSS }
+        #fooBar {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'it ignores all invalid elements' do
+      let(:css) { <<-CSS }
+        fooBar {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'it ignores all invalid placeholders' do
+      let(:css) { <<-CSS }
+        %fooBar {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'it ignores all invalid attributes' do
+      let(:css) { <<-CSS }
+        [fooBar=fooBar] {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'it ignores all invalid pseudo-selectors' do
+      let(:css) { <<-CSS }
+        :fooBar {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -225,4 +225,14 @@ describe SCSSLint::Linter::TrailingSemicolon do
 
     it { should_not report_lint }
   end
+
+  context 'when variable declaration ends with multiple semicolons' do
+    let(:css) { <<-CSS }
+      .foo {
+        $bar: 1;;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
 end

data/spec/scss_lint/linter/trailing_zero_spec.rb

@@ -0,0 +1,176 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::TrailingZero do
+  context 'when no values exist' do
+    let(:css) { 'p {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when a zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an integer value exists' do
+    let(:css) { <<-CSS }
+      p {
+        line-height: 2;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an integer value with units exists' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 5px;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a unitless fractional value with no trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        line-height: .5;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a negative unitless fractional value with no trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        line-height: -.5;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a fractional value with units and no trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        margin: .5em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a negative fractional value with units and no trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        margin: -.5em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a fractional value with a trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        line-height: .50;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a fractional value with units and a trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        margin: .50em;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a negative fractional value with units and a trailing zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        margin: -.50em;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a fractional value with a mantissa ending in zero exists' do
+    let(:css) { <<-CSS }
+      p {
+        line-height: 10.5;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when multiple fractional values with trailing zeros exist' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0.50em .50 0.10px .90pt;
+      }
+    CSS
+
+    it { should report_lint count: 4, line: 2 }
+  end
+
+  context 'when trailing zeros appear in function arguments' do
+    let(:css) { <<-CSS }
+      p {
+        margin: some-function(.50em, 0.40 0.30 .2);
+      }
+    CSS
+
+    it { should report_lint count: 3, line: 2 }
+  end
+
+  context 'when trailing zeros appear in mixin arguments' do
+    let(:css) { <<-CSS }
+      p {
+        @include some-mixin(0.50em, 0.40 0.30 .2);
+      }
+    CSS
+
+    it { should report_lint count: 3, line: 2 }
+  end
+
+  context 'when trailiing zeros appear in variable declarations' do
+    let(:css) { '$some-var: .50em;' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when trailing zeros appear in named arguments' do
+    let(:css) { <<-CSS }
+      p {
+        @include line-clamp($line-height: .90, $line-count: 2);
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when trailing zeros appear in parameter defaults' do
+    let(:css) { <<-CSS }
+      @mixin my-mixin($bad-value: .50, $good-value: .9, $string-value: ".90") {
+        margin: $some-value;
+        padding: $some-other-value;
+      }
+    CSS
+
+    it { should report_lint count: 1, line: 1 }
+  end
+end

data/spec/scss_lint/linter/unnecessary_parent_reference_spec.rb

@@ -52,6 +52,16 @@ describe SCSSLint::Linter::UnnecessaryParentReference do
     it { should_not report_lint }
   end
 
+  context 'when multiple ampersands exist with one concatenated' do
+    let(:css) { <<-CSS }
+      p {
+        & + &:hover {}
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
   context 'when an amperand is used in a comma sequence to DRY up code' do
     let(:css) { <<-CSS }
       p {

data/spec/scss_lint/linter/url_quotes_spec.rb

@@ -60,4 +60,14 @@ describe SCSSLint::Linter::UrlQuotes do
 
     it { should_not report_lint }
   end
+
+  context 'when property has a data URI' do
+    let(:css) { <<-CSS }
+      .tracking-pixel {
+        background: url(data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==);
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/reporter/json_reporter_spec.rb

@@ -0,0 +1,96 @@
+require 'spec_helper'
+
+describe SCSSLint::Reporter::JSONReporter do
+  subject { SCSSLint::Reporter::JSONReporter.new(lints) }
+
+  describe '#report_lints' do
+    let(:json) { JSON.parse(subject.report_lints) }
+
+    shared_examples_for 'parsed JSON' do
+      it 'is a Hash' do
+        json.is_a?(Hash)
+      end
+    end
+
+    context 'when there are no lints' do
+      let(:lints) { [] }
+
+      it_should_behave_like 'parsed JSON'
+    end
+
+    context 'when there are lints' do
+      let(:filenames)    { ['f1.scss', 'f2.scss', 'f1.scss'] }
+      # Include invalid XML characters in the third description to validate
+      # that escaping happens for preventing broken XML output
+      let(:descriptions) { ['lint 1', 'lint 2', 'lint 3 " \' < & >'] }
+      let(:severities)   { [:warning] * 3 }
+
+      let(:locations)    do
+        [
+          SCSSLint::Location.new(5,  2, 3),
+          SCSSLint::Location.new(7,  6, 2),
+          SCSSLint::Location.new(9, 10, 1)
+        ]
+      end
+
+      let(:lints) do
+        filenames.each_with_index.map do |filename, index|
+          SCSSLint::Lint.new(nil, filename, locations[index],
+                             descriptions[index], severities[index])
+        end
+      end
+
+      it_should_behave_like 'parsed JSON'
+
+      it 'contains an <issue> node for each lint' do
+        json.values.inject(0) { |sum, issues| sum + issues.size }.should == 3
+      end
+
+      it 'contains a group of issues for each file' do
+        json.keys.should == filenames.uniq
+      end
+
+      it 'contains <issue> nodes grouped by <file>' do
+        json.values.map(&:size).should == [2, 1]
+      end
+
+      it 'marks each issue with a line number' do
+        json.values.flat_map { |issues| issues.map { |issue| issue['line'] } }
+          .should =~ locations.map(&:line)
+      end
+
+      it 'marks each issue with a column number' do
+        json.values.flat_map { |issues| issues.map { |issue| issue['column'] } }
+          .should =~ locations.map(&:column)
+      end
+
+      it 'marks each issue with a length' do
+        json.values.flat_map { |issues| issues.map { |issue| issue['length'] } }
+          .should =~ locations.map(&:length)
+      end
+
+      it 'marks each issue with a reason containing the lint description' do
+        json.values.flat_map { |issues| issues.map { |issue| issue['reason'] } }
+          .should =~ descriptions
+      end
+
+      context 'when lints are warnings' do
+        it 'marks each issue with a severity of "warning"' do
+          json.values.inject(0) do |sum, issues|
+            sum + issues.select { |i| i['severity'] == 'warning' }.size
+          end.should == 3
+        end
+      end
+
+      context 'when lints are errors' do
+        let(:severities) { [:error] * 3 }
+
+        it 'marks each issue with a severity of "error"' do
+          json.values.inject(0) do |sum, issues|
+            sum + issues.select { |i| i['severity'] == 'error' }.size
+          end.should == 3
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors:
 - Causes Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-04 00:00:00.000000000 Z
+date: 2014-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.25.0
+        version: 0.26.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.25.0
+        version: 0.26.0
 description: Configurable tool for writing clean and consistent SCSS
 email:
 - eng@causes.com
@@ -100,6 +100,7 @@ files:
 - lib/scss_lint/reporter/files_reporter.rb
 - lib/scss_lint/reporter/xml_reporter.rb
 - lib/scss_lint/reporter/default_reporter.rb
+- lib/scss_lint/reporter/json_reporter.rb
 - lib/scss_lint/reporter/config_reporter.rb
 - lib/scss_lint/runner.rb
 - lib/scss_lint/reporter.rb
@@ -113,8 +114,8 @@ files:
 - lib/scss_lint/config.rb
 - lib/scss_lint/linter/compass.rb
 - lib/scss_lint/linter/space_after_comma.rb
+- lib/scss_lint/linter/trailing_zero.rb
 - lib/scss_lint/linter/space_before_brace.rb
-- lib/scss_lint/linter/capitalization_in_selector.rb
 - lib/scss_lint/linter/hex_length.rb
 - lib/scss_lint/linter/indentation.rb
 - lib/scss_lint/linter/mergeable_selector.rb
@@ -128,6 +129,7 @@ files:
 - lib/scss_lint/linter/placeholder_in_extend.rb
 - lib/scss_lint/linter/selector_depth.rb
 - lib/scss_lint/linter/else_placement.rb
+- lib/scss_lint/linter/selector_format.rb
 - lib/scss_lint/linter/hex_validation.rb
 - lib/scss_lint/linter/compass/property_with_mixin.rb
 - lib/scss_lint/linter/space_after_property_name.rb
@@ -157,6 +159,7 @@ files:
 - lib/scss_lint.rb
 - spec/scss_lint/location_spec.rb
 - spec/scss_lint/reporter/files_reporter_spec.rb
+- spec/scss_lint/reporter/json_reporter_spec.rb
 - spec/scss_lint/reporter/xml_reporter_spec.rb
 - spec/scss_lint/reporter/config_reporter_spec.rb
 - spec/scss_lint/reporter/default_reporter_spec.rb
@@ -175,6 +178,7 @@ files:
 - spec/scss_lint/linter/hex_length_spec.rb
 - spec/scss_lint/linter/url_quotes_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
+- spec/scss_lint/linter/selector_format_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
 - spec/scss_lint/linter/property_spelling_spec.rb
 - spec/scss_lint/linter/property_sort_order_spec.rb
@@ -183,7 +187,6 @@ files:
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
 - spec/scss_lint/linter/name_format_spec.rb
-- spec/scss_lint/linter/capitalization_in_selector_spec.rb
 - spec/scss_lint/linter/duplicate_property_spec.rb
 - spec/scss_lint/linter/hex_validation_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
@@ -198,6 +201,7 @@ files:
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/declaration_order_spec.rb
 - spec/scss_lint/linter/leading_zero_spec.rb
+- spec/scss_lint/linter/trailing_zero_spec.rb
 - spec/scss_lint/linter/url_format_spec.rb
 - spec/scss_lint/linter/comment_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb
@@ -237,6 +241,7 @@ summary: SCSS lint tool
 test_files:
 - spec/scss_lint/location_spec.rb
 - spec/scss_lint/reporter/files_reporter_spec.rb
+- spec/scss_lint/reporter/json_reporter_spec.rb
 - spec/scss_lint/reporter/xml_reporter_spec.rb
 - spec/scss_lint/reporter/config_reporter_spec.rb
 - spec/scss_lint/reporter/default_reporter_spec.rb
@@ -255,6 +260,7 @@ test_files:
 - spec/scss_lint/linter/hex_length_spec.rb
 - spec/scss_lint/linter/url_quotes_spec.rb
 - spec/scss_lint/linter/space_between_parens_spec.rb
+- spec/scss_lint/linter/selector_format_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
 - spec/scss_lint/linter/property_spelling_spec.rb
 - spec/scss_lint/linter/property_sort_order_spec.rb
@@ -263,7 +269,6 @@ test_files:
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/unnecessary_mantissa_spec.rb
 - spec/scss_lint/linter/name_format_spec.rb
-- spec/scss_lint/linter/capitalization_in_selector_spec.rb
 - spec/scss_lint/linter/duplicate_property_spec.rb
 - spec/scss_lint/linter/hex_validation_spec.rb
 - spec/scss_lint/linter/space_before_brace_spec.rb
@@ -278,6 +283,7 @@ test_files:
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/declaration_order_spec.rb
 - spec/scss_lint/linter/leading_zero_spec.rb
+- spec/scss_lint/linter/trailing_zero_spec.rb
 - spec/scss_lint/linter/url_format_spec.rb
 - spec/scss_lint/linter/comment_spec.rb
 - spec/scss_lint/linter/trailing_semicolon_spec.rb

data/lib/scss_lint/linter/capitalization_in_selector.rb

@@ -1,49 +0,0 @@
-module SCSSLint
-  # Checks for capitalized letters in IDs, classes, types, etc. in selectors.
-  class Linter::CapitalizationInSelector < Linter
-    include LinterRegistry
-
-    def visit_root(_node)
-      @ignored_names = Array(config['ignored_names']).to_set
-      @ignored_types = Array(config['ignored_types']).to_set
-      yield
-    end
-
-    def visit_attribute(attribute)
-      check(attribute) unless @ignored_types.include?('attribute')
-    end
-
-    def visit_class(klass)
-      check(klass) unless @ignored_types.include?('class')
-    end
-
-    def visit_element(element)
-      check(element) unless @ignored_types.include?('element')
-    end
-
-    def visit_id(id)
-      check(id) unless @ignored_types.include?('id')
-    end
-
-    def visit_placeholder(placeholder)
-      check(placeholder) unless @ignored_types.include?('placeholder')
-    end
-
-    def visit_pseudo(pseudo)
-      check(pseudo, 'Pseudo-selector') unless @ignored_types.include?('pseudo-selector')
-    end
-
-  private
-
-    def check(node, selector_name = nil)
-      name = node.name
-
-      return if @ignored_names.include?(name)
-      return unless name =~ /[A-Z]/
-
-      selector_name ||= node.class.name.split('::').last
-      add_lint(node, "#{selector_name} `#{name}` in selector should be " \
-                     "written in all lowercase as `#{name.downcase}`")
-    end
-  end
-end

data/spec/scss_lint/linter/capitalization_in_selector_spec.rb

@@ -1,71 +0,0 @@
-require 'spec_helper'
-
-describe SCSSLint::Linter::CapitalizationInSelector do
-  context 'when selector is all lowercase' do
-    let(:css) { <<-CSS }
-      span {
-      }
-    CSS
-
-    it { should_not report_lint }
-  end
-
-  context 'when selector is lowercase with non-alphabetic characters' do
-    let(:css) { <<-CSS }
-      .foo-bar {
-      }
-    CSS
-
-    it { should_not report_lint }
-  end
-
-  context 'when selector is camelCase' do
-    let(:css) { <<-CSS }
-      .fooBar {
-      }
-    CSS
-
-    it { should report_lint line: 1 }
-  end
-
-  context 'when selector is UPPER CASE' do
-    let(:css) { <<-CSS }
-      SPAN {
-      }
-    CSS
-
-    it { should report_lint line: 1 }
-  end
-
-  context 'when attribute selector has attribute containing uppercase letters' do
-    let(:css) { <<-CSS }
-      [dataText] {
-      }
-    CSS
-
-    it { should report_lint line: 1 }
-  end
-
-  context 'when attribute selector has value containing uppercase letters' do
-    let(:css) { <<-CSS }
-      [data-text=someText] {
-      }
-    CSS
-
-    it { should_not report_lint }
-  end
-
-  context 'when a selector name is whitelisted' do
-    let(:linter_config) { { 'ignored_names' => %w[Foo] } }
-    let(:css) { '.Foo {}' }
-
-    it { should_not report_lint }
-  end
-
-  context 'when a certain type of selector is ignored' do
-    let(:linter_config) { { 'ignored_types' => %w[class] } }
-    let(:css) { '.Foo {}' }
-
-    it { should_not report_lint }
-  end
-end