scss-lint 0.23.0 → 0.23.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bbc506b11e888967c3a60b4ee497049899db21d
-  data.tar.gz: 3474861bb7c69bc96acfc51a6c4c78ac75372bb3
+  metadata.gz: 2d1a01eec7c1dd954e81749c6a668a660013b228
+  data.tar.gz: 05988d04580327776387a94171c4297f6a7493d1
 SHA512:
-  metadata.gz: abdcc9357f0db63b291114acf5748ea2df1ca077fca03033b8b71ac4faae48d26424d00ea23c846854f9da47a6c67baf5187cb34932182ced1f987932cc58970
-  data.tar.gz: 673461370cc8c5598b25bea6b2a06e8e61cb3b53389a7a729cebf6eb79b836b36d4e4c3d211a5aebf6826423b0536f27575042b1ee450712acc5f837b0031941
+  metadata.gz: f82ac7a86ac50b2f172f0bb08879ec3fef8fc20f6fbdbf35816ea6cab6feae0963062da65ae550a86bf7106d3e44e755c3d510baf81a2ed43f779b3248d0ba2e
+  data.tar.gz: a47bd582bb1208992367eb5f7f3f61fde36a9d308f8be3745532333a08c70d0e04f90a14adb00e71e409ee3ea6547b46bb1d9d27909e345fe332f3082fe67474

data/lib/scss_lint/cli.rb

@@ -45,7 +45,7 @@ module SCSSLint
     end
 
     # @return [OptionParser]
-    def options_parser
+    def options_parser # rubocop:disable MethodLength
       @options_parser ||= OptionParser.new do |opts|
         opts.banner = "Usage: #{opts.program_name} [options] [scss-files]"
 
@@ -62,7 +62,7 @@ module SCSSLint
         end
 
         opts.on('-f', '--format Formatter', 'Specify how to display lints', String) do |format|
-          set_output_format(format)
+          define_output_format(format)
         end
 
         opts.on('-i', '--include-linter linter,...', Array,
@@ -189,7 +189,7 @@ module SCSSLint
     end
 
     # @param format [String]
-    def set_output_format(format)
+    def define_output_format(format)
       @options[:reporter] = SCSSLint::Reporter.const_get(format + 'Reporter')
     rescue NameError
       puts "Invalid output format specified: #{format}"

data/lib/scss_lint/linter.rb

@@ -44,7 +44,7 @@ module SCSSLint
       length = if range.start_pos.line == range.end_pos.line
                  range.end_pos.offset - range.start_pos.offset
                else
-                 line_source = engine.lines[range.start_pos.line]
+                 line_source = engine.lines[range.start_pos.line - 1]
                  line_source.length - range.start_pos.offset + 1
                end
 

data/lib/scss_lint/linter/duplicate_root.rb

@@ -23,6 +23,7 @@ module SCSSLint
 
     # Define stubs so we don't check rules nested in other constructs
     %w[
+      directive
       media
       mixin
       mixindef

data/lib/scss_lint/linter/id_with_extraneous_selector.rb

@@ -15,7 +15,7 @@ module SCSSLint
       if can_be_simplified
         # TODO: Sass::Selector::SimpleSequence#source_range sometimes lies about
         # its line, so reference `#line` directly
-        add_lint(seq.line, "Selector `#{seq}` can be simplified to `#{id_sel}`, " <<
+        add_lint(seq.line, "Selector `#{seq}` can be simplified to `#{id_sel}`, " \
                            'since IDs should be uniquely identifying')
       end
     end

data/lib/scss_lint/linter/single_line_per_selector.rb

@@ -21,8 +21,7 @@ module SCSSLint
     # Sass::Script::Nodes, we need to condense it into a single string that we
     # can run a regex against.
     def condense_to_string(sequence_list)
-      sequence_list.select { |item| item.is_a?(String) }
-                   .inject('') { |combined, item| combined + item }
+      sequence_list.select { |item| item.is_a?(String) }.inject(:+)
     end
 
     # Removes extra spacing between lines in a comma-separated sequence due to

data/lib/scss_lint/linter/space_between_parens.rb

@@ -27,8 +27,8 @@ module SCSSLint
 
       if spaces != @spaces
         location = Location.new(index + 1)
-        message = "Expected #{pluralize(@spaces, 'space')}" <<
-                  " between parentheses instead of #{spaces}"
+        message = "Expected #{pluralize(@spaces, 'space')} " \
+                  "between parentheses instead of #{spaces}"
         @lints << Lint.new(engine.filename, location, message)
       end
     end

data/lib/scss_lint/reporter/xml_reporter.rb

@@ -6,14 +6,14 @@ module SCSSLint
 
       output << '<lint>'
       lints.group_by(&:filename).each do |filename, file_lints|
-        output << "<file name=#{filename.encode(:xml => :attr)}>"
+        output << "<file name=#{filename.encode(xml: :attr)}>"
 
         file_lints.each do |lint|
           output << "<issue line=\"#{lint.location.line}\" " <<
                            "column=\"#{lint.location.column}\" " <<
                            "length=\"#{lint.location.length}\" " <<
                            "severity=\"#{lint.severity}\" " <<
-                           "reason=#{lint.description.encode(:xml => :attr)} />"
+                           "reason=#{lint.description.encode(xml: :attr)} />"
         end
 
         output << '</file>'

data/lib/scss_lint/sass/tree.rb

@@ -67,7 +67,7 @@ module Sass::Tree
     def children
       begin
         additional_children = extract_script_nodes(value)
-      rescue NotImplementedError
+      rescue NotImplementedError # rubocop:disable HandleExceptions
         # Directive nodes may not define `value`
       end
       concat_expr_lists super, additional_children

data/lib/scss_lint/selector_visitor.rb

@@ -23,10 +23,10 @@ module SCSSLint
     def selector_node_name(node)
       # Converts the class name of a node into snake_case form, e.g.
       # `Sass::Selector::SimpleSequence` -> `simple_sequence`
-      node.class.name.gsub(/.*::(.*?)$/, '\\1').
-                      gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
-                      gsub(/([a-z\d])([A-Z])/, '\1_\2').
-                      downcase
+      node.class.name.gsub(/.*::(.*?)$/, '\\1')
+                      .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+                      .gsub(/([a-z\d])([A-Z])/, '\1_\2')
+                      .downcase
     end
   end
 end

data/lib/scss_lint/utils.rb

@@ -15,9 +15,9 @@ module SCSSLint
     # This is useful for lints that wish to ignore interpolation, since
     # interpolation can't be resolved at this step.
     def extract_string_selectors(selector_array)
-      selector_array.reject { |item| item.is_a? Sass::Script::Node }.
-                     join.
-                     split
+      selector_array.reject { |item| item.is_a? Sass::Script::Node }
+                    .join
+                    .split
     end
 
     def shortest_hex_form(hex)

data/lib/scss_lint/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.23.0'
+  VERSION = '0.23.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.23.1
 platform: ruby
 authors:
 - Causes Engineering
@@ -67,6 +67,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Configurable tool for writing clean and consistent SCSS
 email:
 - eng@causes.com