scss-lint 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0c38097da925d1dcc77a8cc9c4d90468e598abb
-  data.tar.gz: e5e2f0352fc1e808b3ebe147c200c24727e425d0
+  metadata.gz: f1861dcef7f2f3be9166fd44664791979a1f1f7b
+  data.tar.gz: 032466f84b7ad63144ebf038d86e5b7b26455dd6
 SHA512:
-  metadata.gz: 0e65ae3133dbdefac6e650b8561db659671280f659d050d37c5dc0704b3b592ac1d7ab8303a936ccaf0aa6fab6a02c50a2e8be254039e5cfc2caa741890cf600
-  data.tar.gz: e7677e4fe7bbc9337884d8cc423105a08d77361d9d50369ae41c4677677cf8626e920e791592d715db56d763dca2d91292469453a61b4201dbe66c1e3be25419
+  metadata.gz: 522188c952f6be108b512e9b606472227e91ccaa9766c223116592d52ba18f30b91ba201cf657ba77da35575914bf16b47c25af1ddf154f72bbe6ff7b3427353
+  data.tar.gz: 4e13aa18990e381d7e8a7d5316975daac70dc2525d7ebdbe24d47bd64786a4f6a4d2151b1e84f2144492bb8a26850bd3318e45eeef4566d49301f0f313f12a73

data/config/default.yml

@@ -43,6 +43,9 @@ linters:
   PlaceholderInExtend:
     enabled: true
 
+  PropertySpelling:
+    enabled: true
+
   SelectorDepth:
     enabled: true
     max_depth: 3
@@ -68,6 +71,10 @@ linters:
   SpaceBeforeBrace:
     enabled: true
 
+  SpaceBetweenParens:
+    enabled: true
+    spaces: 0
+
   TrailingSemicolonAfterPropertyValue:
     enabled: true
 

data/lib/scss_lint/linter/duplicate_property.rb

@@ -13,10 +13,25 @@ module SCSSLint
       properties.each do |prop|
         name = prop.name.join
 
-        if existing_prop = prop_names[name]
+        prop_hash = name
+        prop_value =
+          case prop.value
+          when Sass::Script::Funcall
+            prop.value.name
+          when Sass::Script::String
+            prop.value.value
+          else
+            prop.value.to_s
+          end
+
+        prop_value.to_s.scan(/^(-[^-]+-.+)/) do |vendor_keyword|
+          prop_hash << vendor_keyword.first
+        end
+
+        if existing_prop = prop_names[prop_hash]
           add_lint(prop, "Property '#{name}' already defined on line #{existing_prop.line}")
         else
-          prop_names[name] = prop
+          prop_names[prop_hash] = prop
         end
       end
     end

data/lib/scss_lint/linter/id_with_extraneous_selector.rb

@@ -7,7 +7,7 @@ module SCSSLint
       id_sel = seq.members.find { |simple| simple.is_a?(Sass::Selector::Id) }
       return unless id_sel
 
-      if seq.members.any? { |simple| !simple.is_a?(Sass::Selector::Id) }
+      if seq.members.any? { |simple| !simple.is_a?(Sass::Selector::Id) && !simple.is_a?(Sass::Selector::Pseudo) }
         add_lint(seq, "Selector `#{seq}` can be simplified to `#{id_sel}`, " <<
                       'since IDs should be uniquely identifying')
       end

data/lib/scss_lint/linter/property_spelling.rb

@@ -0,0 +1,280 @@
+module SCSSLint
+  # Checks for misspelled properties.
+  class Linter::PropertySpelling < Linter
+    include LinterRegistry
+
+    def visit_prop(node)
+      # Ignore properties with interpolation
+      return if node.name.count > 1 || !node.name.first.is_a?(String)
+
+      name = node.name.join
+
+      # Ignore vendor-prefixed properties
+      return if name.start_with?('-')
+
+      unless KNOWN_PROPERTIES.include?(name)
+        add_lint(node, "Unknown property #{name}")
+      end
+    end
+
+  private
+
+    KNOWN_PROPERTIES = %w[
+      @keyframes
+      alignment-adjust
+      alignment-baseline
+      animation
+      animation-delay
+      animation-direction
+      animation-duration
+      animation-fill-mode
+      animation-iteration-count
+      animation-name
+      animation-play-state
+      animation-timing-function
+      appearance
+      backface-visibility
+      background
+      background-attachment
+      background-clip
+      background-color
+      background-image
+      background-origin
+      background-position
+      background-repeat
+      background-size
+      baseline-shift
+      bookmark-label
+      bookmark-level
+      bookmark-target
+      border
+      border-bottom
+      border-bottom-color
+      border-bottom-left-radius
+      border-bottom-right-radius
+      border-bottom-style
+      border-bottom-width
+      border-collapse
+      border-color
+      border-image
+      border-image-outset
+      border-image-repeat
+      border-image-slice
+      border-image-source
+      border-image-width
+      border-left
+      border-left-color
+      border-left-style
+      border-left-width
+      border-radius
+      border-right
+      border-right-color
+      border-right-style
+      border-right-width
+      border-spacing
+      border-style
+      border-top
+      border-top-color
+      border-top-left-radius
+      border-top-right-radius
+      border-top-style
+      border-top-width
+      border-width
+      bottom
+      box-align
+      box-decoration-break
+      box-direction
+      box-flex
+      box-flex-group
+      box-lines
+      box-ordinal-group
+      box-orient
+      box-pack
+      box-shadow
+      box-sizing
+      caption-side
+      clear
+      clip
+      color
+      color-profile
+      column-count
+      column-fill
+      column-gap
+      column-rule
+      column-rule-color
+      column-rule-style
+      column-rule-width
+      column-span
+      column-width
+      columns
+      content
+      counter-increment
+      counter-reset
+      crop
+      cursor
+      direction
+      display
+      dominant-baseline
+      drop-initial-after-adjust
+      drop-initial-after-align
+      drop-initial-before-adjust
+      drop-initial-before-align
+      drop-initial-size
+      drop-initial-value
+      empty-cells
+      fill
+      filter
+      fit
+      fit-position
+      float
+      float-offset
+      font
+      font-family
+      font-size
+      font-size-adjust
+      font-stretch
+      font-style
+      font-variant
+      font-weight
+      grid-columns
+      grid-rows
+      hanging-punctuation
+      height
+      hyphenate-after
+      hyphenate-before
+      hyphenate-character
+      hyphenate-lines
+      hyphenate-resource
+      hyphens
+      icon
+      image-orientation
+      image-resolution
+      inline-box-align
+      left
+      letter-spacing
+      line-height
+      line-stacking
+      line-stacking-ruby
+      line-stacking-shift
+      line-stacking-strategy
+      list-style
+      list-style-image
+      list-style-position
+      list-style-type
+      margin
+      margin-bottom
+      margin-left
+      margin-right
+      margin-top
+      mark
+      mark-after
+      mark-before
+      marks
+      marquee-direction
+      marquee-play-count
+      marquee-speed
+      marquee-style
+      max-height
+      max-width
+      min-height
+      min-width
+      move-to
+      nav-down
+      nav-index
+      nav-left
+      nav-right
+      nav-up
+      opacity
+      orphans
+      outline
+      outline-color
+      outline-offset
+      outline-style
+      outline-width
+      overflow
+      overflow-style
+      overflow-x
+      overflow-y
+      padding
+      padding-bottom
+      padding-left
+      padding-right
+      padding-top
+      page
+      page-break-after
+      page-break-before
+      page-break-inside
+      page-policy
+      perspective
+      perspective-origin
+      phonemes
+      pointer-events
+      position
+      punctuation-trim
+      quotes
+      rendering-intent
+      resize
+      rest
+      rest-after
+      rest-before
+      right
+      rotation
+      rotation-point
+      ruby-align
+      ruby-overhang
+      ruby-position
+      ruby-span
+      shape-rendering
+      size
+      speak
+      src
+      stroke
+      stroke-width
+      string-set
+      table-layout
+      target
+      target-name
+      target-new
+      target-position
+      text-align
+      text-align-last
+      text-decoration
+      text-height
+      text-indent
+      text-justify
+      text-outline
+      text-overflow
+      text-rendering
+      text-shadow
+      text-transform
+      text-wrap
+      top
+      transform
+      transform-origin
+      transform-style
+      transition
+      transition-delay
+      transition-duration
+      transition-property
+      transition-timing-function
+      unicode-bidi
+      vertical-align
+      visibility
+      voice-balance
+      voice-duration
+      voice-pitch
+      voice-pitch-range
+      voice-rate
+      voice-stress
+      voice-volume
+      white-space
+      widows
+      width
+      word-break
+      word-spacing
+      word-wrap
+      z-index
+      zoom
+    ]
+  end
+end

data/lib/scss_lint/linter/selector_depth.rb

@@ -38,7 +38,9 @@ module SCSSLint
         item.is_a?(String)
       end
 
-      parent_selectors = simple_sequences.count { |item| item.to_s == '&' }
+      parent_selectors = simple_sequences.count do |item|
+        item.rest.any? { |i| i.is_a?(Sass::Selector::Parent) }
+      end
 
       # Take the number of simple sequences and subtract one for each sibling
       # combinator, as these "combine" simple sequences such that they do not

data/lib/scss_lint/linter/space_between_parens.rb

@@ -0,0 +1,26 @@
+module SCSSLint
+  # Checks for the presence of spaces between parentheses.
+  class Linter::SpaceBetweenParens < Linter
+    include LinterRegistry
+
+    def visit_root(node)
+      @spaces = config['spaces']
+      engine.lines.each_with_index do |line, index|
+        line.scan /(\( *[^ ]|[^\s] *\))/ do |match|
+          match.each { |str| check(str, index, engine) }
+        end
+      end
+    end
+
+  private
+
+    def check(str, index, engine)
+      spaces = str.count ' '
+
+      if spaces != @spaces
+        @lints << Lint.new(engine.filename, index + 1, "Expected #{pluralize(@spaces, 'space')}" <<
+                                                       " between parentheses instead of #{spaces}")
+      end
+    end
+  end
+end

data/lib/scss_lint/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.14.0'
+  VERSION = '0.15.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Causes Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-12 00:00:00.000000000 Z
+date: 2014-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -106,7 +106,9 @@ files:
 - lib/scss_lint/linter/selector_depth.rb
 - lib/scss_lint/linter/compass/property_with_mixin.rb
 - lib/scss_lint/linter/space_after_property_name.rb
+- lib/scss_lint/linter/property_spelling.rb
 - lib/scss_lint/linter/usage_name.rb
+- lib/scss_lint/linter/space_between_parens.rb
 - lib/scss_lint/linter/border_zero.rb
 - lib/scss_lint/linter/space_after_property_colon.rb
 - lib/scss_lint/linter/debug_statement.rb
@@ -147,3 +149,4 @@ signing_key:
 specification_version: 4
 summary: SCSS lint tool
 test_files: []
+has_rdoc: